Re: Review Request 59849: add StringPrefixPartitionResolver

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177074
---


Ship it!




Ship It!

- Eric Shu


On June 6, 2017, 6:54 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 6:54 p.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 59849: add StringPrefixPartitionResolver

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/
---

(Updated June 6, 2017, 11:54 a.m.)


Review request for geode, Eric Shu and Lynn Gallinat.


Changes
---

removed delimiter from getName


Bugs: GEODE-3027
https://issues.apache.org/jira/browse/GEODE-3027


Repository: geode


Description
---

The new resolver uses a fixed delimiter of "|".
In this version of the resolver you can not configure the delimiter.
"|" was chosen over ":" because it seemed less likely that the desired prefix 
string would contain it.
Since the delimiter can not be configured it is important that it would not be 
a common one to occur in a key string.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59849/diff/2/

Changes: https://reviews.apache.org/r/59849/diff/1-2/


Testing
---

precheckin


Thanks,

Darrel Schneider

Re: Review Request 59849: add StringPrefixPartitionResolver

[Darrel Schneider]

> On June 6, 2017, 11:17 a.m., Eric Shu wrote:
> > geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
> > Lines 60 (patched)
> > 
> >
> > Does getName() needs the Delimiter being included? If it is used in the 
> > equals(), can we just check getDelimiter() in the equals method?

I thought it did but I reviewed how the product uses getName and it seems like 
it expects it to be just the class name of the resolver.
So I will change getName to not include it and change equals and hashCode to 
also call getDelimiter.
Thanks for the review.


- Darrel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177064
---


On June 6, 2017, 10:44 a.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 10:44 a.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 59849: add StringPrefixPartitionResolver

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59849/#review177064
---




geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
Lines 60 (patched)


Does getName() needs the Delimiter being included? If it is used in the 
equals(), can we just check getDelimiter() in the equals method?


- Eric Shu


On June 6, 2017, 5:44 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59849/
> ---
> 
> (Updated June 6, 2017, 5:44 p.m.)
> 
> 
> Review request for geode, Eric Shu and Lynn Gallinat.
> 
> 
> Bugs: GEODE-3027
> https://issues.apache.org/jira/browse/GEODE-3027
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The new resolver uses a fixed delimiter of "|".
> In this version of the resolver you can not configure the delimiter.
> "|" was chosen over ":" because it seemed less likely that the desired prefix 
> string would contain it.
> Since the delimiter can not be configured it is important that it would not 
> be a common one to occur in a key string.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/partition/StringPrefixPartitionResolver.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/cache/partition/StringPrefixPartitionResolverJUnitTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59849/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>