Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Emily Yeh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review181245
---


Ship it!




+1!

- Emily Yeh


On July 17, 2017, 3:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 17, 2017, 3:49 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review180740
---


Ship it!




+1

- Kirk Lund


On July 17, 2017, 3:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 17, 2017, 3:49 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review180683
---


Ship it!




Ship It!

- Ken Howe


On July 17, 2017, 3:49 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 17, 2017, 3:49 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/3/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/
---

(Updated July 17, 2017, 3:49 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

fixed comment to include deprecated version


Repository: geode


Description
---

geode-3166: remove the uncalled getCredential method

I simply removed the call. Since the new method is never called, if we have any 
users that's implementing this method, it's never used anyway. We will not be 
breaking backward compatibility, I believe.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
6b0675a5629a3e057fd3d54841db740189007966 


Diff: https://reviews.apache.org/r/60666/diff/3/

Changes: https://reviews.apache.org/r/60666/diff/2-3/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review180088
---




geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java
Lines 96 (patched)


Deprecated text should mention the release 1st deprecated in and the API 
that user should use instead. Something like:

@deprecated As of Geode 1.3, please use getCredentials(Properties, 
DistributedMember, boolean)


- Kirk Lund


On July 6, 2017, 4:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 6, 2017, 4:03 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review179794
---



One small change that might be helpful is to note the version

- Jared Stewart


On July 6, 2017, 4:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 6, 2017, 4:03 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review179793
---


Ship it!




Ship It!

- Jared Stewart


On July 6, 2017, 4:03 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 6, 2017, 4:03 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/2/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/
---

(Updated July 6, 2017, 4:03 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

geode-3166: remove the uncalled getCredential method

I simply removed the call. Since the new method is never called, if we have any 
users that's implementing this method, it's never used anyway. We will not be 
breaking backward compatibility, I believe.


Diffs (updated)
-

  geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
6b0675a5629a3e057fd3d54841db740189007966 


Diff: https://reviews.apache.org/r/60666/diff/2/

Changes: https://reviews.apache.org/r/60666/diff/1-2/


Testing
---

precheckin running


Thanks,

Jinmei Liao

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/#review179785
---



For the record, and as discussed offline, I think 1-arg method should be marked 
as @Deprecated for the upcoming release rather than immediately removing it. 
Removing the @Deprecated annotation on the 3-arg method is appropriate as this 
is now the preferred method.

- Ken Howe


On July 5, 2017, 7:47 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60666/
> ---
> 
> (Updated July 5, 2017, 7:47 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> geode-3166: remove the uncalled getCredential method
> 
> I simply removed the call. Since the new method is never called, if we have 
> any users that's implementing this method, it's never used anyway. We will 
> not be breaking backward compatibility, I believe.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
> 6b0675a5629a3e057fd3d54841db740189007966 
> 
> 
> Diff: https://reviews.apache.org/r/60666/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Review Request 60666: geode-3166: remove the uncalled getCredential method

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60666/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

geode-3166: remove the uncalled getCredential method

I simply removed the call. Since the new method is never called, if we have any 
users that's implementing this method, it's never used anyway. We will not be 
breaking backward compatibility, I believe.


Diffs
-

  geode-core/src/main/java/org/apache/geode/security/AuthInitialize.java 
6b0675a5629a3e057fd3d54841db740189007966 


Diff: https://reviews.apache.org/r/60666/diff/1/


Testing
---

precheckin running


Thanks,

Jinmei Liao