[GitHub] incubator-geode pull request: Wrong one line build command

[jaoki]

GitHub user jaoki opened a pull request:

https://github.com/apache/incubator-geode/pull/24

Wrong one line build command

How to build Geode in Spark Connector document seems odd.
It should be 2 lines but it is combined into one line.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaoki/incubator-geode minor-spark-document-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 2a4d6cbc2a46c30b2fd2b2ba96784132c841a9d1
Author: jaoki 
Date:   2015-10-27T07:29:41Z

Fixed




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

[Tushar Khairnar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39445/#review104160
---



pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
 (line 2350)


We can Remove gemXD realated code completely from Geode



pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java (line 
258)


Lot of test fail due to id/selection not found error mainly bcoz targeted 
elements are not visible or present in DOM. To avoid that test 
when checking for particular view should first navigate to that view by 
clicking some button or widget to make it visible.  PulseAutomatedTests have 
lot of navigatTo** methods. Optionally if you can separate out all tests inside 
PulseTests class and run as a separate test it would avoid issues where test is 
at different html page/html view/html widget. All tests in Pulsetests expect 
current page to be default dashboard which may not be the case bcoz tests in 
PulseAutomatedTests navigate to lot of differnt pages.



pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java (line 
293)


We should remove GemXD realated tests completely


- Tushar Khairnar


On Oct. 19, 2015, 6:35 p.m., Nitin Lamba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39445/
> ---
> 
> (Updated Oct. 19, 2015, 6:35 p.m.)
> 
> 
> Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This includes several clean-ups for Pulse tests including:
> - Build gradle (to invoke the right set of tests)
> - Pulse JMX test beans update based on Geode JMX changes in recent releases
> - Test references (corrected or ignored)
> 
> Still a few more clean-ups pending. This is an WIP commit on feature/GEODE-12 
> branch.
> 
> 
> Diffs
> -
> 
>   pulse/build.gradle b2bd5fc 
>   
> pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
>  27aed67 
>   pulse/src/main/resources/pulse.properties 17299c2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java 
> 812e055 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java
>  21c14d5 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java 
> d1a92a2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java 
> b6dd7c6 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java 
> 7402a8b 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java 
> 97acac7 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java
>  9487c0e 
>   pulse/src/test/resources/test.properties fabeea1 
> 
> Diff: https://reviews.apache.org/r/39445/diff/
> 
> 
> Testing
> ---
> 
> Tests done on local setup. A total of 4 tests are failing, down from 28 
> initially.
> 
> 
> Thanks,
> 
> Nitin Lamba
> 
>

Re: Review Request 39585: Integrated Security DUnitTest

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39585/#review104173
---


We need to have you remove usage of hydra.Log. All hydra classes are either 
only on the closed side or need to be removed from open.

Please add comments to every commented out dead code block so we know why it 
was commented out instead of being deleted.

We also need to get rid of any thread sleeps and replace them with 
WaitCriterion from DistributedTestCase or the test will fail intermittently on 
heavily loaded machines (including ASF infrastructure).


gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/CommandTestBase.java
 (line 163)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/CommandTestBase.java
 (line 298)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 3)


need to remove this usage of hydra because it should be in open yet -- 
maybe just use a log4j2 logger:

private static final Logger logger = LogService.getLogger();



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 134)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 230)


change this to use DistributedTestCase.WaitCriterion with check to see if 
mbeans have been registered or this will fail intermittently because of thread 
sleep



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/IntegratedSecDUnitTest.java
 (line 640)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 3)


same as the last test -- need to get rid of all hydra.Log imports and use 
log4j2 Logger or cache.getLogger instead



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 148)


please add comment explaining if this code is incomplete or if it works in 
old ant build but not gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 225)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 281)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/MBeanSecurityJUnitTest.java
 (line 328)


please add comment explaining if this code works in old ant build but not 
gradle



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAccessControl.java
 (line 3)


need to get rid of using hydra.Log



gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/security/TestAuthenticator.java
 (line 3)


need to get rid of using hydra.Log


- Kirk Lund


On Oct. 27, 2015, 3:39 p.m., Tushar Khairnar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39585/
> ---
> 
> (Updated Oct. 27, 2015, 3:39 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Kirk Lund, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> 1. CommandTestBase - Base class for all the CLI/gfsh command dunit tests.
> 2. HeadlessGfsh - Gfsh as an API (and not a shell in terminal) which can be 
> used to submit random commands and get command-result object, output string 
> and errors
> 3. IntegratedSecDUnitTest - Tests gfsh data-commands, monitoring commands by 
> granting/revoking 

Re: Bump language level to 1.8

[William Markito]

Just saw it and fixed.

Let's see the next build.

Thanks!

On Tue, Oct 27, 2015 at 9:01 AM, Dan Smith  wrote:

> Looks like the apache jenkins server is currently running java 1.7. Can
> someone with access to it fix this?
>
> https://builds.apache.org/job/Geode-nightly/258/console
>
> * What went wrong:
> Execution failed for task ':gemfire-junit:compileTestJava'.
> > invalid source release: 1.8
>
>
>
> On Mon, Oct 26, 2015 at 4:25 PM, William Markito 
> wrote:
>
> > Thanks guys!
> >
> > I'm moving ahead and merge PR 23.
> >
> >
> > On Mon, Oct 26, 2015 at 3:06 PM, Kirk Lund  wrote:
> >
> > > +1
> > >
> > > On Fri, Oct 23, 2015 at 9:27 AM, William Markito 
> > > wrote:
> > >
> > > > Folks,
> > > >
> > > > We had some discussions around this in the past but I guess we have
> not
> > > yet
> > > > made the decision to move forward and change the language level.
> > > >
> > > > Just opened GEODE-479 and would like to propose to do this change
> > before
> > > > our Alpha release.
> > > >
> > > > Any thoughts ?
> > > > --
> > > > William Markito Oliveira
> > > > Enterprise Architect
> > > > -- For questions about Apache Geode, please write to
> > > > *dev@geode.incubator.apache.org
> > > > *
> > > >
> > >
> >
> >
> >
> > --
> >
> > William Markito Oliveira
> > -- For questions about Apache Geode, please write to
> > *dev@geode.incubator.apache.org
> > *
> >
>



-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*

Re: Bump language level to 1.8

[Dan Smith]

Looks like the apache jenkins server is currently running java 1.7. Can
someone with access to it fix this?

https://builds.apache.org/job/Geode-nightly/258/console

* What went wrong:
Execution failed for task ':gemfire-junit:compileTestJava'.
> invalid source release: 1.8



On Mon, Oct 26, 2015 at 4:25 PM, William Markito 
wrote:

> Thanks guys!
>
> I'm moving ahead and merge PR 23.
>
>
> On Mon, Oct 26, 2015 at 3:06 PM, Kirk Lund  wrote:
>
> > +1
> >
> > On Fri, Oct 23, 2015 at 9:27 AM, William Markito 
> > wrote:
> >
> > > Folks,
> > >
> > > We had some discussions around this in the past but I guess we have not
> > yet
> > > made the decision to move forward and change the language level.
> > >
> > > Just opened GEODE-479 and would like to propose to do this change
> before
> > > our Alpha release.
> > >
> > > Any thoughts ?
> > > --
> > > William Markito Oliveira
> > > Enterprise Architect
> > > -- For questions about Apache Geode, please write to
> > > *dev@geode.incubator.apache.org
> > > *
> > >
> >
>
>
>
> --
>
> William Markito Oliveira
> -- For questions about Apache Geode, please write to
> *dev@geode.incubator.apache.org
> *
>

Re: Bump language level to 1.8

[William Markito]

Yes, but just because the base image we created for Docker is already JDK 8
based.

On Tue, Oct 27, 2015 at 9:41 AM, Anthony Baker  wrote:

> If we the jenkins build in a docker container that would fix this issue
> right?  GEODE-60?
>
> Anthony
>
> > On Oct 27, 2015, at 9:01 AM, Dan Smith  wrote:
> >
> > Looks like the apache jenkins server is currently running java 1.7. Can
> > someone with access to it fix this?
> >
> > https://builds.apache.org/job/Geode-nightly/258/console
> >
> > * What went wrong:
> > Execution failed for task ':gemfire-junit:compileTestJava'.
> >> invalid source release: 1.8
> >
> >
> >
> > On Mon, Oct 26, 2015 at 4:25 PM, William Markito 
> > wrote:
> >
> >> Thanks guys!
> >>
> >> I'm moving ahead and merge PR 23.
> >>
> >>
> >> On Mon, Oct 26, 2015 at 3:06 PM, Kirk Lund  wrote:
> >>
> >>> +1
> >>>
> >>> On Fri, Oct 23, 2015 at 9:27 AM, William Markito 
> >>> wrote:
> >>>
>  Folks,
> 
>  We had some discussions around this in the past but I guess we have
> not
> >>> yet
>  made the decision to move forward and change the language level.
> 
>  Just opened GEODE-479 and would like to propose to do this change
> >> before
>  our Alpha release.
> 
>  Any thoughts ?
>  --
>  William Markito Oliveira
>  Enterprise Architect
>  -- For questions about Apache Geode, please write to
>  *dev@geode.incubator.apache.org
>  *
> 
> >>>
> >>
> >>
> >>
> >> --
> >>
> >> William Markito Oliveira
> >> -- For questions about Apache Geode, please write to
> >> *dev@geode.incubator.apache.org
> >> *
> >>
>
>


-- 

William Markito Oliveira
-- For questions about Apache Geode, please write to
*dev@geode.incubator.apache.org
*

Re: Propose changing check to only depend on UnitTest

[Mark Bretl]

I have checked in GEODE-487 into develop to remove integrationTests and
distributedTests from the build task. The new task for running all tests is
'precheckin'. I have also updated the nightly build with this change.

--Mark

On Thu, Oct 1, 2015 at 5:30 PM, Nitin Lamba  wrote:

> +1 .
>
> Initial dev experience needs to be frictionless... :)
>
> 
> From: Bruce Schuchardt 
> Sent: Thursday, October 1, 2015 4:56 PM
> To: dev@geode.incubator.apache.org
> Subject: Re: Propose changing check to only depend on UnitTest
>
> +1
>
> Le 10/1/2015 2:21 PM, Darrel Schneider a écrit :
> > +1
> >
> > How about "precheckin" for the target that runs IntegrationTest and
> > DistributionTest? Perhaps this target should start with a line informing
> > the runner that it will take hours.
> >
> >
> > On Thu, Oct 1, 2015 at 12:48 PM, Kirk Lund  wrote:
> >
> >> Proposal:
> >>
> >> 1) Remove IntegrationTest and DistributionTest from "check" target
> >>
> >> 2) Add a new target (name TBD) that executes IntegrationTest and
> >> DistributionTest
> >>
> >> Reasons:
> >>
> >> 1) new people who clone and then build wait forever and complain that
> build
> >> hung resulting in bad first impression by users
> >>
> >> 2) Index-Geodein5minutes instructs user to skip tests but internet
> wisdom
> >> says never use -Dskip.tests=true
> >>
> >>
> >>
> https://cwiki.apache.org/confluence/display/GEODE/Index#Index-Geodein5minutes
> >>
> >> 3) non-developers don't need to run IntegrationTest and DistributedTest
> --
> >> they just want to clone, build and try out basics to see if they want to
> >> become a Geode User
> >>
> >> 4) anyone who decides they want to become a developer can easily learn
> that
> >> we invoke a target to run the long-running tests -- we can easily
> document
> >> this everywhere if people are truly worried about it
> >>
> >> 5) this change encourages us to improve our coverage with fast-running
> >> UnitTests
> >>
> >> Anti-goals
> >>
> >> 1) I'm not suggesting that anyone can commit changes without running the
> >> long-running tests
> >>
> >> -Kirk
> >>
>
>


-- 
Mark Bretl
Software Build Engineer
Pivotal
503-533-3869
www.pivotal.io

Review Request 39699: GEODE-192: Removing TransactionFunctionService

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39699/
---

Review request for geode and Swapnil Bawaskar.


Repository: geode


Description
---

This internal class was added for a use case that is no longer
supported. It has a bug, in that the client may never have connected to
the server that it supposed to be able to look up and invoke the
function on. Deleting the class rather than trying to fix the bug
because the class is no longer needed.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java
 5c03be8cc1fb1d96d1637a05d78a74392aea32ef 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java
 ba87bb5ef66b25d8cea3bad02d39c7c4a4491d45 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/TransactionFunctionService.java
 e56e6477b0904d70e6cb5a0c019f40e9f6ad65a0 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java
 bafafa99e557110541da16df2a07475c7f0a2a4d 
  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java
 7dbfc62b9cf7758749a76ccef7033c19acf8cb8b 
  
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java
 b3611105e5d8369e435098589ba340d9eda538db 

Diff: https://reviews.apache.org/r/39699/diff/


Testing
---


Thanks,

Dan Smith

Re: Review Request 39605: GEODE-77: Coordinator shutdown does not trigger coordinator reassignment

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39605/
---

(Updated Oct. 27, 2015, 9:41 p.m.)


Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, 
and Lynn Gallinat.


Repository: geode


Description
---

It looks like the coordinator node has left, sent a leave message but the 
member that is supposed to become coordinator next, ignores this leave message 
(as he is not yet the coordinator).
The fix is to not ignore these leave messages and instead have each member 
track them, similar to removedMembers list. When the leave message is processed 
by non coordinators, the results will be the same. However if the non 
coordinator will now become coordinator, they can now process these leave 
messages


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java
 cb61a1b 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 774ab37 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 6d39a6a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 41b0df7 

Diff: https://reviews.apache.org/r/39605/diff/


Testing
---

Ran precheckin but had a handful of failures due to suspect strings, will rerun


Thanks,

Jason Huynh

Re: Review Request 39605: GEODE-77: Coordinator shutdown does not trigger coordinator reassignment

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39605/
---

(Updated Oct. 27, 2015, 9:25 p.m.)


Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, 
and Lynn Gallinat.


Changes
---

Additional change to not clear from removedMember and leftMembers collections 
when a view is installed.  Instead we will only remove from those collections 
if the new view does not contain the member ids.  This should help with booting 
out members in a more timely fashion.


Repository: geode


Description
---

It looks like the coordinator node has left, sent a leave message but the 
member that is supposed to become coordinator next, ignores this leave message 
(as he is not yet the coordinator).
The fix is to not ignore these leave messages and instead have each member 
track them, similar to removedMembers list. When the leave message is processed 
by non coordinators, the results will be the same. However if the non 
coordinator will now become coordinator, they can now process these leave 
messages


Diffs (updated)
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java
 cb61a1b 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 774ab37 
  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
 6d39a6a 
  
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
 41b0df7 

Diff: https://reviews.apache.org/r/39605/diff/


Testing
---

Ran precheckin but had a handful of failures due to suspect strings, will rerun


Thanks,

Jason Huynh

[GitHub] incubator-geode pull request: Fixes GEODE-495.

[sboorlagadda]

GitHub user sboorlagadda opened a pull request:

https://github.com/apache/incubator-geode/pull/25

Fixes GEODE-495. 

To use a random port for the JMX manager, also fixed "cleanup" not to 
create cache if not already created in-order to delete a region.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sboorlagadda/incubator-geode GEODE-409

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 1c74b8b07672a941b7d453219540a916f8b34b74
Author: Sai Boorlagadda 
Date:   2015-10-27T23:17:07Z

Fixes GEODE-495. To use a random port for the JMX manager, also fixed 
cleanup not to create cache if not created already




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 39706: GEODE-411: fix suspect string on disconnect

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39706/
---

Review request for geode and Dan Smith.


Bugs: GEODE-411
https://issues.apache.org/jira/browse/GEODE-411


Repository: geode


Description
---

DistributionManager now has a isCloseInProgress method
that checks both the volatile closeInProgress boolean
and ask its DistributedSystem if it is disconnecting.
This new method is used in places that decide if a warning
should be logged.


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java
 37f355f6039ca87df72354c19b8d15945b509bf9 

Diff: https://reviews.apache.org/r/39706/diff/


Testing
---

ConnectDisconnectDUnitTest


Thanks,

Darrel Schneider

Re: Review Request 39699: GEODE-192: Removing TransactionFunctionService

[Swapnil Bawaskar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39699/#review104222
---

Ship it!


Ship It!

- Swapnil Bawaskar


On Oct. 27, 2015, 8:44 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39699/
> ---
> 
> (Updated Oct. 27, 2015, 8:44 p.m.)
> 
> 
> Review request for geode and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This internal class was added for a use case that is no longer
> supported. It has a bug, in that the client may never have connected to
> the server that it supposed to be able to look up and invoke the
> function on. Deleting the class rather than trying to fix the bug
> because the class is no longer needed.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/EndpointManagerImpl.java
>  5c03be8cc1fb1d96d1637a05d78a74392aea32ef 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/ServerFunctionExecutor.java
>  ba87bb5ef66b25d8cea3bad02d39c7c4a4491d45 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/TransactionFunctionService.java
>  e56e6477b0904d70e6cb5a0c019f40e9f6ad65a0 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java
>  bafafa99e557110541da16df2a07475c7f0a2a4d 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java
>  7dbfc62b9cf7758749a76ccef7033c19acf8cb8b 
>   
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java
>  b3611105e5d8369e435098589ba340d9eda538db 
> 
> Diff: https://reviews.apache.org/r/39699/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 39706: GEODE-411: fix suspect string on disconnect

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39706/#review104227
---

Ship it!


Ship It!

- Dan Smith


On Oct. 27, 2015, 11:31 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39706/
> ---
> 
> (Updated Oct. 27, 2015, 11:31 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-411
> https://issues.apache.org/jira/browse/GEODE-411
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> DistributionManager now has a isCloseInProgress method
> that checks both the volatile closeInProgress boolean
> and ask its DistributedSystem if it is disconnecting.
> This new method is used in places that decide if a warning
> should be logged.
> 
> 
> Diffs
> -
> 
>   
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java
>  37f355f6039ca87df72354c19b8d15945b509bf9 
> 
> Diff: https://reviews.apache.org/r/39706/diff/
> 
> 
> Testing
> ---
> 
> ConnectDisconnectDUnitTest
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

[Nitin Lamba]

> On Oct. 27, 2015, 10:43 a.m., Tushar Khairnar wrote:
> > pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java,
> >  line 2350
> > 
> >
> > We can Remove gemXD realated code completely from Geode

Removed GemFire XD tests - see Patch_03


> On Oct. 27, 2015, 10:43 a.m., Tushar Khairnar wrote:
> > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java, 
> > line 258
> > 
> >
> > Lot of test fail due to id/selection not found error mainly bcoz 
> > targeted elements are not visible or present in DOM. To avoid that test 
> > when checking for particular view should first navigate to that view by 
> > clicking some button or widget to make it visible.  PulseAutomatedTests 
> > have lot of navigatTo** methods. Optionally if you can separate out all 
> > tests inside PulseTests class and run as a separate test it would avoid 
> > issues where test is at different html page/html view/html widget. All 
> > tests in Pulsetests expect current page to be default dashboard which may 
> > not be the case bcoz tests in PulseAutomatedTests navigate to lot of 
> > differnt pages.

Resolved all tests that were originally included. Other Ignored (WIP) tests are 
retained - see Patch_03


> On Oct. 27, 2015, 10:43 a.m., Tushar Khairnar wrote:
> > pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java, 
> > line 293
> > 
> >
> > We should remove GemXD realated tests completely

Removed Gemfire XD tests - see Patch_03


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39445/#review104160
---


On Oct. 19, 2015, 6:35 p.m., Nitin Lamba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39445/
> ---
> 
> (Updated Oct. 19, 2015, 6:35 p.m.)
> 
> 
> Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This includes several clean-ups for Pulse tests including:
> - Build gradle (to invoke the right set of tests)
> - Pulse JMX test beans update based on Geode JMX changes in recent releases
> - Test references (corrected or ignored)
> 
> Still a few more clean-ups pending. This is an WIP commit on feature/GEODE-12 
> branch.
> 
> 
> Diffs
> -
> 
>   pulse/build.gradle b2bd5fc 
>   
> pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
>  27aed67 
>   pulse/src/main/resources/pulse.properties 17299c2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java 
> 812e055 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java
>  21c14d5 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java 
> d1a92a2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java 
> b6dd7c6 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java 
> 7402a8b 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java 
> 97acac7 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java
>  9487c0e 
>   pulse/src/test/resources/test.properties fabeea1 
> 
> Diff: https://reviews.apache.org/r/39445/diff/
> 
> 
> Testing
> ---
> 
> Tests done on local setup. A total of 4 tests are failing, down from 28 
> initially.
> 
> 
> Thanks,
> 
> Nitin Lamba
> 
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #108 has FAILED

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #108 failed.
---
Scheduled
No failed tests found, a possible compilation error.

https://build.spring.io/browse/SGF-NAG-108/

-
Currently Responsible
-

No one is responsible for fixing this build.



--
Failing Jobs
--
  - Default Job (Default Stage): No tests found.




--
This message is automatically generated by Atlassian Bamboo

[GitHub] incubator-geode pull request: Fixes GEODE-495.

[sboorlagadda]

Github user sboorlagadda closed the pull request at:

https://github.com/apache/incubator-geode/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

[Nitin Lamba]

> On Oct. 19, 2015, 7:14 p.m., Mark Bretl wrote:
> > pulse/build.gradle, line 43
> > 
> >
> > gemfire-core is using version 4.12. Can the version be upgraded from 
> > 4.10 to 4.12?
> 
> Nitin Lamba wrote:
> I'm not actively using junit in code so can easily rev-up the version.

JUnit updated to 4.12 - see Patch_02


- Nitin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39445/#review103144
---


On Oct. 19, 2015, 6:35 p.m., Nitin Lamba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39445/
> ---
> 
> (Updated Oct. 19, 2015, 6:35 p.m.)
> 
> 
> Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This includes several clean-ups for Pulse tests including:
> - Build gradle (to invoke the right set of tests)
> - Pulse JMX test beans update based on Geode JMX changes in recent releases
> - Test references (corrected or ignored)
> 
> Still a few more clean-ups pending. This is an WIP commit on feature/GEODE-12 
> branch.
> 
> 
> Diffs
> -
> 
>   pulse/build.gradle b2bd5fc 
>   
> pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
>  27aed67 
>   pulse/src/main/resources/pulse.properties 17299c2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java 
> 812e055 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java
>  21c14d5 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java 
> d1a92a2 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java 
> b6dd7c6 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java 
> 7402a8b 
>   pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java 
> 97acac7 
>   
> pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java
>  9487c0e 
>   pulse/src/test/resources/test.properties fabeea1 
> 
> Diff: https://reviews.apache.org/r/39445/diff/
> 
> 
> Testing
> ---
> 
> Tests done on local setup. A total of 4 tests are failing, down from 28 
> initially.
> 
> 
> Thanks,
> 
> Nitin Lamba
> 
>

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

[Nitin Lamba]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39445/
---

(Updated Oct. 28, 2015, 4:29 a.m.)


Review request for geode, Dick Cavender, Tushar Khairnar, and Dan Smith.


Summary (updated)
-

GEODE-12/GEODE-304 Fix Pulse tests


Repository: geode


Description (updated)
---

This includes several clean-ups for Pulse tests including:
- Build gradle (to invoke the right set of tests)
- Pulse JMX test beans update based on Geode JMX changes in recent releases
- Test references (corrected or ignored)

This is set of 3 commits on feature/GEODE-12 branch.


Diffs
-

  pulse/build.gradle b2bd5fc 
  
pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java
 27aed67 
  pulse/src/main/resources/pulse.properties 17299c2 
  pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Member.java 812e055 
  
pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseAutomatedTests.java
 21c14d5 
  pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTestData.java 
d1a92a2 
  pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/PulseTests.java 
b6dd7c6 
  pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/RegionOnMember.java 
7402a8b 
  pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObject.java 
97acac7 
  
pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/ServerObjectMBean.java 
9487c0e 
  pulse/src/test/resources/test.properties fabeea1 

Diff: https://reviews.apache.org/r/39445/diff/


Testing (updated)
---

Tested with the latest Firefox browser 41.0.2.
All UI tests pass.


File Attachments (updated)


Patch_02 - JUnit & gradle updates
  
https://reviews.apache.org/media/uploaded/files/2015/10/28/4a2bf570-14f8-458d-9cc6-529d0f9b8f77__patch_02.diff
Patch_03 - Test clean-up & fixes
  
https://reviews.apache.org/media/uploaded/files/2015/10/28/b5497b9a-8742-46e8-870e-a16e8622cebc__patch_03.diff


Thanks,

Nitin Lamba