Re: Review Request 46354: GEODE-1072: Removing HDFS related code

2016-04-19 Thread Dan Smith 


> On April 19, 2016, 11:13 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java, 
> > line 726
> > 
> >
> > Seems like a good feature to have on the regions, is this tied to HDFS? 
> > if not can we retain this?

This was discussed on the dev list, and the decision was to remove it along 
with the HDFS code. Part of the reason is a lack of tests for this feature.

http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201603.mbox/%3CCAFh%2B7k2mDmKPHCoWyTqOCR3RvZv8F0MLjQgdx_j3FNn8y5yAOg%40mail.gmail.com%3E


> On April 19, 2016, 11:13 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java,
> >  line 1172
> > 
> >
> > Is this HDFS/custome eviction specific?

getEvictionCriteria is specific to custom eviction. I think the change I made 
preserves the original logic without custom eviction.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46354/#review129574
---


On April 19, 2016, 12:35 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46354/
> ---
> 
> (Updated April 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removing all HDFS and EvictionCriteria created code. This code will be
> reinstated on a branch to be cleaned up and merged as a separate module.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 2206018efeebb9c0105834dd09760592b7032873 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 
> 201c1aabb2f5452b980a3aa5ae7e1c5a949c1e61 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesMutator.java 
> eb46433979ea6c3c111d62ed16ed8eaba7bae143 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/CustomEvictionAttributes.java
>  c2bc41b93e458d3defa79c1ec5246368ede008ef 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java 
> 1e87c0f164e77555e6685841f75dd41044a3ab90 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/EvictionCriteria.java 
> 8df201c047e6ee1e19cd0ffda558eb658589d868 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/Operation.java 
> 7a63855389927a3805a2ecc86cce06a11a9a64fb 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionAttributes.java 
> dd5c0e0cb1ae553b4bbc9e044520235994adccb6 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionFactory.java 
> 729374ed6b6050dde92fd00de88615ede3283fd4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  d15222b85828d8b450e3aa5c8858502259a9e4e6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSIOException.java 
> d9b6179fa0377b18d6d333a022acc06ef52a8032 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java 
> 45ba370034c6b1385a35763bdff575f31c6694e8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreFactory.java
>  0d80a67354f61546f2ec13c6a3c4c43fc51a7288 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreMutator.java
>  d98c9cdb187f38d023cd6d5c4212fef1cb514bc8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/StoreExistsException.java
>  de21b2322cc41adf997607f0dd682006c055fe73 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FailureTracker.java
>  789d49765f4e4959a6e5b88b8ace3f8d5b99fb2b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FlushObserver.java
>  f69b3dc3b77854b10dfde40f503264a437a3163f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSBucketRegionQueue.java
>  9127e4dbc3edbe0dbd993ca3b72b68ed8cbb65ff 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEntriesSet.java
>  c8b7b282487b48edfcbed8f21a69c8b2b3c33de3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventListener.java
>  607650f30d44d4a792e0bbca3c2d495c84d098d1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventQueueFilter.java
>  0860e752dec9e0aa7d8efc21d09e0b84ea7b1a04 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSGatewayEventImpl.java
>  db99e7eb9b10bdfda4f64332221b73bf085e5ccd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSIntegrationUtil.java
>  740a607d48dd51d3cf82709f441fe7bbd96d37aa 
>   
> geode-core/src/main/java/com/gemstone/gemfire/

Review Request 46417: fixed GEODE-1238

2016-04-19 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46417/
---

Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1238
https://issues.apache.org/jira/browse/GEODE-1238


Repository: geode


Description
---

Reviewed all EntryEventImpl creators 
Created two new subclasses to mark ones that are never off-heap 
Added annotations and comments on all creators
Added missing release calls
Added TODO comments for distributed tx off-heap work


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ServerRegionProxy.java
 40f240f3f8766a59ae6d37d7b5f470373ecd2020 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/admin/ClientStatsManager.java
 20f6dbf46638d1b94558b1648eba7cc540f11a01 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractBucketRegionQueue.java
 2c8f49365a0ee69e3901492f7c460ac01f7c8981 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractLRURegionMap.java
 a19ee66c70d60c3e9a2078d463a588bfb5664b6d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
 e78c8eb8dff69bec9cc0eb548ed5f535dd06dbaf 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
 1cb7a20b454e28da5190dc376c53766d7fb2d86f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java 
3946fda76e16b6d16e2057f2570b001152440d2a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegionQueue.java
 6b76c31c8b51810f5e906b97ffb92118a59cee3d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DestroyOperation.java
 b0ac963e4a2b9f00418e548290c9e74e59eae15a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistPeerTXStateStub.java
 cd17770b7027566f1a8d4f90dfbc3362e9b0f59c 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXState.java 
19cc1759db2890e667d3f37ec2e0c5142f65f3af 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateOnCoordinator.java
 10d892a87d71efbffa79ca7a50215f575310dfc6 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistTXStateProxyImplOnCoordinator.java
 75a1df7963869de46c4fe0d3bcc70e8dba14fde2 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java
 79ae4eed0f1eac1e259581a4715715d6f56e448e 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedPutAllOperation.java
 2e83cb8c3c4264cfdf2e03c1cacdd1baa3efe106 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java
 467efc66eb6695967894bb4d7fb33e7f80c96b01 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRemoveAllOperation.java
 70d39dc0f4e43f6b8902ec9229ad64b03288a26b 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 3c87654ac02a358a3eab9379edd2e26c988ad23d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryExpiryTask.java
 cba78028ef2bd2643b28a928b9f4fd6172809c56 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EventIDHolder.java 
PRE-CREATION 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterProfile.java 
90c4dc07d71e4d5ac9f631b67cf746df3081f393 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/HARegion.java 
fa29bf3802c8365e6784f6bde2cb5295357cbc65 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
 a72ca8efe61c9f8558b369f09fea79b0db52b3d7 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InvalidateOperation.java
 de6adda74abe9688eabfbb2642f01804faa4ad23 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 
3ff48bb11640c5f0792a626f19b0f0af4e9e2fcb 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 049f7df872314e6ed0fd7198eadaae0e6736c6ad 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ProxyRegionMap.java
 7b4504dbfb8e5edf39d28cf697bf9acfdc66131f 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/QueuedOperation.java
 fa7aea19d05e1fc631a1366c10574ac754d8cc70 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteDestroyMessage.java
 4a8c101d103c48aac385ef86db8e1851b8e03c41 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteInvalidateMessage.java
 ee01c9ba649538fd6d635603495d4597decd7a46 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutAllMessage.java
 c706e4fedb7cf2117a8b4eade3c512355d335994 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemotePutMessage.java
 9f51b39bf66d5ea3c6b0829f83d614b656f660a2 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteRemoveAllMessage.java
 7f3a1385a4b1d1cb4666a0a3504c8aa0070fab3f 
  
geode-core/src/main/java/c

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

2016-04-19 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45706/#review129647
---


Fix it, then Ship it!




Ship It!


geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java
 (lines 237 - 241)


I just noticed this, it was in the first version of 
ReferenceCountHelperImpl.java, but I don't think we really need to keep 
commented out debug code.


- Ken Howe


On April 19, 2016, 9:32 p.m., Scott Jewell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45706/
> ---
> 
> (Updated April 19, 2016, 9:32 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Ken Howe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Split ReferenceCountHelper into ReferenceCountHelper and 
> ReferenceCountHelperImpl
> 
> Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java
>  f6696b035438f4ba2d4157584f0551e2b4ccf02a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45706/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Scott Jewell
> 
>

Re: Review Request 46354: GEODE-1072: Removing HDFS related code

2016-04-19 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46354/#review129574
---


Fix it, then Ship it!




Ship It!


geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 


Seems like a good feature to have on the regions, is this tied to HDFS? if 
not can we retain this?



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
 (line 1147)


Is this HDFS/custome eviction specific?


- anilkumar gingade


On April 19, 2016, 12:35 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46354/
> ---
> 
> (Updated April 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removing all HDFS and EvictionCriteria created code. This code will be
> reinstated on a branch to be cleaned up and merged as a separate module.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 2206018efeebb9c0105834dd09760592b7032873 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 
> 201c1aabb2f5452b980a3aa5ae7e1c5a949c1e61 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesMutator.java 
> eb46433979ea6c3c111d62ed16ed8eaba7bae143 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/CustomEvictionAttributes.java
>  c2bc41b93e458d3defa79c1ec5246368ede008ef 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java 
> 1e87c0f164e77555e6685841f75dd41044a3ab90 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/EvictionCriteria.java 
> 8df201c047e6ee1e19cd0ffda558eb658589d868 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/Operation.java 
> 7a63855389927a3805a2ecc86cce06a11a9a64fb 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionAttributes.java 
> dd5c0e0cb1ae553b4bbc9e044520235994adccb6 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionFactory.java 
> 729374ed6b6050dde92fd00de88615ede3283fd4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  d15222b85828d8b450e3aa5c8858502259a9e4e6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSIOException.java 
> d9b6179fa0377b18d6d333a022acc06ef52a8032 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java 
> 45ba370034c6b1385a35763bdff575f31c6694e8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreFactory.java
>  0d80a67354f61546f2ec13c6a3c4c43fc51a7288 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreMutator.java
>  d98c9cdb187f38d023cd6d5c4212fef1cb514bc8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/StoreExistsException.java
>  de21b2322cc41adf997607f0dd682006c055fe73 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FailureTracker.java
>  789d49765f4e4959a6e5b88b8ace3f8d5b99fb2b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FlushObserver.java
>  f69b3dc3b77854b10dfde40f503264a437a3163f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSBucketRegionQueue.java
>  9127e4dbc3edbe0dbd993ca3b72b68ed8cbb65ff 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEntriesSet.java
>  c8b7b282487b48edfcbed8f21a69c8b2b3c33de3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventListener.java
>  607650f30d44d4a792e0bbca3c2d495c84d098d1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventQueueFilter.java
>  0860e752dec9e0aa7d8efc21d09e0b84ea7b1a04 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSGatewayEventImpl.java
>  db99e7eb9b10bdfda4f64332221b73bf085e5ccd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSIntegrationUtil.java
>  740a607d48dd51d3cf82709f441fe7bbd96d37aa 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSParallelGatewaySenderQueue.java
>  1e6a0343ca9782f040d26c2259fe330155dfde5b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreConfigHolder.java
>  16d3d87762323b5dde0c90e2e6e91c356e86fe43 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreCreation.java
>  9ecc5e37871dabe70764bf21a030a9c319dd2d11 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreFactoryImpl.java
>  749f01ce0414e454ada0ab3efb666e60ab33c445 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HD

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

2016-04-19 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45706/#review129646
---


Ship it!




Ship It!

- Darrel Schneider


On April 19, 2016, 2:32 p.m., Scott Jewell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45706/
> ---
> 
> (Updated April 19, 2016, 2:32 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Ken Howe.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Split ReferenceCountHelper into ReferenceCountHelper and 
> ReferenceCountHelperImpl
> 
> Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java
>  f6696b035438f4ba2d4157584f0551e2b4ccf02a 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45706/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Scott Jewell
> 
>

Re: Review Request 45706: ReferenceCountHelper junit tests for GEODE-656

2016-04-19 Thread Scott Jewell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45706/
---

(Updated April 19, 2016, 9:32 p.m.)


Review request for geode, Darrel Schneider and Ken Howe.


Changes
---

GEODE-656: Add protected attribute to test hook methods


Repository: geode


Description
---

Split ReferenceCountHelper into ReferenceCountHelper and 
ReferenceCountHelperImpl

Create new unit tests for ReferenceCountHelper and ReferenceCountHelperImpl


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelper.java
 f6696b035438f4ba2d4157584f0551e2b4ccf02a 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImpl.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperImplTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/offheap/ReferenceCountHelperJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45706/diff/


Testing (updated)
---


Thanks,

Scott Jewell

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/#review129628
---




geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 (line 50)


Since getConnectedInstance and returns an IDS that is connected this extra 
check here for isConnected is not needed.



geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 (line 61)


It is not obvious why this is done in its own thread. What do you think 
adding a comment to startShutdownThread explaining why you need to do the 
disconnect call in a non-daemon thread.

Also I think you should do all the thread work in the method; don't return 
the thread and join on it. Instead do the join in this method. And you could 
call the method disconnectInNonDaemonThread.


- Darrel Schneider


On April 19, 2016, 12:55 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46402/
> ---
> 
> (Updated April 19, 2016, 12:55 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This fixes two issues when using gfsh 'shutdown' command
> - One is that the JVM can exit prematurely because all remaining threads
>   are daemon threads. When coupled with network partition detection this
>   can result in member departed events causing split brain scenarios -
>   [GEODE-1236].
> - The other issue is that when a member is starting up it may have
>   synchronized on the CacheFactory class waiting on disk store recovery.
>   This prevented gfsh shutdown to run as it would also try and
>   synchronize on the CacheFactory and be blocked.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
>  90b582b778e4df2b4b6b6cda045d83d9098d8c56 
> 
> Diff: https://reviews.apache.org/r/46402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/#review129618
---




geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 (line 52)


You are potentially hiding all errors that happen during shutdown here. If 
the shutdown thread has an exception that should probably be handed back to the 
caller.


- Dan Smith


On April 19, 2016, 7:55 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46402/
> ---
> 
> (Updated April 19, 2016, 7:55 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This fixes two issues when using gfsh 'shutdown' command
> - One is that the JVM can exit prematurely because all remaining threads
>   are daemon threads. When coupled with network partition detection this
>   can result in member departed events causing split brain scenarios -
>   [GEODE-1236].
> - The other issue is that when a member is starting up it may have
>   synchronized on the CacheFactory class waiting on disk store recovery.
>   This prevented gfsh shutdown to run as it would also try and
>   synchronize on the CacheFactory and be blocked.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
>  90b582b778e4df2b4b6b6cda045d83d9098d8c56 
> 
> Diff: https://reviews.apache.org/r/46402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #284 was SUCCESSFUL (with 1379 tests)

2016-04-19 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #284 was successful.
---
Scheduled
1383 tests in total.

https://build.spring.io/browse/SGF-NAG-284/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Bruce Schuchardt 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/#review129617
---


Ship it!




Ship It!

- Bruce Schuchardt


On April 19, 2016, 7:55 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46402/
> ---
> 
> (Updated April 19, 2016, 7:55 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This fixes two issues when using gfsh 'shutdown' command
> - One is that the JVM can exit prematurely because all remaining threads
>   are daemon threads. When coupled with network partition detection this
>   can result in member departed events causing split brain scenarios -
>   [GEODE-1236].
> - The other issue is that when a member is starting up it may have
>   synchronized on the CacheFactory class waiting on disk store recovery.
>   This prevented gfsh shutdown to run as it would also try and
>   synchronize on the CacheFactory and be blocked.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
>  90b582b778e4df2b4b6b6cda045d83d9098d8c56 
> 
> Diff: https://reviews.apache.org/r/46402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
---

(Updated April 19, 2016, 8:41 p.m.)


Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
Markito.


Changes
---

Removed AvailablePort changes. These changes have been moved to GEODE-1257.


Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233


Repository: geode


Description
---

GEODE-1233: apply FlakyTest category to Flaky tests

* Perform basic analysis on all JIRA tickets filed against flickering 
(intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // 
GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of 
pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.


Diffs (updated)
-

  
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 0abd85e 
  geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
9417d7a 
  geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
 2acab3a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
 1250d5a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
 8f8c966 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 feefb6d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
 8c455d4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
 5d44dfd 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
 c85a6d9 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
 4a4c38d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
 0853162 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
 677321f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
 8fc8049 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
 6463e88 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
 60fd6ff 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
ccd9df0 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
 3e5994d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
 639f93f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
 464b61c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
 426a8da 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
 27f5e36 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
 c9b9ac8 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
 26f0983 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
 f6836ae 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
 538132c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
 8d6160e 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
 1599271 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
 1da697f 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
64ca3ba 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java
 a1d6aca 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 
8dfe7a5 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
 52ebe24 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
 5eeb04e 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java
 710550b 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java
 7ab452

Review Request 46406: GEODE-1257: always setReuseAddress(true) regardless of OS

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46406/
---

Review request for geode, Anthony Baker, Bruce Schuchardt, Jens Deppe, Jinmei 
Liao, and Mark Bretl.


Bugs: GEODE-1257
https://issues.apache.org/jira/browse/GEODE-1257


Repository: geode


Description
---

GEODE-1257: always setReuseAddress(true) regardless of OS

I separated this change from my changes for GEODE-1233.


Diffs
-

  geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
9417d7a 

Diff: https://reviews.apache.org/r/46406/diff/


Testing
---

precheckin


Thanks,

Kirk Lund

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/#review129612
---


Ship it!




Ship It!

- Kirk Lund


On April 19, 2016, 7:55 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46402/
> ---
> 
> (Updated April 19, 2016, 7:55 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
> Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - This fixes two issues when using gfsh 'shutdown' command
> - One is that the JVM can exit prematurely because all remaining threads
>   are daemon threads. When coupled with network partition detection this
>   can result in member departed events causing split brain scenarios -
>   [GEODE-1236].
> - The other issue is that when a member is starting up it may have
>   synchronized on the CacheFactory class waiting on disk store recovery.
>   This prevented gfsh shutdown to run as it would also try and
>   synchronize on the CacheFactory and be blocked.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
>  90b582b778e4df2b4b6b6cda045d83d9098d8c56 
> 
> Diff: https://reviews.apache.org/r/46402/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 46276: GEODE-1215: Error running gfsh history

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46276/#review129611
---


Ship it!




Ship It!

- Kirk Lund


On April 15, 2016, 6:06 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46276/
> ---
> 
> (Updated April 15, 2016, 6:06 p.m.)
> 
> 
> Review request for geode, Jinmei Liao and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> - Issue probably surfaced with new jline library.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
>  daffa80ab06cb2027d36cd00cdc32c8eff99b5e3 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommandsDUnitTest.java
>  f5aa50600f85d59abe2a75449cc12cce31bea9a3 
> 
> Diff: https://reviews.apache.org/r/46276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/
---

(Updated April 19, 2016, 7:55 p.m.)


Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
Smith.


Repository: geode


Description (updated)
---

- This fixes two issues when using gfsh 'shutdown' command
- One is that the JVM can exit prematurely because all remaining threads
  are daemon threads. When coupled with network partition detection this
  can result in member departed events causing split brain scenarios -
  [GEODE-1236].
- The other issue is that when a member is starting up it may have
  synchronized on the CacheFactory class waiting on disk store recovery.
  This prevented gfsh shutdown to run as it would also try and
  synchronize on the CacheFactory and be  blocked.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 90b582b778e4df2b4b6b6cda045d83d9098d8c56 

Diff: https://reviews.apache.org/r/46402/diff/


Testing
---


Thanks,

Jens Deppe

Re: Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/
---

(Updated April 19, 2016, 7:55 p.m.)


Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
Smith.


Repository: geode


Description (updated)
---

- This fixes two issues when using gfsh 'shutdown' command
- One is that the JVM can exit prematurely because all remaining threads
  are daemon threads. When coupled with network partition detection this
  can result in member departed events causing split brain scenarios -
  [GEODE-1236].
- The other issue is that when a member is starting up it may have
  synchronized on the CacheFactory class waiting on disk store recovery.
  This prevented gfsh shutdown to run as it would also try and
  synchronize on the CacheFactory and be blocked.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 90b582b778e4df2b4b6b6cda045d83d9098d8c56 

Diff: https://reviews.apache.org/r/46402/diff/


Testing
---


Thanks,

Jens Deppe

Review Request 46402: GEODE-1236 GEODE-1248: Fix gfsh sutdown call

2016-04-19 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46402/
---

Review request for geode, Darrel Schneider, Jinmei Liao, Kirk Lund, and Dan 
Smith.


Repository: geode


Description
---

- This fixes two issues when using gfsh 'shutdown' command
- One is that the JVM can exit prematurely because all remaining threads
  are daemon threads. When coupled with network partition detection this
  can result in member departed events causing split brain scenarios -
  [GEODE-1236].
- The other issue is that when a member is starting up it may have
  synchronized on the CacheFactory class waiting on disk store recovery.
  This prevented gfsh shutdown to run as it would also try and
  synchronize on the CacheFactory and be blocked.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/ShutDownFunction.java
 90b582b778e4df2b4b6b6cda045d83d9098d8c56 

Diff: https://reviews.apache.org/r/46402/diff/


Testing
---


Thanks,

Jens Deppe

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Mark Bretl 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129602
---


Fix it, then Ship it!





geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
(lines 197 - 200)


Is this part of GEODE-1233? If it is, then can delete the commented code.


- Mark Bretl


On April 19, 2016, 11:20 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> ---
> 
> (Updated April 19, 2016, 11:20 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
> Markito.
> 
> 
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1233: apply FlakyTest category to Flaky tests
> 
> * Perform basic analysis on all JIRA tickets filed against flickering 
> (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // 
> GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of 
> pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
>  0abd85e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
> 9417d7a 
>   geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 937d8e4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
>  2acab3a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  1250d5a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  8f8c966 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  feefb6d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
>  8c455d4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  5d44dfd 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
>  c85a6d9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
>  4a4c38d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  0853162 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
>  677321f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
>  8fc8049 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
>  6463e88 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
>  60fd6ff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
> ccd9df0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
>  3e5994d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
>  639f93f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
>  464b61c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
>  426a8da 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
>  27f5e36 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
>  c9b9ac8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
>  26f0983 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
>  f6836ae 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
>  538132c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
>  8d6160e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
>  1599271 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
>  1da697f 
>   geode-core/src/test/java/co

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129594
---


Ship it!




Ship It!

- Anthony Baker


On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> ---
> 
> (Updated April 19, 2016, 6:20 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
> Markito.
> 
> 
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1233: apply FlakyTest category to Flaky tests
> 
> * Perform basic analysis on all JIRA tickets filed against flickering 
> (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // 
> GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of 
> pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
>  0abd85e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
> 9417d7a 
>   geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 937d8e4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
>  2acab3a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  1250d5a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  8f8c966 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  feefb6d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
>  8c455d4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  5d44dfd 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
>  c85a6d9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
>  4a4c38d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  0853162 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
>  677321f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
>  8fc8049 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
>  6463e88 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
>  60fd6ff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
> ccd9df0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
>  3e5994d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
>  639f93f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
>  464b61c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
>  426a8da 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
>  27f5e36 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
>  c9b9ac8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
>  26f0983 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
>  f6836ae 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
>  538132c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
>  8d6160e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
>  1599271 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
>  1da697f 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
> 64ca3ba 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java
>  a1d6aca 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/Loca

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129592
---


Ship it!




Ship It!

- Anthony Baker


On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> ---
> 
> (Updated April 19, 2016, 6:20 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
> Markito.
> 
> 
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1233: apply FlakyTest category to Flaky tests
> 
> * Perform basic analysis on all JIRA tickets filed against flickering 
> (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // 
> GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of 
> pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
>  0abd85e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
> 9417d7a 
>   geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 937d8e4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
>  2acab3a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  1250d5a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  8f8c966 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  feefb6d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
>  8c455d4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  5d44dfd 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
>  c85a6d9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
>  4a4c38d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  0853162 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
>  677321f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
>  8fc8049 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
>  6463e88 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
>  60fd6ff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
> ccd9df0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
>  3e5994d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
>  639f93f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
>  464b61c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
>  426a8da 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
>  27f5e36 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
>  c9b9ac8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
>  26f0983 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
>  f6836ae 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
>  538132c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
>  8d6160e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
>  1599271 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
>  1da697f 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
> 64ca3ba 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java
>  a1d6aca 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/Loca

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Kirk Lund 


> On April 19, 2016, 6:18 p.m., Anthony Baker wrote:
> > gradle/test.gradle, line 157
> > 
> >
> > This excludes 'flaky' tests from the distributedTest task.  Does this 
> > also apply to integrationTest?
> > 
> > How can I run just @FlakyTests?

That will require gradle changes. I've reverted the change I made to 
test.gradle. My plan was to annotate all flickering test methods with 
"FlakyTest" first and then later we can make any required changes to 
test.gradle.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129586
---


On April 19, 2016, 6:20 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> ---
> 
> (Updated April 19, 2016, 6:20 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
> Markito.
> 
> 
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1233: apply FlakyTest category to Flaky tests
> 
> * Perform basic analysis on all JIRA tickets filed against flickering 
> (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // 
> GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of 
> pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
>  0abd85e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
> 9417d7a 
>   geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 937d8e4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
>  2acab3a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  1250d5a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  8f8c966 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  feefb6d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
>  8c455d4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  5d44dfd 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
>  c85a6d9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
>  4a4c38d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  0853162 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
>  677321f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
>  8fc8049 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
>  6463e88 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
>  60fd6ff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
> ccd9df0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
>  3e5994d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
>  639f93f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
>  464b61c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
>  426a8da 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
>  27f5e36 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
>  c9b9ac8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
>  26f0983 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
>  f6836ae 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
>  538132c 
>   
> geode-core/src/test/java/com/gem

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
---

(Updated April 19, 2016, 6:20 p.m.)


Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
Markito.


Changes
---

Revert test.gradle change


Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233


Repository: geode


Description
---

GEODE-1233: apply FlakyTest category to Flaky tests

* Perform basic analysis on all JIRA tickets filed against flickering 
(intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // 
GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of 
pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.


Diffs (updated)
-

  
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 0abd85e 
  geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
9417d7a 
  geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
 2acab3a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
 1250d5a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
 8f8c966 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 feefb6d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
 8c455d4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
 5d44dfd 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
 c85a6d9 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
 4a4c38d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
 0853162 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
 677321f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
 8fc8049 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
 6463e88 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
 60fd6ff 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
ccd9df0 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
 3e5994d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
 639f93f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
 464b61c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
 426a8da 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
 27f5e36 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
 c9b9ac8 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
 26f0983 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
 f6836ae 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
 538132c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
 8d6160e 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
 1599271 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
 1da697f 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
64ca3ba 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java
 a1d6aca 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 
8dfe7a5 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
 52ebe24 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
 5eeb04e 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java
 710550b 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java
 7ab452b 
  
geode-core/src/test/java/com/gemstone/gemfir

Re: Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/#review129586
---




gradle/test.gradle (line 157)


This excludes 'flaky' tests from the distributedTest task.  Does this also 
apply to integrationTest?

How can I run just @FlakyTests?


- Anthony Baker


On April 19, 2016, 6:07 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46399/
> ---
> 
> (Updated April 19, 2016, 6:07 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
> Markito.
> 
> 
> Bugs: GEODE-1233
> https://issues.apache.org/jira/browse/GEODE-1233
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1233: apply FlakyTest category to Flaky tests
> 
> * Perform basic analysis on all JIRA tickets filed against flickering 
> (intermittently failing) tests.
> * Annotate each flickering test method with "@Category(FlakyTest.class) // 
> GEODE-xxx: basic analysis of pausible causes for flakiness".
> * Label each flickering JIRA ticket with "Flaky".
> * Add comment to each flickering JIRA ticket with the same "basic analysis of 
> pausible causes for flakiness".
> * Fix some obvious cases of "eats exceptions".
> * Add some TODOs to problem areas found in code.
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
>  0abd85e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
> 9417d7a 
>   geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 
> 937d8e4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
>  2acab3a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
>  1250d5a 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
>  8f8c966 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
>  feefb6d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
>  8c455d4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  5d44dfd 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
>  c85a6d9 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
>  4a4c38d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
>  0853162 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
>  677321f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
>  8fc8049 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
>  6463e88 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
>  60fd6ff 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
> ccd9df0 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
>  3e5994d 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
>  639f93f 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
>  464b61c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
>  426a8da 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
>  27f5e36 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
>  c9b9ac8 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
>  26f0983 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
>  f6836ae 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
>  538132c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
>  8d6160e 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
>  1599271 
>   
> geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
>  1da697f 
>   geode-core/src/test/java/com/gemstone/gemfire

Review Request 46399: GEODE-1233: apply FlakyTest category to flickering tests

2016-04-19 Thread Kirk Lund 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46399/
---

Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, and William 
Markito.


Bugs: GEODE-1233
https://issues.apache.org/jira/browse/GEODE-1233


Repository: geode


Description
---

GEODE-1233: apply FlakyTest category to Flaky tests

* Perform basic analysis on all JIRA tickets filed against flickering 
(intermittently failing) tests.
* Annotate each flickering test method with "@Category(FlakyTest.class) // 
GEODE-xxx: basic analysis of pausible causes for flakiness".
* Label each flickering JIRA ticket with "Flaky".
* Add comment to each flickering JIRA ticket with the same "basic analysis of 
pausible causes for flakiness".
* Fix some obvious cases of "eats exceptions".
* Add some TODOs to problem areas found in code.


Diffs
-

  
extensions/geode-modules-session/src/test/java/com/gemstone/gemfire/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
 0abd85e 
  geode-core/src/main/java/com/gemstone/gemfire/internal/AvailablePort.java 
9417d7a 
  geode-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java 937d8e4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/ConnectionPoolDUnitTest.java
 2acab3a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/pooling/ConnectionManagerJUnitTest.java
 1250d5a 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsDUnitTest.java
 8f8c966 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java
 feefb6d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java
 8c455d4 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
 5d44dfd 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingFunctionContextDUnitTest.java
 c85a6d9 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/QueryUsingPoolDUnitTest.java
 4a4c38d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/RemoteQueryDUnitTest.java
 0853162 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/QueryREUpdateInProgressJUnitTest.java
 677321f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/ConcurrentIndexUpdateWithInplaceObjectModFalseDUnitTest.java
 8fc8049 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/InitializeIndexEntryDestroyQueryDUnitTest.java
 6463e88 
  
geode-core/src/test/java/com/gemstone/gemfire/cache/query/partitioned/PRQueryCacheCloseDUnitTest.java
 60fd6ff 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/Bug44418JUnitTest.java 
ccd9df0 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheLogRollDUnitTest.java
 3e5994d 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/ClientMembershipDUnitTest.java
 639f93f 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckAsyncRegionDUnitTest.java
 464b61c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DiskDistributedNoAckRegionTestCase.java
 426a8da 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckPersistentRegionCCEDUnitTest.java
 27f5e36 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java
 c9b9ac8 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionDUnitTest.java
 26f0983 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionCCEDUnitTest.java
 f6836ae 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedNoAckRegionDUnitTest.java
 538132c 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java
 8d6160e 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/PartitionedRegionDUnitTest.java
 1599271 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionReliabilityTestCase.java
 1da697f 
  geode-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java 
64ca3ba 
  
geode-core/src/test/java/com/gemstone/gemfire/cache30/TXDistributedDUnitTest.java
 a1d6aca 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 
8dfe7a5 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
 52ebe24 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java
 5eeb04e 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/LocatorLoadSnapshotJUnitTest.java
 710550b 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/deadlock/GemFireDeadlockDetectorDUnitTest.java
 7ab452b 
  
geode-core/src/test/java/com/gemstone/gemfire/disttx/DistTXExpiryJUnitTest.java 
e9e7cc1 
  
geode-core/src/test/java/com/gemstone/gemfir

Re: AvailblePort

2016-04-19 Thread Bruce Schuchardt 

+1

I just tested this on Windows 7 and it worked fine


Le 4/19/2016 10:43 AM, Kirk Lund a écrit :

We're hitting BindExceptions a lot in precheckin runs. Another engineer
mentioned that he's seen port reuse (bind, unbind, repeat) fail even on
linux distros (not just windows).

Also, some of the discussions about BindException online seem to have
solutions involve using setReuseAddress(true) on linux.

I think we may need to change the following code in com.gemstone.gemfire.
internal.AvailablePort to call setReuseAddress(true) regardless of the OS.
Opinions?

197: server = new ServerSocket();
198: String osName = System.getProperty("os.name");
199: if(osName != null && !osName.startsWith("Windows")) {
200:   server.setReuseAddress(true);
201: }
202: if (addr != null) {
203:   server.bind(new InetSocketAddress(addr, port));
204: }
205: else {
206:   server.bind(new InetSocketAddress(port));
207: }

I'm going to try removing the conditional on line 199 and run precheckin.

Is there any additional kernel configuration settings on linux that might
affect this behavior as well?

-Kirk

AvailblePort

2016-04-19 Thread Kirk Lund 
We're hitting BindExceptions a lot in precheckin runs. Another engineer
mentioned that he's seen port reuse (bind, unbind, repeat) fail even on
linux distros (not just windows).

Also, some of the discussions about BindException online seem to have
solutions involve using setReuseAddress(true) on linux.

I think we may need to change the following code in com.gemstone.gemfire.
internal.AvailablePort to call setReuseAddress(true) regardless of the OS.
Opinions?

197: server = new ServerSocket();
198: String osName = System.getProperty("os.name");
199: if(osName != null && !osName.startsWith("Windows")) {
200:   server.setReuseAddress(true);
201: }
202: if (addr != null) {
203:   server.bind(new InetSocketAddress(addr, port));
204: }
205: else {
206:   server.bind(new InetSocketAddress(port));
207: }

I'm going to try removing the conditional on line 199 and run precheckin.

Is there any additional kernel configuration settings on linux that might
affect this behavior as well?

-Kirk

Re: Review Request 46356: GEODE-978: Increasing the port range used in CacheXmlGateway tests

2016-04-19 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46356/#review129571
---


Ship it!




Ship It!

- anilkumar gingade


On April 19, 2016, 12:50 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46356/
> ---
> 
> (Updated April 19, 2016, 12:50 a.m.)
> 
> 
> Review request for geode and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The tests were previously hardcoding a very narrow range of ports.
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml70GatewayDUnitTest.java
>  e9a47e26d8f7fbb217960114c9095282e988ccfa 
>   
> geode-wan/src/test/java/com/gemstone/gemfire/cache/CacheXml80GatewayDUnitTest.java
>  d04e91615100a1d405cc14438f8ee2413fba7143 
> 
> Diff: https://reviews.apache.org/r/46356/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 46354: GEODE-1072: Removing HDFS related code

2016-04-19 Thread Dan Smith 


> On April 19, 2016, 5:10 p.m., Jianxia Chen wrote:
> > Is the corresponding feature branch available now? Any JIRA ticket to track 
> > the feature branch?

I don't want to create the corresponding feature branch until after this is 
pushed. The reason is that I want to create the feature branch base on a 
revision after this removal, and then revert the removal on the feature branch. 
That will make future merges cleaner, because it will be clear that the feature 
branch is adding all of the HDFS functionality.

Hmm, as far as the jira ticket for the feature branch, I was originally 
thinking of using this ticket. But yeah, I should probably create a new ticket 
that more clearly desribes the cleanup needed before this feature can be merged 
back into develop. I'll do that.


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46354/#review129564
---


On April 19, 2016, 12:35 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46354/
> ---
> 
> (Updated April 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removing all HDFS and EvictionCriteria created code. This code will be
> reinstated on a branch to be cleaned up and merged as a separate module.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 2206018efeebb9c0105834dd09760592b7032873 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 
> 201c1aabb2f5452b980a3aa5ae7e1c5a949c1e61 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesMutator.java 
> eb46433979ea6c3c111d62ed16ed8eaba7bae143 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/CustomEvictionAttributes.java
>  c2bc41b93e458d3defa79c1ec5246368ede008ef 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java 
> 1e87c0f164e77555e6685841f75dd41044a3ab90 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/EvictionCriteria.java 
> 8df201c047e6ee1e19cd0ffda558eb658589d868 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/Operation.java 
> 7a63855389927a3805a2ecc86cce06a11a9a64fb 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionAttributes.java 
> dd5c0e0cb1ae553b4bbc9e044520235994adccb6 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionFactory.java 
> 729374ed6b6050dde92fd00de88615ede3283fd4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  d15222b85828d8b450e3aa5c8858502259a9e4e6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSIOException.java 
> d9b6179fa0377b18d6d333a022acc06ef52a8032 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java 
> 45ba370034c6b1385a35763bdff575f31c6694e8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreFactory.java
>  0d80a67354f61546f2ec13c6a3c4c43fc51a7288 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreMutator.java
>  d98c9cdb187f38d023cd6d5c4212fef1cb514bc8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/StoreExistsException.java
>  de21b2322cc41adf997607f0dd682006c055fe73 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FailureTracker.java
>  789d49765f4e4959a6e5b88b8ace3f8d5b99fb2b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FlushObserver.java
>  f69b3dc3b77854b10dfde40f503264a437a3163f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSBucketRegionQueue.java
>  9127e4dbc3edbe0dbd993ca3b72b68ed8cbb65ff 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEntriesSet.java
>  c8b7b282487b48edfcbed8f21a69c8b2b3c33de3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventListener.java
>  607650f30d44d4a792e0bbca3c2d495c84d098d1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventQueueFilter.java
>  0860e752dec9e0aa7d8efc21d09e0b84ea7b1a04 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSGatewayEventImpl.java
>  db99e7eb9b10bdfda4f64332221b73bf085e5ccd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSIntegrationUtil.java
>  740a607d48dd51d3cf82709f441fe7bbd96d37aa 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSParallelGatewaySenderQueue.java
>  1e6a0343ca9782f040d26c2259fe330155dfde5b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreConfigHolder.java
>  16d3d87762323b5dde0c90e2e6e91c356e86fe43 
>   
> geode-core/src/main/java/com/gemstone/gemfire/

Re: Review Request 46354: GEODE-1072: Removing HDFS related code

2016-04-19 Thread Jianxia Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46354/#review129564
---



Is the corresponding feature branch available now? Any JIRA ticket to track the 
feature branch?

- Jianxia Chen


On April 19, 2016, 12:35 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46354/
> ---
> 
> (Updated April 19, 2016, 12:35 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Jason Huynh, and nabarun nag.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Removing all HDFS and EvictionCriteria created code. This code will be
> reinstated on a branch to be cleaned up and merged as a separate module.
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle 2206018efeebb9c0105834dd09760592b7032873 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesFactory.java 
> 201c1aabb2f5452b980a3aa5ae7e1c5a949c1e61 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/AttributesMutator.java 
> eb46433979ea6c3c111d62ed16ed8eaba7bae143 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/CustomEvictionAttributes.java
>  c2bc41b93e458d3defa79c1ec5246368ede008ef 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/DataPolicy.java 
> 1e87c0f164e77555e6685841f75dd41044a3ab90 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/EvictionCriteria.java 
> 8df201c047e6ee1e19cd0ffda558eb658589d868 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/Operation.java 
> 7a63855389927a3805a2ecc86cce06a11a9a64fb 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionAttributes.java 
> dd5c0e0cb1ae553b4bbc9e044520235994adccb6 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/RegionFactory.java 
> 729374ed6b6050dde92fd00de88615ede3283fd4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  d15222b85828d8b450e3aa5c8858502259a9e4e6 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSIOException.java 
> d9b6179fa0377b18d6d333a022acc06ef52a8032 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java 
> 45ba370034c6b1385a35763bdff575f31c6694e8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreFactory.java
>  0d80a67354f61546f2ec13c6a3c4c43fc51a7288 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreMutator.java
>  d98c9cdb187f38d023cd6d5c4212fef1cb514bc8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/StoreExistsException.java
>  de21b2322cc41adf997607f0dd682006c055fe73 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FailureTracker.java
>  789d49765f4e4959a6e5b88b8ace3f8d5b99fb2b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/FlushObserver.java
>  f69b3dc3b77854b10dfde40f503264a437a3163f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSBucketRegionQueue.java
>  9127e4dbc3edbe0dbd993ca3b72b68ed8cbb65ff 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEntriesSet.java
>  c8b7b282487b48edfcbed8f21a69c8b2b3c33de3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventListener.java
>  607650f30d44d4a792e0bbca3c2d495c84d098d1 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventQueueFilter.java
>  0860e752dec9e0aa7d8efc21d09e0b84ea7b1a04 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSGatewayEventImpl.java
>  db99e7eb9b10bdfda4f64332221b73bf085e5ccd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSIntegrationUtil.java
>  740a607d48dd51d3cf82709f441fe7bbd96d37aa 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSParallelGatewaySenderQueue.java
>  1e6a0343ca9782f040d26c2259fe330155dfde5b 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreConfigHolder.java
>  16d3d87762323b5dde0c90e2e6e91c356e86fe43 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreCreation.java
>  9ecc5e37871dabe70764bf21a030a9c319dd2d11 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreFactoryImpl.java
>  749f01ce0414e454ada0ab3efb666e60ab33c445 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreImpl.java
>  b5d56b67059ebfdf56627be574c196e6597dc6d3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreMutatorImpl.java
>  203e6239eae5a7bc6eb2a23ddcbdfe570dbacc9d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSWriteOnlyStoreEventListener.java
>  0298523ee9a285d6c26bfe80bd35b74a10fdedf6 
>   
> geode-c