Re: Proposal - provide a callback to compute statistics

2016-06-06 Thread Dan Smith 
>
> Which thread are you proposing to invoke the new statistic provider SPIs?\
>

Yeah - that's the tricky question :) For the stats I want to collect, the
callbacks could be invoked in the stat sampler thread. But it think it
probably makes sense to invoke these callbacks on a separate thread, just
in case someone installs a bad callback it won't completely take down
statistics collection. The downside is that the stats collected with these
callbacks may be slightly stale. What do you think?

-Dan

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-06 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/#review136389
---


Ship it!




Ship It!

- Dan Smith


On June 6, 2016, 8:26 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48188/
> ---
> 
> (Updated June 6, 2016, 8:26 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt, 
> Jason Huynh, William Markito, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The CQEvents as seen by CQs are cached in order to avoid applying CQ queries 
> on old values.
> 
> In case of a destory CQEvent, the CQEvents are marked with destroy tokens and 
> removed from
> the cache after the CQEvent is added to HAQueue.
> This works fine for the CQs registered locally, but for the CQs registered on 
> peer server, the
> CQs weren't removed from the cache, which resulted in generating wrong 
> CQEvent for subsequent
> operation.
> This change removes the destroy CQevent from the cache after the CQEvent is 
> distributed to
> peer server.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java
>  6a7b4f2 
>   
> geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java
>  ee8ea9f 
> 
> Diff: https://reviews.apache.org/r/48188/diff/
> 
> 
> Testing
> ---
> 
> Reproduce the issue with manual testing. The test passed after the changes 
> are made to remove cached destroy events from remote CQs.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>

Re: Proposal - provide a callback to compute statistics

2016-06-06 Thread Kirk Lund 
Which thread are you proposing to invoke the new statistic provider SPIs?\

-Kirk


On Thu, Jun 2, 2016 at 2:31 PM, Dan Smith  wrote:

> On Thu, Jun 2, 2016 at 11:47 AM, Darrel Schneider 
> wrote:
>
> > Statistics are supposed to work even if you don't have sampling enabled.
> > For example you could turn off sampling and not have a statistic archive
> > but could still run a gfsh command that fetches a bunch of stats from the
> > running system or use the pulse tool.
> >
> > However you can leave sampling turned on even if you do not have a
> > statistic archive and it is true that our current OSStats (linux,
> windows,
> > solaris) and VMStats are only updated when sampling is enabled.
> > If you go with that then you just need to make clear that your sampler
> will
> > only be called if the config property "statistic-sampling-enabled" is
> true
> > and the frequency of calls will be determined by the config property
> > "statistic-sample-rate".
> >
>
> Interesting. I think it make sense for these stats to be controlled by the
> statistic-sampling-enabled property. It looks like that property defaults
> to true, and the javadocs say that if you turn it off some of your stats
> will display as 0.
>
> -Dan
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #332 was SUCCESSFUL (with 1398 tests)

2016-06-06 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #332 was successful.
---
Scheduled
1400 tests in total.

https://build.spring.io/browse/SGF-NAG-332/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Darrel Schneider 


> On June 6, 2016, 2:51 p.m., Ken Howe wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java,
> >  lines 919-924
> > 
> >
> > Couldn't these statements be coalesced? "entriesEqual" doesn't look 
> > like it's used anywhere else.

They could be but that seems outside the scope of removing the sqlf code.
The old code also only used the local var "entriesEqual" once but still wanted 
this local var.
Since these 6 lines of code were not modified by these changes I'd prefer to 
leave it that way.


- Darrel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136365
---


On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 3:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Bu

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Eric Shu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136373
---


Ship it!




- Eric Shu


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java
>  84e44d84807ae05440edd664d1a4b0ab79bf9ea0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java
>  72edc1076c5480a665bba39af21

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136370
---


Ship it!




Reviewed pages 1 & 2 of the diffs.

- Ken Howe


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java
>  84e44d84807ae05440edd664d1a4b0ab79bf9ea0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Ken Howe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136365
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
 (lines 373 - 374)


Add the removed word "for". Comment shold read, "...icon to appear for 
launched procs"



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java
 (line 210)


Correct typo in string "never e" should be "never be"



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java
 (lines 888 - 893)


Couldn't these statements be coalesced? "entriesEqual" doesn't look like 
it's used anywhere else.


- Ken Howe


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-06 Thread anilkumar gingade 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/
---

(Updated June 6, 2016, 8:26 p.m.)


Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt, 
Jason Huynh, William Markito, nabarun nag, Dan Smith, and xiaojian zhou.


Changes
---

Addressed NPE with CacheProfile (cf.filterProfile) found during testing.


Repository: geode


Description
---

The CQEvents as seen by CQs are cached in order to avoid applying CQ queries on 
old values.

In case of a destory CQEvent, the CQEvents are marked with destroy tokens and 
removed from
the cache after the CQEvent is added to HAQueue.
This works fine for the CQs registered locally, but for the CQs registered on 
peer server, the
CQs weren't removed from the cache, which resulted in generating wrong CQEvent 
for subsequent
operation.
This change removes the destroy CQevent from the cache after the CQEvent is 
distributed to
peer server.


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java
 6a7b4f2 
  
geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/PrCqUsingPoolDUnitTest.java
 ee8ea9f 

Diff: https://reviews.apache.org/r/48188/diff/


Testing
---

Reproduce the issue with manual testing. The test passed after the changes are 
made to remove cached destroy events from remote CQs.


Thanks,

anilkumar gingade

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Scott Jewell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136326
---


Ship it!




Page 4 reviewed - looks good

- Scott Jewell


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java
>  84e44d84807ae05440edd664d1a4b0ab79bf9ea0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.j

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136325
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 (line 570)


removed unneeded indentation


- Darrel Schneider


On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 3:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cac

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136322
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java
 (line 25)


removed the extra the


- Darrel Schneider


On June 2, 2016, 3:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 3:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeseriali

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Sai Boorlagadda 


> On June 6, 2016, 5:25 p.m., Sai Boorlagadda wrote:
> > Ship It!

Reviewed pages 5 & 6


- Sai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136315
---


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java
>  84e44d84807ae05440edd664d1a4b0ab79bf9ea0 
>   
> geode-core/src/main/java/com/gemstone/ge

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Sai Boorlagadda 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136315
---


Ship it!




Ship It!

- Sai Boorlagadda


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheDistributionAdvisor.java
>  4a34771388da63a648c6d7763fc39334aa716b38 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheServerLauncher.java
>  d4c19ce6e0d464e90fd62935e00e7a7be72ce659 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/CachedDeserializableFactory.java
>  84e44d84807ae05440edd664d1a4b0ab79bf9ea0 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java
>  72edc1076c

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

2016-06-06 Thread Sai Boorlagadda 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48189/#review136309
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PREntriesIterator.java
 (line 25)


Alteast one 'the' can be removed or both as in "This interface provides 
bucket ID..."



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
 (line 570)


The statement prQ.shadowPRWaitForBucketRecovery does not need to be wrapped 
with "{" & "}"?


- Sai Boorlagadda


On June 2, 2016, 10:20 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48189/
> ---
> 
> (Updated June 2, 2016, 10:20 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai 
> Boorlagadda.
> 
> 
> Bugs: GEODE-1464
> https://issues.apache.org/jira/browse/GEODE-1464
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> removed internal Delta (only used by sqlf)
> removed sqlfDisconnectListener
> removed getStringForSQLF
> removed sqlfabric.sys-disk-dir system property
> removed unInitializedMembers and deferredVolunteerForPrimary
> removed sqlf serialization code
> removed GemFireUtilLauncher
> removed afterValueOverflow
> removed preferObject, eager deserialize, and KeyWithRegionContext
> removed unused sqlf methods in PartitionedRegion
> removed memberUnInitialized
> removed sqlf from DiskEntry
> removed setCallbackArgument from EntryOperationImpl
> removed distributeUpdatedProfileOnHubCreation
> removed getEntriesInTxForSqlFabric
> removed withRoutingObjects and hasRoutingObjects
> removed resetBucketAdvisorParents
> rebalance no longer calls GemFireCacheImpl.getInstance comments
> removed sqlf log messages
> removed sqlf OffHeapIdentifiers
> removed SqlfSerializationException from sanctionedSerializables
> removed static helper methods from DiskWriteAttributesImpl
> removed contextObject from EntryEventImpl
> remove serializeCallbackArg from WrappedCallbackArgument since it was always 
> true
> removed getLeaderRegionName and getColocatedRegionName
> removed newPutEntryEvent
> removed clearLocalPrimaries
> removed call to non-existent OSProcess$NativeOSCalls
> removed putDML
> removed getClassesToSerializers
> simplified cleanUpOnImcompleteOp
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/IndexUpdater.java
>  facbdf2cecd699361c3cc7782a38ab21d436637e 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionMessage.java
>  bb36b8023b050f17e2d8e742875c736bcabf7755 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
>  552dbe3e2aeda91a6dbce7d0f27e07c038f683cc 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java
>  e5e8cbfb9ab734d93fea991b1d6715b9a7b31a9e 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSCODE.java 
> 8d91c6b7e616e42f0c92da07492c2ade4d8e3e6f 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java 
> bd78f5ae78953fab616f2ada870aa1aa920d56f3 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
>  7427f9009dfb732971970a518a2a27adc81c62cd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireUtilLauncher.java
>  fa19049a8f2e1af70250a7c18abe3d4fa8d27a26 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/InternalDataSerializer.java
>  bff592b5ac8dc98f7bcd716910ae4c776fadb358 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 
> 515b27dcf0ff38ea5f1024f7ba8b7262172c203a 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/Version.java 
> 258eaf0e683da7ce4025f5cf388574935dcc3bc4 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/VersionedDataStream.java
>  a2711ffee9e7575edeff8cd921a3168883ce9ec8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractDiskRegionEntry.java
>  b65b7addc4d572b262b0a0a8a99ee4a79ac0390f 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  25cc818603e5a4f1a0a10f57a2861afb0599bd81 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  0cbec19408198a5d4fc7f975b43ad4075e29a580 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketAdvisor.java
>  c241c6b7760e0cde59facd7f708c716f563eb2a9 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java
>  e2482bb5592546d280c6f3fb73f7775e9a174afd 
>   
> geode-core/src/main/

[GitHub] incubator-geode pull request #149: GEODE-1331: gfsh.bat on Windows is incorr...

2016-06-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #491

2016-06-06 Thread Apache Jenkins Server 
See 

--
[...truncated 585 lines...]
at org.junit.Assert.fail(Assert.java:88)
at 
com.gemstone.gemfire.test.dunit.Wait.waitForCriterion(Wait.java:185)
at 
com.gemstone.gemfire.security.SecurityTestUtils.waitForCondition(SecurityTestUtils.java:546)
at 
com.gemstone.gemfire.security.SecurityTestUtils.waitForCondition(SecurityTestUtils.java:527)
at 
com.gemstone.gemfire.security.ClientAuthorizationTestCase.doOp(ClientAuthorizationTestCase.java:355)
at 
com.gemstone.gemfire.security.DeltaClientPostAuthorizationDUnitTest.lambda$executeOpBlock$5613dd4c$1(DeltaClientPostAuthorizationDUnitTest.java:209)

7270 tests completed, 1 failed, 23 skipped
:geode-core:distributedTest FAILED
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest

com.gemstone.gemfire.security.ClientPostAuthorizationDUnitTest > 
testAllOpsNotifications FAILED
com.gemstone.gemfire.test.dunit.RMIException: While invoking 
com.gemstone.gemfire.test.dunit.NamedRunnable.run in VM 3 running on Host 
asf902.gq1.ygridcore.net with 4 VMs
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:389)
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:355)
at com.gemstone.gemfire.test.dunit.VM.invoke(VM.java:280)
at 
com.gemstone.gemfire.security.ClientAuthorizationTestCase.executeOpBlock(ClientAuthorizationTestCase.java:757)
at 
com.gemstone.gemfire.security.ClientPostAuthorizationDUnitTest.testAllOpsNotifications(ClientPostAuthorizationDUnitTest.java:159)

Caused by:
java.lang.AssertionError: Event never occurred after 12000 ms: null

423 tests completed, 1 failed, 2 skipped
:geode-cq:distributedTest FAILED
:geode-cq:integrationTest
:geode-joptsimple:assemble
:geode-joptsimple:compileTestJava UP-TO-DATE
:geode-joptsimple:processTestResources UP-TO-DATE
:geode-joptsimple:testClasses UP-TO-DATE
:geode-joptsimple:checkMissedTests UP-TO-DATE
:geode-joptsimple:test UP-TO-DATE
:geode-joptsimple:check
:geode-joptsimple:build
:geode-joptsimple:distributedTest UP-TO-DATE
:geode-joptsimple:integrationTest UP-TO-DATE
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar
:geode-rebalancer:signArchives SKIPPED
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:proc