Build failed in Jenkins: Geode-release #19

2016-08-01 Thread Apache Jenkins Server 
See 

--
[...truncated 916 lines...]
:geode-assembly:distTar
:geode-assembly:distZip
:geode-assembly:writeBuildInfo
:geode-assembly:srcDistTar
:geode-assembly:srcDistZip
:geode-assembly:signArchives SKIPPED
:geode-assembly:assemble
:geode-assembly:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpclient/4.5.1/httpclient-4.5.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.5.1/httpcomponents-client-4.5.1.pom
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpcore/4.4.3/httpcore-4.4.3.pom
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.4.3/httpcomponents-core-4.4.3.pom
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpclient/4.5.1/httpclient-4.5.1.jar
Download 
https://repo1.maven.org/maven2/org/apache/httpcomponents/httpcore/4.4.3/httpcore-4.4.3.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:checkMissedTests
:geode-assembly:installDist
:geode-assembly:test
:geode-assembly:check
:geode-assembly:build
:geode-assembly:distributedTest
:geode-assembly:flakyTest

com.gemstone.gemfire.rest.internal.web.controllers.RestAPIsOnMembersFunctionExecutionDUnitTest
 > testFunctionExecutionOnAllMembers FAILED
java.lang.AssertionError: unable to locate geode-web-api WAR file

java.lang.NullPointerException

1 test completed, 1 failed
:geode-assembly:flakyTest FAILED
:geode-assembly:integrationTest
:geode-common:assemble
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:checkMissedTests
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:flakyTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
Download 
https://repo1.maven.org/maven2/org/apache/derby/derby/10.2.2.0/derby-10.2.2.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/derby/derby/10.2.2.0/derby-10.2.2.0.jar
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:flakyTest
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJava
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.0.0/lucene-test-framework-6.0.0.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.0.0/lucene-codecs-6.0.0.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.3.2/randomizedtesting-runner-2.3.2.pom
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-parent/2.3.2/randomizedtesting-parent-2.3.2.pom
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-test-framework/6.0.0/lucene-test-framework-6.0.0.jar
Download 
https://repo1.maven.org/maven2/org/apache/lucene/lucene-codecs/6.0.0/lucene-codecs-6.0.0.jar
Download 
https://repo1.maven.org/maven2/com/carrotsearch/randomizedtesting/randomizedtesting-runner/2.3.2/randomizedtesting-runner-2.3.2.jar
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build

Re: Flaky tests failing with BindException

2016-08-01 Thread Kirk Lund 
Quite a few Geode tests already use Rules including TemporaryFolder.

I do like the idea of repackaging some of our re-used testing components as
Rules. Some of our testing utilities would make ideal candidates for
repackaging as Rules include:

* IgnoredException
* AvailablePortHelper
* DistributedTestUtils.deleteLocatorStateFile

We already have a few custom Rules in the Geode codebase that have been
tweaked specially for use in dunit tests:

* DistributedRestoreSystemProperties (restores System properties across
every dunit VM)
* DistributedDisconnectRule (similar to disconnectAllFromDS but repackaged
as a Rule)
* DistributedExternalResource (similar to ExternalResource but applies to
every dunit VM)
* SerializableRuleList
* SerializableTemporaryFolder (extends a TemporaryFolder Rule to work
across every dunit VM)
* SerializableTestName (serializable so that all dunit VMs see the TestName)
* SerializableTimeout (serializable version of our own Timeout Rule)

-Kirk


On Fri, Jul 29, 2016 at 2:35 PM, William Markito 
wrote:

> Why not create a JUnit rule that returns available ports and keep track of
> ports being used ?
>
> I've cloned this gist from somewhere (don't remember now) but I've planning
> to send it for discussion...
>
> https://gist.github.com/markito/b5be3fc570c7c7c84e6d09e064a6e898
>
> Still talking about rules, I've played a bit with the TemporaryFolder rule
> and that's very useful as well, specially to clean up after test runs and
> to avoid conflicts.
>
> http://junit.org/junit4/javadoc/4.12/org/junit/rules/TemporaryFolder.html
>
> Just my 2c
>
> On Fri, Jul 29, 2016 at 1:54 PM, Hitesh Khamesra <
> hitesh...@yahoo.com.invalid> wrote:
>
> > Is there any possibility of running multiple test same time on that
> > machine?
> >
> > -Hitesh
> >
> >
> >   From: Kirk Lund 
> >  To: geode 
> >  Sent: Friday, July 29, 2016 1:21 PM
> >  Subject: Flaky tests failing with BindException
> >
> > Many of our flaky tests are flaky because they use AvailablePort or
> > AvailablePortHelper to find randomly available ports. They then later
> fail
> > with a BindException because the port is already in use by the time the
> > test uses it.
> >
> > Here's a proposal for a temporary fix:
> >
> > The module geode-junit contains a JUnit 4 rule called RetryRule. We could
> > modify RetryRule to only retry if a BindException (or configurable
> > exception/s) is detected. This rule would then be dropped into every test
> > that uses AvailablePort or AvailablePortHelper. Then if the test fails
> with
> > a BindException, it would automatically retry (once or twice or whatever
> we
> > decide to configure RetryRule with). If the test fails without any
> detected
> > BindException, then it would just fail without retrying.
> >
> > Opinions on this?
> >
> > Thanks,
> > Kirk
> >
> >
> >
> >
>
>
>
> --
>
> ~/William
>

Re: Flaky tests failing with BindException

2016-08-01 Thread Kirk Lund 
I think that the changes mentioned by Jens and Bruce obviate the need to do
what I was proposing.

-Kirk


On Fri, Jul 29, 2016 at 3:41 PM, Bruce Schuchardt 
wrote:

> I'm making another change that will help.
>
> One of the problems with these tests is that they will choose a random
> port for a Cache Server or some other component and only use the port after
> opening a cache.  Doing that allows the communications/membership component
> to grab two ports. AvailablePort restricts the ports it hands out to the
> range [2, 3], so if we restrict the communications/membership
> component to use ports outside of that range it will help avoid collisions.
>
>
> Le 7/29/2016 à 3:23 PM, Nabarun Nag a écrit :
>
>> +1 for the retry.
>>
>> In my opinion, maintaining available port lists maybe hard as we move
>> towards running test modules in parallel. Also maybe some non-geode entity
>> may come up and pick up a port hence we will need to constantly
>> refresh/update the list before/after each test run. (1 ports needs to
>> be checked as per geode getRandomWildcardBindPortNumber)
>>
>>
>> Also for GEODE-1600 fix, DUnitLauncher now passes 0 as the port number
>> while creating a locator. The system assigns it an available port number
>> while staring the server rather than getting a random available port
>> number
>> first then asking things to be started on that port. (race conditions
>> ensues )
>>
>> On Fri, Jul 29, 2016 at 2:36 PM William Markito 
>> wrote:
>>
>> Why not create a JUnit rule that returns available ports and keep track of
>>> ports being used ?
>>>
>>> I've cloned this gist from somewhere (don't remember now) but I've
>>> planning
>>> to send it for discussion...
>>>
>>> https://gist.github.com/markito/b5be3fc570c7c7c84e6d09e064a6e898
>>>
>>> Still talking about rules, I've played a bit with the TemporaryFolder
>>> rule
>>> and that's very useful as well, specially to clean up after test runs and
>>> to avoid conflicts.
>>>
>>> http://junit.org/junit4/javadoc/4.12/org/junit/rules/TemporaryFolder.html
>>>
>>> Just my 2c
>>>
>>> On Fri, Jul 29, 2016 at 1:54 PM, Hitesh Khamesra <
>>> hitesh...@yahoo.com.invalid> wrote:
>>>
>>> Is there any possibility of running multiple test same time on that
 machine?

 -Hitesh


From: Kirk Lund 
   To: geode 
   Sent: Friday, July 29, 2016 1:21 PM
   Subject: Flaky tests failing with BindException

 Many of our flaky tests are flaky because they use AvailablePort or
 AvailablePortHelper to find randomly available ports. They then later

>>> fail
>>>
 with a BindException because the port is already in use by the time the
 test uses it.

 Here's a proposal for a temporary fix:

 The module geode-junit contains a JUnit 4 rule called RetryRule. We
 could
 modify RetryRule to only retry if a BindException (or configurable
 exception/s) is detected. This rule would then be dropped into every
 test
 that uses AvailablePort or AvailablePortHelper. Then if the test fails

>>> with
>>>
 a BindException, it would automatically retry (once or twice or whatever

>>> we
>>>
 decide to configure RetryRule with). If the test fails without any

>>> detected
>>>
 BindException, then it would just fail without retrying.

 Opinions on this?

 Thanks,
 Kirk





>>>
>>> --
>>>
>>> ~/William
>>>
>>>
>

Re: Review Request 50680: fix replace on overflowed entry

2016-08-01 Thread Eric Shu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50680/#review144407
---


Ship it!




Ship It!

- Eric Shu


On Aug. 1, 2016, 11:17 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50680/
> ---
> 
> (Updated Aug. 1, 2016, 11:17 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Eric Shu, Scott Jewell, and Ken Howe.
> 
> 
> Bugs: GEODE-1718
> https://issues.apache.org/jira/browse/GEODE-1718
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test demonstrated that replace would return false when done on an 
> overflowed entry.
> With the fix the test passes.
> Also added a null check in checkPdxEquals to prevent NPE if obj is ever null.
> If obj is null checkPdxEquals will now call basicEquals which handles testing 
> null.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  15a5bed750b676c668ddde64291a5b315fca90fd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  f3cb3d654087c797de430f448348c3ba66846ac4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ReplaceWithOverflowJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50680/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Re: Review Request 50680: fix replace on overflowed entry

2016-08-01 Thread Barry Oglesby 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50680/#review144405
---


Ship it!




Ship It!

- Barry Oglesby


On Aug. 1, 2016, 11:17 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50680/
> ---
> 
> (Updated Aug. 1, 2016, 11:17 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Eric Shu, Scott Jewell, and Ken Howe.
> 
> 
> Bugs: GEODE-1718
> https://issues.apache.org/jira/browse/GEODE-1718
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test demonstrated that replace would return false when done on an 
> overflowed entry.
> With the fix the test passes.
> Also added a null check in checkPdxEquals to prevent NPE if obj is ever null.
> If obj is null checkPdxEquals will now call basicEquals which handles testing 
> null.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  15a5bed750b676c668ddde64291a5b315fca90fd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  f3cb3d654087c797de430f448348c3ba66846ac4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ReplaceWithOverflowJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50680/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

Review Request 50680: fix replace on overflowed entry

2016-08-01 Thread Darrel Schneider 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50680/
---

Review request for geode, Barry Oglesby, Eric Shu, Scott Jewell, and Ken Howe.


Bugs: GEODE-1718
https://issues.apache.org/jira/browse/GEODE-1718


Repository: geode


Description
---

New unit test demonstrated that replace would return false when done on an 
overflowed entry.
With the fix the test passes.
Also added a null check in checkPdxEquals to prevent NPE if obj is ever null.
If obj is null checkPdxEquals will now call basicEquals which handles testing 
null.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
 15a5bed750b676c668ddde64291a5b315fca90fd 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
 f3cb3d654087c797de430f448348c3ba66846ac4 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ReplaceWithOverflowJUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50680/diff/


Testing
---

precheckin


Thanks,

Darrel Schneider

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #388 was SUCCESSFUL (with 1423 tests)

2016-08-01 Thread Spring CI 

---
Spring Data GemFire > Nightly-ApacheGeode > #388 was successful.
---
Scheduled
1425 tests in total.

https://build.spring.io/browse/SGF-NAG-388/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] incubator-geode issue #222: GEODE-11: Fixing creation of replicated region a...

2016-08-01 Thread gesterzhou 
Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/222
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #222: GEODE-11: Fixing creation of replicated r...

2016-08-01 Thread aparnard 
GitHub user aparnard opened a pull request:

https://github.com/apache/incubator-geode/pull/222

GEODE-11: Fixing creation of replicated region after an error is thrown

If a replicated region is created after a lucene index is defined, an error 
is thrown but the region is still created (since this check is done in the 
afterCreate method). This was fixed by moving the check to the beforeCreate 
method of the region listener.

Signed-off-by: Gester Zhou 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aparnard/incubator-geode 
feature/GEODE-11-create-index-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit e059013070cb61b468cbe8f3c14bcd3e70aadbd4
Author: Aparna Dharmakkan 
Date:   2016-08-01T21:54:39Z

GEODE-11: Fixing creation of replicated region after index creation.

If a replicated region is created after a lucene index is defined, an error 
is thrown but the region is created (since this check is done in the 
afterCreate method). This was fixed by moving the check to the beforeCreate 
method of the region listener.

Signed-off-by: Gester Zhou 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 50420: there is a race that cache is still initializing, some components are not ready

2016-08-01 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50420/#review144339
---


Ship it!




Aha, it's the accessor that's the problem! Good catch, change looks good!

- Dan Smith


On July 29, 2016, 10:13 p.m., xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50420/
> ---
> 
> (Updated July 29, 2016, 10:13 p.m.)
> 
> 
> Review request for geode, anilkumar gingade and Dan Smith.
> 
> 
> Bugs: GEODE-1671
> https://issues.apache.org/jira/browse/GEODE-1671
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Need to add Awaitility.waitAtMost
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java
>  dc86a7c 
> 
> Diff: https://reviews.apache.org/r/50420/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Re: Review Request 50604: GEODE-1666: Bump Gradle from 2.12 to 2.14

2016-08-01 Thread Jens Deppe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50604/
---

(Updated Aug. 1, 2016, 2:11 p.m.)


Review request for geode, Anthony Baker and Dan Smith.


Changes
---

Fix minimumGradleVersion


Repository: geode


Description
---

GEODE-1666: Bump Gradle from 2.12 to 2.14


Diffs (updated)
-

  gradle.properties 4d1cce91d8a419abad0472237fd54a8814a5c3eb 
  gradle/wrapper/gradle-wrapper.properties 
ec27a3978e43e387385f32e0ad8b1d62359afd07 

Diff: https://reviews.apache.org/r/50604/diff/


Testing
---

Run through complete build in concourse


Thanks,

Jens Deppe

Re: Review Request 50604: GEODE-1666: Bump Gradle from 2.12 to 2.14

2016-08-01 Thread Anthony Baker 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50604/#review144331
---



Do you need to update the minimumGradleVersion in gradle.properties?

- Anthony Baker


On July 29, 2016, 2:50 p.m., Jens Deppe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50604/
> ---
> 
> (Updated July 29, 2016, 2:50 p.m.)
> 
> 
> Review request for geode, Anthony Baker and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1666: Bump Gradle from 2.12 to 2.14
> 
> 
> Diffs
> -
> 
>   gradle/wrapper/gradle-wrapper.properties 
> ec27a3978e43e387385f32e0ad8b1d62359afd07 
> 
> Diff: https://reviews.apache.org/r/50604/diff/
> 
> 
> Testing
> ---
> 
> Run through complete build in concourse
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>