GEMFIRE env var

[Anthony Baker]

I was looking at the geode-assembly build script and noticed this:

tasks.withType(Test){
  environment 'GEMFIRE', "$buildDir/install/${distributions.main.baseName}/lib”
}

…

// Create a configuration closure to configure test targets with the install 
directory
def dependOnInstalledProduct = {
  dependsOn installDist
  def install = file("$buildDir/install/${distributions.main.baseName}")
  environment ('GEMFIRE', install)
}


Any idea why we setting the GEMFIRE var twice to different values?  I think the 
first one is wrong.

Anthony



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50715/#review144540
---




geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java
 (line 226)


Instead of a thread per missing child how about just one thread that 
monitors all the missing children? Instead of the PartitionedRegino having a 
list have ColocationLoggers it could have a single ColocationLogger and the 
ColocationLogger could have a list of missing children.

Seems like this might scale better and make it easier for an offline reason 
the log all of the reasons it is still offline (it could log that it has 
children that exist but that are themselves offline).



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java
 (line 401)


Seems like you should change: 
getRegionIdentifier(partitionedRegion.getFullPath())
to:
partitionedRegion.getRegionIdentifier()



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 36)


any reason for keeping the commented out stuff?



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 40)


A better name would be "childFullPath"



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 41)


add final on the inst vars that never change



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 49)


make the time units (millis) clear.
Also seems like LOG_INTERVAL should be and inst var instead of static (or 
does it need to be static for the test hooks?)



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 52)


typo



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 78)


I would put this sync on setMissingChildRegions.
Also this seems like when you would also want to do a notify so the thread 
could wakeup and detect that it is no longer needed.



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 118)


something is missing between "that  of".



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 125)


get rid of "== true". I see it multiple times.



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 141)


Get rid of "printStackTrace". The logger will log the stack trace. Once is 
enough.



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 146)


This should not be a bitwise operator "&". Instead it should be logical op 
"&&".



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 (line 151)


This notify does not make sense. You should not be notifing yourself.



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 (line 306)


can this be made final?



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 (line 7464)


I think it is bad practice to have assignment it expressions.
Also I don't see any need for this isEmpty check.
I think this method body could just be:
for (ColocationLogger offlineChildLogger: getOfflineColcatedLoggers()) {
  offlineChildLogger.setRegionDestroyed(true);
}



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 (line 7468)


This sync and notify should all be in the setRegionDestroyed method.
getLoggerLock should be private



geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 (line 7475)


typo: "Colcated" shouldbe "Colocated"



geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java
 (line 3763)


Instead of "is not present" how about "must be created" or "does not exist".

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #389 was SUCCESSFUL (with 1423 tests). Change made by John Blum <jb...@pivotal.io>.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #389 was successful.
---
Scheduled with changes by John Blum .
1425 tests in total.

https://build.spring.io/browse/SGF-NAG-389/




--
Code Changes
--
John Blum  (186157a97d65467e290742808464048fa61e306d):

>SGF-510 - Create 1.0.0.APACHE-GEODE-INCUBATING-M3-SNAPSHOT.
>Upgrade Spring Framework version to 4.2.7.RELEASE.
>
>Upgrade Spring Data Build version to 1.8.2.RELEASE.
>
>Upgrade Spring Data Commons version to 1.12.2.RELEASE.
>
>Upgrade SLF4J version to 1.7.21.
>
>Update Jackson version to 2.7.6.



--
This message is automatically generated by Atlassian Bamboo

Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50715/
---

Review request for geode.


Repository: geode


Description
---

Test for missing parent regions on child region creates and throw 
IllegalStateException

Log warnings about missing colocated child regions.

Create Unit and DUnit tests for new exceptions and warnings

There are two cases of missing colocated regions,
1) The 'parent' region hasn't been created when a region specifies it in the 
'colocated-with' attribute
2) A persistent child region does not exist.

For (1), this condition can be determined in 
ColocationHelper.getColocatedRegion(). The core product currently does not test 
for this which results in an NPE being thrown without any logging to indicate 
the reason. There are two variations of this state.

1a) When starting a region with non-null 'colocated'with', a reference to the 
parent region configuration is obtained through the configuration root. When 
the reference obtained is null (the region doesn't exist in the root 
configuration) the NPE ends up getting thrown. The fix for this is to 
immediately throw an IllegalStateException with a message to note the missing 
colocated-with region.

1b) The parent region configuration may exist in the root configuration (the 
parent PR has been created on another member) but does not exist on the local 
member. In this case the null comes about when obtaining the local region 
(PartitionedRegion.getPRFromId()). The fix here is the same as (1a) - throw an 
IllegalStateException.

For (2), missing child regions: This state will always exist for an 
indeterminate period because the parent is always created before the child 
region. There currently isn't any indication in the logs of this condition, 
even it if persists indefinitely, other than a failure to recover the PR's 
persistent data. The fix for this is starting a logging thread (similar to the 
RedundancyLogger) when a child region is found missing. The condition will be 
periodically logged (set initially to 30 secs) until the region is created. 
There is a delay before the first log message to allow time for the normal 
sequencing of region creations.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationHelper.java
 012a77f3eeaaa5d1c782c6f868ced017a9a26163 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ColocationLogger.java
 PRE-CREATION 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionRegionConfig.java
 6d7c1ca6c1588bf5f36a021a5d6e9c9a97cd7487 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java
 9ac95a1f9c0ab880d6cab8a350bd9c4842797d5d 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java
 2254a895f2cfdb189727fe8cdce3f770c9c48364 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ColocationHelperTest.java
 PRE-CREATION 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 d8b351417575c3e164e634a91f3ff0e7218860ed 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java
 692378c6dacf5ea4def4f1dbfec7744beb2bc9c6 

Diff: https://reviews.apache.org/r/50715/diff/


Testing
---

precheckin in progress


Thanks,

Ken Howe

[GitHub] incubator-geode pull request #223: GEODE-1712: introduce SecurityService and...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/223#discussion_r73215457
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java
 ---
@@ -0,0 +1,164 @@
+package com.gemstone.gemfire.internal.security;
+
+import java.util.Properties;
+import java.util.concurrent.Callable;
+
+import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.security.SecurityManager;
+import org.apache.logging.log4j.Logger;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.util.ThreadState;
+
+import com.gemstone.gemfire.internal.logging.LogService;
+import com.gemstone.gemfire.management.internal.security.ResourceOperation;
+
+public class IntegratedSecurityService implements SecurityService {
+
+  private static Logger logger = 
LogService.getLogger(LogService.SECURITY_LOGGER_NAME);
+
+  private static SecurityService defaultInstance = new 
IntegratedSecurityService();
+
--- End diff --

Can someone just call new IntegratedSecurityService()? If so, probably just 
create a private constructor here to prevent that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73213204
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
@@ -509,8 +510,7 @@ private void registerAccessControlMBean() {
 
 
   private boolean isIntegratedSecurity() {
--- End diff --

We can get rid of this method. I believe this is called to check if we need 
to enabled pulse security in the same file as well. Yeah, what about pulse 
security? Do we need to add another enum or just say if jmx is enabled. pulse 
should be enabled as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73212878
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
@@ -447,8 +449,7 @@ public synchronized void start() throws IOException {
   }
 };
 
-String shiroConfig = this.config.getShiroInit();
-if (! StringUtils.isBlank(shiroConfig) || isIntegratedSecurity()) {
+if (isIntegratedSecurity()) {
--- End diff --

probably be easier to read if it just read "if 
(GeodeSecurityUtil.isJmxSecurityEnabled())" here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73211230
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java
 ---
@@ -471,16 +499,27 @@ public static PostProcessor getPostProcessor() {
 return postProcessor;
   }
 
-  public static boolean isClientSecurityRequired() {
-return isClientAuthenticator || isIntegratedSecurity;
+  public static boolean isIntegratedSecurity(){
--- End diff --

We can get rid of this public method now. I believe now all the other 
components are just using component specific security enabled function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/224#discussion_r73207985
  
--- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java
 ---
@@ -498,6 +502,29 @@ protected String checkRedisBindAddress(String value) {
 return value;
   }
 
+  /**
+   * First check if sslComponents are in the list of valid components. If 
so, check that no other *-ssl-* properties other than cluster-ssl-* are set.
--- End diff --

comments need to be changed here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #224: GEODE-1648: Introduce security-enabled-co...

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/224

GEODE-1648: Introduce security-enabled-components and tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1648

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #224


commit 4d9796e57bfa26cb1207145106eccb78447292a0
Author: gmeilen 
Date:   2016-08-02T17:52:18Z

GEODE-1648: Introduce security-enabled-components and tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #223: GEODE-1712: introduce SecurityService and...

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/223

GEODE-1712: introduce SecurityService and unit tests for security



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode 
feature/GEODE-1712-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #223


commit 70440b15fcebd1187e31c08da1142e56bea60b62
Author: gmeilen 
Date:   2016-07-18T20:13:11Z

GEODE-1712: introduce SecurityService interface for mocking

* create Unit Tests for client commands that use security

commit d5d91fb3e9ddd54887724d63a3fa93551e1719dc
Author: gmeilen 
Date:   2016-07-28T17:46:30Z

GEODE-1713: cleanup imports

commit 2b62775280fb5aff33c853278996884404d9392c
Author: gmeilen 
Date:   2016-07-28T20:20:23Z

GEODE-1712: add static factory methods to SecurityService

commit 453f5e95dfdd62756f033a6b416999dcfb6db854
Author: gmeilen 
Date:   2016-08-01T20:16:25Z

GEODE-1712: add missing categories and fix test failures




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Build failed in Jenkins: Geode-release #22

[William Markito]

Added H0 to the exclusion list... Seems to be the machine that has some
other problems.

On Tue, Aug 2, 2016 at 9:25 AM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> See 
>
> --
> Started by user markito
> [EnvInject] - Loading node environment variables.
> Building remotely on H0 (Hadoop Tez yahoo-not-h2) in workspace <
> https://builds.apache.org/job/Geode-release/ws/>
>  > git rev-parse --is-inside-work-tree # timeout=10
> Fetching changes from the remote Git repository
>  > git config remote.origin.url
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git # timeout=10
> Fetching upstream changes from
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
>  > git --version # timeout=10
>  > git -c core.askpass=true fetch --tags --progress
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
> +refs/heads/*:refs/remotes/origin/*
> Seen branch in repository origin/GEODE-1372
> Seen branch in repository origin/asf-site
> Seen branch in repository origin/asf/asf-site
> Seen branch in repository origin/develop
> Seen branch in repository origin/feature/GEODE-10
> Seen branch in repository origin/feature/GEODE-1017
> Seen branch in repository origin/feature/GEODE-1040
> Seen branch in repository origin/feature/GEODE-1056
> Seen branch in repository origin/feature/GEODE-1096
> Seen branch in repository origin/feature/GEODE-11
> Seen branch in repository origin/feature/GEODE-1109
> Seen branch in repository origin/feature/GEODE-1153
> Seen branch in repository origin/feature/GEODE-1186
> Seen branch in repository origin/feature/GEODE-12
> Seen branch in repository origin/feature/GEODE-1209
> Seen branch in repository origin/feature/GEODE-1269
> Seen branch in repository origin/feature/GEODE-1276
> Seen branch in repository origin/feature/GEODE-1369
> Seen branch in repository origin/feature/GEODE-1370
> Seen branch in repository origin/feature/GEODE-1371
> Seen branch in repository origin/feature/GEODE-1372
> Seen branch in repository origin/feature/GEODE-1374
> Seen branch in repository origin/feature/GEODE-1376
> Seen branch in repository origin/feature/GEODE-1385
> Seen branch in repository origin/feature/GEODE-1392
> Seen branch in repository origin/feature/GEODE-14
> Seen branch in repository origin/feature/GEODE-14-2
> Seen branch in repository origin/feature/GEODE-1452
> Seen branch in repository origin/feature/GEODE-1464
> Seen branch in repository origin/feature/GEODE-1493
> Seen branch in repository origin/feature/GEODE-1565
> Seen branch in repository origin/feature/GEODE-1567
> Seen branch in repository origin/feature/GEODE-1573
> Seen branch in repository origin/feature/GEODE-16
> Seen branch in repository origin/feature/GEODE-1666
> Seen branch in repository origin/feature/GEODE-1666-2
> Seen branch in repository origin/feature/GEODE-1673-PR-212
> Seen branch in repository origin/feature/GEODE-17
> Seen branch in repository origin/feature/GEODE-17-2
> Seen branch in repository origin/feature/GEODE-1700
> Seen branch in repository origin/feature/GEODE-1701
> Seen branch in repository origin/feature/GEODE-1718
> Seen branch in repository origin/feature/GEODE-178
> Seen branch in repository origin/feature/GEODE-217
> Seen branch in repository origin/feature/GEODE-259
> Seen branch in repository origin/feature/GEODE-308
> Seen branch in repository origin/feature/GEODE-33
> Seen branch in repository origin/feature/GEODE-374
> Seen branch in repository origin/feature/GEODE-417
> Seen branch in repository origin/feature/GEODE-420
> Seen branch in repository origin/feature/GEODE-52
> Seen branch in repository origin/feature/GEODE-564
> Seen branch in repository origin/feature/GEODE-574
> Seen branch in repository origin/feature/GEODE-607
> Seen branch in repository origin/feature/GEODE-610
> Seen branch in repository origin/feature/GEODE-639
> Seen branch in repository origin/feature/GEODE-64
> Seen branch in repository origin/feature/GEODE-678
> Seen branch in repository origin/feature/GEODE-681
> Seen branch in repository origin/feature/GEODE-715
> Seen branch in repository origin/feature/GEODE-773
> Seen branch in repository origin/feature/GEODE-773-2
> Seen branch in repository origin/feature/GEODE-78
> Seen branch in repository origin/feature/GEODE-781
> Seen branch in repository origin/feature/GEODE-79
> Seen branch in repository origin/feature/GEODE-80
> Seen branch in repository origin/feature/GEODE-805
> Seen branch in repository origin/feature/GEODE-819
> Seen branch in repository origin/feature/GEODE-835
> Seen branch in repository origin/feature/GEODE-835-test
> Seen branch in repository origin/feature/GEODE-837
> Seen branch in repository origin/feature/GEODE-866
> Seen branch in repository origin/feature/GEODE-917
> Seen branch in repository origin/feature/GEODE-92
> Seen branch in repository origin/feature/GEODE-93
> Seen branch in repository 

[GitHub] incubator-geode issue #215: GEODE-1674: Using a immuatable object to pass th...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/incubator-geode/pull/215
  
Checked in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #215: GEODE-1674: Using a immuatable object to ...

[nabarunnag]

Github user nabarunnag closed the pull request at:

https://github.com/apache/incubator-geode/pull/215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-release #22

[Apache Jenkins Server]

See 

--
Started by user markito
[EnvInject] - Loading node environment variables.
Building remotely on H0 (Hadoop Tez yahoo-not-h2) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git # timeout=10
Fetching upstream changes from 
https://git-wip-us.apache.org/repos/asf/incubator-geode.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/incubator-geode.git 
 > +refs/heads/*:refs/remotes/origin/*
Seen branch in repository origin/GEODE-1372
Seen branch in repository origin/asf-site
Seen branch in repository origin/asf/asf-site
Seen branch in repository origin/develop
Seen branch in repository origin/feature/GEODE-10
Seen branch in repository origin/feature/GEODE-1017
Seen branch in repository origin/feature/GEODE-1040
Seen branch in repository origin/feature/GEODE-1056
Seen branch in repository origin/feature/GEODE-1096
Seen branch in repository origin/feature/GEODE-11
Seen branch in repository origin/feature/GEODE-1109
Seen branch in repository origin/feature/GEODE-1153
Seen branch in repository origin/feature/GEODE-1186
Seen branch in repository origin/feature/GEODE-12
Seen branch in repository origin/feature/GEODE-1209
Seen branch in repository origin/feature/GEODE-1269
Seen branch in repository origin/feature/GEODE-1276
Seen branch in repository origin/feature/GEODE-1369
Seen branch in repository origin/feature/GEODE-1370
Seen branch in repository origin/feature/GEODE-1371
Seen branch in repository origin/feature/GEODE-1372
Seen branch in repository origin/feature/GEODE-1374
Seen branch in repository origin/feature/GEODE-1376
Seen branch in repository origin/feature/GEODE-1385
Seen branch in repository origin/feature/GEODE-1392
Seen branch in repository origin/feature/GEODE-14
Seen branch in repository origin/feature/GEODE-14-2
Seen branch in repository origin/feature/GEODE-1452
Seen branch in repository origin/feature/GEODE-1464
Seen branch in repository origin/feature/GEODE-1493
Seen branch in repository origin/feature/GEODE-1565
Seen branch in repository origin/feature/GEODE-1567
Seen branch in repository origin/feature/GEODE-1573
Seen branch in repository origin/feature/GEODE-16
Seen branch in repository origin/feature/GEODE-1666
Seen branch in repository origin/feature/GEODE-1666-2
Seen branch in repository origin/feature/GEODE-1673-PR-212
Seen branch in repository origin/feature/GEODE-17
Seen branch in repository origin/feature/GEODE-17-2
Seen branch in repository origin/feature/GEODE-1700
Seen branch in repository origin/feature/GEODE-1701
Seen branch in repository origin/feature/GEODE-1718
Seen branch in repository origin/feature/GEODE-178
Seen branch in repository origin/feature/GEODE-217
Seen branch in repository origin/feature/GEODE-259
Seen branch in repository origin/feature/GEODE-308
Seen branch in repository origin/feature/GEODE-33
Seen branch in repository origin/feature/GEODE-374
Seen branch in repository origin/feature/GEODE-417
Seen branch in repository origin/feature/GEODE-420
Seen branch in repository origin/feature/GEODE-52
Seen branch in repository origin/feature/GEODE-564
Seen branch in repository origin/feature/GEODE-574
Seen branch in repository origin/feature/GEODE-607
Seen branch in repository origin/feature/GEODE-610
Seen branch in repository origin/feature/GEODE-639
Seen branch in repository origin/feature/GEODE-64
Seen branch in repository origin/feature/GEODE-678
Seen branch in repository origin/feature/GEODE-681
Seen branch in repository origin/feature/GEODE-715
Seen branch in repository origin/feature/GEODE-773
Seen branch in repository origin/feature/GEODE-773-2
Seen branch in repository origin/feature/GEODE-78
Seen branch in repository origin/feature/GEODE-781
Seen branch in repository origin/feature/GEODE-79
Seen branch in repository origin/feature/GEODE-80
Seen branch in repository origin/feature/GEODE-805
Seen branch in repository origin/feature/GEODE-819
Seen branch in repository origin/feature/GEODE-835
Seen branch in repository origin/feature/GEODE-835-test
Seen branch in repository origin/feature/GEODE-837
Seen branch in repository origin/feature/GEODE-866
Seen branch in repository origin/feature/GEODE-917
Seen branch in repository origin/feature/GEODE-92
Seen branch in repository origin/feature/GEODE-93
Seen branch in repository origin/feature/GEODE-949
Seen branch in repository origin/feature/GEODE-951
Seen branch in repository origin/feature/GEODE-953
Seen branch in repository origin/feature/GEODE-996
Seen branch in repository origin/feature/wan_single_hop_wip
Seen branch in repository origin/gh-wiki
Seen branch in repository origin/master
Seen branch in repository 

Re: Review Request 50680: fix replace on overflowed entry

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50680/#review144503
---


Ship it!




Ship It!

- Ken Howe


On Aug. 1, 2016, 11:17 p.m., Darrel Schneider wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50680/
> ---
> 
> (Updated Aug. 1, 2016, 11:17 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Eric Shu, Scott Jewell, and Ken Howe.
> 
> 
> Bugs: GEODE-1718
> https://issues.apache.org/jira/browse/GEODE-1718
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> New unit test demonstrated that replace would return false when done on an 
> overflowed entry.
> With the fix the test passes.
> Also added a null check in checkPdxEquals to prevent NPE if obj is ever null.
> If obj is null checkPdxEquals will now call basicEquals which handles testing 
> null.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java
>  15a5bed750b676c668ddde64291a5b315fca90fd 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java
>  f3cb3d654087c797de430f448348c3ba66846ac4 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ReplaceWithOverflowJUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50680/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>

[GitHub] incubator-geode pull request #218: GEODE-1682: Adding options for starting G...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-geode/pull/218


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---