[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #413 was SUCCESSFUL (with 1439 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #413 was successful.
---
Scheduled
1441 tests in total.

https://build.spring.io/browse/SGF-NAG-413/





--
This message is automatically generated by Atlassian Bamboo

Re: Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51465/#review147025
---




geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 (line 713)


This is overkill for this test. Your grand-parent (JUnit4CacheTestCache) 
closes the cache on each jvm. I think you only need to close them early when 
you have an async thread stuck.



geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 (line 753)


I think in general it would be better to have the closeCache and 
async0.join in a finally block after you have done the assertEquals.

Also make clear that you expect async0 to block until closeCache is called.



geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 (line 914)


Another way to unstick these async0 guys that are waiting for vm1 to do 
something (like create all its regions) would be to have the test create those 
regions and confirm that we stop logging warnings in vm1 and that vm0 completes 
region creation.


- Darrel Schneider


On Aug. 26, 2016, 1:36 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51465/
> ---
> 
> (Updated Aug. 26, 2016, 1:36 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1128: Cleaned up some of the colocation logging tests
> 
> Ensure that the asyncInvocation threads terminate. Failure of a thread to 
> terminate on one of the tests is apparently responsible for at least 1 CI 
> failure.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
>  b701b70f94f0a8410ea71dd7fb77f586ba456f3f 
> 
> Diff: https://reviews.apache.org/r/51465/diff/
> 
> 
> Testing
> ---
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

please close your submitted and discarded RB reviews

[Bruce Schuchardt]

My dashboard has 105 items from other engineers on it and I know they're 
mostly old reviews that are no longer needed.


 It just takes a minute to close them.  Go to the dashboard, click on 
"Outgoing - Open" to bring up your reviews.   Click on the check-boxes 
of the ones you're done with and hit closed-submitted or closed-discarded.


Thanks

Re: Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51465/
---

(Updated Aug. 26, 2016, 8:36 p.m.)


Review request for geode, anilkumar gingade, Darrel Schneider, and Kirk Lund.


Repository: geode


Description (updated)
---

GEODE-1128: Cleaned up some of the colocation logging tests

Ensure that the asyncInvocation threads terminate. Failure of a thread to 
terminate on one of the tests is apparently responsible for at least 1 CI 
failure.


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 b701b70f94f0a8410ea71dd7fb77f586ba456f3f 

Diff: https://reviews.apache.org/r/51465/diff/


Testing (updated)
---

precheckin in progress


Thanks,

Ken Howe

Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51465/
---

Review request for geode.


Repository: geode


Description
---

GEODE-1128: Cleaned up some of the colocation logging tests


Diffs
-

  
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java
 b701b70f94f0a8410ea71dd7fb77f586ba456f3f 

Diff: https://reviews.apache.org/r/51465/diff/


Testing
---

Ensure that the asyncInvocation threads terminate. Failure of a thread to 
terminate on one of the tests is apparently responsible for at least 1 CI 
failure.


Thanks,

Ken Howe

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146978
---


Ship it!




Ship It!

- Hitesh Khamesra


On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> ---
> 
> (Updated Aug. 26, 2016, 4:21 p.m.)
> 
> 
> Review request for geode and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> avoid using Collections.shuffle() to find a random server location
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
>  d3b0cf3204b2d295b362544425a3f08a83090974 
> 
> Diff: https://reviews.apache.org/r/51461/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146976
---




geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
 (line 120)


Nice catch Bruce.


- Hitesh Khamesra


On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> ---
> 
> (Updated Aug. 26, 2016, 4:21 p.m.)
> 
> 
> Review request for geode and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> avoid using Collections.shuffle() to find a random server location
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
>  d3b0cf3204b2d295b362544425a3f08a83090974 
> 
> Diff: https://reviews.apache.org/r/51461/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/#review146975
---




geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
 (line 120)


I'm going to change this to use the new "random" instance variable.


- Bruce Schuchardt


On Aug. 26, 2016, 4:21 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51461/
> ---
> 
> (Updated Aug. 26, 2016, 4:21 p.m.)
> 
> 
> Review request for geode and Hitesh Khamesra.
> 
> 
> Bugs: GEODE-1803
> https://issues.apache.org/jira/browse/GEODE-1803
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> avoid using Collections.shuffle() to find a random server location
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
>  d3b0cf3204b2d295b362544425a3f08a83090974 
> 
> Diff: https://reviews.apache.org/r/51461/diff/
> 
> 
> Testing
> ---
> 
> precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51461/
---

Review request for geode and Hitesh Khamesra.


Bugs: GEODE-1803
https://issues.apache.org/jira/browse/GEODE-1803


Repository: geode


Description
---

avoid using Collections.shuffle() to find a random server location


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ClientPartitionAdvisor.java
 d3b0cf3204b2d295b362544425a3f08a83090974 

Diff: https://reviews.apache.org/r/51461/diff/


Testing
---

precheckin


Thanks,

Bruce Schuchardt

Jenkins build is back to normal : Geode-nightly #572

[Apache Jenkins Server]

See