Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterat

2015-08-05 Thread Kishor Bachhav

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37119/
---

Review request for geode, suranjan kumar and Yogesh Mahajan.


Repository: geode


Description
---

GEODE-187:AsyncEventQueue with Event Filter test log shows 
IllegalStateException  -AbstractGatewaySenderEventProcessor#processqueue 
iterates events to get filtered. While iterating 2 consditions are checked and 
event is removed in thses both condition. for single itr.next() when itr.remove 
is called second time, it causes IllegalStateException.  -Added 'continue' 
after first itr.remove is called


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
 67b38948a8fe4b347f3ed3e9035a76e4cd834716 

Diff: https://reviews.apache.org/r/37119/diff/


Testing
---

This is verified on 82 branch
Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and 
without changes to verify fix.


Thanks,

Kishor Bachhav



Re: Review Request 36223: GEODE-82 Removing unused import of jrockit class.

2015-07-07 Thread Kishor Bachhav

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36223/#review90655
---

Ship it!


Ship It!

- Kishor Bachhav


On July 6, 2015, 9:55 p.m., Dan Smith wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36223/
 ---
 
 (Updated July 6, 2015, 9:55 p.m.)
 
 
 Review request for geode, Darrel Schneider and Kishor Bachhav.
 
 
 Repository: geode
 
 
 Description
 ---
 
 This import causes the build to fail with openjdk, because jrockit is
 not available with openjdk.
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAdvisor.java
  68cb15d56c1fb00998b8053adf86280544ba7251 
 
 Diff: https://reviews.apache.org/r/36223/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Dan Smith
 




Re: Blog under blogs.apache.org

2015-05-28 Thread Kishor Bachhav
Twitter: @ApacheGeode does not have Geode logo yet. We need to add it.
Rest of the channels have our geode logo.

Regards
  Kishor

On Thu, May 28, 2015 at 12:53 AM, Roman Shaposhnik ro...@shaposhnik.org
wrote:

 On Wed, May 27, 2015 at 9:21 AM, Gregory Chase gch...@pivotal.io wrote:
  Fellow contributors,
  I currently hold @ASFGeode and @ApacheGeode and have not tweeted from
 them
  awaiting exactly this conversation.
 
  I will set up a TweetDeck account that can be accessed by those with
 access
  to priv...@geode.inclubator.org, and by those on the PMC, or delegates
  thereof.

 Perfect! As William captured in his Social media guidelines wiki page
 the proposal for this is to be an opt-in scheme. As such, could you
 please add my account rhatr to both via the Tweedeck?

  I recommend, however, that this single Twitter account, and the
  Geode.incubator.Apache.org website be the only communication vehicles
 for
  the project.  My reasons are as follows:
 
  1)  Apache Geode is a collaborative software development community, and
 its
  communications should reflect this. It should not be a marketing engine.
 
  2)  Many social media channels are a lot to maintain, and it also dilutes
  communications.   As a primarily text-based medium, Twitter works well
 for
  linking and curating to third party content.

 Great points! +1

  3) We are trying to build a supportive community around Apache Geode, and
  we should encourage others to keep their names associated with content
  about Geode they create. I believe its good for multiple parties to be
  supporting Geode, not just have a monolithic Geode brand in this case.
 
  4) How does the PMC decide what content is Geode branded and what
 content
  is not Geode branded? I recommend we keep this very simple:  Software
  versions, official product documentation, and the website are Geode
  branded.  Everything else should be branded according to its producer 
  source.  Apache Geode can curate such content, but leave it branded, and
  residing on the source feed of the producer.

 Both are really great point, but I think there's a happy medium. Lets take
 slideshare as an example: things that are linked/embedded from our wiki
 would make sense (in my mind) to be posted under Geode account on
 slideshare. Things that are more personal voices/etc. make total sense
 under personal accounts.

 Long story short: I agree with you that usage of anything other than
 Twitter
 account will not be huge, but I also think we should reserve the handles
 and even post things there from time to time.

 Makes sense?

 Thanks,
 Roman.