Re: Review Request 37169: GEODE-188:wrong name for the gateway substitution filter in 'create async-event-queue' command -replaced string gateway-event-substitution-listener with gateway-event-subs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37169/#review94379 --- Ship it! Ship It! - suranjan kumar On Aug. 6, 2015, 8:45 a.m., Kishor Bachhav wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37169/ --- (Updated Aug. 6, 2015, 8:45 a.m.) Review request for geode, suranjan kumar and Yogesh Mahajan. Repository: geode Description --- -replaced string gateway-event-substitution-listener with gateway-event-substitution-filter and GatewayEventSubstitutionListener with GatewayEventSubstitutionFilter Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/QueueCommands.java 7b298d633463cfec8b8396e3c0f448d857c0893d gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/CreateAsyncEventQueueFunction.java 547b199211ca29558eb4dfcae294e43dd188a572 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/i18n/CliStrings.java c65212f13bf5f459d0e5512c49b1af3304cd8943 gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/QueueCommandsController.java 00cbd1adb7e7e17fafa4cd1a3cd4aec8011f3134 Diff: https://reviews.apache.org/r/37169/diff/ Testing --- QueueCommandsDUnitTest Thanks, Kishor Bachhav
Re: Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While it
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37119/#review94199 --- Ship it! Ship It! - suranjan kumar On Aug. 5, 2015, 7:11 a.m., Kishor Bachhav wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37119/ --- (Updated Aug. 5, 2015, 7:11 a.m.) Review request for geode, suranjan kumar and Yogesh Mahajan. Repository: geode Description --- GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterating 2 consditions are checked and event is removed in thses both condition. for single itr.next() when itr.remove is called second time, it causes IllegalStateException. -Added 'continue' after first itr.remove is called Diffs - gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java 67b38948a8fe4b347f3ed3e9035a76e4cd834716 Diff: https://reviews.apache.org/r/37119/diff/ Testing --- This is verified on 82 branch Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and without changes to verify fix. Thanks, Kishor Bachhav