subject:"Re\: more spotless problems on Windows"

Re: more spotless problems on Windows

2016-11-04 Thread Bruce Schuchardt

I don't believe we did #2

Le 11/4/2016 à 12:09 PM, Jared Stewart a écrit :

@Bruce

To be clear, are you saying you did both of the following?

1). Create a .gitattributes file with “ *test eol=lf” at the top level of Geode
2). Change ‘UNIX’ in build.gradle to ‘GIT_ATTRIBUTES'

On Nov 4, 2016, at 12:07 PM, Bruce Schuchardt wrote:

Udo and I tried that & it didn't work. Maybe you'll have better luck.

Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit :

From the spotless devs:

Git is not a pure content store, it mucks with line endings. Regardless of what
you check-in, it will store your files with unix line endings in the repo.

Then, when you checkout, it will modify the line endings to suit your platform. Unless
you add a .gitattributes file to tell git "forget the platform, do what this file
says".

Remove lineEndings 'UNIX' in your build.gradle [Jared - we should put
‘GIT_ATTRIBUTES’ in its place], and add a .gitattributes file in your root
directory with the content * text eol=lf and your problem will be fixed.

On Nov 4, 2016, at 10:48 AM, Nabarun Nag wrote:

Thank you Jared. I wanted to confirm that this was not an isolated incident
specific to my machine.

Regards
Naba

On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart wrote:

@Naba,

I filed a bug report with Spotless this morning. The Spotless devs have
been very responsive so far in my experience, hopefully this will be fixed
soon.

On Nov 4, 2016, at 10:35 AM, Nabarun Nag wrote:

@Udo, I confirmed that this is not limited to my windows 10 environment.

ran the steps on a Windows Server 2016 AMI instance and the same error
occurred in the AMI too. [source checkout time 4th Nov 10:00AM PST]

I wanted to know if there is a mandate on what the value of
core.autocrlf should
be set to on a windows machine for geode dev work. For my experiments

value

of core.autocrlf was set to true. [recommended for cross platform
development]

Regards
Naba

On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag wrote:

@Jared
I ran ./gradlew spotlessApply on the Windows 10 machine using git bash
this is what has happened.
NOTE: I started the below steps on a fresh git clone of the open side.
[Steps:
1. git clone

https://git-wip-us.apache.org/repos/asf/incubator-geode.git

open
2. cd open
3. git checkout -b develop origin/develop]

*Step 1. ./gradlew clean build -Dskip.tests=true*

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.

Format violations were found. Run 'gradlew spotlessApply' to fix them.

geode-core\src\main\java\org\apache\geode\internal\statistics\StatArchiveReader.java
geode-core\src\test\java\org\apache\geode\cache\query\dunit\PdxLocalQueryVersionedClassDUnitTest.java
geode-core\src\test\java\org\apache\geode\internal\cache\execute\ClientServerFunctionExecutionDUnitTest.java
geode-core\src\test\java\org\apache\geode\internal\cache\functions\TestFunction.java
geode-core\src\test\java\org\apache\geode\internal\statistics\StatArchiveWithMissingResourceTypeRegressionTest.java

*Step 2: ./gradlew spotlessApply*

BUILD SUCCESSFUL

Total time: 12.728 secs

*Step 3: git status*

modified:

geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java

modified:

geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java

modified:

geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java

modified:

geode-core/src/test/java/org/apache/geode/internal/cache/functions/TestFunction.java

modified:

geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java

*Step 4 : git add .*
warning: LF will be replaced by CRLF in

geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java.

The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in

geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java.

The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in

geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java.

The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in

geode-core/src/test/java/org/apache/geode/internal/cache/functions/TestFunction.java.

The file will have its original line endings in your working directory.
warning: LF will be replaced by CRLF in

geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java.

The file will have its original line endings in your working directory.

*Step 5: git status*
On branch develop
Your branch is up-to-date with 'origin/develop'.
nothing to commit, working tree clean

*Step 6: ./g

Re: more spotless problems on Windows

2016-11-04 Thread Nabarun Nag

@Jared, sure I will verify the branch when I'm at my home windows
workstation. (Creating a AMI instance consumes a lot of time).

I will be let you know of the results asap.

Regards
Naba

On Fri, Nov 4, 2016 at 1:42 PM Jared Stewart  wrote:

> @Naba
>
> I pushed the proposed changes to a branch here:
> https://github.com/jaredjstewart/incubator-geode/tree/windowsLF <
> https://github.com/jaredjstewart/incubator-geode/tree/windowsLF>
>
> Can you see if you still have the same problem when you check out this
> branch?
>
> > On Nov 4, 2016, at 12:07 PM, Bruce Schuchardt 
> wrote:
> >
> > Udo and I tried that & it didn't work.  Maybe you'll have better luck.
> >
> > Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit :
> >> From the spotless devs:
> >>
> >> Git is not a pure content store, it mucks with line endings. Regardless
> of what you check-in, it will store your files with unix line endings in
> the repo.
> >>
> >> Then, when you checkout, it will modify the line endings to suit your
> platform. Unless you add a .gitattributes file to tell git "forget the
> platform, do what this file says".
> >>
> >> Remove lineEndings 'UNIX' in your build.gradle [Jared - we should put
> ‘GIT_ATTRIBUTES’ in its place], and add a .gitattributes file in your root
> directory with the content * text eol=lf and your problem will be fixed.
> >>
> >>
> >>
> >>> On Nov 4, 2016, at 10:48 AM, Nabarun Nag  wrote:
> >>>
> >>> Thank you Jared. I wanted to confirm that this was not an isolated
> incident
> >>> specific to my machine.
> >>>
> >>> Regards
> >>> Naba
> >>>
> >>> On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart 
> wrote:
> >>>
>  @Naba,
> 
>  I filed a bug report with Spotless this morning.  The Spotless devs
> have
>  been very responsive so far in my experience, hopefully this will be
> fixed
>  soon.
> 
> > On Nov 4, 2016, at 10:35 AM, Nabarun Nag  wrote:
> >
> > @Udo, I confirmed that this is not limited to my windows 10
> environment.
>  I
> > ran  the steps on a Windows Server 2016 AMI instance and the same
> error
> > occurred in the AMI too. [source checkout time 4th Nov 10:00AM PST]
> >
> > I wanted to know if there is a mandate on what the value of
> > core.autocrlf should
> > be set to on a windows machine for geode dev work. For my experiments
>  value
> > of core.autocrlf was set to true. [recommended for cross platform
> > development]
> >
> > Regards
> > Naba
> >
> >
> > On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag  wrote:
> >
> >> @Jared
> >> I ran ./gradlew spotlessApply on the Windows 10 machine using git
> bash
> >> this is what has happened.
> >> NOTE: I started the below steps on a fresh git clone of the open
> side.
> >> [Steps:
> >> 1.  git clone
>  https://git-wip-us.apache.org/repos/asf/incubator-geode.git
> >> open
> >> 2. cd open
> >> 3. git checkout -b develop origin/develop]
> >>
> >> *Step 1. ./gradlew clean build -Dskip.tests=true*
> >>
> >> FAILURE: Build failed with an exception.
> >>
> >> * What went wrong:
> >> Execution failed for task ':geode-core:spotlessJavaCheck'.
> >>> Format violations were found. Run 'gradlew spotlessApply' to fix
> them.
> >>
> 
> geode-core\src\main\java\org\apache\geode\internal\statistics\StatArchiveReader.java
> >>
> 
> geode-core\src\test\java\org\apache\geode\cache\query\dunit\PdxLocalQueryVersionedClassDUnitTest.java
> >>
> 
> geode-core\src\test\java\org\apache\geode\internal\cache\execute\ClientServerFunctionExecutionDUnitTest.java
> >>
> 
> geode-core\src\test\java\org\apache\geode\internal\cache\functions\TestFunction.java
> >>
> 
> geode-core\src\test\java\org\apache\geode\internal\statistics\StatArchiveWithMissingResourceTypeRegressionTest.java
> >>
> >> *Step 2: ./gradlew spotlessApply*
> >>
> >> BUILD SUCCESSFUL
> >>
> >> Total time: 12.728 secs
> >>
> >>
> >> *Step 3: git status*
> >>
> >> modified:
> >>
> 
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
> >>   modified:
> >>
> 
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java
> >>   modified:
> >>
> 
> geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java
> >>   modified:
> >>
> 
> geode-core/src/test/java/org/apache/geode/internal/cache/functions/TestFunction.java
> >>   modified:
> >>
> 
> geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java
> >>
> >> *Step 4 : git add .*
> >> warning: LF will be replaced by CRLF in
> >>
> 
> geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java.
> >> The file will have its or

Re: more spotless problems on Windows

2016-11-04 Thread Jared Stewart

@Naba

I pushed the proposed changes to a branch here: 
https://github.com/jaredjstewart/incubator-geode/tree/windowsLF 


Can you see if you still have the same problem when you check out this branch?

> On Nov 4, 2016, at 12:07 PM, Bruce Schuchardt  wrote:
> 
> Udo and I tried that & it didn't work.  Maybe you'll have better luck.
> 
> Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit :
>> From the spotless devs:
>> 
>> Git is not a pure content store, it mucks with line endings. Regardless of 
>> what you check-in, it will store your files with unix line endings in the 
>> repo.
>> 
>> Then, when you checkout, it will modify the line endings to suit your 
>> platform. Unless you add a .gitattributes file to tell git "forget the 
>> platform, do what this file says".
>> 
>> Remove lineEndings 'UNIX' in your build.gradle [Jared - we should put 
>> ‘GIT_ATTRIBUTES’ in its place], and add a .gitattributes file in your root 
>> directory with the content * text eol=lf and your problem will be fixed.
>> 
>> 
>> 
>>> On Nov 4, 2016, at 10:48 AM, Nabarun Nag  wrote:
>>> 
>>> Thank you Jared. I wanted to confirm that this was not an isolated incident
>>> specific to my machine.
>>> 
>>> Regards
>>> Naba
>>> 
>>> On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart  wrote:
>>> 
 @Naba,
 
 I filed a bug report with Spotless this morning.  The Spotless devs have
 been very responsive so far in my experience, hopefully this will be fixed
 soon.
 
> On Nov 4, 2016, at 10:35 AM, Nabarun Nag  wrote:
> 
> @Udo, I confirmed that this is not limited to my windows 10 environment.
 I
> ran  the steps on a Windows Server 2016 AMI instance and the same error
> occurred in the AMI too. [source checkout time 4th Nov 10:00AM PST]
> 
> I wanted to know if there is a mandate on what the value of
> core.autocrlf should
> be set to on a windows machine for geode dev work. For my experiments
 value
> of core.autocrlf was set to true. [recommended for cross platform
> development]
> 
> Regards
> Naba
> 
> 
> On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag  wrote:
> 
>> @Jared
>> I ran ./gradlew spotlessApply on the Windows 10 machine using git bash
>> this is what has happened.
>> NOTE: I started the below steps on a fresh git clone of the open side.
>> [Steps:
>> 1.  git clone
 https://git-wip-us.apache.org/repos/asf/incubator-geode.git
>> open
>> 2. cd open
>> 3. git checkout -b develop origin/develop]
>> 
>> *Step 1. ./gradlew clean build -Dskip.tests=true*
>> 
>> FAILURE: Build failed with an exception.
>> 
>> * What went wrong:
>> Execution failed for task ':geode-core:spotlessJavaCheck'.
>>> Format violations were found. Run 'gradlew spotlessApply' to fix them.
>> 
 geode-core\src\main\java\org\apache\geode\internal\statistics\StatArchiveReader.java
>> 
 geode-core\src\test\java\org\apache\geode\cache\query\dunit\PdxLocalQueryVersionedClassDUnitTest.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\cache\execute\ClientServerFunctionExecutionDUnitTest.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\cache\functions\TestFunction.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\statistics\StatArchiveWithMissingResourceTypeRegressionTest.java
>> 
>> *Step 2: ./gradlew spotlessApply*
>> 
>> BUILD SUCCESSFUL
>> 
>> Total time: 12.728 secs
>> 
>> 
>> *Step 3: git status*
>> 
>> modified:
>> 
 geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/functions/TestFunction.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java
>> 
>> *Step 4 : git add .*
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java.
>> The file will have its original line endings in your working directory.
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java.
>> The file will have its original line endings in your working directory.
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java.
>>

Re: more spotless problems on Windows

2016-11-04 Thread Jared Stewart

Correction:
“ * text eol=lf”
> On Nov 4, 2016, at 12:09 PM, Jared Stewart  wrote:
> 
> “ *test eol=lf”

Re: more spotless problems on Windows

2016-11-04 Thread Jared Stewart

@Bruce

To be clear, are you saying you did both of the following?

1). Create a .gitattributes file with “ *test eol=lf” at the top level of Geode
2). Change ‘UNIX’ in build.gradle to ‘GIT_ATTRIBUTES'

> On Nov 4, 2016, at 12:07 PM, Bruce Schuchardt  wrote:
> 
> Udo and I tried that & it didn't work.  Maybe you'll have better luck.
> 
> Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit :
>> From the spotless devs:
>> 
>> Git is not a pure content store, it mucks with line endings. Regardless of 
>> what you check-in, it will store your files with unix line endings in the 
>> repo.
>> 
>> Then, when you checkout, it will modify the line endings to suit your 
>> platform. Unless you add a .gitattributes file to tell git "forget the 
>> platform, do what this file says".
>> 
>> Remove lineEndings 'UNIX' in your build.gradle [Jared - we should put 
>> ‘GIT_ATTRIBUTES’ in its place], and add a .gitattributes file in your root 
>> directory with the content * text eol=lf and your problem will be fixed.
>> 
>> 
>> 
>>> On Nov 4, 2016, at 10:48 AM, Nabarun Nag  wrote:
>>> 
>>> Thank you Jared. I wanted to confirm that this was not an isolated incident
>>> specific to my machine.
>>> 
>>> Regards
>>> Naba
>>> 
>>> On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart  wrote:
>>> 
 @Naba,
 
 I filed a bug report with Spotless this morning.  The Spotless devs have
 been very responsive so far in my experience, hopefully this will be fixed
 soon.
 
> On Nov 4, 2016, at 10:35 AM, Nabarun Nag  wrote:
> 
> @Udo, I confirmed that this is not limited to my windows 10 environment.
 I
> ran  the steps on a Windows Server 2016 AMI instance and the same error
> occurred in the AMI too. [source checkout time 4th Nov 10:00AM PST]
> 
> I wanted to know if there is a mandate on what the value of
> core.autocrlf should
> be set to on a windows machine for geode dev work. For my experiments
 value
> of core.autocrlf was set to true. [recommended for cross platform
> development]
> 
> Regards
> Naba
> 
> 
> On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag  wrote:
> 
>> @Jared
>> I ran ./gradlew spotlessApply on the Windows 10 machine using git bash
>> this is what has happened.
>> NOTE: I started the below steps on a fresh git clone of the open side.
>> [Steps:
>> 1.  git clone
 https://git-wip-us.apache.org/repos/asf/incubator-geode.git
>> open
>> 2. cd open
>> 3. git checkout -b develop origin/develop]
>> 
>> *Step 1. ./gradlew clean build -Dskip.tests=true*
>> 
>> FAILURE: Build failed with an exception.
>> 
>> * What went wrong:
>> Execution failed for task ':geode-core:spotlessJavaCheck'.
>>> Format violations were found. Run 'gradlew spotlessApply' to fix them.
>> 
 geode-core\src\main\java\org\apache\geode\internal\statistics\StatArchiveReader.java
>> 
 geode-core\src\test\java\org\apache\geode\cache\query\dunit\PdxLocalQueryVersionedClassDUnitTest.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\cache\execute\ClientServerFunctionExecutionDUnitTest.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\cache\functions\TestFunction.java
>> 
 geode-core\src\test\java\org\apache\geode\internal\statistics\StatArchiveWithMissingResourceTypeRegressionTest.java
>> 
>> *Step 2: ./gradlew spotlessApply*
>> 
>> BUILD SUCCESSFUL
>> 
>> Total time: 12.728 secs
>> 
>> 
>> *Step 3: git status*
>> 
>> modified:
>> 
 geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/functions/TestFunction.java
>>   modified:
>> 
 geode-core/src/test/java/org/apache/geode/internal/statistics/StatArchiveWithMissingResourceTypeRegressionTest.java
>> 
>> *Step 4 : git add .*
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveReader.java.
>> The file will have its original line endings in your working directory.
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/test/java/org/apache/geode/cache/query/dunit/PdxLocalQueryVersionedClassDUnitTest.java.
>> The file will have its original line endings in your working directory.
>> warning: LF will be replaced by CRLF in
>> 
 geode-core/src/test/java/org/apache/geode/internal/cache/execute/ClientServerFunctionExecutionDUnitTest.java.
>> The file will have its original line endings in your working dire

Re: more spotless problems on Windows

2016-11-04 Thread Bruce Schuchardt

Udo and I tried that & it didn't work. Maybe you'll have better luck.

Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit :

From the spotless devs:

Git is not a pure content store, it mucks with line endings. Regardless of what
you check-in, it will store your files with unix line endings in the repo.

Then, when you checkout, it will modify the line endings to suit your platform. Unless
you add a .gitattributes file to tell git "forget the platform, do what this file
says".

On Nov 4, 2016, at 10:48 AM, Nabarun Nag wrote:

Thank you Jared. I wanted to confirm that this was not an isolated incident
specific to my machine.

Regards
Naba

On Fri, Nov 4, 2016 at 10:45 AM Jared Stewart wrote:

@Naba,

I filed a bug report with Spotless this morning. The Spotless devs have
been very responsive so far in my experience, hopefully this will be fixed
soon.

On Nov 4, 2016, at 10:35 AM, Nabarun Nag wrote:

@Udo, I confirmed that this is not limited to my windows 10 environment.

ran the steps on a Windows Server 2016 AMI instance and the same error
occurred in the AMI too. [source checkout time 4th Nov 10:00AM PST]

I wanted to know if there is a mandate on what the value of
core.autocrlf should
be set to on a windows machine for geode dev work. For my experiments

value

of core.autocrlf was set to true. [recommended for cross platform
development]

Regards
Naba

On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag wrote:

@Jared
I ran ./gradlew spotlessApply on the Windows 10 machine using git bash
this is what has happened.
NOTE: I started the below steps on a fresh git clone of the open side.
[Steps:
1. git clone

https://git-wip-us.apache.org/repos/asf/incubator-geode.git

open
2. cd open
3. git checkout -b develop origin/develop]

*Step 1. ./gradlew clean build -Dskip.tests=true*

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.

Format violations were found. Run 'gradlew spotlessApply' to fix them.

geode-core\src\main\java\org\apache\geode\internal\statistics\StatArchiveReader.java

geode-core\src\test\java\org\apache\geode\cache\query\dunit\PdxLocalQueryVersionedClassDUnitTest.java

geode-core\src\test\java\org\apache\geode\internal\cache\execute\ClientServerFunctionExecutionDUnitTest.java

geode-core\src\test\java\org\apache\geode\internal\cache\functions\TestFunction.java

geode-core\src\test\java\org\apache\geode\internal\statistics\StatArchiveWithMissingResourceTypeRegressionTest.java