Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While iterat

2015-08-05 Thread Kishor Bachhav

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37119/
---

Review request for geode, suranjan kumar and Yogesh Mahajan.


Repository: geode


Description
---

GEODE-187:AsyncEventQueue with Event Filter test log shows 
IllegalStateException  -AbstractGatewaySenderEventProcessor#processqueue 
iterates events to get filtered. While iterating 2 consditions are checked and 
event is removed in thses both condition. for single itr.next() when itr.remove 
is called second time, it causes IllegalStateException.  -Added 'continue' 
after first itr.remove is called


Diffs
-

  
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
 67b38948a8fe4b347f3ed3e9035a76e4cd834716 

Diff: https://reviews.apache.org/r/37119/diff/


Testing
---

This is verified on 82 branch
Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and 
without changes to verify fix.


Thanks,

Kishor Bachhav



Re: Review Request 37119: GEODE-187:AsyncEventQueue with Event Filter test log shows IllegalStateException -AbstractGatewaySenderEventProcessor#processqueue iterates events to get filtered. While it

2015-08-05 Thread suranjan kumar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37119/#review94199
---

Ship it!


Ship It!

- suranjan kumar


On Aug. 5, 2015, 7:11 a.m., Kishor Bachhav wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37119/
 ---
 
 (Updated Aug. 5, 2015, 7:11 a.m.)
 
 
 Review request for geode, suranjan kumar and Yogesh Mahajan.
 
 
 Repository: geode
 
 
 Description
 ---
 
 GEODE-187:AsyncEventQueue with Event Filter test log shows 
 IllegalStateException  -AbstractGatewaySenderEventProcessor#processqueue 
 iterates events to get filtered. While iterating 2 consditions are checked 
 and event is removed in thses both condition. for single itr.next() when 
 itr.remove is called second time, it causes IllegalStateException.  -Added 
 'continue' after first itr.remove is called
 
 
 Diffs
 -
 
   
 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
  67b38948a8fe4b347f3ed3e9035a76e4cd834716 
 
 Diff: https://reviews.apache.org/r/37119/diff/
 
 
 Testing
 ---
 
 This is verified on 82 branch
 Also ran newWan/serial/filters/hctBeforeTransmitEventFilterHA.conf with and 
 without changes to verify fix.
 
 
 Thanks,
 
 Kishor Bachhav