---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37486/#review95470
---
Ship it!
Ship It!
gemfire-core/src/main/java/com/gemstone/gemfire/internal/SharedLibrary.java
(line 112)
https://reviews.apache.org/r/37486/#comment150432
I would recommend fixing the indentation of this method. Also need to make
sure the assumption of compressed oops is not used when using Zing JVM.
- Kirk Lund
On Aug. 14, 2015, 5:22 p.m., Darrel Schneider wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37486/
---
(Updated Aug. 14, 2015, 5:22 p.m.)
Review request for geode and Kirk Lund.
Bugs: GEODE-214
https://issues.apache.org/jira/browse/GEODE-214
Repository: geode
Description
---
- isTenured now looks for GenPauseless Old Gen for azul.
- Fatal message about jvm version no longer logged for azul jvm.
- Fatal log message about jvm version is now a warning since we continue to
run.
- Fixed a bug in ReflectionSingleObjectSizer in how it calculated the size of
a field It was calling Field.getClass instead of Field.getType.
Field.getClass always returns and instance of Field.class which the sizer
always says is an objref size. getType will return a primitive class for
primitive fields which is what we want.
- Improved ObjectSizerJUnitTest.
- The object header size and reference size are now correctly computed for
azul.
- Fix tests that are unintentionally spawning processes that use the default
mcast-port. This fixes intermittent failures caused by finding another member
of the wrong GemFire version.
Diffs
-
gemfire-core/src/main/java/com/gemstone/gemfire/internal/SharedLibrary.java
59ab34e8c13e1e47cfb5b918f551b4175855409a
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/MinimumSystemRequirements.java
d0a346faaf9d9aa3f12ccf289de2bdb6910e3d51
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/HeapMemoryMonitor.java
fda337b94f34d0ce2c8211152f82609325b29438
gemfire-core/src/main/java/com/gemstone/gemfire/internal/lang/SystemUtils.java
f4f111ac0f108b326252786f925a669f85061634
gemfire-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionSingleObjectSizer.java
47b73a8de2db21abd415ba7e71d3fc4eb276eaef
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteFileJUnitTest.java
b4814619b821f20d7d5c8cab65231f77f3eaf31e
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorLauncherRemoteJUnitTest.java
25aa23cc10dc4037d1b1277127c794be62e2cf79
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherLocalJUnitTest.java
1addfc89427223b330ce6f476d1b37de7f058dd7
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteFileJUnitTest.java
3b321edba497e7c2a3d4fb0802128b123218899e
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithSpringJUnitTest.java
dbefdbdc06cd4174321c6483216f8e38ae478cd3
gemfire-core/src/test/java/com/gemstone/gemfire/internal/size/ObjectSizerJUnitTest.java
3d6a73189924cfb9a4bb86c81a60be730589ec2a
Diff: https://reviews.apache.org/r/37486/diff/
Testing
---
precheckin
Thanks,
Darrel Schneider
