Re: Review Request 45599: GEODE-1160 TransactionWriter is unexpectedly triggered if updating data entries with using PDX serializer

2016-04-04 Thread Swapnil Bawaskar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45599/#review126908
---


Ship it!




Ship It!

- Swapnil Bawaskar


On April 1, 2016, 7:22 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45599/
> ---
> 
> (Updated April 1, 2016, 7:22 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, 
> and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This inhibits invocation of transaction writers and listners for operations 
> on internal cache Regions.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java
>  1a4d3777fc9efdba813f2215ef9f8deed55bbeef 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEvent.java 
> e686ceae6ac010cc4e04972453cb90a578d7dade 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRmtEvent.java 
> b378c8e5949c6fc310d1cb9fd9634e795c4751cb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 
> 9e8dd18fd5065be1a9b94086732746bd8f770463 
>   
> geode-core/src/test/java/com/gemstone/gemfire/pdx/PdxSerializableDUnitTest.java
>  1e901bc2f12eba2e9ed9ea77e4cb57a97c0beb4c 
> 
> Diff: https://reviews.apache.org/r/45599/diff/
> 
> 
> Testing
> ---
> 
> precheckin including a new test for this problem
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>



Re: Review Request 45599: GEODE-1160 TransactionWriter is unexpectedly triggered if updating data entries with using PDX serializer

2016-04-04 Thread Udo Kohlmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45599/#review126843
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 1, 2016, 7:22 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45599/
> ---
> 
> (Updated April 1, 2016, 7:22 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, 
> and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This inhibits invocation of transaction writers and listners for operations 
> on internal cache Regions.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java
>  1a4d3777fc9efdba813f2215ef9f8deed55bbeef 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEvent.java 
> e686ceae6ac010cc4e04972453cb90a578d7dade 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRmtEvent.java 
> b378c8e5949c6fc310d1cb9fd9634e795c4751cb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 
> 9e8dd18fd5065be1a9b94086732746bd8f770463 
>   
> geode-core/src/test/java/com/gemstone/gemfire/pdx/PdxSerializableDUnitTest.java
>  1e901bc2f12eba2e9ed9ea77e4cb57a97c0beb4c 
> 
> Diff: https://reviews.apache.org/r/45599/diff/
> 
> 
> Testing
> ---
> 
> precheckin including a new test for this problem
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>



Re: Review Request 45599: GEODE-1160 TransactionWriter is unexpectedly triggered if updating data entries with using PDX serializer

2016-04-04 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45599/#review126837
---


Ship it!




Udo and Darrel have given me a private review of these changes and they have 
now passed precheckin testing (no failures).

- Bruce Schuchardt


On April 1, 2016, 7:22 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45599/
> ---
> 
> (Updated April 1, 2016, 7:22 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, 
> and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> This inhibits invocation of transaction writers and listners for operations 
> on internal cache Regions.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java
>  1a4d3777fc9efdba813f2215ef9f8deed55bbeef 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXEvent.java 
> e686ceae6ac010cc4e04972453cb90a578d7dade 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRmtEvent.java 
> b378c8e5949c6fc310d1cb9fd9634e795c4751cb 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java 
> 9e8dd18fd5065be1a9b94086732746bd8f770463 
>   
> geode-core/src/test/java/com/gemstone/gemfire/pdx/PdxSerializableDUnitTest.java
>  1e901bc2f12eba2e9ed9ea77e4cb57a97c0beb4c 
> 
> Diff: https://reviews.apache.org/r/45599/diff/
> 
> 
> Testing
> ---
> 
> precheckin including a new test for this problem
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>