Re: Review Request 46108: GEODE-1216 Fix the scalability of remove member

2016-04-12 Thread Hitesh Khamesra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46108/#review128557
---


Ship it!




Ship It!

- Hitesh Khamesra


On April 12, 2016, 6:51 p.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46108/
> ---
> 
> (Updated April 12, 2016, 6:51 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Uncomment the code that is for optimization when sending the suspect 
> requests. So when there are more than 4 members in the view, the suspect 
> request will only be sent to at most 5 members, which might include a random 
> non-preferred coordinator.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>  5427d77 
> 
> Diff: https://reviews.apache.org/r/46108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>



Re: Review Request 46108: GEODE-1216 Fix the scalability of remove member

2016-04-12 Thread Udo Kohlmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46108/#review128541
---


Ship it!




Ship It!

- Udo Kohlmeyer


On April 12, 2016, 6:51 p.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46108/
> ---
> 
> (Updated April 12, 2016, 6:51 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Uncomment the code that is for optimization when sending the suspect 
> requests. So when there are more than 4 members in the view, the suspect 
> request will only be sent to at most 5 members, which might include a random 
> non-preferred coordinator.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>  5427d77 
> 
> Diff: https://reviews.apache.org/r/46108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>



Re: Review Request 46108: GEODE-1216 Fix the scalability of remove member

2016-04-12 Thread Bruce Schuchardt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46108/#review128536
---


Ship it!




Ship It!

- Bruce Schuchardt


On April 12, 2016, 6:51 p.m., Jianxia Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46108/
> ---
> 
> (Updated April 12, 2016, 6:51 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Uncomment the code that is for optimization when sending the suspect 
> requests. So when there are more than 4 members in the view, the suspect 
> request will only be sent to at most 5 members, which might include a random 
> non-preferred coordinator.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
>  5427d77 
> 
> Diff: https://reviews.apache.org/r/46108/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jianxia Chen
> 
>



Review Request 46108: GEODE-1216 Fix the scalability of remove member

2016-04-12 Thread Jianxia Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46108/
---

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Repository: geode


Description
---

Uncomment the code that is for optimization when sending the suspect requests. 
So when there are more than 4 members in the view, the suspect request will 
only be sent to at most 5 members, which might include a random non-preferred 
coordinator.


Diffs
-

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
 5427d77 

Diff: https://reviews.apache.org/r/46108/diff/


Testing
---


Thanks,

Jianxia Chen