Re: Review Request 47378: GEODE-11: Split out lucene tests of persistence and off heap

2016-05-16 Thread anilkumar gingade

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47378/#review133389
---


Ship it!




Ship It!

- anilkumar gingade


On May 14, 2016, 12:25 a.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47378/
> ---
> 
> (Updated May 14, 2016, 12:25 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Persistence and offheap require some special before and after code to
> create and clean up the resources. Splitting these to separate
> integration tests.
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
>  6429143ea57d1cc71fa2fe30fe5af0ce826fc49c 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationOffHeapIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
>  67775d229e93c0607fff53e6f64a583a04c0d382 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/TestObject.java
>  PRE-CREATION 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/package-info.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47378/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>



Review Request 47378: GEODE-11: Split out lucene tests of persistence and off heap

2016-05-13 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47378/
---

Review request for geode, anilkumar gingade, Barry Oglesby, and xiaojian zhou.


Repository: geode


Description
---

Persistence and offheap require some special before and after code to
create and clean up the resources. Splitting these to separate
integration tests.


Diffs
-

  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationIntegrationTest.java
 6429143ea57d1cc71fa2fe30fe5af0ce826fc49c 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationOffHeapIntegrationTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexCreationPersistenceIntegrationTest.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIntegrationTest.java
 67775d229e93c0607fff53e6f64a583a04c0d382 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/TestObject.java
 PRE-CREATION 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/package-info.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47378/diff/


Testing
---


Thanks,

Dan Smith