Re: Review Request 48865: GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events (by setting the flag forwardExpirationDestroy()).

2016-06-17 Thread Dan Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48865/#review138361
---


Ship it!




Ship It!

- Dan Smith


On June 17, 2016, 6:53 p.m., anilkumar gingade wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48865/
> ---
> 
> (Updated June 17, 2016, 6:53 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
> William Markito, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events 
> (by setting the flag forwardExpirationDestroy()).
> 
> 
> Diffs
> -
> 
>   
> geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
>  d283e29 
>   
> geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
>  05b6990 
> 
> Diff: https://reviews.apache.org/r/48865/diff/
> 
> 
> Testing
> ---
> 
> Added new test.
> Running new test with and without the forwardExpirationDestroy flag.
> 
> 
> Thanks,
> 
> anilkumar gingade
> 
>



Re: Review Request 48865: GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events (by setting the flag forwardExpirationDestroy()).

2016-06-17 Thread anilkumar gingade

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48865/
---

(Updated June 17, 2016, 6:53 p.m.)


Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
William Markito, nabarun nag, Dan Smith, and xiaojian zhou.


Changes
---

For review...


Repository: geode


Description
---

GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events 
(by setting the flag forwardExpirationDestroy()).


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 d283e29 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 05b6990 

Diff: https://reviews.apache.org/r/48865/diff/


Testing (updated)
---

Added new test.
Running new test with and without the forwardExpirationDestroy flag.


Thanks,

anilkumar gingade



Review Request 48865: GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events (by setting the flag forwardExpirationDestroy()).

2016-06-17 Thread anilkumar gingade

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48865/
---

Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, 
William Markito, nabarun nag, Dan Smith, and xiaojian zhou.


Repository: geode


Description
---

GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events 
(by setting the flag forwardExpirationDestroy()).


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 d283e29 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java
 05b6990 

Diff: https://reviews.apache.org/r/48865/diff/


Testing
---

Running new test with and without the forwardExpirationDestroy flag.


Thanks,

anilkumar gingade