Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

2016-09-06 Thread Udo Kohlmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51612/#review147929
---


Ship it!




Ship It!

- Udo Kohlmeyer


On Sept. 2, 2016, 6:38 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51612/
> ---
> 
> (Updated Sept. 2, 2016, 6:38 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Kevin Duling, Kirk Lund, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator with the correct ssl settings
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
>  09a25a67d748524cbbc19099c453d045b415ce5c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51612/diff/
> 
> 
> Testing
> ---
> 
> the newly added tests to cover both cluster-ssl-* and jmx-ssl-* settings. 
> This would test for both GEM-877 and GEM-626
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

2016-09-02 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51612/#review147703
---




geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
 (line 313)


Actually this entire if block is not needed anymore.


- Jinmei Liao


On Sept. 2, 2016, 6:38 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51612/
> ---
> 
> (Updated Sept. 2, 2016, 6:38 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Kevin Duling, Kirk Lund, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator with the correct ssl settings
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
>  09a25a67d748524cbbc19099c453d045b415ce5c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51612/diff/
> 
> 
> Testing
> ---
> 
> the newly added tests to cover both cluster-ssl-* and jmx-ssl-* settings. 
> This would test for both GEM-877 and GEM-626
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>



Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

2016-09-02 Thread Jinmei Liao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51612/
---

(Updated Sept. 2, 2016, 6:38 p.m.)


Review request for geode, Bruce Schuchardt, Kevin Duling, Kirk Lund, and Udo 
Kohlmeyer.


Repository: geode


Description
---

GEODE-1834: initilize the socketcreator with the correct ssl settings


Diffs (updated)
-

  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
 861f51d4e0077440ab3128e6053c389cecfd9bb8 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
 09a25a67d748524cbbc19099c453d045b415ce5c 
  
geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51612/diff/


Testing
---

the newly added tests to cover both cluster-ssl-* and jmx-ssl-* settings. This 
would test for both GEM-877 and GEM-626


Thanks,

Jinmei Liao



Re: Review Request 51612: GEODE-1834: initilize the socketcreator with the correct ssl settings

2016-09-02 Thread Jinmei Liao


> On Sept. 2, 2016, 6:14 p.m., Kirk Lund wrote:
> > geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java,
> >  line 56
> > 
> >
> > Change this to @Rule so each Test method gets its own TemporaryFolder. 
> > Change to our own custom rule SerializableTemporaryFolder (all dunit VMs 
> > can share this).
> > 
> > @Rule
> > public SerializableTemporaryFolder folder = new 
> > SerializableTemporaryFolder();

My thought is to create the folder only once for all the tests in this class 
and delete it after all tests are done, but this could be good as well.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51612/#review147677
---


On Sept. 2, 2016, 5:46 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51612/
> ---
> 
> (Updated Sept. 2, 2016, 5:46 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Kevin Duling, Kirk Lund, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-1834: initilize the socketcreator with the correct ssl settings
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/JmxManagerLocatorRequest.java
>  861f51d4e0077440ab3128e6053c389cecfd9bb8 
>   
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java
>  09a25a67d748524cbbc19099c453d045b415ce5c 
>   
> geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51612/diff/
> 
> 
> Testing
> ---
> 
> the newly added tests to cover both cluster-ssl-* and jmx-ssl-* settings. 
> This would test for both GEM-877 and GEM-626
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>