-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51666/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 9:30 p.m.)


Review request for geode, Bruce Schuchardt and Hitesh Khamesra.


Summary (updated)
-----------------

GEODE-1792: Configuration consistency in SSL configuration


Repository: geode


Description
-------

ssl-ciphers & ssl-protocols are defined as space-delimited multi-valued. 
Whereas ssl-enabled-components is comma-delimited. It is more logical that 
multi-values are comma-delimited rather than space-delimited. To have some 
consistency in the new ssl configuration ssl-ciphers and ssl-protocols will be 
comma-delimited.
This is contradictory to the already configured *-ssl-ciphers and 
*-ssl-protocols legacy settings which are space-delimited.
In order not to have a time-costly refactor just to handle the ssl-ciphers and 
ssl-protocols, the comma-delimited properties will internally be converted to 
space-delimited. This is safer as all testing has been done with 
space-delimited.
A cleaner solution is proposed in GEODE-1865.

In this diff JMX_MANAGER_SSL_ALIAS is also renamed to JMX_SSL_ALIAS.


Diffs
-----

  
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java
 df85aca 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java
 f92511e 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java
 4ad95c6 
  
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java
 c86b0e7 
  
geode-core/src/main/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactory.java
 df4f49c 
  geode-core/src/main/java/com/gemstone/gemfire/internal/net/SocketCreator.java 
0a2bfa3 
  
geode-core/src/main/java/com/gemstone/gemfire/management/GemFireProperties.java 
410d658 
  
geode-core/src/main/java/com/gemstone/gemfire/management/internal/beans/BeanUtilFuncs.java
 9d62fbf 
  
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 
b68841a 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SSLConfigurationFactoryTest.java
 d890457 
  
geode-core/src/test/java/com/gemstone/gemfire/internal/net/SocketCreatorFactoryJUnitTest.java
 c55c661 
  
geode-core/src/test/java/com/gemstone/gemfire/management/ConnectToLocatorSSLDUnitTest.java
 75a0e82 
  
geode-core/src/test/java/com/gemstone/gemfire/management/JMXMBeanDUnitTest.java 
f08c172 

Diff: https://reviews.apache.org/r/51666/diff/


Testing
-------

Precheckin currently running.


Thanks,

Udo Kohlmeyer

Reply via email to