Re: Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

2016-09-22 Thread Dan Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52179/#review150105
---


Ship it!




Ship It!

- Dan Smith


On Sept. 23, 2016, midnight, xiaojian zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52179/
> ---
> 
> (Updated Sept. 23, 2016, midnight)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: geode-1894
> https://issues.apache.org/jira/browse/geode-1894
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> To resolve the race condition, we should double check if if Sender's 
> processor is stopped. If yes, then don't wait for ack
> 
> 
> Diffs
> -
> 
>   
> geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  6beb0ee046d7e0cae5985b6430a390dd68f1351a 
> 
> Diff: https://reviews.apache.org/r/52179/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>

Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

2016-09-22 Thread xiaojian zhou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52179/
---

Review request for geode and Dan Smith.


Bugs: geode-1894
https://issues.apache.org/jira/browse/geode-1894


Repository: geode


Description
---

To resolve the race condition, we should double check if if Sender's processor 
is stopped. If yes, then don't wait for ack


Diffs
-

  
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
 6beb0ee046d7e0cae5985b6430a390dd68f1351a 

Diff: https://reviews.apache.org/r/52179/diff/


Testing
---


Thanks,

xiaojian zhou