Re: Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

[anilkumar gingade]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52619/#review151855
---




geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java
 (line 144)


Is this safe to remove entry here...The backing map looks like just hash 
map (not concurrent)...


- anilkumar gingade


On Oct. 7, 2016, 5:48 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52619/
> ---
> 
> (Updated Oct. 7, 2016, 5:48 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
> zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> CompactMapRangeIndex loses track when the same entry is deleted and added 
> because after the mapping was removed from the CompactMapRangeIndex it was 
> not removed from removedKeyValuesEntries. So when the same entry is 
> reentered, the system ends up thinking inplace modification has occured and 
> ends up removing the updated new entry, resulting in empty query results for 
> that entry.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java
>  234dfae 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java
>  b651272 
> 
> Diff: https://reviews.apache.org/r/52619/diff/
> 
> 
> Testing
> ---
> 
> precheck 
> Additional tests were written.
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Re: Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52619/#review151843
---


Ship it!




Ship It!

- Dan Smith


On Oct. 7, 2016, 5:48 p.m., nabarun nag wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52619/
> ---
> 
> (Updated Oct. 7, 2016, 5:48 p.m.)
> 
> 
> Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
> zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> CompactMapRangeIndex loses track when the same entry is deleted and added 
> because after the mapping was removed from the CompactMapRangeIndex it was 
> not removed from removedKeyValuesEntries. So when the same entry is 
> reentered, the system ends up thinking inplace modification has occured and 
> ends up removing the updated new entry, resulting in empty query results for 
> that entry.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java
>  234dfae 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java
>  b651272 
> 
> Diff: https://reviews.apache.org/r/52619/diff/
> 
> 
> Testing
> ---
> 
> precheck 
> Additional tests were written.
> 
> 
> Thanks,
> 
> nabarun nag
> 
>

Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52619/
---

Review request for geode, Barry Oglesby, Jason Huynh, Dan Smith, and xiaojian 
zhou.


Repository: geode


Description
---

CompactMapRangeIndex loses track when the same entry is deleted and added 
because after the mapping was removed from the CompactMapRangeIndex it was not 
removed from removedKeyValuesEntries. So when the same entry is reentered, the 
system ends up thinking inplace modification has occured and ends up removing 
the updated new entry, resulting in empty query results for that entry.


Diffs
-

  
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactMapRangeIndex.java
 234dfae 
  
geode-core/src/test/java/org/apache/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java
 b651272 

Diff: https://reviews.apache.org/r/52619/diff/


Testing
---

precheck 
Additional tests were written.


Thanks,

nabarun nag