Re: git commit messages
>>statistics > >>>> > >>>>* move statistics tests into com.gemstone.gemfire.internal. > >>> statistics > >>>> > >>>>* modify tests to include integration and distributed in names > >>>> > >>>>* modify tests to use TemporaryFolder and TestName rules > >>>> > >>>> On Wed, Aug 17, 2016 at 4:22 PM, Kenneth Howe <kh...@pivotal.io > <javascript:;>> > >> wrote: > >>>> > >>>>> Agree with Kirk, 50 chars is really short by the time you use up the > >>>> first > >>>>> 12 characters for the Jira tag. If we’re going to have a guideline, > >> I’d > >>>>> rather be longer - somewhat arbitrarily I’d probably make it 20-30 > >>> chars > >>>>> more. It’s been a long time since text listings were intended to fit > >>> on a > >>>>> 80x24 dumb terminal, so I don’t see a need to restrict the commit > >>> message > >>>>> headers so severely. > >>>>> > >>>>> I do use the —online option embedded in a local alias I use to look > >> at > >>> a > >>>>> history list of my local repo. > >>>>> > >>>>> Ken > >>>>> > >>>>>> On Aug 17, 2016, at 3:45 PM, Kevin Duling <kdul...@pivotal.io > <javascript:;>> > >>> wrote: > >>>>>> > >>>>>> The format is very similar to the one most other git shops I've > >>> worked > >>>> in > >>>>>> before use. I don't believe we ever had formal length limits. > >>>>> Typically, > >>>>>> it was: > >>>>>> > >>>>>> -: > >>>>>>> > >>>>>> blank line > >>>>>> > >>>>>> >>>>> ticket> > >>>>>> > >>>>>> > >>>>>> The Atlassian plugin for IDEA automates a lot of this. There are > >>>> limits > >>>>> on > >>>>>> the length of a jira ticket summary, but I'm not sure what that is. > >>> I > >>>>> ran > >>>>>> in to it when I did my round of CI. > >>>>>> > >>>>>> I don't see a reason to change anything except maybe stress that he > >>>>> lengths > >>>>>> are a guideline, not a hard & fast rule. If more room is needed to > >>>> write > >>>>>> good information, it shouldn't be truncated as it's not unknown to > >>> move > >>>>>> away from a given ticket system. > >>>>>> > >>>>>> On Wed, Aug 17, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io > <javascript:;>> > >> wrote: > >>>>>> > >>>>>>> 50 chars including "GEODE-: " is awfully short. > >>>>>>> http://chris.beams.io/posts/git-commit/ does say that's just a > >>>> general > >>>>>>> rule > >>>>>>> of thumb and not a hard limit. The author's reasoning seems to be > >>>>>>> specifically for using "git log --oneline" -- does anyone use that > >>>>> option > >>>>>>> with git log? I don't. > >>>>>>> > >>>>>>> I guess another option is to not have to have a guideline if we > >>> don't > >>>>> want > >>>>>>> one... our current git log messages are reasonable and make sense. > >>>>>>> > >>>>>>> -Kirk > >>>>>>> > >>>>>>> > >>>>>>> On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io > <javascript:;>> > >>> wrote: > >>>>>>> > >>>>>>>> Here's the git commit message guidelines we discussed and voted > >> on > >>>> last > >>>>>>>> year. I just checked and my own git commit message line lengths > >>> have > >>>>>>> grown > >>>>>>>> beyond what we decided to use. Most other are also not following > >>> this > >>>>>>>> guideline. > >>>>>>>> > >>>>>>>> Here's the list of folks who voted last year along with their > >> vote: > >>>>>>>> > >>>>>>>> Anthony Baker +1 > >>>>>>>> Vincent Ford +1 > >>>>>>>> William Markito +1 > >>>>>>>> arghya sadhu +1 > >>>>>>>> > >>>>>>>> Do we want to reaffirm this guideline or should it change? > >>>>>>>> > >>>>>>>> -Kirk > >>>>>>>> > >>>>>>>> -- Forwarded message -- > >>>>>>>> From: Kirk Lund <kl...@pivotal.io <javascript:;>> > >>>>>>>> Date: Wed, Aug 5, 2015 at 3:18 PM > >>>>>>>> Subject: git commit messages > >>>>>>>> To: dev@geode.incubator.apache.org <javascript:;> > >>>>>>>> > >>>>>>>> > >>>>>>>> Several of us were discussing http://chris.beams.io/posts/ > >>>> git-commit/ > >>>>> -- > >>>>>>>> there are a couple other really good articles about git commit > >>>> messages > >>>>>>> and > >>>>>>>> below is the message style I've been trying to follow. > >>>>>>>> > >>>>>>>> http://chris.beams.io/posts/git-commit/ > >>>>>>>> http://www.laurencegellert.com/2013/07/how-to-write-a- > >>> proper-commit- > >>>>>>>> message/ > >>>>>>>> http://tbaggery.com/2008/04/19/a-note-about-git-commit- > >>> messages.html > >>>>>>>> > >>>>>>>> GEODE-nn: Begin capitalized and 50 chars or less > >>>>>>>> > >>>>>>>> More detailed explanation with linefeeds to wrap at 72 characters > >>>> after > >>>>>>>> a blank line following the summary. > >>>>>>>> > >>>>>>>> Further paragraphs come after blank lines. > >>>>>>>> > >>>>>>>> - Bullet points are okay, too > >>>>>>>> > >>>>>>>> - Typically a hyphen or asterisk is used for the bullet, followed > >>> by > >>>> a > >>>>>>>> single space, with blank lines in between, but conventions vary > >>> here > >>>>>>>> > >>>>>>>> - Use a hanging indent > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>> > >>>>> > >>>> > >>> > >> > >
Re: git commit messages
ed to fit >>> on a >>>>> 80x24 dumb terminal, so I don’t see a need to restrict the commit >>> message >>>>> headers so severely. >>>>> >>>>> I do use the —online option embedded in a local alias I use to look >> at >>> a >>>>> history list of my local repo. >>>>> >>>>> Ken >>>>> >>>>>> On Aug 17, 2016, at 3:45 PM, Kevin Duling <kdul...@pivotal.io> >>> wrote: >>>>>> >>>>>> The format is very similar to the one most other git shops I've >>> worked >>>> in >>>>>> before use. I don't believe we ever had formal length limits. >>>>> Typically, >>>>>> it was: >>>>>> >>>>>> -: >>>>>>> >>>>>> blank line >>>>>> >>>>>> >>>> ticket> >>>>>> >>>>>> >>>>>> The Atlassian plugin for IDEA automates a lot of this. There are >>>> limits >>>>> on >>>>>> the length of a jira ticket summary, but I'm not sure what that is. >>> I >>>>> ran >>>>>> in to it when I did my round of CI. >>>>>> >>>>>> I don't see a reason to change anything except maybe stress that he >>>>> lengths >>>>>> are a guideline, not a hard & fast rule. If more room is needed to >>>> write >>>>>> good information, it shouldn't be truncated as it's not unknown to >>> move >>>>>> away from a given ticket system. >>>>>> >>>>>> On Wed, Aug 17, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io> >> wrote: >>>>>> >>>>>>> 50 chars including "GEODE-: " is awfully short. >>>>>>> http://chris.beams.io/posts/git-commit/ does say that's just a >>>> general >>>>>>> rule >>>>>>> of thumb and not a hard limit. The author's reasoning seems to be >>>>>>> specifically for using "git log --oneline" -- does anyone use that >>>>> option >>>>>>> with git log? I don't. >>>>>>> >>>>>>> I guess another option is to not have to have a guideline if we >>> don't >>>>> want >>>>>>> one... our current git log messages are reasonable and make sense. >>>>>>> >>>>>>> -Kirk >>>>>>> >>>>>>> >>>>>>> On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> >>> wrote: >>>>>>> >>>>>>>> Here's the git commit message guidelines we discussed and voted >> on >>>> last >>>>>>>> year. I just checked and my own git commit message line lengths >>> have >>>>>>> grown >>>>>>>> beyond what we decided to use. Most other are also not following >>> this >>>>>>>> guideline. >>>>>>>> >>>>>>>> Here's the list of folks who voted last year along with their >> vote: >>>>>>>> >>>>>>>> Anthony Baker +1 >>>>>>>> Vincent Ford +1 >>>>>>>> William Markito +1 >>>>>>>> arghya sadhu +1 >>>>>>>> >>>>>>>> Do we want to reaffirm this guideline or should it change? >>>>>>>> >>>>>>>> -Kirk >>>>>>>> >>>>>>>> -- Forwarded message -- >>>>>>>> From: Kirk Lund <kl...@pivotal.io> >>>>>>>> Date: Wed, Aug 5, 2015 at 3:18 PM >>>>>>>> Subject: git commit messages >>>>>>>> To: dev@geode.incubator.apache.org >>>>>>>> >>>>>>>> >>>>>>>> Several of us were discussing http://chris.beams.io/posts/ >>>> git-commit/ >>>>> -- >>>>>>>> there are a couple other really good articles about git commit >>>> messages >>>>>>> and >>>>>>>> below is the message style I've been trying to follow. >>>>>>>> >>>>>>>> http://chris.beams.io/posts/git-commit/ >>>>>>>> http://www.laurencegellert.com/2013/07/how-to-write-a- >>> proper-commit- >>>>>>>> message/ >>>>>>>> http://tbaggery.com/2008/04/19/a-note-about-git-commit- >>> messages.html >>>>>>>> >>>>>>>> GEODE-nn: Begin capitalized and 50 chars or less >>>>>>>> >>>>>>>> More detailed explanation with linefeeds to wrap at 72 characters >>>> after >>>>>>>> a blank line following the summary. >>>>>>>> >>>>>>>> Further paragraphs come after blank lines. >>>>>>>> >>>>>>>> - Bullet points are okay, too >>>>>>>> >>>>>>>> - Typically a hyphen or asterisk is used for the bullet, followed >>> by >>>> a >>>>>>>> single space, with blank lines in between, but conventions vary >>> here >>>>>>>> >>>>>>>> - Use a hanging indent >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>> >>>>> >>>> >>> >>
Re: git commit messages
> > >> > > >> I guess another option is to not have to have a guideline if we don't > > want > > >> one... our current git log messages are reasonable and make sense. > > >> > > >> -Kirk > > >> > > >> > > >> On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> wrote: > > >> > > >>> Here's the git commit message guidelines we discussed and voted on > last > > >>> year. I just checked and my own git commit message line lengths have > > >> grown > > >>> beyond what we decided to use. Most other are also not following this > > >>> guideline. > > >>> > > >>> Here's the list of folks who voted last year along with their vote: > > >>> > > >>> Anthony Baker +1 > > >>> Vincent Ford +1 > > >>> William Markito +1 > > >>> arghya sadhu +1 > > >>> > > >>> Do we want to reaffirm this guideline or should it change? > > >>> > > >>> -Kirk > > >>> > > >>> -- Forwarded message -- > > >>> From: Kirk Lund <kl...@pivotal.io> > > >>> Date: Wed, Aug 5, 2015 at 3:18 PM > > >>> Subject: git commit messages > > >>> To: dev@geode.incubator.apache.org > > >>> > > >>> > > >>> Several of us were discussing http://chris.beams.io/posts/ > git-commit/ > > -- > > >>> there are a couple other really good articles about git commit > messages > > >> and > > >>> below is the message style I've been trying to follow. > > >>> > > >>> http://chris.beams.io/posts/git-commit/ > > >>> http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit- > > >>> message/ > > >>> http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html > > >>> > > >>> GEODE-nn: Begin capitalized and 50 chars or less > > >>> > > >>> More detailed explanation with linefeeds to wrap at 72 characters > after > > >>> a blank line following the summary. > > >>> > > >>> Further paragraphs come after blank lines. > > >>> > > >>> - Bullet points are okay, too > > >>> > > >>> - Typically a hyphen or asterisk is used for the bullet, followed by > a > > >>> single space, with blank lines in between, but conventions vary here > > >>> > > >>> - Use a hanging indent > > >>> > > >>> > > >>> > > >>> > > >> > > > > >
Re: git commit messages
Agree with Kirk, 50 chars is really short by the time you use up the first 12 characters for the Jira tag. If we’re going to have a guideline, I’d rather be longer - somewhat arbitrarily I’d probably make it 20-30 chars more. It’s been a long time since text listings were intended to fit on a 80x24 dumb terminal, so I don’t see a need to restrict the commit message headers so severely. I do use the —online option embedded in a local alias I use to look at a history list of my local repo. Ken > On Aug 17, 2016, at 3:45 PM, Kevin Duling <kdul...@pivotal.io> wrote: > > The format is very similar to the one most other git shops I've worked in > before use. I don't believe we ever had formal length limits. Typically, > it was: > > -: >> > blank line > > > > > The Atlassian plugin for IDEA automates a lot of this. There are limits on > the length of a jira ticket summary, but I'm not sure what that is. I ran > in to it when I did my round of CI. > > I don't see a reason to change anything except maybe stress that he lengths > are a guideline, not a hard & fast rule. If more room is needed to write > good information, it shouldn't be truncated as it's not unknown to move > away from a given ticket system. > > On Wed, Aug 17, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io> wrote: > >> 50 chars including "GEODE-: " is awfully short. >> http://chris.beams.io/posts/git-commit/ does say that's just a general >> rule >> of thumb and not a hard limit. The author's reasoning seems to be >> specifically for using "git log --oneline" -- does anyone use that option >> with git log? I don't. >> >> I guess another option is to not have to have a guideline if we don't want >> one... our current git log messages are reasonable and make sense. >> >> -Kirk >> >> >> On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> wrote: >> >>> Here's the git commit message guidelines we discussed and voted on last >>> year. I just checked and my own git commit message line lengths have >> grown >>> beyond what we decided to use. Most other are also not following this >>> guideline. >>> >>> Here's the list of folks who voted last year along with their vote: >>> >>> Anthony Baker +1 >>> Vincent Ford +1 >>> William Markito +1 >>> arghya sadhu +1 >>> >>> Do we want to reaffirm this guideline or should it change? >>> >>> -Kirk >>> >>> -- Forwarded message -- >>> From: Kirk Lund <kl...@pivotal.io> >>> Date: Wed, Aug 5, 2015 at 3:18 PM >>> Subject: git commit messages >>> To: dev@geode.incubator.apache.org >>> >>> >>> Several of us were discussing http://chris.beams.io/posts/git-commit/ -- >>> there are a couple other really good articles about git commit messages >> and >>> below is the message style I've been trying to follow. >>> >>> http://chris.beams.io/posts/git-commit/ >>> http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit- >>> message/ >>> http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html >>> >>> GEODE-nn: Begin capitalized and 50 chars or less >>> >>> More detailed explanation with linefeeds to wrap at 72 characters after >>> a blank line following the summary. >>> >>> Further paragraphs come after blank lines. >>> >>> - Bullet points are okay, too >>> >>> - Typically a hyphen or asterisk is used for the bullet, followed by a >>> single space, with blank lines in between, but conventions vary here >>> >>> - Use a hanging indent >>> >>> >>> >>> >>
Re: git commit messages
To me, having a meaningful short summary line is still pretty useful. I use git oneline and github and my ide also use that summary line. -Dan On Wed, Aug 17, 2016 at 3:45 PM, Kevin Duling <kdul...@pivotal.io> wrote: > The format is very similar to the one most other git shops I've worked in > before use. I don't believe we ever had formal length limits. Typically, > it was: > > -: > > > blank line > > > > > The Atlassian plugin for IDEA automates a lot of this. There are limits on > the length of a jira ticket summary, but I'm not sure what that is. I ran > in to it when I did my round of CI. > > I don't see a reason to change anything except maybe stress that he lengths > are a guideline, not a hard & fast rule. If more room is needed to write > good information, it shouldn't be truncated as it's not unknown to move > away from a given ticket system. > > On Wed, Aug 17, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > 50 chars including "GEODE-: " is awfully short. > > http://chris.beams.io/posts/git-commit/ does say that's just a general > > rule > > of thumb and not a hard limit. The author's reasoning seems to be > > specifically for using "git log --oneline" -- does anyone use that option > > with git log? I don't. > > > > I guess another option is to not have to have a guideline if we don't > want > > one... our current git log messages are reasonable and make sense. > > > > -Kirk > > > > > > On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > > > Here's the git commit message guidelines we discussed and voted on last > > > year. I just checked and my own git commit message line lengths have > > grown > > > beyond what we decided to use. Most other are also not following this > > > guideline. > > > > > > Here's the list of folks who voted last year along with their vote: > > > > > > Anthony Baker +1 > > > Vincent Ford +1 > > > William Markito +1 > > > arghya sadhu +1 > > > > > > Do we want to reaffirm this guideline or should it change? > > > > > > -Kirk > > > > > > -- Forwarded message -- > > > From: Kirk Lund <kl...@pivotal.io> > > > Date: Wed, Aug 5, 2015 at 3:18 PM > > > Subject: git commit messages > > > To: dev@geode.incubator.apache.org > > > > > > > > > Several of us were discussing http://chris.beams.io/posts/git-commit/ > -- > > > there are a couple other really good articles about git commit messages > > and > > > below is the message style I've been trying to follow. > > > > > > http://chris.beams.io/posts/git-commit/ > > > http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit- > > > message/ > > > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html > > > > > > GEODE-nn: Begin capitalized and 50 chars or less > > > > > > More detailed explanation with linefeeds to wrap at 72 characters after > > > a blank line following the summary. > > > > > > Further paragraphs come after blank lines. > > > > > > - Bullet points are okay, too > > > > > > - Typically a hyphen or asterisk is used for the bullet, followed by a > > > single space, with blank lines in between, but conventions vary here > > > > > > - Use a hanging indent > > > > > > > > > > > > > > >
Re: git commit messages
The format is very similar to the one most other git shops I've worked in before use. I don't believe we ever had formal length limits. Typically, it was: -: > blank line The Atlassian plugin for IDEA automates a lot of this. There are limits on the length of a jira ticket summary, but I'm not sure what that is. I ran in to it when I did my round of CI. I don't see a reason to change anything except maybe stress that he lengths are a guideline, not a hard & fast rule. If more room is needed to write good information, it shouldn't be truncated as it's not unknown to move away from a given ticket system. On Wed, Aug 17, 2016 at 3:38 PM, Kirk Lund <kl...@pivotal.io> wrote: > 50 chars including "GEODE-: " is awfully short. > http://chris.beams.io/posts/git-commit/ does say that's just a general > rule > of thumb and not a hard limit. The author's reasoning seems to be > specifically for using "git log --oneline" -- does anyone use that option > with git log? I don't. > > I guess another option is to not have to have a guideline if we don't want > one... our current git log messages are reasonable and make sense. > > -Kirk > > > On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> wrote: > > > Here's the git commit message guidelines we discussed and voted on last > > year. I just checked and my own git commit message line lengths have > grown > > beyond what we decided to use. Most other are also not following this > > guideline. > > > > Here's the list of folks who voted last year along with their vote: > > > > Anthony Baker +1 > > Vincent Ford +1 > > William Markito +1 > > arghya sadhu +1 > > > > Do we want to reaffirm this guideline or should it change? > > > > -Kirk > > > > -- Forwarded message -- > > From: Kirk Lund <kl...@pivotal.io> > > Date: Wed, Aug 5, 2015 at 3:18 PM > > Subject: git commit messages > > To: dev@geode.incubator.apache.org > > > > > > Several of us were discussing http://chris.beams.io/posts/git-commit/ -- > > there are a couple other really good articles about git commit messages > and > > below is the message style I've been trying to follow. > > > > http://chris.beams.io/posts/git-commit/ > > http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit- > > message/ > > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html > > > > GEODE-nn: Begin capitalized and 50 chars or less > > > > More detailed explanation with linefeeds to wrap at 72 characters after > > a blank line following the summary. > > > > Further paragraphs come after blank lines. > > > > - Bullet points are okay, too > > > > - Typically a hyphen or asterisk is used for the bullet, followed by a > > single space, with blank lines in between, but conventions vary here > > > > - Use a hanging indent > > > > > > > > >
Re: git commit messages
50 chars including "GEODE-: " is awfully short. http://chris.beams.io/posts/git-commit/ does say that's just a general rule of thumb and not a hard limit. The author's reasoning seems to be specifically for using "git log --oneline" -- does anyone use that option with git log? I don't. I guess another option is to not have to have a guideline if we don't want one... our current git log messages are reasonable and make sense. -Kirk On Wed, Aug 17, 2016 at 3:21 PM, Kirk Lund <kl...@pivotal.io> wrote: > Here's the git commit message guidelines we discussed and voted on last > year. I just checked and my own git commit message line lengths have grown > beyond what we decided to use. Most other are also not following this > guideline. > > Here's the list of folks who voted last year along with their vote: > > Anthony Baker +1 > Vincent Ford +1 > William Markito +1 > arghya sadhu +1 > > Do we want to reaffirm this guideline or should it change? > > -Kirk > > -- Forwarded message -- > From: Kirk Lund <kl...@pivotal.io> > Date: Wed, Aug 5, 2015 at 3:18 PM > Subject: git commit messages > To: dev@geode.incubator.apache.org > > > Several of us were discussing http://chris.beams.io/posts/git-commit/ -- > there are a couple other really good articles about git commit messages and > below is the message style I've been trying to follow. > > http://chris.beams.io/posts/git-commit/ > http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit- > message/ > http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html > > GEODE-nn: Begin capitalized and 50 chars or less > > More detailed explanation with linefeeds to wrap at 72 characters after > a blank line following the summary. > > Further paragraphs come after blank lines. > > - Bullet points are okay, too > > - Typically a hyphen or asterisk is used for the bullet, followed by a > single space, with blank lines in between, but conventions vary here > > - Use a hanging indent > > > >
Fwd: git commit messages
Here's the git commit message guidelines we discussed and voted on last year. I just checked and my own git commit message line lengths have grown beyond what we decided to use. Most other are also not following this guideline. Here's the list of folks who voted last year along with their vote: Anthony Baker +1 Vincent Ford +1 William Markito +1 arghya sadhu +1 Do we want to reaffirm this guideline or should it change? -Kirk -- Forwarded message -- From: Kirk Lund <kl...@pivotal.io> Date: Wed, Aug 5, 2015 at 3:18 PM Subject: git commit messages To: dev@geode.incubator.apache.org Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent
Re: git commit messages
On Wed, Aug 5, 2015 at 11:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. Even though it's on Subversion's site, the conventions we adopted as a community are more generic and applicable to git as well: http://subversion.apache.org/docs/community-guide/conventions.html#log-messages Cheers. -- justin
Re: git commit messages
+1 On Thu, Aug 6, 2015 at 9:15 AM, William Markito wmark...@pivotal.io wrote: +1 On Wed, Aug 5, 2015 at 4:49 PM, Vincent Ford vf...@pivotal.io wrote: +1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent -- William Markito Oliveira Enterprise Architect -- For questions about Apache Geode, please write to *dev@geode.incubator.apache.org dev@geode.incubator.apache.org*
Re: git commit messages
+1 On Wed, Aug 5, 2015 at 4:49 PM, Vincent Ford vf...@pivotal.io wrote: +1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent -- William Markito Oliveira Enterprise Architect -- For questions about Apache Geode, please write to *dev@geode.incubator.apache.org dev@geode.incubator.apache.org*
Re: git commit messages
+1 *Vince Ford* GemFire Sustenance Engineering Beaverton, OR USA 503-533-3726 (office) http://www.pivotal.io Open Source Project Geode https://geode.incubator.apache.org/ https://network.pivotal.io/products/project-geode On Wed, Aug 5, 2015 at 3:59 PM, Anthony Baker aba...@pivotal.io wrote: +1 Anthony On Aug 5, 2015, at 3:18 PM, Kirk Lund kl...@pivotal.io wrote: Several of us were discussing http://chris.beams.io/posts/git-commit/ -- there are a couple other really good articles about git commit messages and below is the message style I've been trying to follow. http://chris.beams.io/posts/git-commit/ http://www.laurencegellert.com/2013/07/how-to-write-a-proper-commit-message/ http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html GEODE-nn: Begin capitalized and 50 chars or less More detailed explanation with linefeeds to wrap at 72 characters after a blank line following the summary. Further paragraphs come after blank lines. - Bullet points are okay, too - Typically a hyphen or asterisk is used for the bullet, followed by a single space, with blank lines in between, but conventions vary here - Use a hanging indent
