Re: jmh benchmarks

[William Markito Oliveira]

+1

Sent from my iPhone

> On Nov 2, 2016, at 11:35 AM, Udo Kohlmeyer  wrote:
> 
> +2
> 
> 
>> On 3/11/16 5:17 am, Dan Smith wrote:
>> Hi all,
>> 
>> I'd like to add some support for running benchmarks with jmh to geode. Is
>> this something we're interested in having? JMH is a framework for easily
>> writing microbenchmarks. It's probably not that useful for large scale
>> multiple member benchmarks, but it can help us benchmark and optimize
>> smaller pieces of code.
>> 
>> You can look at this review request for what I want to change and a couple
>> of example benchmarks:
>> 
>> https://reviews.apache.org/r/53395/
>> 
>> -Dan
>> 
> 

Re: jmh benchmarks

[Udo Kohlmeyer]

+2


On 3/11/16 5:17 am, Dan Smith wrote:

Hi all,

I'd like to add some support for running benchmarks with jmh to geode. Is
this something we're interested in having? JMH is a framework for easily
writing microbenchmarks. It's probably not that useful for large scale
multiple member benchmarks, but it can help us benchmark and optimize
smaller pieces of code.

You can look at this review request for what I want to change and a couple
of example benchmarks:

https://reviews.apache.org/r/53395/

-Dan

Re: jmh benchmarks

[Jared Stewart]

+1 Jmh is great

On Nov 2, 2016 11:18 AM, "Dan Smith"  wrote:

> Hi all,
>
> I'd like to add some support for running benchmarks with jmh to geode. Is
> this something we're interested in having? JMH is a framework for easily
> writing microbenchmarks. It's probably not that useful for large scale
> multiple member benchmarks, but it can help us benchmark and optimize
> smaller pieces of code.
>
> You can look at this review request for what I want to change and a couple
> of example benchmarks:
>
> https://reviews.apache.org/r/53395/
>
> -Dan
>

jmh benchmarks

[Dan Smith]

Hi all,

I'd like to add some support for running benchmarks with jmh to geode. Is
this something we're interested in having? JMH is a framework for easily
writing microbenchmarks. It's probably not that useful for large scale
multiple member benchmarks, but it can help us benchmark and optimize
smaller pieces of code.

You can look at this review request for what I want to change and a couple
of example benchmarks:

https://reviews.apache.org/r/53395/

-Dan

Re: Review Request 53395: Adding a geode-benchmark project with support for running jmh benchmarks

[William Markito]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53395/#review154604
---


Ship it!




Thanks for doing this Dan! Would love to see a README with instructions on how 
to get the results (for people not familiar with JMH) and integration of the 
results with Jenkins/CI so we have historical data.  Ship-it!

- William Markito


On Nov. 2, 2016, 6:11 p.m., Dan Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53395/
> ---
> 
> (Updated Nov. 2, 2016, 6:11 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Adding a new project with a couple of simple benchmarks using jmh, to
> make it easier for developers to write microbenchmarks of geode.
> 
> 
> Diffs
> -
> 
>   build.gradle 6e82433e81ad832cc753c71873b112b73b81397e 
>   geode-benchmarks/build.gradle PRE-CREATION 
>   
> geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RangeQueryWithIndexBenchmark.java
>  PRE-CREATION 
>   
> geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RegionOperationBenchmark.java
>  PRE-CREATION 
>   settings.gradle 5aaa17ad69d1f3e4d3c2c8af5b8a5667b3fab7d9 
> 
> Diff: https://reviews.apache.org/r/53395/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Review Request 53395: Adding a geode-benchmark project with support for running jmh benchmarks

[Dan Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53395/
---

Review request for geode.


Repository: geode


Description
---

Adding a new project with a couple of simple benchmarks using jmh, to
make it easier for developers to write microbenchmarks of geode.


Diffs
-

  build.gradle 6e82433e81ad832cc753c71873b112b73b81397e 
  geode-benchmarks/build.gradle PRE-CREATION 
  
geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RangeQueryWithIndexBenchmark.java
 PRE-CREATION 
  
geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RegionOperationBenchmark.java
 PRE-CREATION 
  settings.gradle 5aaa17ad69d1f3e4d3c2c8af5b8a5667b3fab7d9 

Diff: https://reviews.apache.org/r/53395/diff/


Testing
---


Thanks,

Dan Smith