Re: Setting ClientID for connection

2005-12-27 Thread Hiram Chirino 

Thanks for the patch!  It's now applied.

Regards,
Hiram

On Dec 27, 2005, at 2:54 AM, [EMAIL PROTECTED]  
[EMAIL PROTECTED] wrote:



Hello,

Please find a diff below for the  
org.activemq.ActiveMQConnectionFactory

class to ensure that when the clientID is specified using a URL
parameter e.g. tcp://localhost:1244?jms.clientID=TestClientID it is  
set
for the connection. This seems like the only way to ensure that a  
client
ID is specified when using a message driven bean under WebSphere  
with a

persistent topic.

199a200,204

// Ensure Client ID is set for the connection if it was

explicity specified for the factory

if (clientID != null) {
connection.setClientID(clientID);
}




Regards,

Marcus



-Original Message-
From: Adrian Co [mailto:[EMAIL PROTECTED]
Sent: 27 December 2005 03:15 AM
To: activemq-dev@geronimo.apache.org
Subject: Re: svn commit: r358785 -
/incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/ 
broke

r/region/PrefetchSubscription.java

Sorry, my bad.

I've rolled back the changes to the position of
node.incrementReferenceCount, but I did maintain the change for
incrementPreloadSize, since this was causing the memory leak in the
subscription.

Hope this is ok.

[EMAIL PROTECTED] wrote:


Hello,

By adding an incrementReferenceCount and decrementReferenceCount  
to the



PrefetchSubscription::dispatch method I have fixed the null message
problem I was experiencing.

   private void dispatch(final MessageReference node) throws
IOException {
   try {

   node.incrementReferenceCount();

   final Message message = node.getMessage();
   if( message == null ) {
   return;
   }

   // Make sure we can dispatch a message.
   if( canDispatch(node) ) {

   MessageDispatch md = createMessageDispatch(node,
message);
   dispatched.addLast(node);

   node.incrementReferenceCount();
   incrementPreloadSize(node.getMessage().getSize());

   if( info.isDispatchAsync() ) {
   md.setConsumer(new Runnable(){
   public void run() {
   onDispatch(node, message);
   }
   });
   context.getConnection().dispatchAsync(md);
   } else {
   context.getConnection().dispatchSync(md);
   onDispatch(node, message);
   }
   }
   }
   finally {
  node.decrementReferenceCount();
   }
   }

Regards,

Marcus

-Original Message-
From: Hiram Chirino [mailto:[EMAIL PROTECTED]
Sent: 23 December 2005 07:37 PM
To: activemq-dev@geronimo.apache.org
Cc: activemq-commits@geronimo.apache.org
Subject: Re: svn commit: r358785 -
/incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/ 
brok

e
r/region/PrefetchSubscription.java

Hi Adrian,

doing a getMessage() before incrementReferenceCount() is dangerous
since the message could have been swapped out and the call to
getMessage() will return null.
Yes, I know there is a null check to see if the message is null, but
that should only happen if the message was expired.  Right now I  
think

it's possible that we are going to have cases of where messages get
swapped out and this code is going to think that the message has been
expired.

Regards,
Hiram


On Dec 23, 2005, at 4:48 AM, [EMAIL PROTECTED] wrote:




Author: aco
Date: Fri Dec 23 01:47:47 2005
New Revision: 358785

URL: http://svn.apache.org/viewcvs?rev=358785view=rev
Log:
Postpone incrementing of reference count and preload size, only  
after

we are sure that the message will be dispatched by the current
subscription. This is to prevent a memory leak type of scenario.

Modified:
   incubator/activemq/trunk/activemq-core/src/main/java/org/
activemq/broker/region/PrefetchSubscription.java

Modified: incubator/activemq/trunk/activemq-core/src/main/java/org/
activemq/broker/region/PrefetchSubscription.java
URL: http://svn.apache.org/viewcvs/incubator/activemq/trunk/
activemq-core/src/main/java/org/activemq/broker/region/
PrefetchSubscription.java?rev=358785r1=358784r2=358785view=diff
 
==


--- incubator/activemq/trunk/activemq-core/src/main/java/org/
activemq/broker/region/PrefetchSubscription.java (original)
+++ incubator/activemq/trunk/activemq-core/src/main/java/org/
activemq/broker/region/PrefetchSubscription.java Fri Dec 23
01:47:47 2005
@@ -239,19 +239,19 @@

private void dispatch(final MessageReference node) throws
IOException {

-node.incrementReferenceCount();
-
final Message message = node.getMessage();
if( message == null ) {
return;
-}
-incrementPreloadSize(node.getMessage().getSize());
+}

// Make sure we can dispatch a message.
if( canDispatch(node) )

Fatal error while building j2ee-installer (izpack)

2005-12-27 Thread Jacek Laskowski 
Hi,

Is it only me who experiences the following error? It seems that the
solution might be as simple as editing the geronimo-izpack.xml and
change the referenced file name, but don't know whether or not it
doesn't incur any other troubles along the way.
...
[java] - Fatal error :
[java]
d:\projs\geronimo\assemblies\j2ee-installer/target/geronimo-1.0-SNAPSHOT/geronimo-izpack.xml:23:
Resource
not found: 
d:\projs\geronimo\assemblies\j2ee-installer\target\geronimo-1.0-SNAPSHOT\RELEASE-NOTES-1.0-M5.txt
[java] com.izforge.izpack.compiler.CompilerException:
d:\projs\geronimo\assemblies\j2ee-installer/target/geronimo-1.
0-SNAPSHOT/geronimo-izpack.xml:23: Resource not found:
d:\projs\geronimo\assemblies\j2ee-installer\target\geronimo-1.0-S
NAPSHOT\RELEASE-NOTES-1.0-M5.txt
[java]  at
com.izforge.izpack.compiler.CompilerConfig.parseError(CompilerConfig.java:1518)
[java]  at
com.izforge.izpack.compiler.CompilerConfig.findProjectResource(CompilerConfig.java:1447)
[java]  at
com.izforge.izpack.compiler.CompilerConfig.addResources(CompilerConfig.java:1044)
[java]  at
com.izforge.izpack.compiler.CompilerConfig.executeCompiler(CompilerConfig.java:313)
[java]  at
com.izforge.izpack.compiler.CompilerConfig.main(CompilerConfig.java:1847)
[java]  at com.izforge.izpack.compiler.Compiler.main(Compiler.java:620)
[java]
[java] (tip : use -? to get the commmand line parameters)
[java] [ERROR] Java Result: 1

BUILD FAILED

Jacek

Re: [VOTE] Change ServiceMix version to 3.0-SNAPSHOT

2005-12-27 Thread Dan Diephouse 

+1
Guillaume Nodet wrote:

As we have to change the package names to org.apache.servicemix, i 
propose that we change
the version number of ServiceMix to 3.0 to reflect this, and also the 
fact that we are focusing

on full jbi compliance for both the container and components.

[ ] +1 Change version to 3.0-SNAPSHOT
[ ] -1 Keep 2.1 version number (provide specific comments)

Cheers,
Guillaume Nodet





--
Dan Diephouse
(616) 971-2053
Envoi Solutions LLC
http://netzooid.com

Re: Fatal error while building j2ee-installer (izpack)

2005-12-27 Thread Aaron Mulder 
It is not only you.  When I looked, it appeared that the variable for
the release notes file is hardcoded in the plugin Jelly.  I think it
needs to be changed to read that from a value passed when the plugin
is invoked, which can then be read from etc/project.properties. 
Someone had a tip on how they thought this could be done.

In the mean time, if you want to use the installer, you can hardcode
the value in the XML file in src/izpack instead of using the variable
at all...  But I think there are pending patches for the installer
script that John Sisson was looking at.  And I think David B removed
the installer from the top-level Maven build until this is fixed.

Thanks,
Aaron

On 12/27/05, Jacek Laskowski [EMAIL PROTECTED] wrote:
 Hi,

 Is it only me who experiences the following error? It seems that the
 solution might be as simple as editing the geronimo-izpack.xml and
 change the referenced file name, but don't know whether or not it
 doesn't incur any other troubles along the way.
 ...
 [java] - Fatal error :
 [java]
 d:\projs\geronimo\assemblies\j2ee-installer/target/geronimo-1.0-SNAPSHOT/geronimo-izpack.xml:23:
 Resource
 not found: 
 d:\projs\geronimo\assemblies\j2ee-installer\target\geronimo-1.0-SNAPSHOT\RELEASE-NOTES-1.0-M5.txt
 [java] com.izforge.izpack.compiler.CompilerException:
 d:\projs\geronimo\assemblies\j2ee-installer/target/geronimo-1.
 0-SNAPSHOT/geronimo-izpack.xml:23: Resource not found:
 d:\projs\geronimo\assemblies\j2ee-installer\target\geronimo-1.0-S
 NAPSHOT\RELEASE-NOTES-1.0-M5.txt
 [java]  at
 com.izforge.izpack.compiler.CompilerConfig.parseError(CompilerConfig.java:1518)
 [java]  at
 com.izforge.izpack.compiler.CompilerConfig.findProjectResource(CompilerConfig.java:1447)
 [java]  at
 com.izforge.izpack.compiler.CompilerConfig.addResources(CompilerConfig.java:1044)
 [java]  at
 com.izforge.izpack.compiler.CompilerConfig.executeCompiler(CompilerConfig.java:313)
 [java]  at
 com.izforge.izpack.compiler.CompilerConfig.main(CompilerConfig.java:1847)
 [java]  at 
 com.izforge.izpack.compiler.Compiler.main(Compiler.java:620)
 [java]
 [java] (tip : use -? to get the commmand line parameters)
 [java] [ERROR] Java Result: 1

 BUILD FAILED

 Jacek

Re: Fatal error while building j2ee-installer (izpack)

2005-12-27 Thread Sachin Patel 

Try...

Index: plugins/geronimo-izpack-plugin/plugin.properties
===
--- plugins/geronimo-izpack-plugin/plugin.properties(revision 358629)
+++ plugins/geronimo-izpack-plugin/plugin.properties(working copy)
@@ -27,4 +27,5 @@
geronimo.assembly.zip=true
geronimo.assembly.distributions.dir=${maven.build.dir}/distributions
+release_notes_version=
Index: plugins/geronimo-izpack-plugin/plugin.jelly
===
--- plugins/geronimo-izpack-plugin/plugin.jelly (revision 358629)
+++ plugins/geronimo-izpack-plugin/plugin.jelly (working copy)
@@ -43,7 +43,7 @@
 /fileScanner
 j:set var=GeronimoVersion value=${geronimo_version}/
 j:set var=InstallSource value=${geronimo.assembly.dest}/
-j:set var=ReleaseNotesVersion value=1.0-M5/
+j:set var=ReleaseNotesVersion value=$ 
{release_notes_version}/

 j:forEach var=installer items=${installFiles.iterator()}
 j:set var=installerName value=${installer.name}/
 echoProcessing installer file ${installerName}/echo
Index: etc/project.properties
===
--- etc/project.properties  (revision 358629)
+++ etc/project.properties  (working copy)
@@ -86,6 +86,8 @@
tranql_connector_version=1.1
tranql_vendors_version=1.1
+release_notes_version=1.0
+
geronimo_packaging_plugin_version=1.0.1
geronimo_assembly_plugin_version=1.0.2
geronimo_deployment_plugin_version=1.0.0


- sachin



On Dec 27, 2005, at 4:10 PM, Aaron Mulder wrote:


It is not only you.  When I looked, it appeared that the variable for
the release notes file is hardcoded in the plugin Jelly.  I think it
needs to be changed to read that from a value passed when the plugin
is invoked, which can then be read from etc/project.properties.
Someone had a tip on how they thought this could be done.

In the mean time, if you want to use the installer, you can hardcode
the value in the XML file in src/izpack instead of using the variable
at all...  But I think there are pending patches for the installer
script that John Sisson was looking at.  And I think David B removed
the installer from the top-level Maven build until this is fixed.

Thanks,
Aaron

On 12/27/05, Jacek Laskowski [EMAIL PROTECTED] wrote:

Hi,

Is it only me who experiences the following error? It seems that the
solution might be as simple as editing the geronimo-izpack.xml and
change the referenced file name, but don't know whether or not it
doesn't incur any other troubles along the way.
...
[java] - Fatal error :
[java]d:\projs\geronimo\assemblies\j2ee-installer/target/ 
geronimo-1.0-SNAPSHOT/geronimo-izpack.xml:23:

Resource
not found: d:\projs\geronimo\assemblies\j2ee-installer\target 
\geronimo-1.0-SNAPSHOT\RELEASE-NOTES-1.0-M5.txt

[java] com.izforge.izpack.compiler.CompilerException:
d:\projs\geronimo\assemblies\j2ee-installer/target/geronimo-1.
0-SNAPSHOT/geronimo-izpack.xml:23: Resource not found:
d:\projs\geronimo\assemblies\j2ee-installer\target\geronimo-1.0-S
NAPSHOT\RELEASE-NOTES-1.0-M5.txt
[java]  at
com.izforge.izpack.compiler.CompilerConfig.parseError 
(CompilerConfig.java:1518)

[java]  at
com.izforge.izpack.compiler.CompilerConfig.findProjectResource 
(CompilerConfig.java:1447)

[java]  at
com.izforge.izpack.compiler.CompilerConfig.addResources 
(CompilerConfig.java:1044)

[java]  at
com.izforge.izpack.compiler.CompilerConfig.executeCompiler 
(CompilerConfig.java:313)

[java]  at
com.izforge.izpack.compiler.CompilerConfig.main 
(CompilerConfig.java:1847)
[java]  at com.izforge.izpack.compiler.Compiler.main 
(Compiler.java:620)

[java]
[java] (tip : use -? to get the commmand line parameters)
[java] [ERROR] Java Result: 1

BUILD FAILED

Jacek

Unrecognized argument: --quiet during openejb integration tests

2005-12-27 Thread Ken Perl 
+
| Executing default OpenEJB :: Integration Tests
| Memory: 26M/43M
+
DEPRECATED: the default goal should be specified in the build
section of project.xml instead of maven.xml
DEPRECATED: the default goal should be specified in the build
section of project.xml instead of maven.xml

build:end:

Attempting to download openejb-builder-2.0-SNAPSHOT.jar.
Attempting to download geronimo-deployment-plugin-1.0-SNAPSHOT.jar.
Attempting to download geronimo-1.0-SNAPSHOT.zip.
DEPRECATED: the default goal should be specified in the build
section of project.xml instead of maven.xml
DEPRECATED: the default goal should be specified in the build
section of project.xml instead of maven.xml
build:start:
ejb:init:
java:prepare-filesystem:

java:compile:
depend closure=false srcdir=1.4 dump=false
destdir=/root/geronimo1.0/openejb/modules/itests/target/classes/depend
   [echo] Compiling to
/root/geronimo1.0/openejb/modules/itests/target/classes

java:jar-resources:

test:prepare-filesystem:

test:test-resources:

test:compile:
[echo] No test source files to compile.

test:test:
[echo] NOTICE: Skipping tests; they seem to have passed already
[echo] No tests to run.
Running post goal: test:test


ejb:ejb:
ejb:ejb-jar-internal:
[echo] Building ejb openejb-itests-2.0-SNAPSHOT
[jar] Building jar:
/root/geronimo1.0/openejb/modules/itests/target/openejb-itests-2.0-SNAPSHOT.jar


ejb:install:
[echo] Installing...
Uploading to openejb/ejbs/openejb-itests-2.0-SNAPSHOT.jar:
 (163K)
Uploading to openejb/poms/openejb-itests-2.0-SNAPSHOT.pom:
 (9K)
Running post goal: ejb:install
java:prepare-filesystem:

java:compile:
depend closure=false srcdir=1.4 dump=false
destdir=/root/geronimo1.0/openejb/modules/itests/target/classes/depend
   [echo] Compiling to
/root/geronimo1.0/openejb/modules/itests/target/classes

java:jar-resources:

itest:prepare-filesystem:

itest:test-resources:

itest:compile:

itest:itest:
itest:setup:
[echo] Preprocessing security-plan.xml
[delete] Deleting directory
/root/geronimo1.0/openejb/modules/itests/target/geronimo-1.0-SNAPSHOT
[unzip] Expanding:
/root/.maven/repository/geronimo/distributions/geronimo-1.0-SNAPSHOT.zip
into /root/geronimo1.0/openejb/modules/itests/target
[copy] Copying 4 files to
/root/geronimo1.0/openejb/modules/itests/target/geronimo-1.0-SNAPSHOT/var
Preprocessing security/public_users.properties
Preprocessing security/black_groups.properties
Preprocessing security/public_groups.properties
Preprocessing security/black_users.properties
Preprocess plans elapse time: 0 sec

[copy] Copying 2 files to
/root/geronimo1.0/openejb/modules/itests/target/geronimo-1.0-SNAPSHOT/var/certstores
[echo] Waiting for server at:
Unrecognized argument: --quiet

Syntax: java -jar bin/server.jar [options]

Available options are:
  -quiet
 Suppress the normal startup progress bar.  This is typically
 used when redirecting console output to a file, or starting
 the server from an IDE or other tool.
  -v
 Reduces the console log level to INFO, resulting in more
 console output than is normally present.
  -vv
 Reduces the console log level to DEBUG, resulting in still
 more console output.

  -override [configId] [configId] ...
 USE WITH CAUTION!  Overrides the configurations in
 var/config/config.xml such that only the configurations listed on
 the command line will be started.  Note that many J2EE
 features depend on certain configs being started, so you
 should be very careful what you omit.  Any arguments after
 this are assumed to be configuration names.

In addition you may specify a replacement for var/config/config.xml
using by setting the property
-Dorg.apache.geronimo.config.file=var/config/my-config.xml
This is resolved relative to the geronimo base directory.

��
BUILD FAILED
File.. /root/.maven/cache/maven-multiproject-plugin-1.4.1/plugin.jelly
Element... maven:reactor
Line.. 218
Column -1
Unable to obtain goal [ejb:install] --
/root/geronimo1.0/openejb/modules/itests/maven.xml:110:-1:
deploy:waitForStarted Bad JMX URI
(deployer:geronimo:jmx:rmi://localhost/jndi/rmi:/JMXConnector)
Total time   : 51 minutes 28 seconds

I know if skip the test then the build may success, but I want to know
how to fix the issue by myself, could somebody give me a clue?


--
perl -e 'print unpack(u,62V5N\FME;G\!EFQ`9VUA:6PN8V]M\[EMAIL PROTECTED]
)'