Re: [VOTE] Release Apache Geronimo Metrics 3.0-M2

[Mark Struberg]

and mine as well

+1

LieGrue,
strub

> Am 13.04.2020 um 17:22 schrieb Romain Manni-Bucau :
> 
> Hi all,
> 
> Here is the vote for our Microprofile Metrics implementation.
> It brings our compliance to v3.0-M2 spec and also provides jars without jaxrs 
> part of the impl.
> 
> Tag: 
> https://gitbox.apache.org/repos/asf?p=geronimo-metrics.git;a=commit;h=b870aff24346cde82415d808138239d8283f2fd7
>  
> 
> Dist area: https://dist.apache.org/repos/dist/dev/geronimo/metrics/ 
> 
> Staging repo: 
> https://repository.apache.org/content/repositories/orgapachegeronimo-1122 
> 
> 
> Please vote:
> 
> [ ]+1
> [ ] -1 ${cause}
> 
> Vote will be opened as usual for 3 days or until we get enough binding votes.
> 
> Romain Manni-Bucau
> @rmannibucau  |  Blog 
>  | Old Blog 
>  | Github  
> | LinkedIn  | Book 
> 

Re: potential enhancement for our microprofile fault tolerance impl

[Francois Papon]

Hi Romain,

I can try to take a look and push a PR :)

regards,

François
fpa...@apache.org

Le 22/04/2020 à 15:48, Romain Manni-Bucau a écrit :
> Hi everyone,
>
> I'm not a big user of Microprofile fault tolerance (without entering
> into the details cause it is not the goal but I'm putting the features
> elsewhere in the app), but I realized implementing a custom circuit
> breaker with more or less the same kind of configuration than MP one
> that we can optimize our circuit breaker implementation. Long story
> short the spec requires to have a rolling window which is basically an
> array of boolean representing successes and failures.
> However, our current impl uses an array of boolean, which means for a
> window of 1024 we'll have 1024 boolean.
>
> Using a BitSet we can make it pass to 16 longs instead of 1024
> booleans which is quite different.
> Implementation change is not that complicated, it will just require to
> handle an "int count" next to the BitSet to replace the array.length
> usage and bitSet.cardinality() will give us the number of "true" (so
> false are 1-that).
> With that we can reduce a lot the memory usage of our circuit breaker.
>
> If anyone wants to have a go, feel free to open a PR.
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github
>  | LinkedIn
>  | Book
> 

potential enhancement for our microprofile fault tolerance impl

[Romain Manni-Bucau]

Hi everyone,

I'm not a big user of Microprofile fault tolerance (without entering into
the details cause it is not the goal but I'm putting the features elsewhere
in the app), but I realized implementing a custom circuit breaker with more
or less the same kind of configuration than MP one that we can optimize our
circuit breaker implementation. Long story short the spec requires to have
a rolling window which is basically an array of boolean representing
successes and failures.
However, our current impl uses an array of boolean, which means for a
window of 1024 we'll have 1024 boolean.

Using a BitSet we can make it pass to 16 longs instead of 1024 booleans
which is quite different.
Implementation change is not that complicated, it will just require to
handle an "int count" next to the BitSet to replace the array.length usage
and bitSet.cardinality() will give us the number of "true" (so false are
1-that).
With that we can reduce a lot the memory usage of our circuit breaker.

If anyone wants to have a go, feel free to open a PR.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book