[jira] [Resolved] (GERONIMO-6847) Switch Language Level to 11 in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis Monteiro resolved GERONIMO-6847. --- Fix Version/s: TxManager-4.0.0 Resolution: Fixed Thanks [~rzo1] > Switch Language Level to 11 in TX Manager > - > > Key: GERONIMO-6847 > URL: https://issues.apache.org/jira/browse/GERONIMO-6847 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > Fix For: TxManager-4.0.0 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (GERONIMO-6844) Jakarta Version of Geronimo TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis Monteiro resolved GERONIMO-6844. --- Fix Version/s: TxManager-4.0.0 Resolution: Fixed Thanks [~rzo1] > Jakarta Version of Geronimo TX Manager > -- > > Key: GERONIMO-6844 > URL: https://issues.apache.org/jira/browse/GERONIMO-6844 > Project: Geronimo > Issue Type: New Feature > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > Fix For: TxManager-4.0.0 > > > We should provide related standalone artifacts without the need to shade. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (GERONIMO-6846) Replace Dependency Towards SLF4J with JUL in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis Monteiro resolved GERONIMO-6846. --- Fix Version/s: TxManager-4.0.0 Resolution: Fixed Thanks [~rzo1] > Replace Dependency Towards SLF4J with JUL in TX Manager > --- > > Key: GERONIMO-6846 > URL: https://issues.apache.org/jira/browse/GERONIMO-6846 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > Fix For: TxManager-4.0.0 > > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] jeanouii merged pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
jeanouii merged PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GERONIMO-6846) Replace Dependency Towards SLF4J with JUL in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675584#comment-17675584 ] Richard Zowalla commented on GERONIMO-6846: --- Related to https://github.com/apache/geronimo-txmanager/pull/8 > Replace Dependency Towards SLF4J with JUL in TX Manager > --- > > Key: GERONIMO-6846 > URL: https://issues.apache.org/jira/browse/GERONIMO-6846 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GERONIMO-6847) Switch Language Level to 11 in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17675583#comment-17675583 ] Richard Zowalla commented on GERONIMO-6847: --- Related to https://github.com/apache/geronimo-txmanager/pull/8 > Switch Language Level to 11 in TX Manager > - > > Key: GERONIMO-6847 > URL: https://issues.apache.org/jira/browse/GERONIMO-6847 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GERONIMO-6846) Replace Dependency Towards SLF4J with JUL in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla updated GERONIMO-6846: -- Summary: Replace Dependency Towards SLF4J with JUL in TX Manager (was: Replace Dependency Towards SLF4J iwith JUL in TX Manager) > Replace Dependency Towards SLF4J with JUL in TX Manager > --- > > Key: GERONIMO-6846 > URL: https://issues.apache.org/jira/browse/GERONIMO-6846 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1067025406
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ${{ matrix.os }}
+continue-on-error: ${{ matrix.experimental }}
+strategy:
+ matrix:
+os: [ubuntu-latest]
+java: [ 11 ]
Review Comment:
https://issues.apache.org/jira/browse/GERONIMO-6847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (GERONIMO-6846) Replace Dependency Towards SLF4J iwith JUL in TX Manager
[ https://issues.apache.org/jira/browse/GERONIMO-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla updated GERONIMO-6846: -- Summary: Replace Dependency Towards SLF4J iwith JUL in TX Manager (was: Remove Dependency Towards SLF4J in TX Manager) > Replace Dependency Towards SLF4J iwith JUL in TX Manager > > > Key: GERONIMO-6846 > URL: https://issues.apache.org/jira/browse/GERONIMO-6846 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) > Components: transaction manager >Reporter: Richard Zowalla >Priority: Major > > as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (GERONIMO-6847) Switch Language Level to 11 in TX Manager
Richard Zowalla created GERONIMO-6847: - Summary: Switch Language Level to 11 in TX Manager Key: GERONIMO-6847 URL: https://issues.apache.org/jira/browse/GERONIMO-6847 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Components: transaction manager Reporter: Richard Zowalla as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (GERONIMO-6846) Remove Dependency Towards SLF4J in TX Manager
Richard Zowalla created GERONIMO-6846: - Summary: Remove Dependency Towards SLF4J in TX Manager Key: GERONIMO-6846 URL: https://issues.apache.org/jira/browse/GERONIMO-6846 Project: Geronimo Issue Type: Task Security Level: public (Regular issues) Components: transaction manager Reporter: Richard Zowalla as the title says -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] jeanouii commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
jeanouii commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066964549
##
geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java:
##
@@ -24,21 +24,20 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.logging.Level;
+import java.util.logging.Logger;
-import javax.resource.ResourceException;
-import javax.resource.spi.ConnectionRequestInfo;
-import javax.resource.spi.ManagedConnection;
-import javax.resource.spi.ManagedConnectionFactory;
+import jakarta.resource.ResourceException;
+import jakarta.resource.spi.ConnectionRequestInfo;
+import jakarta.resource.spi.ManagedConnection;
+import jakarta.resource.spi.ManagedConnectionFactory;
import javax.security.auth.Subject;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
/**
* @version $Rev$ $Date$
*/
public abstract class AbstractSinglePoolConnectionInterceptor implements
ConnectionInterceptor, PoolingAttributes {
-protected static Logger log =
LoggerFactory.getLogger(AbstractSinglePoolConnectionInterceptor.class);
+protected static Logger log =
Logger.getLogger(AbstractSinglePoolConnectionInterceptor.class.getName());
Review Comment:
I'd also make a small ticket for this component to have the logger switch to
JUL
##
pom.xml:
##
@@ -113,102 +95,70 @@
junit
junit
-3.8.2
+4.13.2
test
-
-
-java8-doclint-disabled
-
-[1.8,)
-
-
-
--Xdoclint:none
--Xdoclint:none
-
-
-
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+11
Review Comment:
I'd use the new release attribute
##
pom.xml:
##
@@ -113,102 +95,70 @@
junit
junit
-3.8.2
+4.13.2
test
-
-
-java8-doclint-disabled
-
-[1.8,)
-
-
-
--Xdoclint:none
--Xdoclint:none
-
-
-
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+11
+11
+
+
org.apache.maven.plugins
maven-javadoc-plugin
-2.9
attach-javadocs
jar
-
${javadoc.opts}
+true
+11
Review Comment:
I think there is a release attribute as well
##
geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java:
##
@@ -24,21 +24,20 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.logging.Level;
+import java.util.logging.Logger;
-import javax.resource.ResourceException;
-import javax.resource.spi.ConnectionRequestInfo;
-import javax.resource.spi.ManagedConnection;
-import javax.resource.spi.ManagedConnectionFactory;
+import jakarta.resource.ResourceException;
+import jakarta.resource.spi.ConnectionRequestInfo;
+import jakarta.resource.spi.ManagedConnection;
+import jakarta.resource.spi.ManagedConnectionFactory;
import javax.security.auth.Subject;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
/**
* @version $Rev$ $Date$
*/
public abstract class AbstractSinglePoolConnectionInterceptor implements
ConnectionInterceptor, PoolingAttributes {
-protected static Logger log =
LoggerFactory.getLogger(AbstractSinglePoolConnectionInterceptor.class);
+protected static Logger log =
Logger.getLogger(AbstractSinglePoolConnectionInterceptor.class.getName());
Review Comment:
Haven't seen SLF4J dependency removed. Maybe we were using a transitive
dependency as compile
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright
[GitHub] [geronimo-txmanager] jeanouii commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
jeanouii commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378710169 Looks good to me. I'll merge it for you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378651316 Ok did the switch to Apache Parent v29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (GERONIMO-6845) Provide Genesis Flava for Java 11
[ https://issues.apache.org/jira/browse/GERONIMO-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis Monteiro resolved GERONIMO-6845. --- Resolution: Won't Fix We don't need that parent pom anymore. Let's start using the regular Apache parent pom. > Provide Genesis Flava for Java 11 > - > > Key: GERONIMO-6845 > URL: https://issues.apache.org/jira/browse/GERONIMO-6845 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) >Reporter: Richard Zowalla >Priority: Major > Attachments: GERONIMO-6845.patch > > > as the title says. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066727262 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT org.apache.geronimo.components geronimo-connector -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378394073 > As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to merge the change. I am fine with either using the java11 flava thing or apache-parent directly. Whatever the project wants to use. Yup - there is an ongoing discussion on the list regarding the spec jars, if I remember correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066697045 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT org.apache.geronimo.components geronimo-connector -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT Review Comment: I am fine to migrate the slf4j dep to jul. ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT org.apache.geronimo.components geronimo-connector -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT Review Comment: I am fine to migrate slf4j to jul. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GERONIMO-6845) Provide Genesis Flava for Java 11
[ https://issues.apache.org/jira/browse/GERONIMO-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17669030#comment-17669030 ] Richard Zowalla commented on GERONIMO-6845: --- Yup - I am also open to just use `apache-parent` (for the specific use-case). Whatever the project decides :) > Provide Genesis Flava for Java 11 > - > > Key: GERONIMO-6845 > URL: https://issues.apache.org/jira/browse/GERONIMO-6845 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) >Reporter: Richard Zowalla >Priority: Major > Attachments: GERONIMO-6845.patch > > > as the title says. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] rmannibucau commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rmannibucau commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378384552 As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to merge the change. Except the slf4j and this "move task" +1 from me once they are both done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rmannibucau commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066690285 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT org.apache.geronimo.components geronimo-connector -3.1.6-SNAPSHOT +4.0.0-SNAPSHOT Review Comment: think the new major is the opportunity to ditch this required dep and migrate to jul for consistency with the other stacks and new API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (GERONIMO-6845) Provide Genesis Flava for Java 11
[ https://issues.apache.org/jira/browse/GERONIMO-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17667736#comment-17667736 ] Romain Manni-Bucau commented on GERONIMO-6845: -- +1 to not do it and just use apache parent pom, genesis is way outdated and overkill, we should have dropped it years ago > Provide Genesis Flava for Java 11 > - > > Key: GERONIMO-6845 > URL: https://issues.apache.org/jira/browse/GERONIMO-6845 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) >Reporter: Richard Zowalla >Priority: Major > Attachments: GERONIMO-6845.patch > > > as the title says. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378367735 Genesis Parent: https://issues.apache.org/jira/browse/GERONIMO-6845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (GERONIMO-6845) Provide Genesis Flava for Java 11
[ https://issues.apache.org/jira/browse/GERONIMO-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Zowalla updated GERONIMO-6845: -- Attachment: GERONIMO-6845.patch > Provide Genesis Flava for Java 11 > - > > Key: GERONIMO-6845 > URL: https://issues.apache.org/jira/browse/GERONIMO-6845 > Project: Geronimo > Issue Type: Task > Security Level: public(Regular issues) >Reporter: Richard Zowalla >Priority: Major > Attachments: GERONIMO-6845.patch > > > as the title says. -- This message was sent by Atlassian Jira (v8.20.10#820010)
