[jira] Closed: (GERONIMODEVTOOLS-541) move all Abbot testcases to run during a single server install/uninstall

2009-01-22 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-541.
--

   Resolution: Fixed
Fix Version/s: 2.2.0
 Assignee: B.J. Reed  (was: Tim McConnell)

Fixed with r736695 in trunk.  Use Eclipse Extension Points and Extensions for 
each new test case.  The EclipseUITest is now the driver for the testsuite. It 
does a quick sanity check to verify the Geronimo installation, starts the 
server, and then calls each Test Case Extension to build, run, and clean the 
test.  After all are finished, it uninstalls the server.

> move all Abbot testcases to run during a single server install/uninstall
> 
>
> Key: GERONIMODEVTOOLS-541
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-541
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0
>
>
> For each Abbot test case, each test case creates a new server, starts the 
> server, stops the server, and then removes the server.  This is very time 
> consuming for the test cases to run and ends up testing much of the same code 
> over and over again.
> It would be better to change the test suite to really only have one test (for 
> each server version) with everything else done while the server is running.  
> So the algorithm should be:
> check valid GEP installation
> create server
> start server
> test A
> test A cleanup
> test B
> test B cleanup
> .
> stop server
> remove server

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-558) Testsuite not able to find DefaultSelenium class

2009-01-22 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-558.
--

Resolution: Cannot Reproduce

Not sure what had happened, but for a few days I couldn't get Selenium to work 
from my Eclipse installation.  It always worked fine on another machine and for 
Tim.  Yesterday it began working again and I haven't had any more problems.  
Closing this as I think it was just a gremlin in my computer that was stopping 
it.

> Testsuite not able to find DefaultSelenium class
> 
>
> Key: GERONIMODEVTOOLS-558
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-558
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: Tim McConnell
>Priority: Blocker
> Fix For: 2.2.0, 2.1.4
>
>
> Running the testsuite from Eclipse, I get a java.lang.NoClassDefFoundError: 
> com/thoughtworks/selenium/DefaultSelenium
>   at java.lang.ClassLoader.defineClass1(Native Method)
>   at java.lang.ClassLoader.defineClass(Unknown Source)
>   at 
> org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.defineClass(DefaultClassLoader.java:165)
>   at 
> org.eclipse.osgi.baseadaptor.loader.ClasspathManager.defineClass(ClasspathManager.java:554)
>   at 
> org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassImpl(ClasspathManager.java:524)
>   at 
> org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClassImpl(ClasspathManager.java:455)
>   at 
> org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass_LockClassLoader(ClasspathManager.java:443)
>   at 
> org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:423)
>   at 
> org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:193)
>   at 
> org.eclipse.osgi.framework.internal.core.BundleLoader.findLocalClass(BundleLoader.java:368)
>   at 
> org.eclipse.osgi.framework.internal.core.SingleSourcePackage.loadClass(SingleSourcePackage.java:33)
>   at 
> org.eclipse.osgi.framework.internal.core.BundleLoader.findClassInternal(BundleLoader.java:441)
>   at 
> org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:397)
>   at 
> org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:385)
>   at 
> org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:87)
>   at java.lang.ClassLoader.loadClass(Unknown Source)
>   at java.lang.ClassLoader.loadClassInternal(Unknown Source)
>   at 
> org.apache.geronimo.testsuite.v22.ui.EclipseUITest.installServer(EclipseUITest.java:110)
>   at 
> org.apache.geronimo.testsuite.v22.ui.EclipseUITest.testEclipseUI(EclipseUITest.java:58)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at junit.framework.TestCase.runTest(TestCase.java:164)
>   at junit.framework.TestCase.runBare(TestCase.java:130)
>   at 
> abbot.swt.junit.extensions.SWTTestCase.runBareWrapper(SWTTestCase.java:279)
>   at abbot.swt.junit.extensions.SWTTestCase.access$2(SWTTestCase.java:276)
>   at 
> abbot.swt.junit.extensions.SWTTestCase$4.execute(SWTTestCase.java:253)
>   at abbot.swt.junit.extensions.UserThread.run(UserThread.java:75)
> Testsuite runs fine when run from maven.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-558) Testsuite not able to find DefaultSelenium class

2009-01-16 Thread B.J. Reed (JIRA)
Testsuite not able to find DefaultSelenium class


 Key: GERONIMODEVTOOLS-558
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-558
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: Tim McConnell
Priority: Blocker
 Fix For: 2.2.0, 2.1.4


Running the testsuite from Eclipse, I get a java.lang.NoClassDefFoundError: 
com/thoughtworks/selenium/DefaultSelenium
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(Unknown Source)
at 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.defineClass(DefaultClassLoader.java:165)
at 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.defineClass(ClasspathManager.java:554)
at 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findClassImpl(ClasspathManager.java:524)
at 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClassImpl(ClasspathManager.java:455)
at 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass_LockClassLoader(ClasspathManager.java:443)
at 
org.eclipse.osgi.baseadaptor.loader.ClasspathManager.findLocalClass(ClasspathManager.java:423)
at 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.findLocalClass(DefaultClassLoader.java:193)
at 
org.eclipse.osgi.framework.internal.core.BundleLoader.findLocalClass(BundleLoader.java:368)
at 
org.eclipse.osgi.framework.internal.core.SingleSourcePackage.loadClass(SingleSourcePackage.java:33)
at 
org.eclipse.osgi.framework.internal.core.BundleLoader.findClassInternal(BundleLoader.java:441)
at 
org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:397)
at 
org.eclipse.osgi.framework.internal.core.BundleLoader.findClass(BundleLoader.java:385)
at 
org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:87)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClassInternal(Unknown Source)
at 
org.apache.geronimo.testsuite.v22.ui.EclipseUITest.installServer(EclipseUITest.java:110)
at 
org.apache.geronimo.testsuite.v22.ui.EclipseUITest.testEclipseUI(EclipseUITest.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at 
abbot.swt.junit.extensions.SWTTestCase.runBareWrapper(SWTTestCase.java:279)
at abbot.swt.junit.extensions.SWTTestCase.access$2(SWTTestCase.java:276)
at 
abbot.swt.junit.extensions.SWTTestCase$4.execute(SWTTestCase.java:253)
at abbot.swt.junit.extensions.UserThread.run(UserThread.java:75)

Testsuite runs fine when run from maven.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-556) Applications List Refresh during create geronimo plugin in GEP

2009-01-15 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-556.


   Resolution: Fixed
Fix Version/s: 2.1.4
   2.2.0
 Assignee: B.J. Reed  (was: Tim McConnell)

Excellent test case.  Since the dialog is modal, I hadn't thought about adding 
applications from outside GEP  to the server while the dialog is open.  r734751 
has an update that will refresh the list when the page is brought up via the 
"next" button.  In this case, if the user is on the page when the server is 
updated, then they only have to click "previous" and "next" to get the updated 
list rather than close the whole dialog.

> Applications List Refresh during create geronimo plugin in GEP
> --
>
> Key: GERONIMODEVTOOLS-556
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-556
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: viola.lu
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
>
> 1.Install GEP snapshot,start G2.2snapshot in it.
> 2.Lanuch "Convert apps to plugins "Window, deploy a sample cviewer to server, 
> choose local plugin repository folder, and dropdown applications list, newly 
> deployed application cviewer doesn't exist in it, you should close window and 
> relauch it to refresh applications list to select one.
> So if you deploy apps after launch "Convert apps to plugins "Window, you 
> should restart this window to refresh apps list.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-555) Generated geronimo-plugin.xml file is empy after converting application to plugin

2009-01-15 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664152#action_12664152
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-555:


I'm not able to reproduce this error with my test cases.  Can you check to see 
if the geronimo-plugin.xml is also empty in the server repository before you 
try to convert it?  If it isn't empty, can you attach the application to this 
JIRA?  Thanks,

> Generated  geronimo-plugin.xml file is empy after converting application to 
> plugin
> --
>
> Key: GERONIMODEVTOOLS-555
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-555
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
> Environment: SunJDk 1.5, 1.6
>Reporter: viola.lu
>Assignee: Tim McConnell
>
> 1.Install GEP 2.2 snapshot on eclispe, start G2.2snapshot in it.
> 2.Open defined server, and launch convert apps to plugins 
> 3.Choose deployed app cviewer and conver it to plugin, successfully saved 
> ,but check geronimo-plugin.xml, it's empty.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-450) Modifications to JAXB classes for DWR in PlanCreator

2009-01-13 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663353#action_12663353
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-450:


I've looked at this patch and I have to put a -1 on it.

According to the comments in the code and from what I've seen, the getXXX 
methods for Lists of Object are "accessor method returns a reference to the 
live list, not a snapshot. Therefore any modification you make to the returned 
list will be present inside the JAXB object.  This is why there is not a 
set method for the property."

This patch just adds set methods which aren't needed and could be potentially 
dangerous since a set would replace any data that may already be present in a 
List of objects.

I will leave the JIRA open for a while to allow for any discussion to challenge 
the original thinking.

> Modifications to JAXB classes for DWR in PlanCreator
> 
>
> Key: GERONIMODEVTOOLS-450
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-450
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Shrey Banga
>Assignee: Shiva Kumar H R
> Fix For: 2.2.0
>
> Attachments: GEP_JAXB_1.patch
>
>
> I've attached a patch which makes some modifications to JAXB classes in GEP 
> in order to support their use with DWR in PlanCreator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-553) add list of plugins to the Geronimo Server Plugin Page

2009-01-12 Thread B.J. Reed (JIRA)
add list of plugins to the Geronimo Server Plugin Page
--

 Key: GERONIMODEVTOOLS-553
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-553
 Project: Geronimo-Devtools
  Issue Type: New Feature
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Minor
 Fix For: 2.2.0, 2.1.4


On the Geronimo Server Plugin Page (double click on the Geronimo Server), it 
would be nice to have the list of plugins that are installed on the server.  
This list would need to be updated if plugins are added/removed.  Would 
probably also be nice to have an Edit button (but no Add or Delete) so that the 
plugin info could be updated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-544) add wizard for converting applications into Geronimo plugins

2009-01-12 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-544.
--

Resolution: Fixed

All subtasks have been completed.

> add wizard for converting applications into Geronimo plugins
> 
>
> Key: GERONIMODEVTOOLS-544
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-544
> Project: Geronimo-Devtools
>  Issue Type: New Feature
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
>
> Task list for converting application into Geronimo plugins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-548) combine Custom Server Assembly and the Plugin Server Manager into one wizard.

2009-01-12 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-548.


Resolution: Fixed

Fixed with r733867.  Not really logical to combine the 2 wizards.

Created a Plugin page for the server (double click the Geronimo server to bring 
it up).  There are now 2 buttons on here to bring up the wizards.  This seems 
to make more sense since these are not every day actions, but are still easy to 
find when the user wants to perform these tasks.

> combine Custom Server Assembly and the Plugin Server Manager into one wizard.
> -
>
> Key: GERONIMODEVTOOLS-548
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-548
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
>
> Custom Server Assembly and the Plugin Server Manager should probably be just 
> one wizard (and one server popup menu item).  Seems to me that one is adding 
> to the server and one is subtracting from the server so it seems that they 
> could be combined somehow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager

2009-01-09 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-547.
--

Resolution: Fixed

Fixed in r733105 in 2.1.4 and r733106 in trunk.  Thanks to Delos Dai for the 
patch, the code within GeronimoServerPluginManager.java has been greatly 
reduced and org.apache.geronimo.system.plugin.PluginInstaller is now being 
used..

I couldn't reproduce the exception you were getting.  When I tried to match up 
the exception output with the code, it didn't match, so it may be that 
something funny was going on.  Maybe try a fresh trunk build and see if you 
still have the problem.  If so, open a new JIRA for it.  Thanks again.

> code cleanup on Server Plugin Manager
> -
>
> Key: GERONIMODEVTOOLS-547
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 547.patch, 547_updated.patch, 547_updated2.patch, 
> exception.TXT
>
>
> From the initial version of the Server Plugin Manager, there are several 
> things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels 
> (org.apache.geronimo.jee.plugin).  When I tried to use the .jar file, I kept 
> get exceptions that ObjectFactory could not be found.  As it is now, the 
> org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the 
> geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This 
> will cut down on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other 
> calls to the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-4303) Document new 2.2 Plugin features - plugingroups, pluginGroup attribute and no classloader option

2009-01-07 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661691#action_12661691
 ] 

B.J. Reed commented on GERONIMO-4303:
-

I've reviewed the 3rd link and it looks pretty good to me.  My only suggestion 
is that maybe have all the above pages reference another page that explains 
plugin groups (and maybe even what plugins are currently in each group, but 
that may be a bit much to maintain as things change).

> Document new 2.2 Plugin features - plugingroups, pluginGroup attribute and no 
> classloader option
> 
>
> Key: GERONIMO-4303
> URL: https://issues.apache.org/jira/browse/GERONIMO-4303
> Project: Geronimo
>  Issue Type: Improvement
>  Security Level: public(Regular issues) 
>  Components: documentation
>Affects Versions: 2.2
>Reporter: Donald Woods
>Assignee: Lin Sun
> Fix For: 2.2
>
>
> Need to make sure this new pluginGroup attribute and no plan behavior gets 
> added to the 2.2 Docs.  We should also document what pluginprofiles we will 
> be providing in 2.2 (along with adding some info to the GMOxDEV wiki, as we 
> want these to be portable between releases) and what each one provides.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager

2009-01-07 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661679#action_12661679
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-547:


Sorry Delos, but I'm still not getting a pluginInstaller from the following 
line:
  pluginInstaller = 
kernel.getGBean(PluginInstallerGBean.class);
If I change the serverChanged method to catch a Throwable instead of an 
Exception, I still get the above error.

The PluginManager does come up (Custom Server Assembly does not), but after 
going through a few pages of it, I get a null pointer caused by pluginInstaller 
being null.  Did you have to update the manifest.mf or plugin.xml to get it to 
work?

> code cleanup on Server Plugin Manager
> -
>
> Key: GERONIMODEVTOOLS-547
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 547.patch, 547_updated.patch
>
>
> From the initial version of the Server Plugin Manager, there are several 
> things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels 
> (org.apache.geronimo.jee.plugin).  When I tried to use the .jar file, I kept 
> get exceptions that ObjectFactory could not be found.  As it is now, the 
> org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the 
> geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This 
> will cut down on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other 
> calls to the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-532) Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)

2009-01-07 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-532.


Resolution: Fixed

fixed with r732383.  Thanks Delos Dai for the patch.  Unfortunately, we had to 
go with option 1 to fix this.  Your patch created a second Server Overview page 
and we couldn't find a way to get rid of the first page.

There were a few things I noticed in the files you created.  Try not to use 
tabs, use 4 spaces instead.  Copy the license header from another file to put 
at the top of any new file.  Also put the following in a comment so that 
versions will be kept track of:
@version $Rev$ $Date$

Thanks again.

> Surface the publish timeout time in the server properties tab like all the 
> other publishing attributes (e.g., publishing interval)
> --
>
> Key: GERONIMODEVTOOLS-532
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: Tim McConnell
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (GERONIMODEVTOOLS-532) Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)

2009-01-07 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed reassigned GERONIMODEVTOOLS-532:
--

Assignee: B.J. Reed  (was: Tim McConnell)

> Surface the publish timeout time in the server properties tab like all the 
> other publishing attributes (e.g., publishing interval)
> --
>
> Key: GERONIMODEVTOOLS-532
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: Tim McConnell
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-542) Ensure all testcases run under Eclipse and Maven

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-542.
--

Resolution: Won't Fix

This really isn't a problem, it's just something to keep in mind as we write 
test cases.  For this reason, I'm just making it a comment in the main test 
suite task list.  If there is a test case that doesn't run under Eclipse or 
Maven, please open that separately.

> Ensure all testcases run under Eclipse and Maven
> 
>
> Key: GERONIMODEVTOOLS-542
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-542
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Tim McConnell
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-407) GEP Testsuite Tasklist

2009-01-06 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661192#action_12661192
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-407:


As test cases are written, please ensure that they run under both Eclipse and 
Maven.

> GEP Testsuite Tasklist
> --
>
> Key: GERONIMODEVTOOLS-407
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-407
> Project: Geronimo-Devtools
>  Issue Type: Task
>  Components: eclipse-plugin
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-538) Remote deployment testcase

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-538:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Remote deployment testcase
> --
>
> Key: GERONIMODEVTOOLS-538
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-538
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-487) Install GEP from staging site testcase

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-487:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Install GEP from staging site testcase
> --
>
> Key: GERONIMODEVTOOLS-487
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Fix For: 2.2.0
>
> Attachments: GERONIMODEVTOOLS-487.patch, screenshot.png
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-529) Investigate removing older versions of the GEP plugins/features from our Eclipse update site on Apache

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-529:
---

Component/s: eclipse-plugin

> Investigate removing older versions of the GEP plugins/features from our 
> Eclipse update site on Apache
> --
>
> Key: GERONIMODEVTOOLS-529
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-529
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0, 2.1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-344) Cannot utilize the xpp3-1.1.3.4.O jar in GEP

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-344:
---

Component/s: eclipse-plugin

> Cannot utilize the xpp3-1.1.3.4.O jar in GEP 
> -
>
> Key: GERONIMODEVTOOLS-344
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-344
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.0
>Reporter: Tim McConnell
>Assignee: B.J. Reed
> Fix For: 2.2.0
>
> Attachments: GERONIMODEVTOOLS-344.patch
>
>
> During the release of the GEP 2.1.0 we encountered problems with the 
> xpp3-1.1.3.4.O.jar file when trying to create a new dynamic web problem 
> (i.e., unhandled event condition). Need to investigate and understand why so 
> that we can use the same version of this artifact that the server is using. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-364) GEP should insure it's eclipse platform is at proper level

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-364:
---

Component/s: eclipse-plugin

> GEP should insure it's eclipse platform is at proper level
> --
>
> Key: GERONIMODEVTOOLS-364
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-364
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Ted Kirby
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Since GEP is very sensitive to the eclipse and especially WTP level it 
> runs/is installed on, it ought to prereq that level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-418) testsuite portion of build hands on mac

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-418:
---

Component/s: eclipse-plugin

> testsuite portion of build hands on mac
> ---
>
> Key: GERONIMODEVTOOLS-418
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-418
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
> Environment: Mac OS 10.5.4
>Reporter: Ted Kirby
>Assignee: B.J. Reed
> Fix For: 2.2.0
>
>
> in one instance, the build completed after 897 minutes!  In another, I used 
> Ctrl-C to cancel the build, and I got a successful build!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-509) Deployment plan editor testsuite

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-509.
--

Resolution: Duplicate

This is a duplicate of 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-490.

> Deployment plan editor testsuite
> 
>
> Key: GERONIMODEVTOOLS-509
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-509
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-490) Edit existing deployment plan testcase(s)

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-490:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Edit existing deployment plan testcase(s)
> -
>
> Key: GERONIMODEVTOOLS-490
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-490
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-486) Optionally run selenium in "slow" mode

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-486:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Optionally run selenium in "slow" mode
> --
>
> Key: GERONIMODEVTOOLS-486
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-486
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-509) Deployment plan editor testsuite

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-509:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Deployment plan editor testsuite
> 
>
> Key: GERONIMODEVTOOLS-509
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-509
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-495) Web Services testcase

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-495:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Web Services testcase
> -
>
> Key: GERONIMODEVTOOLS-495
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-495
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-491) Verify testsuite on linux platform

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-491:
---

  Component/s: eclipse-plugin
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Verify testsuite on linux platform
> --
>
> Key: GERONIMODEVTOOLS-491
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-491
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: B.J. Reed
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-447) Recording testcase using Abbot

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-447:
---

  Component/s: eclipse-plugin
  Description: Use Costello (part of Abbot) to record testcases in 
stead of writing Abbot java code.
Affects Version/s: 2.2.0
Fix Version/s: 2.2.0

> Recording testcase using Abbot
> --
>
> Key: GERONIMODEVTOOLS-447
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-447
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0
>Reporter: Tim McConnell
>Assignee: Tim McConnell
> Fix For: 2.2.0
>
>
> Use Costello (part of Abbot) to record testcases in stead of writing Abbot 
> java code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-229) IOException occurred while saving attributes error starting server in eclipse

2009-01-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-229.
--

   Resolution: Fixed
Fix Version/s: 2.0.x

This looks like a duplicate of 
http://issues.apache.org/jira/browse/GERONIMO-2095 which has been fixed.  
Please re-open if you still have the problem.

> IOException occurred while saving attributes error starting server in eclipse
> -
>
> Key: GERONIMODEVTOOLS-229
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-229
> Project: Geronimo-Devtools
>  Issue Type: Bug
>Affects Versions: 2.0.0, 2.0.2, 2.0.x
>Reporter: Ted Kirby
>Assignee: Tim McConnell
>Priority: Critical
> Fix For: 2.0.x
>
>
> I downloaded and installed a tomcat 2.0.1 server, and started it.  The server 
> started, but I got this error on the (conolse and disk) log, during startup 
> and after startup completed:
> 10:09:09,671 ERROR [LocalAttributeManager] IOException occurred while saving 
> attributes
> java.io.IOException: Unable to rename 
> C:\wagepi\geronimo-tomcat6-jee5-2.0.1\var\config\config.xml to 
> C:\wagepi\geronimo-tomcat6-jee5-2.0.1\var\config\config.xml.bak in order to 
> back up manageable attribute save file
>   at 
> org.apache.geronimo.system.configuration.LocalAttributeManager.save(LocalAttributeManager.java:394)
>   at 
> org.apache.geronimo.system.configuration.LocalAttributeManager$2.run(LocalAttributeManager.java:603)
>   at java.util.TimerThread.mainLoop(Timer.java:527)
>   at java.util.TimerThread.run(Timer.java:477)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager

2009-01-06 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661170#action_12661170
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-547:


Hi Delos, I applied your 547 patch to my latest GEP trunk and tried to use it 
with the 2.2 snapshot server.  To start with, I was getting a 
NullPointerException in the ServerPluginManager constructor because the server 
variable hadn't been set yet.  So I moved the bulk of the constructor to the 
serverChanged method.  Now I get the following stack trace:

java.lang.IllegalArgumentException: Cannot find matching method/constructor
at 
org.apache.geronimo.system.plugin.PluginInstallerGBean$$EnhancerByCGLIB$$8fe213ef$$FastClassByCGLIB$$df601166.newInstance()
at net.sf.cglib.reflect.FastClass.newInstance(FastClass.java:91)
at 
org.apache.geronimo.kernel.basic.BasicProxyManager$ManagedProxyFactory.createProxy(BasicProxyManager.java:213)
at 
org.apache.geronimo.kernel.basic.BasicProxyManager.createProxy(BasicProxyManager.java:103)
at 
org.apache.geronimo.system.jmx.KernelDelegate.getGBean(KernelDelegate.java:106)
at 
org.apache.geronimo.st.v21.core.operations.GeronimoServerPluginManager.serverChanged(GeronimoServerPluginManager.java:100)
at 
org.apache.geronimo.st.v21.ui.actions.LaunchGeronimoPluginManagerAction.selectionChanged(LaunchGeronimoPluginManagerAction.java:84)
at 
org.eclipse.ui.internal.PluginAction.refreshEnablement(PluginAction.java:206)
at 
org.eclipse.ui.internal.PluginAction.createDelegate(PluginAction.java:126)
at 
org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:223)
at 
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:583)
at 
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:500)
at 
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3823)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3422)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
at 
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
at 
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at 
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at 
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at 
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
at 
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
at org.eclipse.equinox.launcher.Main.main(Main.java:1212)

and the pluginInstaller variable remains null so it can't be used later (like 
in the getPluginMetadata method).  Can you take another look at this?

Thanks.

> code cleanup on Server Plugin Manager
> -
>
> Key: GERONIMODEVTOOLS-547
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 547.patch
>
>
> From the initial version of the Server Plugin Manager, there are several 
> things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels 
> (org.apache.geronimo.jee.plugin

[jira] Closed: (GERONIMODEVTOOLS-549) write documentation for the Plugin Server Manager

2009-01-05 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-549.
--

Resolution: Fixed

http://cwiki.apache.org/GMOxDOC22/converting-applications-into-geronimo-plugins-using-gep.html
  has been written for the wiki.

> write documentation for the Plugin Server Manager
> -
>
> Key: GERONIMODEVTOOLS-549
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-549
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Trivial
> Fix For: 2.2.0, 2.1.4
>
>
> Need to add documentation to the wiki for the new Server Plugin Manager.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-546) add summary page to Server Plugin Manager

2008-12-17 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-546.


Resolution: Fixed

Fixed with r727514.  Added another page to the wizard that has a table that 
lists the plugins that were removed or added to the server during the final 
installation process.

> add summary page to Server Plugin Manager
> -
>
> Key: GERONIMODEVTOOLS-546
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-546
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
>
> Would be nice to have a final page to show all the things that got added to 
> or removed from the server during the processing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager

2008-12-12 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656045#action_12656045
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-547:


Item #1 has been fixed with r726047 in trunk and r726056 in 2.1.4.
Thanks to Tim McConnell for figuring out what was missing in the manifest files 
to get this to work properly.

> code cleanup on Server Plugin Manager
> -
>
> Key: GERONIMODEVTOOLS-547
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
>
> From the initial version of the Server Plugin Manager, there are several 
> things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels 
> (org.apache.geronimo.jee.plugin).  When I tried to use the .jar file, I kept 
> get exceptions that ObjectFactory could not be found.  As it is now, the 
> org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the 
> geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This 
> will cut down on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other 
> calls to the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-545) initial version of the code

2008-12-05 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-545.


Resolution: Fixed

Initial version of the Server Plugin Manager is checked in.  trunk r723874 and  
2.1.4 r723875.

> initial version of the code
> ---
>
> Key: GERONIMODEVTOOLS-545
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-545
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
>
> Just a place holder for checking in all the original files that make this 
> work for simple test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-548) combine Custom Server Assembly and the Plugin Server Manager into one wizard.

2008-12-05 Thread B.J. Reed (JIRA)
combine Custom Server Assembly and the Plugin Server Manager into one wizard.
-

 Key: GERONIMODEVTOOLS-548
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-548
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Minor
 Fix For: 2.2.0, 2.1.4


Custom Server Assembly and the Plugin Server Manager should probably be just 
one wizard (and one server popup menu item).  Seems to me that one is adding to 
the server and one is subtracting from the server so it seems that they could 
be combined somehow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-549) write documentation for the Plugin Server Manager

2008-12-05 Thread B.J. Reed (JIRA)
write documentation for the Plugin Server Manager
-

 Key: GERONIMODEVTOOLS-549
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-549
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Trivial
 Fix For: 2.2.0, 2.1.4


Need to add documentation to the wiki for the new Server Plugin Manager.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager

2008-12-05 Thread B.J. Reed (JIRA)
code cleanup on Server Plugin Manager
-

 Key: GERONIMODEVTOOLS-547
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Minor
 Fix For: 2.2.0, 2.1.4


>From the initial version of the Server Plugin Manager, there are several 
>things that can be streamlined.

1. use geronimo-system.jar file instead of the jaxbmodels 
(org.apache.geronimo.jee.plugin).  When I tried to use the .jar file, I kept 
get exceptions that ObjectFactory could not be found.  As it is now, the 
org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the 
geronimo-system.jar file

2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This will 
cut down on a lot of methods that were duplicated into this class.

3. Other methods in GeronimoServerPluginManager.java can probably make other 
calls to the jar files that we already are bringing into the GEP.

All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-546) add summary page to Server Plugin Manager

2008-12-05 Thread B.J. Reed (JIRA)
add summary page to Server Plugin Manager
-

 Key: GERONIMODEVTOOLS-546
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-546
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Minor
 Fix For: 2.2.0, 2.1.4


Would be nice to have a final page to show all the things that got added to or 
removed from the server during the processing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-545) initial version of the code

2008-12-05 Thread B.J. Reed (JIRA)
initial version of the code
---

 Key: GERONIMODEVTOOLS-545
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-545
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
 Fix For: 2.2.0, 2.1.4


Just a place holder for checking in all the original files that make this work 
for simple test cases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-544) add wizard for converting applications into Geronimo plugins

2008-12-05 Thread B.J. Reed (JIRA)
add wizard for converting applications into Geronimo plugins


 Key: GERONIMODEVTOOLS-544
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-544
 Project: Geronimo-Devtools
  Issue Type: New Feature
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
 Fix For: 2.2.0, 2.1.4


Task list for converting application into Geronimo plugins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-541) move all Abbot testcases to run during a single server install/uninstall

2008-12-03 Thread B.J. Reed (JIRA)
move all Abbot testcases to run during a single server install/uninstall


 Key: GERONIMODEVTOOLS-541
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-541
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Reporter: B.J. Reed
Assignee: Tim McConnell
Priority: Minor


For each Abbot test case, each test case creates a new server, starts the 
server, stops the server, and then removes the server.  This is very time 
consuming for the test cases to run and ends up testing much of the same code 
over and over again.

It would be better to change the test suite to really only have one test (for 
each server version) with everything else done while the server is running.  So 
the algorithm should be:
check valid GEP installation
create server
start server
test A
test A cleanup
test B
test B cleanup
.
stop server
remove server

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-530) Faile to show EJB Security Role in security UI

2008-12-01 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-530.
--

Resolution: Fixed

Patch applied to 2.1.4 at r722121 and 2.2 at r722118.  Thanks to Delos Dai for 
supplying the patch.  Please convert tabs to 4 spaces in the future to comply 
with coding standards.

> Faile to show EJB Security Role in security UI
> --
>
> Key: GERONIMODEVTOOLS-530
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
> Environment: OS:Windows 2003 and Suse10
>Reporter: viola.lu
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 530.patch
>
>
> Steps:
> 1.Create an EJB project,edit its ejb-jar.xml, append snippnet below:
> 
> content-admin
> 
> 2.Open openejb-jar.xml, click "Security" tab in deployment descriptor, but in 
> security role, no content display.Different from web dynamic application and 
> Enterpise Project's Behavior.
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-526) st.v21.ui plugin.xml needs internationalization

2008-12-01 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-526.
--

Resolution: Fixed
  Assignee: B.J. Reed  (was: Ted Kirby)

Patch applied at r722113 for 2.1.4 and r722111 for 2.2.  Thanks to Delos Dai 
for the fix.

> st.v21.ui plugin.xml needs internationalization
> ---
>
> Key: GERONIMODEVTOOLS-526
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-526
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.2.0, 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 526.patch, plugin.properties
>
>
> The plugin.xml in org.apache.geronimo.st.v21.ui has had a menu item added to 
> it.  I tried moving the string to a new plugin.properties file, but couldn't 
> figure out the trick to make it work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-400) editing and saving the deployment plan XML doesn't get reflected back into the editor pages.

2008-11-18 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-400.


Resolution: Fixed

Fixed with revision 718691.  Had to create a new class that inherits from the 
StructuredTextEditor (XML Source page editor) to add a call back to the editor 
to do a reload after the save has occurred.  The reload goes through each page 
and has them update themselves to reflect the new deployment plan data.

> editing and saving the deployment plan XML doesn't get reflected back into 
> the editor pages.
> 
>
> Key: GERONIMODEVTOOLS-400
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-400
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0
>
>
> If a user goes to the deployment plan editor xml file and makes updates 
> there, they do not get reflected back into the other editor pages.  For the 
> user to see the changes reflected, they must close and reopen the editor.  
> This is a problem with all 5 editors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (GERONIMODEVTOOLS-530) Faile to show EJB Security Role in security UI

2008-11-12 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed reassigned GERONIMODEVTOOLS-530:
--

Assignee: B.J. Reed  (was: Tim McConnell)

> Faile to show EJB Security Role in security UI
> --
>
> Key: GERONIMODEVTOOLS-530
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
> Environment: OS:Windows 2003 and Suse10
>Reporter: viola.lu
>Assignee: B.J. Reed
>
> Steps:
> 1.Create an EJB project,edit its ejb-jar.xml, append snippnet below:
> 
> content-admin
> 
> 2.Open openejb-jar.xml, click "Security" tab in deployment descriptor, but in 
> security role, no content display.Different from web dynamic application and 
> Enterpise Project's Behavior.
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-530) Faile to show EJB Security Role in security UI

2008-11-12 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646939#action_12646939
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-530:


When the security role code was added to the GUI, it looks like the author of 
the code realized that the EJB stuff couldn't be done the same way as the other 
security role codes.  I think they ran out of time before being able to 
complete this.  It looks like we should be able to update 
EjbJavaEEDeploymnetDescriptor.getSecurityRoles () and 
EjbJ2EEDeploymnetDescriptor.getSecurityRoles () to perform an equivalent 
function.  Not sure if it was intentional or not, but the effect is that this 
will be deferred to a release after 2.1.3.  Will provide more details when I 
have a little more time to look at this.

> Faile to show EJB Security Role in security UI
> --
>
> Key: GERONIMODEVTOOLS-530
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-530
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
> Environment: OS:Windows 2003 and Suse10
>Reporter: viola.lu
>Assignee: B.J. Reed
>
> Steps:
> 1.Create an EJB project,edit its ejb-jar.xml, append snippnet below:
> 
> content-admin
> 
> 2.Open openejb-jar.xml, click "Security" tab in deployment descriptor, but in 
> security role, no content display.Different from web dynamic application and 
> Enterpise Project's Behavior.
>   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-526) st.v21.ui plugin.xml needs internationalization

2008-10-22 Thread B.J. Reed (JIRA)
st.v21.ui plugin.xml needs internationalization
---

 Key: GERONIMODEVTOOLS-526
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-526
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4
Reporter: B.J. Reed
Assignee: Ted Kirby


The plugin.xml in org.apache.geronimo.st.v21.ui has had a menu item added to 
it.  I tried moving the string to a new plugin.properties file, but couldn't 
figure out the trick to make it work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-525) need testcase for create a custom server assembly

2008-10-22 Thread B.J. Reed (JIRA)
need testcase for create a custom server assembly
-

 Key: GERONIMODEVTOOLS-525
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-525
 Project: Geronimo-Devtools
  Issue Type: Test
  Components: eclipse-plugin
Affects Versions: 2.1.4
Reporter: B.J. Reed
Assignee: Ashish Jain
Priority: Minor


We need a testcase for the new function provided by JIRA found at 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-524.  Since the server 
must be running to perform this function, the new testcase could probably be 
added to the testcase that starts and stops a server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-524) need ability to perform Custom Server Assembly

2008-10-22 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-524.


Resolution: Fixed

Code added in revisions 707160 for 2.1.4 and 707162 for trunk.  Will open a 
jira to have a testcase written for the new functionality.

> need ability to perform Custom Server Assembly
> --
>
> Key: GERONIMODEVTOOLS-524
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-524
> Project: Geronimo-Devtools
>  Issue Type: New Feature
>  Components: eclipse-plugin
>Affects Versions: 2.1.4
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.1.4
>
>
> Per the Roadmap, the GEP needs to be able to support Custom Server Assembly.  
> This should be done similar to the way the gsh does it.  We should be able to 
> hang a menu item off of the popup menu that brings up a dialog. The user 
> should be able to add any necessary info and select the desired list of 
> plugins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-524) need ability to perform Custom Server Assembly

2008-10-22 Thread B.J. Reed (JIRA)
need ability to perform Custom Server Assembly
--

 Key: GERONIMODEVTOOLS-524
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-524
 Project: Geronimo-Devtools
  Issue Type: New Feature
  Components: eclipse-plugin
Affects Versions: 2.1.4
Reporter: B.J. Reed
Assignee: B.J. Reed
 Fix For: 2.1.4


Per the Roadmap, the GEP needs to be able to support Custom Server Assembly.  
This should be done similar to the way the gsh does it.  We should be able to 
hang a menu item off of the popup menu that brings up a dialog. The user should 
be able to add any necessary info and select the desired list of plugins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-377) need way to manage the adminobject list

2008-10-16 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-377.


   Resolution: Fixed
Fix Version/s: (was: 2.2.0)
   2.1.4

Fixed with revision 705267 in 2.1.4 and 705268 in trunk.  Added a Tree Section 
to the Connector Deployment Plan Editor so that Admin Objects can be managed.

> need way to manage the adminobject list
> ---
>
> Key: GERONIMODEVTOOLS-377
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-377
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-384) unable to set relationships

2008-10-15 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-384.


   Resolution: Fixed
Fix Version/s: (was: 2.2.0)
   2.1.4

Fixed with revision 704999 to 2.1.4 and revision 705002 in trunk.  Added EJB 
Relation tree section to the naming page for the OpenEJB Deployment Plan Editor.

> unable to set relationships
> ---
>
> Key: GERONIMODEVTOOLS-384
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-384
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-350) Update "Source" view with unsaved changes in Deployment Plan Editor, or prompt user to save before switching to "Source" view

2008-10-14 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-350.


   Resolution: Fixed
Fix Version/s: (was: 2.2.0)
   2.1.4

Fixed with revision 704625 in 2.1.4 and 704628 in 2.2.  Show dialog and return 
to previous page when there is unsaved data on any page and the user tries to 
go to the Source page.  This forces the views to be synchronized when there are 
changes on the non-Source pages.

> Update "Source" view with unsaved changes in Deployment Plan Editor, or 
> prompt user to save before switching to "Source" view
> -
>
> Key: GERONIMODEVTOOLS-350
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-350
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.0
> Environment: Eclipse Europa Winter, Geronimo 2.1.1, GEP 2.1.0
>Reporter: Cedric Hurst
>Assignee: Tim McConnell
> Fix For: 2.1.4
>
> Attachments: deploymentPlanUnsavedChanges.avi, 
> GERONIMODEVTOOLS-350-optionb.patch
>
>
> When editing metadata in one of the graphical views of the Deployment Plan 
> Editor (e.g. "General", "Security", "Deployment"), any unsaved changes are 
> not reflected after switching to the "Source" view.  This might be confusing 
> for the user, because the expectation is that they are editing a "working 
> copy" the values of the fields would be consistently reflected in the 
> "Source" view.   I am proposing two possible options (in order of preference):
> 1. Update the "Source" view to reflect unsaved changes
> 2. Prompt the user to save the Deployment Plan before switching from a 
> graphical view to the "Source" view
> I will attach a screencast to better demonstrate the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-400) editing and saving the deployment plan XML doesn't get reflected back into the editor pages.

2008-10-14 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639464#action_12639464
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-400:


Specific steps for reproducing via the Application Deployment Plan Editor 
provided by viola.lu:

1.Create an Enterprise Application Project named SimpleEAR in eclipse, 
including simpleEJB.jar and simpleClient.jar
2.Open geronimo-application.xml ,click" source " tab to edit plan in source 
mode, and try to add an EJB module or java module to it and save.
3.Click the "deployment " tab, no change reflects in "modules" section.
4.If you click "deployment" tab, and add a module , then save it.After that, 
click "source" tab, changes are there.But inverselly edit plan in source mode, 
changes don't reflect in UI tab.

> editing and saving the deployment plan XML doesn't get reflected back into 
> the editor pages.
> 
>
> Key: GERONIMODEVTOOLS-400
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-400
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0
>
>
> If a user goes to the deployment plan editor xml file and makes updates 
> there, they do not get reflected back into the other editor pages.  For the 
> user to see the changes reflected, they must close and reopen the editor.  
> This is a problem with all 5 editors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-523) Geronimo Deployment Plan Editor can't reflect changes made in source module

2008-10-14 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-523.
--

Resolution: Duplicate

This is a duplicate of 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-400. I will add the 
specific steps from this JIRA to that one.

> Geronimo Deployment Plan Editor  can't reflect  changes made in source module
> -
>
> Key: GERONIMODEVTOOLS-523
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-523
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
> Environment: Windows XP SP2, Eclipse 3.4.0,Sun Java 1.6.0
>Reporter: viola.lu
>Assignee: Tim McConnell
>Priority: Minor
>
> Steps:
> 1.Create an Enterprise Application Project named SimpleEAR in eclipse, 
> including simpleEJB.jar and simpleClient.jar
> 2.Open geronimo-application.xml ,click" source " tab to edit plan in source 
> mode, and try to add an EJB module or java module to it and save.
> 3.Click the "deployment " tab, no change reflects in  "modules" section.
> 4.If you click "deployment" tab, and add a module , then save it.After that, 
> click "source" tab, changes are there.But inverselly edit plan in source 
> mode, changes don't reflect in UI tab.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-385) web application deployment plan editor improvements

2008-10-14 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-385.
--

   Resolution: Fixed
Fix Version/s: (was: 2.2.0)
   2.1.4

All sub tasks completed.  Any more issues specific to the Web Deployment Plan 
Editor do not need this as thier parent.

> web application deployment plan editor improvements
> ---
>
> Key: GERONIMODEVTOOLS-385
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-385
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.4
>
>
> Please add any minor issues or improvements as sub-tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-365) application deployment plan editor improvements

2008-10-14 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-365.
--

   Resolution: Fixed
Fix Version/s: (was: 2.2.0)
   2.1.4

All sub tasks completed.  Any more issues specific to the Application 
Deployment Plan Editor do not need this as thier parent.

> application deployment plan editor improvements
> ---
>
> Key: GERONIMODEVTOOLS-365
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-365
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.4
>
>
> Please add any minor issues or improvements as sub-tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-388) unable to set an abstract-naming-entry

2008-10-14 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-388.


   Resolution: Fixed
Fix Version/s: 2.1.4

Fixed at revision 704564 for 2.1.4 and 704567 for trunk.   Added 3 new tree 
sections to the Naming Page.

> unable to set an abstract-naming-entry
> --
>
> Key: GERONIMODEVTOOLS-388
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-388
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-437) Determing success/failure of Abbot testcase from Maven

2008-10-02 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636434#action_12636434
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-437:


Fixed with revision 701213.

> Determing success/failure of Abbot testcase from Maven
> --
>
> Key: GERONIMODEVTOOLS-437
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-437
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-437) Determing success/failure of Abbot testcase from Maven

2008-10-02 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-437.
--

   Resolution: Fixed
Fix Version/s: 2.2.0

Added a new library.xml based on the org.eclipse.test_3.2.0\library.xml to use 
ant's failonerror flag.  Pointed the test.xml's for each version to this new 
file.  For this to stop the build, a JUnit assert must fail.


> Determing success/failure of Abbot testcase from Maven
> --
>
> Key: GERONIMODEVTOOLS-437
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-437
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-487) Install GEP from staging site testcase

2008-10-02 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636371#action_12636371
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-487:


Something isn't working right for me when I apply the patch, seems that 
installing from the download site may not be a simple test case due to 
different environments.

When running from Eclipse Ganymede, I get an extra dialog "A feature that you 
have selected uses install procedures that are not compatible with the current 
installation support.  This feature can only be installed by the older Update 
Manager.  Do you want to launch the older Update Manager?"

When running from maven, I get an extra dialog after installation stating that 
Geronimo 2.1.3 version is already installed so it does not want to use the 
older version.

> Install GEP from staging site testcase
> --
>
> Key: GERONIMODEVTOOLS-487
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Attachments: GERONIMODEVTOOLS-487.patch, screenshot.png
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-379) unable to set cmp-connection-factory

2008-09-29 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-379.


Resolution: Fixed

Fixed with revision 700249.  Added a new OpenEjbJarCMPSection.java that is used 
by the EjbOverviewPage to update the proper JAXB objects.

> unable to set cmp-connection-factory
> 
>
> Key: GERONIMODEVTOOLS-379
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-379
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.2.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-519) Document the Deployment Plan editors

2008-09-22 Thread B.J. Reed (JIRA)
Document the Deployment Plan editors


 Key: GERONIMODEVTOOLS-519
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-519
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.2.0
Reporter: B.J. Reed
Assignee: B.J. Reed
Priority: Minor
 Fix For: 2.2.0


As the Deployment Plan Editors are completed, we need to add detailed 
documentation for the use of each editor and page.  It should be hooked into 
the existing documentation on the 
http://geronimo.apache.org/development-tools.html page.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-512) When running the testsuite from maven, the Geronimo branding does not show up

2008-09-09 Thread B.J. Reed (JIRA)
When running the testsuite from maven, the Geronimo branding does not show up
-

 Key: GERONIMODEVTOOLS-512
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-512
 Project: Geronimo-Devtools
  Issue Type: Test
  Components: eclipse-plugin
Affects Versions: 2.1.3
 Environment: Windows Ganymede, maven 2.0.9
Reporter: B.J. Reed
Assignee: Tim McConnell
Priority: Minor
 Fix For: 2.1.3


When running the Abbot testsuite from maven, the Geronimo image button does not 
show up in the About window.  Probably can be fixed by unzipping the features 
as well as the plugins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase

2008-09-09 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed closed GERONIMODEVTOOLS-485.
--

Resolution: Fixed

Applied patch at r693553 that included the changes mentioned before.  Also 
needed to update the test.xml so that the new Abbot testcase will be run during 
the maven build process.  Thanks to Ashish Jain for the patch.

> "About Eclipse Platform" testcase
> -
>
> Key: GERONIMODEVTOOLS-485
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Attachments: GERONIMODEVTOOLS-485.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-339) Provide tooling application client interface (instead of current command line interface)

2008-09-08 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-339.


Resolution: Cannot Reproduce

Please re-open if you think this is still a problem.

> Provide tooling application client interface (instead of current command line 
> interface)
> 
>
> Key: GERONIMODEVTOOLS-339
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-339
> Project: Geronimo-Devtools
>  Issue Type: New Feature
>  Components: eclipse-plugin
>Reporter: Tim McConnell
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.3
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-339) Provide tooling application client interface (instead of current command line interface)

2008-09-08 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629238#action_12629238
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-339:


I guess I'm not sure what's really missing here.  I just went all the way 
through the following sample

http://cwiki.apache.org/GMOxDOC21/developing-an-application-client-to-access-ejb.html

and was able to do everything from eclipse - development, publish, test/run 
application client.

Basically, I right clicked on the app client project and did run as->java 
application.  Alternatively, if i wanted to pass an argument in or set an 
environment variable ...I right clicked on the app client project and did run 
as->run confuigurations and it creates a new java application page in the run 
configuration dialog for me.

If more is needed than this, please provide details.

> Provide tooling application client interface (instead of current command line 
> interface)
> 
>
> Key: GERONIMODEVTOOLS-339
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-339
> Project: Geronimo-Devtools
>  Issue Type: New Feature
>  Components: eclipse-plugin
>Reporter: Tim McConnell
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.3
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase

2008-09-08 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629169#action_12629169
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-485:


Thanks Ashish, this patch works for me, but I have several cosmetic issues.

1) EclipseUI.java has no copyright or @version $Rev$ $Date$ line
2) EclipseUI.java has 2 unused imports which show as warnings
3) EclipseUI.java and Abbot.java using tabs in stead of spaces
4) some other spacing issues that would make the code look nice (see below)
5) AbbotHelper.java rename clickButtonForToolItem to clickImageButton - it's a 
regular button with an image on it that we are clicking, not a ToolItem like I 
originally thought it was.

For EclipseUI.java, it should probably look more like this...


public class EclipseUI extends WorkbenchTestCase {
Shell aShell;
AbbotHelper aHelper;

...


   //aHelper.clickItem(newShell, "Geronimo v2.1 Server Adapter");*/
}
catch(Exception e) {
e.printStackTrace();
}
}
}


> "About Eclipse Platform" testcase
> -
>
> Key: GERONIMODEVTOOLS-485
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
> Attachments: GERONIMODEVTOOLS-485.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase

2008-09-03 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628116#action_12628116
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-485:


I see a few problemsthe second line is still looking at the workbench and 
not the dialog

Went ahead and stepped through the Abbot code a little more.  Those things on 
the About dialog are not ToolItems, but are Buttons so we still want to use the 
WidgetToolTipMatcher inner class, but you'll also need to add to the getText 
method to handle instances of Button.  The fact that you found 6 ToolItems was 
just a coincidence.

So for the second call, you may want to copy the clickToolItem (...) method 
(since this one is ToolItem specific) and create one for clicking the Button by 
finding its tool tip text.  (I just named it clickButtonFromToolTipText below, 
but I'm sure there's a better name for it).

The code should look something like this:

Shell dialogShell = aHelper.clickMenuItem(workbenchShell, new String[] 
{"&Help", "&About Eclipse Platform"}, "About Eclipse Platform");
aHelper.clickButtonFromToolTipText(dialogShell,"Eclipse.org - Mylyn"); 


When stepping through the code, I went ahead and copied the tool tip texts that 
were available to me.
Eclipse.org - Help System Base
Eclipse.org - J2EE Standard Tools (JST)
Eclipse.org - Mylyn
Eclipse.org - EMF - Eclipse Modeling Framework
Apache.org - Geronimo v21 Server Tools Core Plug-in
Eclipse.org# - Data Tools Platform User Documentation
plus 4 nulls for the Buttons at the bottom of the dialog

> "About Eclipse Platform" testcase
> -
>
> Key: GERONIMODEVTOOLS-485
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-487) Install GEP from staging site testcase

2008-09-03 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628097#action_12628097
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-487:


You should be able to find the Tabbed item similar to how we find all other 
objects with text..  After that, you should be able to use Abbot's 
TabItemTester.actionClick(Widget) to click on it.  You should probably write a 
small AbbotHelper method to do this.

> Install GEP from staging site testcase
> --
>
> Key: GERONIMODEVTOOLS-487
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-487
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase

2008-09-03 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628091#action_12628091
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-485:


It looks to me like the tool tip text has some spaces in there.  Try

aHelper.clickToolItem(workbenchShell,"Eclipse.org - Mylyn"); 

or try the "Apache.org - Geronimo v21 Server Tools Core Plug-in"

> "About Eclipse Platform" testcase
> -
>
> Key: GERONIMODEVTOOLS-485
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-128) Complete Editor Support for specifying Web Service References in geronimo-web.xml

2008-09-03 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-128:
---

Attachment: GDT-128.patch

GDT-128.patch takes the concept that was provided in the original patch for 
service refs and merges it with the new AbstractTreeSection that was provided 
in revision 690385.

Patch also includes a new AbstractTreeWizard.java and also makes minor changes 
to GBeanWizard to use this new class.

> Complete Editor Support for specifying Web Service References in 
> geronimo-web.xml
> -
>
> Key: GERONIMODEVTOOLS-128
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-128
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: 1.gif, 2.gif, 3.gif, 4.gif, 5.gif, GDT-128.patch
>
>
> Enhancements to "Web Service References" wizard:
> The wizard that comes up when "Add" or "Edit" button in "Service Refs" 
> section is clicked, is updated to provide full support for adding/editing of 
>  elements. Snapshots attached demonstrate this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-127) Complete Editor Support for specifying Security Configuration in geronimo-web.xml

2008-08-29 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-127.


Resolution: Fixed

Shiva and his team have fixed this issue in revision 688452.

> Complete Editor Support for specifying Security Configuration in 
> geronimo-web.xml
> -
>
> Key: GERONIMODEVTOOLS-127
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-127
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: 1.gif, 10.gif, 2.gif, 3.gif, 4.gif, 5.gif, 6.gif, 7.gif, 
> 8.gif, 9.gif
>
>
> The "Security" page of Geronimo Deployment Plan Editor is now enhanced and 
> supports adding/editing of complete Security Configuration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-129) Enhanced Editor Support for specifying GBeans in geronimo-web.xml

2008-08-29 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-129:
---

Attachment: GDT-129.patch

Patch has 2 main functions:

1) convert the GBean table to a tree and provide function for adding GBeans and 
Attributes, Dependencies, and References to the GBeans.  Much of this code is 
based on the work that Shiva and his team completed.

2) clean up the code that Shiva and his team put in recently.  The code was 
good originally, but it needed a little firming up (strings hardcoded, 
duplicate code, etc).

> Enhanced Editor Support for specifying GBeans in geronimo-web.xml
> -
>
> Key: GERONIMODEVTOOLS-129
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-129
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: 1.gif, 2.gif, 3.gif, 4.gif, 5.gif, 6.gif, GDT-129.patch, 
> webplans_editor cumulative-118-120-122-123-124-127-128-129.patch
>
>
> Enhancements to "GBeans" wizard:
> The wizard that comes up when "Add" or "Edit" button in "GBeans" section is 
> clicked, is updated to provide enhanced support for adding/editing of 
>  elements. Snapshots attached demonstrate this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase

2008-08-29 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626953#action_12626953
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-485:


In the AbbotHelper.java class (in our testsuite common plugin), we have a 
method clickToolItem which does a search on Tool Item Buttons by using their 
tool tip text.  We should be able to use that method or one very similar to it 
to find and click the Geronimo icon during an Abbot test run.


> "About Eclipse Platform" testcase
> -
>
> Key: GERONIMODEVTOOLS-485
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>Reporter: Tim McConnell
>Assignee: Ashish Jain
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-57) When user configure server and put wrong password, no message is shown

2008-08-27 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-57.
---

   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

At some point, this has been fixed.  I just put in a bad password and started 
the server.  After loading a few modules in the console, the server status was 
changed to stopped and a message dialog showed up with a message telling me to 
check the log for details.  When checking the logs, I see 

!ENTRY org.apache.geronimo.st.core 4 0 2008-08-27 10:15:05.890
!MESSAGE Invalid username and/or password.
!STACK 0
java.lang.SecurityException: Invalid login

and a stack trace.

If this is still a problem, please re-open.

> When user configure server and put wrong password, no message is shown
> --
>
> Key: GERONIMODEVTOOLS-57
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-57
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.0.x
> Environment: Win2K, Sun JDK 1.4.2, Eclipse 3.11 with WTP 1.0.1 and 
> latest daily build of eclipse plugin (20060130-0958)
>Reporter: Edson Richter
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
>
> When developer configure a new server, it should select HTTP Port, RMI Port 
> and administration user and password. If user and/or password is wrong, when 
> Geronimo is started by developer, no message is shown about wrong user or 
> password, and status for server stay on "starting" forever (or, at least, 
> until timeout occur).
> Expected behaviour is if user or password is incorrect, a message is shown so 
> developer could correct this in server properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-503) security page does not show for application or EJB

2008-08-26 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-503:
---

Attachment: GERONIMODEVTOOLS-503.patch

Attached patch creates several new classes for EJB and Application to read the 
security info from the deployment descriptor using the same process that is 
done for Web.

> security page does not show for application or EJB
> --
>
> Key: GERONIMODEVTOOLS-503
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-503
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.1.3
>
> Attachments: GERONIMODEVTOOLS-503.patch
>
>
> With the new security page updates for the Web deployment plan, the security 
> page no longer shows up for application or EJB deployment plans.  Start with 
> org.apache.geronimost.core.DeploymentDescriptorUtils.java and work from there 
> to add code and classes as needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-504) advanced security section does not allow setting of credential store

2008-08-26 Thread B.J. Reed (JIRA)
advanced security section does not allow setting of credential store


 Key: GERONIMODEVTOOLS-504
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-504
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.1.3
 Environment: Ganymede on Windows 
Reporter: B.J. Reed
Assignee: Tim McConnell
 Fix For: 2.1.3


When editing the Web deployment plan (and probably the application and EJB as 
well), clicking the Credential Store Edit button does nothing.  Have traced 
through the code and when the button is selected, a call to 
getCredentialStoreRefWizard is made in SecurityAdvancedSection.java.  This 
method simply returns null without bringing up a dialog and setting the field.  
With this function disabled, most of the rest of the advanced security options 
are also disabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

2008-08-26 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625749#action_12625749
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-395:


3 more tags that can be removed by the deplyment plan editor when empty.




> should remove tags from source files that have no data
> --
>
> Key: GERONIMODEVTOOLS-395
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.3
>
> Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have 
> nothing in it gives an XML tag with nothing in it. Before editing a plan, 
> unnecessary tags are not shown in the deployment plan,  this is the state the 
> plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I 
> will get a tag like this (which is good)
> aHandler
> Going back into the editor and removing that, I get 
> 
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-503) security page does not show for application or EJB

2008-08-26 Thread B.J. Reed (JIRA)
security page does not show for application or EJB
--

 Key: GERONIMODEVTOOLS-503
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-503
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.1.3
Reporter: B.J. Reed
Assignee: B.J. Reed
 Fix For: 2.1.3


With the new security page updates for the Web deployment plan, the security 
page no longer shows up for application or EJB deployment plans.  Start with 
org.apache.geronimost.core.DeploymentDescriptorUtils.java and work from there 
to add code and classes as needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-394) more possible security options needed

2008-08-26 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-394.


Resolution: Duplicate

This is a duplicate of JIRA 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-127

> more possible security options needed
> -
>
> Key: GERONIMODEVTOOLS-394
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-394
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.3
>
>
> unable to set the security description-list, default subject, and 
> credential-store-ref
> roles also should have a description list, run-as-subject, realm-principal 
> list, login-domain-principal list, principal list, distinguished-name list

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMODEVTOOLS-430) Provide editor support to configure Advanced Security Settings

2008-08-25 Thread B.J. Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625484#action_12625484
 ] 

B.J. Reed commented on GERONIMODEVTOOLS-430:


Shiva, are you sure you applied this patch correctly?  There are several files 
that this patch creates that are not currently in trunk.  If you needed to 
change the patch before you put it in, can you explain what you did since I'm 
trying to learn this code and can't seem to figure out where the functionality 
is in trunk.

> Provide editor support to configure Advanced Security Settings
> --
>
> Key: GERONIMODEVTOOLS-430
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-430
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.2, 2.1.3
>Reporter: Sainath Chowdary
>Assignee: Sainath Chowdary
> Fix For: 2.1.3
>
> Attachments: 1_advanced_security.jpg, 2_populated_security.jpg, 
> GERONIMODEVTOOLS-414-423-430-consolidated.patch
>
>
> Add support in Geronimo Deployment Plan Editor for Advanced Security Options 
> like adding Credential Store, default-subject, doas-current-caller, 
> use-context-handler etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-465) The 'Eclipse-LazyStart' header is deprecated, use 'Bundle-ActivationPolicy'

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-465:
---

Attachment: GERONIMODEVTOOLS-465.patch

Searched through the GEP plugins, found about 8 places with the deprecated 
line.  This patch should resolve those warnings.

> The 'Eclipse-LazyStart' header is deprecated, use 'Bundle-ActivationPolicy'
> ---
>
> Key: GERONIMODEVTOOLS-465
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-465
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Jacek Laskowski
>Assignee: Tim McConnell
> Attachments: GERONIMODEVTOOLS-465.patch
>
>
> MANIFEST.MF from org.apache.geronimo.st.core plugin (and possibly others) 
> uses Eclipse-LazyStart which is deprecated and OSGi's 
> 'Bundle-ActivationPolicy' is recommended.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-295) Delete redundant dependencies from runtime plug-ins - Make GEP thinner!

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-295.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.1

No work has been done on this in a while and the GEP has been made much thinner 
than it used to be.  Please re-open if you see other places where we can make 
the GEP more light weight.

> Delete redundant dependencies from runtime plug-ins - Make GEP thinner!
> ---
>
> Key: GERONIMODEVTOOLS-295
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-295
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.0
>Reporter: Shiva Kumar H R
>Assignee: Shiva Kumar H R
> Fix For: 2.1.1
>
>
> GEP is currently 13.3MB! Out of this ~11.6MB (87%) is from following four 
> plug-ins!
> 1) \plugins\org.apache.geronimo.runtime.common
> 2) \plugins\org.apache.geronimo.runtime.v11
> 3) \plugins\org.apache.geronimo.runtime.v20
> 4) \plugins\org.apache.geronimo.runtime.v21
> After GERONIMODEVTOOLS-294, many of the dependencies in above plug-ins might 
> have become redundant. Identify the redundant ones and delete them to make 
> GEP thinner :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-281) No grammar constraints (DTD or XML schema) detected for the document for generated geronimo-web.xml

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-281.


   Resolution: Fixed
Fix Version/s: 2.1.2

I haven't seen this warning in a while.  I'm closing as fixed (although I have 
no idea when), please re-open if you think this is still a problem.

> No grammar constraints (DTD or XML schema) detected for the document for 
> generated geronimo-web.xml
> ---
>
> Key: GERONIMODEVTOOLS-281
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-281
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.0
>Reporter: Jacek Laskowski
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
>
> Upon creating a new web application with Geronimo 2.1 runtime 
> geronimo-web.xml is marked with a warning:
> No grammar constraints (DTD or XML schema) detected for the document
> It's with Eclipse 3.4M5.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-502) Naming page dialogs no longer show

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-502:
---

Attachment: GERONIMODEVTOOLS-502.patch

One line patch, seems that a NullPointerException is being thrown because the 
test fields were never created and added to the composite.

> Naming page dialogs no longer show
> --
>
> Key: GERONIMODEVTOOLS-502
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-502
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
> Environment: Windows Ganymede GEP 2.1.3 trunk
>Reporter: B.J. Reed
>Assignee: B.J. Reed
> Fix For: 2.1.3
>
> Attachments: GERONIMODEVTOOLS-502.patch
>
>
> When I go to the naming page and click on any of the "Add" buttons to add any 
> reference, nothing happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMODEVTOOLS-502) Naming page dialogs no longer show

2008-08-25 Thread B.J. Reed (JIRA)
Naming page dialogs no longer show
--

 Key: GERONIMODEVTOOLS-502
 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-502
 Project: Geronimo-Devtools
  Issue Type: Sub-task
  Components: eclipse-plugin
Affects Versions: 2.1.3
 Environment: Windows Ganymede GEP 2.1.3 trunk
Reporter: B.J. Reed
Assignee: B.J. Reed
 Fix For: 2.1.3


When I go to the naming page and click on any of the "Add" buttons to add any 
reference, nothing happens.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-393) Do setting of gbeans need more than just name and class?

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-393.


Resolution: Duplicate

This is a duplicate of JIRA 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-129

> Do setting of gbeans need more than just name and class?
> 
>
> Key: GERONIMODEVTOOLS-393
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-393
> Project: Geronimo-Devtools
>  Issue Type: Sub-task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.3
>
>
> If I am reading the JAXB model code correctly, the editors should be able to 
> set the following fields:
> attribute, xml-attribute, reference, references, xml-reference, dependency

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-134) BUILD ERROR - Reason: Unable to download the artifact from any repository org.apache.geronimo.specs:specs:pom:1.1.1

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-134.


Resolution: Fixed

I haven't seen this kind of error in a while and it seems that this JIRA has 
been open for quite some time.  I believe this has been fixed.  If this is 
still an error, please re-open.

> BUILD ERROR - Reason: Unable to download the artifact from any repository 
> org.apache.geronimo.specs:specs:pom:1.1.1
> ---
>
> Key: GERONIMODEVTOOLS-134
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-134
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.0.0
>Reporter: Jacek Laskowski
>Assignee: Jacek Laskowski
>Priority: Critical
>
> Got the following error:
> [INFO] 
> 
> [ERROR] BUILD ERROR
> [INFO] 
> 
> [INFO] Failed to resolve artifact.
> GroupId: org.apache.geronimo.specs
> ArtifactId: specs
> Version: 1.1.1
> Reason: Unable to download the artifact from any repository
>  org.apache.geronimo.specs:specs:pom:1.1.1
> from the specified remote repositories:
>  central (http://repo1.maven.org/maven2),
>  apache.incubator (http://people.apache.org/repo/m2-incubating-repository/),
>  sppatel (http://people.apache.org/~sppatel/maven/repository/),
>  apache-snapshots (http://people.apache.org/repo/m2-snapshot-repository),
>  codehaus-snapshots (http://snapshots.repository.codehaus.org)
> [INFO] 
> 
> [INFO] For more information, run Maven with the -e switch
> [INFO] 
> 
> [INFO] Total time: 140 minutes 58 seconds
> [INFO] Finished at: Tue Feb 27 00:50:07 CET 2007
> [INFO] Final Memory: 40M/254M
> [INFO] 
> 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-273) Server status detection is erroneous

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-273.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

Can you please try this scenario again using trunk?  The code should be doing a 
vetter job of looking for the non-hardcoded server now.   I'm closing it for 
now,  I believe that the final touches were done in the patch for 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-176 and included in 
revision 687428.

If this is still an issue, please re-open.

> Server status detection is erroneous
> 
>
> Key: GERONIMODEVTOOLS-273
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-273
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.0.0
> Environment: Win XP, GEP 2.0.0
>Reporter: Vamsavardhana Reddy
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
>
> I have added a Geronimo 2.0.2 Server under Servers view with Naming port 1100 
> and HTTP Port 8081 and server installation directory 
> c:\geronimo-tomcat6-jee5-2.0.2.  But when I start a Geronimo-2.1-SNAPSHOT 
> installed in a different directory but using the same ports, the Geronimo 
> 2.0.2 Server instance in the Servers view changes the status to "Starting" 
> and then shows "Started"!!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-124) Add editor support for specifying elements in "geronimo-web.xml"

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-124.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

The functionality for maintaining these fields has been included before the 
2.1.2 release. Along with the JAXB model changes that took place before this 
release, I believe that the final touches were done in the patch for 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-391 and included in 
revision 670063.

If this is still an issue, please re-open.

> Add editor support for specifying  elements in 
> "geronimo-web.xml"
> 
>
> Key: GERONIMODEVTOOLS-124
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-124
> Project: Geronimo-Devtools
>  Issue Type: New Feature
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: 1a.gif, 1b.gif, 2.gif
>
>
> This feature enables the user to add/edit   
> elements in "geronimo-web.xml". Snapshots 1a.gif & 1b.gif demonstrate this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-123) Complete Editor Support for specifying EJB References, EJB Local References, Resource References & Resource Environment References in geronimo-web.xml

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-123.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

The functionality for maintaining these fields has been included before the 
2.1.2 release. Along with the JAXB model changes that took place before this 
release.  I haven't been able to find the exact JIRA where these changes were 
made.

If this is still an issue, please re-open.

> Complete Editor Support for specifying EJB References, EJB Local References, 
> Resource References & Resource Environment References in geronimo-web.xml
> --
>
> Key: GERONIMODEVTOOLS-123
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-123
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: 1a.gif, 1b.gif, 1c.gif, 1d.gif, 1e.gif, 2a.gif, 2b.gif, 
> 3a.gif, 3b.gif, 4a.gif, 4b.gif, 
> GERONIMODEVTOOLS-118-120-122-123-124-consolidated.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-120) Refinements to the "Web Container" section of Deployment Plan Editors

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-120.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

The functionality for maintaining these fields has been included before the 
2.1.2 release. Along with the JAXB model changes that took place before this 
release, I believe that the final touches were done in the patch for 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-389 and included in 
revision 669175.

If this is still an issue, please re-open.

> Refinements to the "Web Container" section of Deployment Plan Editors
> -
>
> Key: GERONIMODEVTOOLS-120
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-120
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: GERONIMODEVTOOLS-120.patch, Snapshot-1.gif, 
> Snapshot-2.gif
>
>
> GUI for "Web Container" section in "General" tab is updated as shown in 
> Snapshot1.gif and Snapshot2.gif . When "Specify as GBean Link" radio button 
> is chosen, the section will only ask for "GBean Link". And when "Specify as 
> GBean Pattern" radio button is chosen, it will only ask for the sub-elements 
> of  element.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMODEVTOOLS-118) Complete Editor Support for specifying Dependencies, Hidden Classes, Non Overridable Classes & GBean References in geronimo-web.xml

2008-08-25 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed resolved GERONIMODEVTOOLS-118.


   Resolution: Fixed
Fix Version/s: (was: 2.1.3)
   2.1.2

The functionality for maintaining these fields has been included before the 
2.1.2 release. Along with the JAXB model changes that took place before this 
release, I believe that the final touches were done in the patch for 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-392 and included in 
revision 672424.

> Complete Editor Support for specifying Dependencies, Hidden Classes, Non 
> Overridable Classes & GBean References in geronimo-web.xml
> ---
>
> Key: GERONIMODEVTOOLS-118
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-118
> Project: Geronimo-Devtools
>  Issue Type: Improvement
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Shiva Kumar H R
>Assignee: Tim McConnell
> Fix For: 2.1.2
>
> Attachments: GERONIMODEVTOOLS-118.patch, Snapshot-1a.gif, 
> Snapshot-1b.gif, Snapshot-2a.gif, Snapshot-2b.gif, Snapshot-2c.gif, 
> Snapshot-3a.gif, Snapshot-3b.gif, Snapshot-3c.gif
>
>
> Please see the discussion going on about this at dev@geronimo.apache.org 
> mailing list:
> http://www.mail-archive.com/dev@geronimo.apache.org/msg35865.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-390) common deployment plan editor improvements

2008-08-20 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-390:
---

Issue Type: Task  (was: Improvement)

> common deployment plan editor improvements
> --
>
> Key: GERONIMODEVTOOLS-390
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-390
> Project: Geronimo-Devtools
>  Issue Type: Task
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: B.J. Reed
>Assignee: B.J. Reed
>Priority: Minor
> Fix For: 2.1.2
>
>
> This is a place holder for any issues that are common between multiple 
> deployment plan editors.
> Please add any minor issues or improvements as sub-tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-489) New Dependency popup window creates empty xml tags when no value provided

2008-08-20 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-489:
---

Attachment: GERONIMODEVTOOLS-489.patch

Patch included should fix this.  I'm certain that we have a bunch of small 
problems that are very similar to these.  I started a list at 
http://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395 to try to keep them 
somewhat together.  If you find more (and I'm pretty sure you will), please add 
them to that list.

> New Dependency popup window creates empty xml tags when no value provided
> -
>
> Key: GERONIMODEVTOOLS-489
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-489
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Jacek Laskowski
>Assignee: Tim McConnell
> Attachments: GERONIMODEVTOOLS-489.patch
>
>
> Use Add button in Server Dependencies in Geronimo Deployment Plan Editor to 
> define a new dependency. When Version and Artifact Type are empty, empty xml 
> tags  and  are created. They're unnecessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-488) Incorrect names for Group Id and Artifact Id columns in Server Dependencies in deployment plan editor

2008-08-20 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-488:
---

Attachment: GERONIMODEVTOOLS-488.patch

2 line patch that fixes the GUIthe add/edit dialog was also reversed order.

> Incorrect names for Group Id and Artifact Id columns in Server Dependencies 
> in deployment plan editor
> -
>
> Key: GERONIMODEVTOOLS-488
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-488
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Jacek Laskowski
>Assignee: B.J. Reed
> Attachments: GERONIMODEVTOOLS-488.patch
>
>
> In Geronimo Deployment Plan Editor, in Server Dependencies of Deployment, the 
> Group Id and Artifact Id column names are incorrect (they should change their 
> places).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (GERONIMODEVTOOLS-488) Incorrect names for Group Id and Artifact Id columns in Server Dependencies in deployment plan editor

2008-08-20 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed reassigned GERONIMODEVTOOLS-488:
--

Assignee: B.J. Reed  (was: Tim McConnell)

> Incorrect names for Group Id and Artifact Id columns in Server Dependencies 
> in deployment plan editor
> -
>
> Key: GERONIMODEVTOOLS-488
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-488
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.2
>Reporter: Jacek Laskowski
>Assignee: B.J. Reed
>
> In Geronimo Deployment Plan Editor, in Server Dependencies of Deployment, the 
> Group Id and Artifact Id column names are incorrect (they should change their 
> places).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMODEVTOOLS-176) GeronimoServerBehaviourDelegate always uses rmi port 1099

2008-08-06 Thread B.J. Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

B.J. Reed updated GERONIMODEVTOOLS-176:
---

Attachment: GERONIMODEVTOOLS-176.patch

It looks like the majority of this has been fixed.  At least I could double 
click the server and bring up the Overview page and I could change the RMI 
Naming port to match the server (non 1099).  Then I was able to start the 
server outside of the GEP and the GEP updated its status properly. I was also 
still able to start the server from within GEP.

However, looking at the code a little more closely, I did find one place in 
GeronimoServerBehaviourDelegate.java that still had 1099 hard coded.  A patch 
is included to put the proper value in the map.

> GeronimoServerBehaviourDelegate always uses rmi port 1099
> -
>
> Key: GERONIMODEVTOOLS-176
> URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-176
> Project: Geronimo-Devtools
>  Issue Type: Bug
>  Components: eclipse-plugin
>Affects Versions: 2.1.3
>Reporter: Donald Woods
>Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: GERONIMODEVTOOLS-176.patch
>
>
> We need to allow the user to reconfigure the RMI port, for the cases where 
> they have mapped the server to use something besides the default 1099 port.  
> Also, this would allow the plugin to support the new multiple server instance 
> feature in the 2.0 server

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



  1   2   3   >