Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
HI Kevan, yes these are not trivial files. I shall address. Thanks much for finding. Kevan Miller wrote: The following files are missing src license headers. plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/descriptor/WebJ2EEDeploymentDescriptor.java plugins/org.apache.geronimo.st.ui/src/main/java/org/apache/geronimo/st/ui/actions/LaunchGeronimoSupportAction.java Unless you can convince me that they are trivial (don't look like it) or machine generated, then they must be fixed prior to a release... Minor note: whoever created LaunchGeronimoSupportAction.java needs to turn off tabs in their IDE. Our src files should not contain tab characters, but appropriate space characters, instead. --kevan -- Thanks, Tim McConnell
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
The following files are missing src license headers. plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/ st/core/descriptor/WebJ2EEDeploymentDescriptor.java plugins/org.apache.geronimo.st.ui/src/main/java/org/apache/geronimo/st/ ui/actions/LaunchGeronimoSupportAction.java Unless you can convince me that they are trivial (don't look like it) or machine generated, then they must be fixed prior to a release... Minor note: whoever created LaunchGeronimoSupportAction.java needs to turn off tabs in their IDE. Our src files should not contain tab characters, but appropriate space characters, instead. --kevan
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
That doesn't follow how we do server releases. Once a branch is created (like 2.1.2) the prior code location should be incremented. We need to update the GEP release process -Donald Tim McConnell wrote: Per the GEP release process trunk is not updated until after the release is approved. See step #18: -> http://cwiki.apache.org/confluence/pages/editpage.action?pageId=63893 Donald Woods wrote: Also need to update trunk, which is still set to version=2.1.2. Is trunk going to become 2.1.3 or 2.2.0? If 2.2.0, then lets create a branches/2.1 for any future 2.1.3 bug fixes -Donald Tim McConnell wrote: smime.p7s Description: S/MIME Cryptographic Signature
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
Per the GEP release process trunk is not updated until after the release is approved. See step #18: -> http://cwiki.apache.org/confluence/pages/editpage.action?pageId=63893 Donald Woods wrote: Also need to update trunk, which is still set to version=2.1.2. Is trunk going to become 2.1.3 or 2.2.0? If 2.2.0, then lets create a branches/2.1 for any future 2.1.3 bug fixes -Donald Tim McConnell wrote: -- Thanks, Tim McConnell
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
Hi Donald, yes I failed to FTP them along with the GEP instructions. I also updated the instructions to reference them. I'll update our release process so that it doesn't happen for the next release. Thanks -> http://people.apache.org/~mcconne/releases/2.1.2/RC1/PLUGIN_RELEASE-NOTES-2.1.2.txt Donald Woods wrote: Do we have any release notes for GEP 2.1.2, to denote what has changed? Like support for Ganymede, Java SE 6, additional deployment plan editors, replaced Download and Install a server feature with just a link to the Geronimo Server download page, JIRAs that were included, -Donald Tim McConnell wrote: -- Thanks, Tim McConnell
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
On Thu, Aug 14, 2008 at 10:46 AM, Donald Woods <[EMAIL PROTECTED]> wrote: > Do we have any release notes for GEP 2.1.2, to denote what has changed? > Like support for Ganymede, Java SE 6, additional deployment plan editors, > replaced Download and Install a server feature with just a link to the > Geronimo Server download page, JIRAs that were included, I like the idea of creating, packaging and shipping a release notes file. The about and/or license .html files might even point to the ibm-changes.txt file (which would mean bundling it in the updatesite and deployable .zip files) which would allow users to view them before downloading them. Ted > -Donald > > > Tim McConnell wrote: >> >
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
Also need to update trunk, which is still set to version=2.1.2. Is trunk going to become 2.1.3 or 2.2.0? If 2.2.0, then lets create a branches/2.1 for any future 2.1.3 bug fixes -Donald Tim McConnell wrote: smime.p7s Description: S/MIME Cryptographic Signature
Re: [DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
Do we have any release notes for GEP 2.1.2, to denote what has changed? Like support for Ganymede, Java SE 6, additional deployment plan editors, replaced Download and Install a server feature with just a link to the Geronimo Server download page, JIRAs that were included, -Donald Tim McConnell wrote: smime.p7s Description: S/MIME Cryptographic Signature
[DISCUSS] Release Geronimo Eclipse Plugin 2.1.2 (RC1)
-- Thanks, Tim McConnell
