Re: [VOTE] XBean 4.0
On Aug 20, 2014, at 10:23 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: The main changes are: [...] skip java.* classes since we'll not get their bytecode for sure (protected method if needed) I'm not a fan of hard coding filtering inside the AnnotationFinder itself, so +1 under the condition that we remain open to revising this in a future release. -David
Re: [VOTE] XBean 4.0
@David: it was filtering java.lang.Object since it was created, java.* filter just extend this logic since it will never works (excepted if you bring java.* in your app which is unlikely. That said method is protected to be able to override it. In all case (I think I mentionned it several times) 4.x x 0 will make it more usable (OSGi, this if you think it is bad etc...). Main purpose was to get a first release fixing linking time and respecting the constructor contract Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 16:12 GMT+02:00 David Blevins david.blev...@gmail.com: On Aug 20, 2014, at 10:23 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: The main changes are: [...] skip java.* classes since we'll not get their bytecode for sure (protected method if needed) I'm not a fan of hard coding filtering inside the AnnotationFinder itself, so +1 under the condition that we remain open to revising this in a future release. -David
[RESULT] [VOTE] XBean 4.0
Counting votes it seems it passed: +1s: Alan D Cabrera, David Blevins, Romain Manni-Bucau +0: Jean-Baptiste Onofré, Mark Struberg -1: no thank you all for your votes. PS: ones having identified some issues would be welcomed to at least open a jira explaining it and potentially proposing a fix if you already have an idea to not forget them for 4.1 I'll publish binaries tonight. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 17:08 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: @David: it was filtering java.lang.Object since it was created, java.* filter just extend this logic since it will never works (excepted if you bring java.* in your app which is unlikely. That said method is protected to be able to override it. In all case (I think I mentionned it several times) 4.x x 0 will make it more usable (OSGi, this if you think it is bad etc...). Main purpose was to get a first release fixing linking time and respecting the constructor contract Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 16:12 GMT+02:00 David Blevins david.blev...@gmail.com: On Aug 20, 2014, at 10:23 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: The main changes are: [...] skip java.* classes since we'll not get their bytecode for sure (protected method if needed) I'm not a fan of hard coding filtering inside the AnnotationFinder itself, so +1 under the condition that we remain open to revising this in a future release. -David
Re: [RESULT] [VOTE] XBean 4.0
On Aug 25, 2014, at 9:43 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: PS: ones having identified some issues would be welcomed to at least open a jira explaining it and potentially proposing a fix if you already have an idea to not forget them for 4.1 Nicely phrased. And +1 on the welcome nudges. -David
Re: [RESULT] [VOTE] XBean 4.0
And Thank You for the vote!! -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com On Aug 25, 2014, at 9:43 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Counting votes it seems it passed: +1s: Alan D Cabrera, David Blevins, Romain Manni-Bucau +0: Jean-Baptiste Onofré, Mark Struberg -1: no thank you all for your votes. PS: ones having identified some issues would be welcomed to at least open a jira explaining it and potentially proposing a fix if you already have an idea to not forget them for 4.1 I'll publish binaries tonight. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 17:08 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: @David: it was filtering java.lang.Object since it was created, java.* filter just extend this logic since it will never works (excepted if you bring java.* in your app which is unlikely. That said method is protected to be able to override it. In all case (I think I mentionned it several times) 4.x x 0 will make it more usable (OSGi, this if you think it is bad etc...). Main purpose was to get a first release fixing linking time and respecting the constructor contract Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-25 16:12 GMT+02:00 David Blevins david.blev...@gmail.com: On Aug 20, 2014, at 10:23 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: The main changes are: [...] skip java.* classes since we'll not get their bytecode for sure (protected method if needed) I'm not a fan of hard coding filtering inside the AnnotationFinder itself, so +1 under the condition that we remain open to revising this in a future release. -David
Re: [VOTE] XBean 4.0
Is there an easy way to fix those OSGi issues? If so +0, if there is no _easy_ way then +1 and let's fix this later. LieGrue, strub On Friday, 22 August 2014, 15:03, Jean-Baptiste Onofré j...@nanthrax.net wrote: +0 (non binding) I have some issue on OSGi (but I think it was expected ;)). Regards JB On 08/20/2014 07:23 PM, Romain Manni-Bucau wrote: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: [VOTE] XBean 4.0
well it is exactly the expected case (well guessing but AFAIK it should): the archive was not complete and the app was expecting the finder to leak outside the archive. I expect to handle it in 4.1 if needed (ie the app can't create the archive correctly cause it ignores totally what it scans) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-23 18:40 GMT+02:00 Mark Struberg strub...@yahoo.de: Is there an easy way to fix those OSGi issues? If so +0, if there is no _easy_ way then +1 and let's fix this later. LieGrue, strub On Friday, 22 August 2014, 15:03, Jean-Baptiste Onofré j...@nanthrax.net wrote: +0 (non binding) I have some issue on OSGi (but I think it was expected ;)). Regards JB On 08/20/2014 07:23 PM, Romain Manni-Bucau wrote: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: [VOTE] XBean 4.0
Is your signature in http://www.apache.org/dist/geronimo/KEYS? Regards, Alan On Aug 22, 2014, at 5:55 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: a little up since it makes 2 days the vote started already ;) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-20 19:23 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: [VOTE] XBean 4.0
in http://svn.apache.org/repos/asf/geronimo/KEYS Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-23 20:07 GMT+02:00 Alan D. Cabrera l...@toolazydogs.com: Is your signature in http://www.apache.org/dist/geronimo/KEYS? Regards, Alan On Aug 22, 2014, at 5:55 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: a little up since it makes 2 days the vote started already ;) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-20 19:23 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: [VOTE] XBean 4.0
+1 Regards, Alan On Aug 22, 2014, at 5:55 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: a little up since it makes 2 days the vote started already ;) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-20 19:23 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: [VOTE] XBean 4.0
a little up since it makes 2 days the vote started already ;) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-20 19:23 GMT+02:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
Re: [VOTE] XBean 4.0
+0 (non binding) I have some issue on OSGi (but I think it was expected ;)). Regards JB On 08/20/2014 07:23 PM, Romain Manni-Bucau wrote: Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
[VOTE] XBean 4.0
Hi, As said in a mail last week I'm starting a vote for xbean 4.0 release. The main changes are: 1) force AnnotationFinder to respect archive in its scanning (don't leak in external classes) 1bis) skip java.* classes since we'll not get their bytecode for sure (protected method if needed) 2) Remove asynchronous finder which was really specific and can lead to some classloading issue pretty quickly on recent JVMs Binaries: https://repository.apache.org/content/repositories/orgapachegeronimo-1003/ Tag: http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-4.0/ Vote open 72h. [ ] +1 release this [ ] 0 don't care [ ] -1 don't release this (please explain) Here is my +1 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau
