[jira] [Commented] (GERONIMO-6776) Let specify encoding for generated files
[
https://issues.apache.org/jira/browse/GERONIMO-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155418#comment-17155418
]
Antoni Reus commented on GERONIMO-6776:
---
You can do it, thanks.
> Let specify encoding for generated files
>
>
> Key: GERONIMO-6776
> URL: https://issues.apache.org/jira/browse/GERONIMO-6776
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: geronimo-maven-plugin
>Affects Versions: OpenAPI_1.0.12
>Reporter: Antoni Reus
>Priority: Trivial
> Attachments: encoding.patch
>
>
> Currently the geronimo-openapi-maven-plugin uses a FileWriter to generate the
> openapi.json. This defaults to de platform encoding.
>
> The user should be able to specify an encoding in the plugin configuration:
> UTF-8
> or use ${project.build.sourceEncoding} as default encoding, and only if this
> is not provided fallback to the platform encoding.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GERONIMO-6776) Let specify encoding for generated files
[
https://issues.apache.org/jira/browse/GERONIMO-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155413#comment-17155413
]
Romain Manni-Bucau commented on GERONIMO-6776:
--
[~areus_fbit] do you want to update the patch (you can do a PR on github
([https://github.com/apache/geronimo-openapi]) - or I can do it as well
straight since it is simple
> Let specify encoding for generated files
>
>
> Key: GERONIMO-6776
> URL: https://issues.apache.org/jira/browse/GERONIMO-6776
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: geronimo-maven-plugin
>Affects Versions: OpenAPI_1.0.12
>Reporter: Antoni Reus
>Priority: Trivial
> Attachments: encoding.patch
>
>
> Currently the geronimo-openapi-maven-plugin uses a FileWriter to generate the
> openapi.json. This defaults to de platform encoding.
>
> The user should be able to specify an encoding in the plugin configuration:
> UTF-8
> or use ${project.build.sourceEncoding} as default encoding, and only if this
> is not provided fallback to the platform encoding.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GERONIMO-6776) Let specify encoding for generated files
[
https://issues.apache.org/jira/browse/GERONIMO-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155409#comment-17155409
]
Antoni Reus commented on GERONIMO-6776:
---
you are right, default should be UTF-8
[https://tools.ietf.org/html/rfc7159#section-8.1|https://tools.ietf.org/html/rfc8259#section-8.1]
> Let specify encoding for generated files
>
>
> Key: GERONIMO-6776
> URL: https://issues.apache.org/jira/browse/GERONIMO-6776
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: geronimo-maven-plugin
>Affects Versions: OpenAPI_1.0.12
>Reporter: Antoni Reus
>Priority: Trivial
> Attachments: encoding.patch
>
>
> Currently the geronimo-openapi-maven-plugin uses a FileWriter to generate the
> openapi.json. This defaults to de platform encoding.
>
> The user should be able to specify an encoding in the plugin configuration:
> UTF-8
> or use ${project.build.sourceEncoding} as default encoding, and only if this
> is not provided fallback to the platform encoding.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GERONIMO-6776) Let specify encoding for generated files
[
https://issues.apache.org/jira/browse/GERONIMO-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155402#comment-17155402
]
Romain Manni-Bucau commented on GERONIMO-6776:
--
Hi
Makes sense for me, justwonder ifdefault shouldnt be utf8 in all cases?
Wdyt?
> Let specify encoding for generated files
>
>
> Key: GERONIMO-6776
> URL: https://issues.apache.org/jira/browse/GERONIMO-6776
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: geronimo-maven-plugin
>Affects Versions: OpenAPI_1.0.12
>Reporter: Antoni Reus
>Priority: Trivial
> Attachments: encoding.patch
>
>
> Currently the geronimo-openapi-maven-plugin uses a FileWriter to generate the
> openapi.json. This defaults to de platform encoding.
>
> The user should be able to specify an encoding in the plugin configuration:
> UTF-8
> or use ${project.build.sourceEncoding} as default encoding, and only if this
> is not provided fallback to the platform encoding.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
