[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107667#comment-13107667 ] Han Hong Fang commented on GERONIMODEVTOOLS-764: Good supplement, Yi Xiao. Committed at revision: 1172496. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, controlBundleStartLevel_764_2.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091553#comment-13091553 ] Han Hong Fang commented on GERONIMODEVTOOLS-764: Commit the changes at revision: 1161984 to show the popup menu only when the selection is standalone OSGi bundle. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13090121#comment-13090121 ] Han Hong Fang commented on GERONIMODEVTOOLS-764: Committed at revision: 1161030. Thanks Yi Xiao for the patch. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13090239#comment-13090239 ] Jarek Gawor commented on GERONIMODEVTOOLS-764: -- Can you please check first if the change bundle level popup shows up on any module? It should only show up on bundle projects and only on standalone projects (not part of eba). Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13090725#comment-13090725 ] Han Hong Fang commented on GERONIMODEVTOOLS-764: Good catch! Thanks Jarek. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079893#comment-13079893 ] Yi Xiao commented on GERONIMODEVTOOLS-764: -- The newest patch is controlBundleStartLevel_764_1.patch, it depends on the patch of GERONIMODEVTOOLS-759 Now, the default start level is separated from the server, when the eclipse is shutting down, the value persists to a local file automatically and retrieves when eclipse starts up. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, controlBundleStartLevel_764_1.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066761#comment-13066761 ] Yi Xiao commented on GERONIMODEVTOOLS-764: -- Thanks for your comments. 14 I will make the configuration in my editor~ 2 Yes, I agree with your option #3. I will add some descriptions to illustrate that change the default start level will not effect the server side. 3 I will create the BundleInfo in OSGiModuleHandler and persist the BundleInfo in GEP for more bundle osgi control. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065765#comment-13065765 ] Yi Xiao commented on GERONIMODEVTOOLS-764: -- The patch add a section named Default OSGI Bundle Start Level in server page to control all the user bundle's start level, and also, add a menu item when right click the module in servers view named Change Start Level to control a single bundle's start level. I will attach pics to show them. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13066029#comment-13066029 ] Jarek Gawor commented on GERONIMODEVTOOLS-764: -- A few comments: 1) Make sure you configure your editor to use spaces instead of tabs (per our coding standards). 2) I'm confused about setting the default start level. It looks like the user can set the default start level in the server configuration in Eclipse but the code also looks up the default start level from the server. And changing the level in Eclipse won't be saved in the server configuration. So I think we have a few options: 1) Eclipse shouldn't be allowed the change the default start level at all or 2) If the default start level is changed in Eclipse it should save the server configuration as well, or 3) make the default start level in Eclipse completely separate from the server's (and be persistent between Eclipse restarts). Right now I think my preference would be for option #3. 3) Don't modify the AriesHelper.BundleInfo. BundleInfo was supposed to be somewhat private to AriesHelper class. Instead maybe rename AriesHelper.BundleInfo to AriesHelper.ProjectInfo (or something like that) and create your own BundleInfo for the OSGiModuleHadler purposes. 4) Don't forget about the Apache headers for the new files. Control the OSGI bundle's start level in GEP Key: GERONIMODEVTOOLS-764 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764 Project: Geronimo-Devtools Issue Type: Sub-task Components: eclipse-plugin Affects Versions: 3.0 Environment: WinXP sp3 32bit Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1SR2 Reporter: Yi Xiao Assignee: Yi Xiao Labels: OSGI, startLevel Fix For: 3.0 Attachments: controlBundleStartLevel_764.patch, defaultStartLevel.jpg, singleStartLevel.jpg 1 Provide a UI interface to control all the bundles' start level 2 Control the specific bundle's start level easily -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
