[jira] Commented: (DAYTRADER-20) Daytrader ear includes lots of kitchen sinks
[ https://issues.apache.org/jira/browse/DAYTRADER-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463572 ] Christopher James Blythe commented on DAYTRADER-20: --- Hmmm. I haven't noted this at all when building from the 1.2 branch. The only jar/war files that are packaged inside the ear are the ones that should be there... Did you make any changes to the 1.2 branch to fix this? Can this issue be closed? Archive: daytrader-ear-1.2-SNAPSHOT.ear testing: META-INF/OK testing: META-INF/MANIFEST.MF OK testing: dt-ejb.jar OK testing: streamer.jar OK testing: wsappclient.jar OK testing: web.war OK testing: META-INF/LICENSE.txt OK testing: META-INF/application.xml OK testing: META-INF/NOTICE.txt OK testing: META-INF/maven/ OK testing: META-INF/maven/org.apache.geronimo.daytrader/ OK testing: META-INF/maven/org.apache.geronimo.daytrader/daytrader-ear/ OK testing: META-INF/maven/org.apache.geronimo.daytrader/daytrader-ear/pom.xml OK testing: META-INF/maven/org.apache.geronimo.daytrader/daytrader-ear/pom.properties OK > Daytrader ear includes lots of kitchen sinks > > > Key: DAYTRADER-20 > URL: https://issues.apache.org/jira/browse/DAYTRADER-20 > Project: DayTrader > Issue Type: Bug > Components: buildsystem >Affects Versions: 1.2 >Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2 > > > Currently the ear includes about 10-15 dependent jars it shouldn't. The m2 > dependency scopes need to be adjusted to fix this. > I'll fix this in trunk (2.0), also an issue in 1.2 branch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-20) Daytrader ear includes lots of kitchen sinks
[ http://issues.apache.org/jira/browse/DAYTRADER-20?page=comments#action_12454739 ] David Jencks commented on DAYTRADER-20: --- When you build the daytrader ear with maven 2, you get lots and lots of jars inside that shouldn't be there. I fixed this in daytrader 2.0, but not 1.2. Only daytrader jars/wars should be inside the daytrader ear and wars. My build of 2.0 is about 963103 bytes. If its significantly larger, there are jars inside that shouldn't be there. Before the fix it was something like 20 mb. > Daytrader ear includes lots of kitchen sinks > > > Key: DAYTRADER-20 > URL: http://issues.apache.org/jira/browse/DAYTRADER-20 > Project: DayTrader > Issue Type: Bug > Components: buildsystem >Affects Versions: 1.2 >Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2 > > > Currently the ear includes about 10-15 dependent jars it shouldn't. The m2 > dependency scopes need to be adjusted to fix this. > I'll fix this in trunk (2.0), also an issue in 1.2 branch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-20) Daytrader ear includes lots of kitchen sinks
[ http://issues.apache.org/jira/browse/DAYTRADER-20?page=comments#action_12454734 ] Christopher James Blythe commented on DAYTRADER-20: --- David... Are you referring to all of the spec dependencies that are riddled throughout the pom.xml files or the actual code dependencies between the Daytrader modules/jars? Chris > Daytrader ear includes lots of kitchen sinks > > > Key: DAYTRADER-20 > URL: http://issues.apache.org/jira/browse/DAYTRADER-20 > Project: DayTrader > Issue Type: Bug > Components: buildsystem >Affects Versions: 1.2 >Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2 > > > Currently the ear includes about 10-15 dependent jars it shouldn't. The m2 > dependency scopes need to be adjusted to fix this. > I'll fix this in trunk (2.0), also an issue in 1.2 branch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
