[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12450443 ] Piyush Agarwal commented on DAYTRADER-22: - Chris, Thanks for that overview of the modes. Makes things quite clearer now. Also I guess you have volunteered yourself for doing the modes cleanup work ;-) But I agree the runtime modes above are the ones that we need, plus a seperate category for JMS Support Enablement. I will do the Publish Quote Updates part and submit that patch by re-opening this JIRA. The Process Buy/Sell should be just renaming the matter of renaming Aysnc 2-phase once the Async 1-phase has been removed. I will leave that to you for DT-23. Cheers! Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12449715 ] Christopher James Blythe commented on DAYTRADER-22: --- All... Since my involvement with Daytrader (and Trade), we've never been all that concerned with the Async 1-phase mode. Here is the lay of the land to my understanding... Sync mode - Uses JMS topics and TradeTopicMDB to publish changes to the quote prices - There is flag in the DDs to disable this but it doesn't seem to apply to direct mode (only EJB mode) Async 2-phase mode - This mode uses a JMS queue and the TradeBroker to handle order processing - Specifically, the buy and sell operations call a queueOrder method to place a message on the queue - The queueOrder is part of an XA transaction because two resource managers (JMS and database) are involved to create the order in the databse and place a message on the queue - The MDB starts a new transaction when the message is read from the queue. The MDB then executes the completeOrder method which updates the order in the database inside the original MDB transaction context Async 1-phase mode - Does the same as above, but does not involve an UserTransaction to provide XA - Since the MDB is container-managed, TradeEJB is used to complete the order and create a new transaction (avoiding XA) My guess is that the Async 1-phase mode was added to messure the overhead associated with handling the XA transaction. I think Andrew Spyker was partly responsible for adding this... so, let me see if I can track him down to get more details. Regardless, I have never found that much value in Async 1-phase mode. If you are using two different resources as part of a logical transaction, you should always use XA to ensure proper rollback handling. Honestly, I see very little need to keep it around... However, there might be some possiblities I have not considered. Removing this option (and associated dependency) would also make it easier to decouple the app as suggested in Daytrader-23. I like the idea of splitting up the modes by category and doing a little renaming to make them more descriptive. Persistence Run-time Modes (one has to be selected) 1) Direct (or JDBC) 2) Stateless Session Bean to Direct 3) Full EJB (Stateless Session Bean to Entity Beans) JMS Support Enablement (any can be selected) - Publish Quote Updates (Publish quote price changes to a JMS topic) - Process Buy/Sell Orders using XA (Asychronously process buy/sell orders by placing them on a JMS queue. An MDB is then responsible for reading a message form the queue and completing the order) Thoughts? Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12449378 ] Matt Hogstrom commented on DAYTRADER-22: Sounds good Piyush. So this raises the $64k dollar question about what modes shoud run and how do they get loaded? In direct mode I think it would be beneficial to not require any EJBs but still use JMS. Perhaps we should open a separate JIRA to address the decoupling of components in DT. Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
Matt...I've been looking into the de-coupling topic and have some ideas... will post a short explanation later today once I can put a diagram together.ChrisOn 11/13/06, Matt Hogstrom (JIRA) dev@geronimo.apache.org wrote: [ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12449378 ]Matt Hogstrom commented on DAYTRADER-22: Sounds good Piyush.So this raises the $64k dollar question about what modes shoud run and how do they get loaded?In direct mode I think it would be beneficial to not require any EJBs but still use JMS.Perhaps we should open a separate JIRA to address the decoupling of components in DT. Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: BugComponents: EJB TierAffects Versions: 1.2Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. --This message is automatically generated by JIRA.-If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa -For more information on JIRA, see: http://www.atlassian.com/software/jira-- I say never be complete, I say stop being perfect, I say let... lets evolve, let the chips fall where they may. - Tyler Durden
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12449503 ] Piyush Agarwal commented on DAYTRADER-22: - Matt, the only dependency on EJBs within the TradeDirect code is in the Asynch 1-phase mode. It seems that the dependency on EJBs is due to need for support of multiple transactions within each other but not clear on that. Does anyone use the Async 1-phase mode. Wouldn't the Async 2-phase be the relevant one? If no one is using the Async 1-phase then we can remove it and simplify the runtime modes to be 1) Direct 2) EJB 3) Asynch 2-phase (or Enable TradeBroker) The publishQuotePriceChange would be another flag with the name Enable TradeStreamer. We can provide explanations of each of these in detail. Anything I overlooked ? Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12448808 ] Piyush Agarwal commented on DAYTRADER-22: - I will investigate to make this a configuration property so that it can be changed in an easier user-friendly fashion. Once I have something I will go ahead and re-open the issue Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12448828 ] Matt Hogstrom commented on DAYTRADER-22: Thanks Piyush...I should add that it was confusing about what a particular runtime mode was actually composed of. There is JDBC mode, EJB mode, long run, no long run, JMS pulishing or not, etc. I think as we noodle on this we should probably add a Runtime Settings: that would allow people to get a summary of the modes in effect. Thanks for thinking about this. Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DAYTRADER-22) Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs
[ http://issues.apache.org/jira/browse/DAYTRADER-22?page=comments#action_12448841 ] Piyush Agarwal commented on DAYTRADER-22: - That sounds like a good idea, what do you have in mind, where exactly are you thinking of having the Runtime Settings section? I was thinking we can re-arrange the related settings together on the config page, also possibly have a better explanation on these in some kind of documentation. Currently when you do Reset the runtime summary gets printed out, but its not complete wrt to the settings you mentioned above. Continuing on the issue at hand, I looked at the code and it seems the publishQuotePriceChange flag in ejb-jar.xml has no effect if you are running in Direct Mode as TradeDirect has this value set to True and it doesnt look it up from any of the config xmls neither it is exposed in TradeConfig. Only during EJB mode the TradeBean.java looks it from ejb-jar.xml. So in direct mode we have the MDBs running no matter what. I think we need to fix this so the flag is effective in both the Direct and EJB runtime modes. I am proposing exposing it through the configuration panel, so that user can set its value. The TradeConfigServlet will update the value in TradeConfig. Both Direct and EJB modes during init will check the value from TradeConfig and act accordingly. Once this is done we can remove the flag from the ejb-jar.xml Suggestions/Comments ? Set publichQuotePriceChange to true in ejb-jar.xml so that MDBs get accessed during Daytrader scenario runs --- Key: DAYTRADER-22 URL: http://issues.apache.org/jira/browse/DAYTRADER-22 Project: DayTrader Issue Type: Bug Components: EJB Tier Affects Versions: 1.2 Reporter: Piyush Agarwal Assigned To: Matt Hogstrom Fix For: 1.2 Attachments: Daytrader-22.patch Currently the publishQuotePriceChange is set to False in the ejb-jar.xml and this causes the TradeStreamerMDB to NOT be accessed during the Daytrader trading runs. The TradeStreamerMDB listens to the JMS messages and invokes the logging code to log the debug and trace messages during the runs. Updating the flag to true enables this functionality. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
