[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12369886 ] Prasad Kashyap commented on GERONIMO-1659: -- Hmm.. I don't seem to have any problem with this module. I run it on Win XP. All the tests run fine, no matter from where I run it. Cheers Prasad > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, > org.apache.geronimo.system.serverinfo.ServerInfoTest.txt, pom.patch, > system-m2-migration-new.patch, system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12369828 ] Jacek Laskowski commented on GERONIMO-1659: --- I don't understand this. The module builds fine. All of the below commands finished successfully. Could you please take a look at the appropriate reports to see what's wrong? $ cd $GERONIMO_SOURCES_HOME $ svn info Path: . URL: https://svn.apache.org/repos/asf/geronimo/trunk Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68 Revision: 384740 ... $ mvn -o -Dmodule=system clean test ... [INFO] BUILD SUCCESSFUL ... $ cd modules/system $ mvn -o -Dmodule=system clean test ... [INFO] BUILD SUCCESSFUL ... $ mvn -o clean test ... [INFO] BUILD SUCCESSFUL ... > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, pom.patch, > system-m2-migration-new.patch, system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12369781 ] Anita Kulshreshtha commented on GERONIMO-1659: -- I am still seeing test failures with rev 384583. The surefire-reports directory is not even created. Is anyone else seeing this? Is it a windows only problem? > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12369425 ] Jacek Laskowski commented on GERONIMO-1659: --- The geronimo-timestamp-plugin is in the Sandbox repo since 384169. See GERONIMO-1710 for more information. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368939 ] Anita Kulshreshtha commented on GERONIMO-1659: -- There are test failures in the system module. surefore-reports dir is not even created! > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368291 ] Jacek Laskowski commented on GERONIMO-1659: --- Sounds good, I'll put it in there. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368280 ] Anders Hessellund Jensen commented on GERONIMO-1659: I definitely think we should use the plugin, perhaps not right away, though. I intend to put some more work into the plugin, so it will be as featureful as the Ant TStamp core plugin. The plugin approach is easier and reusable if we need to generate timestamps elsewhere. Perhaps the plugin could go into the sandbox until it has been polished up? > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368234 ] Jacek Laskowski commented on GERONIMO-1659: --- $ svn ci src/filtered-resources pom.xml Sendingpom.xml Adding src/filtered-resources Adding src/filtered-resources/org Adding src/filtered-resources/org/apache Adding src/filtered-resources/org/apache/geronimo Adding src/filtered-resources/org/apache/geronimo/system Adding src/filtered-resources/org/apache/geronimo/system/serverinfo Adding src/filtered-resources/org/apache/geronimo/system/serverinfo/geronimo-version.properties Transmitting file data .. Committed revision 381942. NOTE: Partial commit without the maven-timestamp-plugin since I didn't know where I should've put it in and if it's really necessary. I think we could generate relevant information using maven-ant(run)-plugin. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, system-m2-migration-new.patch, > system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368117 ] Prasad Kashyap commented on GERONIMO-1659: -- Good idea. Anders, instead of that patch , what say you create a geronimo plugin that could be reused by other modules if need be. And if maven wants it, it could be more easily given to them by changing the groupid and artifactid. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Attachments: system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368113 ] Anders Hessellund Jensen commented on GERONIMO-1659: I wrote a mail to the maven developer list regarding a timestamp plugin. I proposed an idea on how it could work, and if they are positive about it I'll go ahead and write the plugin. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Attachments: system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1659) system module migration to Maven 2
[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12368110 ] Anders Hessellund Jensen commented on GERONIMO-1659: There is an issue with migrating the system module to Maven 2. The problem is to generate a correct geronimo-version.properties file. The geronimo-version.properties looks like this: # Generated by Maven version=1.2-SNAPSHOT build.date=2006.02.28 build.time=15:51:07.734+0100 copyright=Copyright (C) 2003-2006, The Apache Software Foundation The problem is to substitute correct timestamps in the properties file. There is, as far as I now, no M2 plugin to to this. I have created a patch that uses the antrun plugin and the propertyfile ant task. This way i manage to generate everything except the year part of the copyright property, so when applying the patch the file would look like this: version=1.2-SNAPSHOT build.date=2006.02.28 build.time=15:51:07.734+0100 copyright=Copyright (C) 2003-, The Apache Software Foundation The optimal solution to this would be write a M2 plugin that is capable of defining timestamps as M2 properties and use the resource filtering mechanism of M2 to substitute these properties into the properties file. Timestamping is undoubtly needed by other projects as well, so the plugin should be contributed back to the M2 project. > system module migration to Maven 2 > -- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
