[jira] Commented: (GERONIMO-1981) Web Connector has GBean=(container name) in AbstractName

2006-05-14 Thread Aaron Mulder (JIRA)
[ 
http://issues.apache.org/jira/browse/GERONIMO-1981?page=comments#action_12402249
 ] 

Aaron Mulder commented on GERONIMO-1981:


It looks like the GBean=JettyWebContainer part of the ObjectName is only added 
to the ObjectName of a web connector added at runtime.  The code that generates 
this name is JettyManagerImpl:75 and TomcatManagerImpl:77

 Web Connector has GBean=(container name) in AbstractName
 

  Key: GERONIMO-1981
  URL: http://issues.apache.org/jira/browse/GERONIMO-1981
  Project: Geronimo
 Type: Bug
 Security: public(Regular issues) 
   Components: kernel
 Versions: 1.1
 Reporter: Aaron Mulder
 Assignee: Aaron Mulder
 Priority: Blocker
  Fix For: 1.1


 The GBean name for the default Jetty AJP connector appears to be (forgive the 
 URL encoding but this came from the console):
 geronimo%2Fjetty%2F1.1-SNAPSHOT%2Fcar%3FGBean%3DJettyWebContainer%2CServiceModule%3Dgeronimo%2Fjetty%2F1.1-SNAPSHOT%2Fcar%2Cj2eeType%3DGBean%2Cname%3DJettyAJP13Connector
 The problem is the part of the connector name that appears to say 
 GBean=JettyWebContainer
 I believe that was introduced in an attempt to have a standard JSR-77 
 component list its parent module with its parent module type, but that 
 doesn't seem to make sense for parents of type GBean.  Can we remove the 
 ParentType=ParentName block for parents of type GBean?
 If not, then we have a bug that when creating a new web connector we don't 
 add the ParentType=ParentName block.  e.g., see 
 JettyManagerImpl.addConnector, which runs this:
 AbstractName name = kernel.getNaming().createChildName(containerName, 
 uniqueName, NameFactory.GERONIMO_SERVICE);
 And that gets a name without the GBean=JettyWebConnector, which means even if 
 the name= component is the same as an existing connector, it comes out with a 
 distinct AbstractName.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (GERONIMO-1981) Web Connector has GBean=(container name) in AbstractName

2006-05-05 Thread David Jencks (JIRA)
[ 
http://issues.apache.org/jira/browse/GERONIMO-1981?page=comments#action_12378077
 ] 

David Jencks commented on GERONIMO-1981:


I looked in the log and the ajp connector abstract name is

geronimo/jetty/1.1-SNAPSHOT/car?ServiceModule=geronimo/jetty/1.1-SNAPSHOT/car,j2eeType=GBean,name=JettyAJP13Connector

I can't figure out where you are finding what you pasted.

 Web Connector has GBean=(container name) in AbstractName
 

  Key: GERONIMO-1981
  URL: http://issues.apache.org/jira/browse/GERONIMO-1981
  Project: Geronimo
 Type: Bug
 Security: public(Regular issues) 
   Components: kernel
 Versions: 1.1
 Reporter: Aaron Mulder
 Assignee: David Jencks
 Priority: Blocker
  Fix For: 1.1


 The GBean name for the default Jetty AJP connector appears to be (forgive the 
 URL encoding but this came from the console):
 geronimo%2Fjetty%2F1.1-SNAPSHOT%2Fcar%3FGBean%3DJettyWebContainer%2CServiceModule%3Dgeronimo%2Fjetty%2F1.1-SNAPSHOT%2Fcar%2Cj2eeType%3DGBean%2Cname%3DJettyAJP13Connector
 The problem is the part of the connector name that appears to say 
 GBean=JettyWebContainer
 I believe that was introduced in an attempt to have a standard JSR-77 
 component list its parent module with its parent module type, but that 
 doesn't seem to make sense for parents of type GBean.  Can we remove the 
 ParentType=ParentName block for parents of type GBean?
 If not, then we have a bug that when creating a new web connector we don't 
 add the ParentType=ParentName block.  e.g., see 
 JettyManagerImpl.addConnector, which runs this:
 AbstractName name = kernel.getNaming().createChildName(containerName, 
 uniqueName, NameFactory.GERONIMO_SERVICE);
 And that gets a name without the GBean=JettyWebConnector, which means even if 
 the name= component is the same as an existing connector, it comes out with a 
 distinct AbstractName.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira