[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12421765 ] Leonard Wu commented on GERONIMO-2167: -- Thanks for the diagnosis. You were quite right. Closing the resources released the lock and solved the problem. Just the InputStreamReader and BufferedReader were enough, didn't have to close any HSQL connection. And I agree, G should handle such rogue coding (thankfully not my own) more gracefully. > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: deployment >Affects Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 >Reporter: Leonard Wu > Assigned To: Kevan Miller > Fix For: 1.1.1 > > Attachments: dwr-demo.war, jw-0620-dwr.zip > > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12421573 ] Kevan Miller commented on GERONIMO-2167: Leonard, thanks for the source. I'm certain that the following line of code from ContextListener.contextInitialized() is at the root of your problem: InputStreamReader in = new InputStreamReader(getClass().getClassLoader().getResourceAsStream("db.sql")); db.sql is the "file" that's being locked by Windows. Right now, your contextDestroyed() method is not doing anything. I'd prefer to see it closing your HSQL connection and insuring that the above InputStreamReader has been closed. I'm pretty confident that if you close the above InputStream, undeploy will work properly... I'm leaving the jira open a bit longer, it's possible that we could/should avoid this situation. Geronimo should be able to deploy/undeploy an app, even if it's not "well-behaved". I'm going to think about this... > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: deployment >Affects Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 >Reporter: Leonard Wu > Assigned To: Kevan Miller > Fix For: 1.1.1 > > Attachments: dwr-demo.war, jw-0620-dwr.zip > > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12421485 ] Leonard Wu commented on GERONIMO-2167: -- You know. I had a thought. That webapp actually uses a inbuilt Java database, HSQL. I suspect that the lock isn't released quick enough by the running HSQL while the app was being shutdown. Now that I've tried other webapps, I can confirm that all the other ones deployed and undeployed perfectly. So it would appear that the deploy problem is specific to my unlucky choice of test app. And, I personally have no real reason to choose HSQL over the G internal Derby, either :) so this is no longer a problem for me. Assuming that you are still determined to iron out all kinks in G, please see the newly attached sources for the orginal test app. I've included IntelliJ v5 project files in case you happen to be using that. > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: deployment >Affects Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 >Reporter: Leonard Wu > Assigned To: Kevan Miller > Fix For: 1.1.1 > > Attachments: dwr-demo.war > > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12420391 ] Kevan Miller commented on GERONIMO-2167: OK. It does look like a Windows file locking problem. Furthermore, it's only happening on Tomcat, not Jetty (at least in this usage scenario). The file that's not being cleaned up is repository/littleoldme/dwrdemo/1.1/dwrdemo-1.1.war/WEB-INF/classes/db.sql > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Type: Bug > Security: public(Regular issues) > Components: deployment > Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 > Reporter: Leonard Wu > Assignee: Kevan Miller > Fix For: 1.1.1 > Attachments: dwr-demo.war > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12420192 ] Kevan Miller commented on GERONIMO-2167: Leonard, thanks much for the test case. I haven't been able to reproduce on MAC OSX. I'm afraid that this is going to be a Windows-based file locking gremlin. I suspect that the undeploy cleanup is not finished before we're starting the deploy phase of a redeploy. If you have a moment or two, would be interesting to know if the following works/fails: 1) deploy 2) undeploy (not redeploy) 3) wait 1 minute 4) deploy Meanwhile, I'll dust off my windoze box and see what I can find... > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Type: Bug > Security: public(Regular issues) > Components: deployment > Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 > Reporter: Leonard Wu > Assignee: Kevan Miller > Fix For: 1.1.1 > Attachments: dwr-demo.war > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
[ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12419630 ] Leonard Wu commented on GERONIMO-2167: -- deployment plan, geronimo-web.xml is included in the WAR > deployer.jar not cleaning up properly during redeploy and undeploy > -- > > Key: GERONIMO-2167 > URL: http://issues.apache.org/jira/browse/GERONIMO-2167 > Project: Geronimo > Type: Bug > Security: public(Regular issues) > Components: deployment > Versions: 1.1 > Environment: Win32/XP SP1 > Sun JDK 1.5_06 > Reporter: Leonard Wu > Attachments: dwr-demo.war > > deployment using deploy.jar doesn't appear to clean up correctly. > first deploy always works. subsequent re-deploy and un-deploy are problematic. > following illustrates the full sequence of events as i had encountered: > -- > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager deploy D:/work/SERVER/dwr-demo.war > Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Deployed littleoldme/dwrdemo/1.1/war > Started littleoldme/dwrdemo/1.1/war > Redeployed littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war > No ModuleID or TargetModuleID provided. Attempting to guess based > on the content of the archive. > Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war' > Stopped littleoldme/dwrdemo/1.1/war > Unloaded littleoldme/dwrdemo/1.1/war > Uninstalled littleoldme/dwrdemo/1.1/war > Error: Operation failed: > org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException: > Configuration already exists: littleoldme/dwrdemo/1.1/war > Configuration already exists: littleoldme/dwrdemo/1.1/war > D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar > deployer.ja > r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war > Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name > of a module available on the selected server. Perhaps it has already > been stopped or undeployed? If you're trying to specify a > TargetModuleID, use the syntax TargetName|ModuleName instead. If > you're not sure what's running, try the list-modules command. > -- > While in this broken state, i'm able to recover by manually removing the > ${geronimo}/repository/littleoldme directory and removing the one line in > ${geronimo}/var/config/config.xml that says > > However, this only gets me to a fresh beginning, and then the whole sequence > starts again as I repeat (re/un)deploying. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira