[jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders
[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433879 ] Jeff Genender commented on GERONIMO-2383: - +1. Replace ENCConfigBuilder with a pluggable set of NamingBuilders --- Key: GERONIMO-2383 URL: http://issues.apache.org/jira/browse/GERONIMO-2383 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Affects Versions: 1.2 Reporter: David Jencks Assigned To: David Jencks Fix For: 1.2 Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch (Previously part of GERONIMO-2349) The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders
[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433993 ] Matt Hogstrom commented on GERONIMO-2383: - +1 ... apply away Replace ENCConfigBuilder with a pluggable set of NamingBuilders --- Key: GERONIMO-2383 URL: http://issues.apache.org/jira/browse/GERONIMO-2383 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Affects Versions: 1.2 Reporter: David Jencks Assigned To: David Jencks Fix For: 1.2 Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch (Previously part of GERONIMO-2349) The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders
[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433680 ] Gianny Damour commented on GERONIMO-2383: - It seems that there is a small issue with the patch: AxisBuilder does not more implement ServiceReferenceBuilder; however, its GBeanInfo still declares this interface has been implemented. This causes a small problem when trying to load the axis-builder module. Anyway, simply need to remove it manually. I still need to do some testings; thought, by reviewing the change sets, it seems to be a great refactoring. Althought, it seems that it is possible to have a successful deployment which is actually not successful (for instance if a NamingBuilder is wrongly stopped, then some naming elements may not be honored.). Replace ENCConfigBuilder with a pluggable set of NamingBuilders --- Key: GERONIMO-2383 URL: http://issues.apache.org/jira/browse/GERONIMO-2383 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Affects Versions: 1.2 Reporter: David Jencks Assigned To: David Jencks Fix For: 1.2 Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch (Previously part of GERONIMO-2349) The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders
[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433684 ] Gianny Damour commented on GERONIMO-2383: - I have tested env-entry and resource-ref and this works as expected. +1 to apply it. Replace ENCConfigBuilder with a pluggable set of NamingBuilders --- Key: GERONIMO-2383 URL: http://issues.apache.org/jira/browse/GERONIMO-2383 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Affects Versions: 1.2 Reporter: David Jencks Assigned To: David Jencks Fix For: 1.2 Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch (Previously part of GERONIMO-2349) The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders
[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433713 ] David Jencks commented on GERONIMO-2383: re gianni's comment: Althought, it seems that it is possible to have a successful deployment which is actually not successful (for instance if a NamingBuilder is wrongly stopped, then some naming elements may not be honored.). I'm aware of this, and think that we can add a set of required qnames to the NamingBuilderCollection. Then we add e.g. all the j2ee 1.4 jndi elements to it. The main work is writing a property editor or xml-attribute editor for a qname set. I'm thinking of doing this after this patch is applied as a bug fix, but might get to it sooner. Replace ENCConfigBuilder with a pluggable set of NamingBuilders --- Key: GERONIMO-2383 URL: http://issues.apache.org/jira/browse/GERONIMO-2383 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Affects Versions: 1.2 Reporter: David Jencks Assigned To: David Jencks Fix For: 1.2 Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch (Previously part of GERONIMO-2349) The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
