[jira] Commented: (GERONIMO-2752) Axis2 integration displays invalid information for URL requests
[ https://issues.apache.org/jira/browse/GERONIMO-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465978 ] Jacek Laskowski commented on GERONIMO-2752: --- Reviewed and it looked fine. Sending modules/geronimo-axis2/src/main/java/org/apache/geronimo/axis2/Axis2WebServiceContainer.java Transmitting file data . Committed revision 497732. Please, create patches from within Geronimo directory. 'GERONIMO-issue-id-consecutive-number-when-more-patches-available.patch' format would be highly appreciated. Axis2 integration displays invalid information for URL requests --- Key: GERONIMO-2752 URL: https://issues.apache.org/jira/browse/GERONIMO-2752 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: webservices Affects Versions: 2.0-M1 Reporter: Lasantha Ranaweera Assigned To: Jacek Laskowski Attachments: GERONIMO-2752.patch1, GERONIMO-2752.patch2, GERONIMO-2752.patch3 Current integration of Axis2 gives wrong information to the wsdl, wsdl2, xsd= .. etc URL requests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2752) Axis2 integration displays invalid information for URL requests
[ https://issues.apache.org/jira/browse/GERONIMO-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465981 ] Lasantha Ranaweera commented on GERONIMO-2752: -- Thanks Jacek! I will follow the your proposed patch file format. Still there is a problem in the ?xsd and ?xsd= requests. I will come up with a solution for that soon. Axis2 integration displays invalid information for URL requests --- Key: GERONIMO-2752 URL: https://issues.apache.org/jira/browse/GERONIMO-2752 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: webservices Affects Versions: 2.0-M1 Reporter: Lasantha Ranaweera Attachments: GERONIMO-2752.patch1, GERONIMO-2752.patch2, GERONIMO-2752.patch3 Current integration of Axis2 gives wrong information to the wsdl, wsdl2, xsd= .. etc URL requests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2752) Axis2 integration displays invalid information for URL requests
[
https://issues.apache.org/jira/browse/GERONIMO-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465949
]
Lin Sun commented on GERONIMO-2752:
---
I have reviewed the patch. There is a small error here below. The 'return;'
should not be deleted.
@@ -237,18 +246,11 @@
}
}
if (uri.getQuery().startsWith(wsdl)) {
-String serviceName = path.substring(path.lastIndexOf(/) + 1);
-HashMap services =
configurationContext.getAxisConfiguration().getServices();
-final AxisService service = (AxisService)
services.get(serviceName);
-if (service != null) {
-service.printWSDL(response.getOutputStream(),
uri.getHost(), servicePath);
-return;
-}
+ if(service != null){
+ service.printWSDL(response.getOutputStream(),
uri.getHost(), servicePath);
+ }
I think the patch works but the original solution works too, except that it may
not work if the uri contains '?wsdl2'. But if you replace the line below it
should work.
if (uri.getQuery().startsWith(wsdl2)) {
-String serviceName = path.substring(path.lastIndexOf(/) + 1,
path.length() - 6);
+ String serviceName = path.substring(path.lastIndexOf(/) + 1);
Overall I don't see a big benefit of using the new proposed approach - use
(AxisService)(services.values().iterator().next()) to get the AxisService while
the original approach - use (AxisService) services.get(serviceName) to get the
AxisService. I think both work well in my simple scenario, but I could easily
have missed something.:-)
Lin
Axis2 integration displays invalid information for URL requests
---
Key: GERONIMO-2752
URL: https://issues.apache.org/jira/browse/GERONIMO-2752
Project: Geronimo
Issue Type: Bug
Security Level: public(Regular issues)
Components: webservices
Affects Versions: 2.0-M1
Reporter: Lasantha Ranaweera
Attachments: GERONIMO-2752.patch1, GERONIMO-2752.patch2
Current integration of Axis2 gives wrong information to the wsdl, wsdl2, xsd=
.. etc URL requests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2752) Axis2 integration displays invalid information for URL requests
[ https://issues.apache.org/jira/browse/GERONIMO-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465955 ] Davanum Srinivas commented on GERONIMO-2752: Lasantha, Please submit a new patch. thanks, dims Axis2 integration displays invalid information for URL requests --- Key: GERONIMO-2752 URL: https://issues.apache.org/jira/browse/GERONIMO-2752 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: webservices Affects Versions: 2.0-M1 Reporter: Lasantha Ranaweera Attachments: GERONIMO-2752.patch1, GERONIMO-2752.patch2 Current integration of Axis2 gives wrong information to the wsdl, wsdl2, xsd= .. etc URL requests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2752) Axis2 integration displays invalid information for URL requests
[ https://issues.apache.org/jira/browse/GERONIMO-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465962 ] Lasantha Ranaweera commented on GERONIMO-2752: -- Please use the patch3 for the reviewing. It will resolve some NPE some of URL requests additionally. Lin, The major difference between latest approach and previous one is the way it calculates 'serviceName' parameter and taking out AxisService from list of services. In previous approach we are calculating 'serviceName' out of URL request and tried to use it as our 'serviceName'. It is correct for the Axis2 related service access but not for JAXWS since we are giving servlet URL to the access services. This is not the name given to the AxisService in the services HashMap. Latest approach I am directly take the serviceName out list of services HashMap. The way our implementation work for each service in the webservices.xml file it will create different Axis2WebServiceContainer object. So the list of services in the ConfigurationContext won't exceed 1 and we can take Axis2Service without any problem. Dims please correct me if I am wrong here :-). thanks, Lasantha Axis2 integration displays invalid information for URL requests --- Key: GERONIMO-2752 URL: https://issues.apache.org/jira/browse/GERONIMO-2752 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: webservices Affects Versions: 2.0-M1 Reporter: Lasantha Ranaweera Attachments: GERONIMO-2752.patch1, GERONIMO-2752.patch2, GERONIMO-2752.patch3 Current integration of Axis2 gives wrong information to the wsdl, wsdl2, xsd= .. etc URL requests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
