[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533724 ] Anita Kulshreshtha commented on GERONIMO-3520: -- Could you please provide a test/application to test this patch? > missing jsr-77 stats for JTA > > > Key: GERONIMO-3520 > URL: https://issues.apache.org/jira/browse/GERONIMO-3520 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring, transaction manager >Affects Versions: 2.0.2, 2.1 > Environment: linux >Reporter: Viet Hung Nguyen > Attachments: geronimo-3520.patch, txmanagerStats.patch > > > we need to surface transaction statistics defined by the JSR 77 spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533925 ] Matt Hogstrom commented on GERONIMO-3520: - Viet, for the txmanager patch I think there may be an issue with the use of the static long. Since the access is not synchronized there exists a strong possibility of lost updates in a heavily concurrent system which would lead to inaccurate values. volatile is one way to address this problem but I don't think it is perfect on all VMs so I think the better solution would be the use of java.util.concurrent.atomic.AtomicLong .getAndIncrement() which should do the trick. Not sure of other folks have suggestions. > missing jsr-77 stats for JTA > > > Key: GERONIMO-3520 > URL: https://issues.apache.org/jira/browse/GERONIMO-3520 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring, transaction manager >Affects Versions: 2.0.2, 2.1 > Environment: linux >Reporter: Viet Hung Nguyen > Attachments: geronimo-3520.patch, > jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch > > > we need to surface transaction statistics defined by the JSR 77 spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534003 ] Anita Kulshreshtha commented on GERONIMO-3520: -- Viet, It might be possible to optimize the computation of ActiveCount by incrementing/decrementing a counter when ever the transactions are associated/disassociated instead of going through the Map every time. Could you please explain how/where the transactions are started in the attached application ear? > missing jsr-77 stats for JTA > > > Key: GERONIMO-3520 > URL: https://issues.apache.org/jira/browse/GERONIMO-3520 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring, transaction manager >Affects Versions: 2.0.2, 2.1 > Environment: linux >Reporter: Viet Hung Nguyen > Attachments: geronimo-3520.patch, > jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch > > > we need to surface transaction statistics defined by the JSR 77 spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534037 ] Viet Hung Nguyen commented on GERONIMO-3520: Anita, I thought since the application was using JMS, each message sent would be a transaction. > missing jsr-77 stats for JTA > > > Key: GERONIMO-3520 > URL: https://issues.apache.org/jira/browse/GERONIMO-3520 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring, transaction manager >Affects Versions: 2.0.2, 2.1 > Environment: linux >Reporter: Viet Hung Nguyen > Attachments: geronimo-3520.patch, > jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch > > > we need to surface transaction statistics defined by the JSR 77 spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3520) missing jsr-77 stats for JTA
[ https://issues.apache.org/jira/browse/GERONIMO-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535556 ] Anita Kulshreshtha commented on GERONIMO-3520: -- Txmaanger patch applied to rev 584554 at txmanager/trunk geronimo patch applied to rev 585497 with minor modifications, Nice Work Viet, Thanks! I have mistakenly entered wrong jira # 3250 in the logs, Sorry for the goof.. > missing jsr-77 stats for JTA > > > Key: GERONIMO-3520 > URL: https://issues.apache.org/jira/browse/GERONIMO-3520 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: monitoring, transaction manager >Affects Versions: 2.0.2, 2.1 > Environment: linux >Reporter: Viet Hung Nguyen >Assignee: Anita Kulshreshtha > Attachments: geronimo-3520.patch, > jms-mdb-sample-ear-2.0-SNAPSHOT.ear, txmanagerStats.patch > > > we need to surface transaction statistics defined by the JSR 77 spec. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
