[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565547#action_12565547 ] Joseph Leong commented on GERONIMO-3746: Update: Added an indicator message on the progress page to list an exception, if one is caught and a back button to bring the user back to the plugin install home page. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Kevan Miller > Attachments: GERONIMO-3746-2.patch, GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565459#action_12565459 ] Joseph Leong commented on GERONIMO-3746: Update: Basic-Auth screen was being caused by the output buffer being flushed on the page include. Turning off flushing fixed issue. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Kevan Miller > Attachments: GERONIMO-3746-2.patch, GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564806#action_12564806 ] Joseph Leong commented on GERONIMO-3746: Update: Wrapped up results page to display the summary correctly. Having the Done button bring you back to index page of plugin installer instead of viewplugindownload page. Tackling CRSF issue next. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > Attachments: GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564732#action_12564732 ] Joseph Leong commented on GERONIMO-3746: The continue form page isn't resolving the CRSF issue, will explicitly handle this with a new session pairing. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > Attachments: GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564532#action_12564532 ] Jarek Gawor commented on GERONIMO-3746: --- Btw, I just added PluginInstallerGBean.checkOnInstall(Object key, boolean remove) function to PluginInstallerGBean so you should be able to use this method to get the DownloadResults from any place without passing the DownloadResults around in the session (committed in revision 617267). Just make sure to call PluginInstallerGBean.checkOnInstall(key, true) somewhere at the end to remove the DownloadResults from the cache. In all other places use PluginInstallerGBean.checkOnInstall(key, false). > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > Attachments: GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564504#action_12564504 ] David Jencks commented on GERONIMO-3746: I applied the patch in rev 617243 with a couple of minor changes to eliminate a NPE I don't know if its due to the problems with DownloadResults but after the progress bar page I was taken to a "start the plugin" page which wasn't relevant because the plugin had already been started. Pushing the button took me back to the "choose plugins to install" page which also seems odd... I think I'd prefer to go back to the first "plugins" page where you choose whether to install more plugins, export plugins, or assemble a server. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > Attachments: GERONIMO-3746.patch > > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564350#action_12564350 ] Joseph Leong commented on GERONIMO-3746: Update: Getting close! The configIds array is now successfully passing to the DSHandler ActionAfterView. The previous issue was request.getParameterValues was returning a string to the array's memory reference... and i can't make any use of that in java. So i discovered looping through setting the the same hidden fields allows the getParameterValue to create the string[] in a usable form. Last piece getting the (DownloadResults) results from ProgressMonitor and patching up some small type issues with the configIdarray and bingo we'll have the results page and everything in the plugin installer will be good to go. -Joseph Leong > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563118#action_12563118 ] Joseph Leong commented on GERONIMO-3746: Update; This JIRA will now consolidate the progresses of JIRAS: GERONIMO-3778, GERONIMO-3788, GERONIMO-3781 due to the fact that these issues occur in several overlapping files. Thanks! Joseph Leong > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563030#action_12563030 ] Joseph Leong commented on GERONIMO-3746: In the upcoming patch: A check has been added to update the message / bar in the event results.isFinished() was returned true on the first poll. In addition, the getCurrentFilePercent is reflective of the progress of each individual file and not of the overall progress so the problem was not polling each individual progress fast enough to catch the '100%'. Polling speed increased slightly to catch the progress for the really small dependency files. Another check implemented at the end to fill the progress bar before redirecting to continue form. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562111#action_12562111 ] Jarek Gawor commented on GERONIMO-3746: --- Maybe that's what you mean by "a small aesthetic 250-500millisecond delay after the '100' values" but I think the key is to always update the bar (and maybe other info) to 100% (when the installation was successful) whether the while(!results.isFinished()) loop executes or not. Changing the loop delay will make the bar fill up nicer but it won't fix the problem especially when results.isFinished() returns true on the very first time. So I'm not sure we need to change the loop delay as long as we add code outside of the loop to update the bar accordingly. > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561978#action_12561978 ] Joseph Leong commented on GERONIMO-3746: Update: The progress bar isn't updating because the thread delay is set at an interval that isn't sampling the progress fast enough. Another factor occurring is that some of the plugins / dependencies we are downloading is so small that the bandwidth burst can grab it in one shot.. so there is no appearance of an incremental download. After the burst of this download, the download poller will grab a percent value of 0 (technically -1) immediately because it is querying the next file. Thus, the progress bar appearance for a lot of small files will seem as though nothing is downloading. In effect of this, i will be increasing the sampling time and implementing a small aesthetic 250-500millisecond delay after the '100' values so the user can see a full bar. Some issues that will arise because of this, if two files are queried and downloaded sequentially under 250-500ms it won't do a double lapse of a full progress bar. Another issue occurring is that when a plugin fails to install for whatever reason (missing file .. ) it throws an exception which doesn't lead for a proper exit, so the next time someone goes into the plugin installer it will flag the CSRF attack because of a session mismatch. I will open a new Jira for this. One last issue, after everything is downloaded and installed. Expecting to submit a patch shortly -Joseph Leong > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3746) Plugin Progress Bar Not Updating
[ https://issues.apache.org/jira/browse/GERONIMO-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559883#action_12559883 ] Joseph Leong commented on GERONIMO-3746: Update: So it may appear that part of the UI process is interfering with properly allowing the installation of a second plugin or following plugins. The first plugin attempt installs.. (although not properly updating the UI with the progress bar). In that process something causes request.isRequestedSessionIdValid() or request.isRequestedSessionIdFromCookie() to invalidate. The side of effect of this is [BATCH] in the DWR files stopping the installation of any plugins in that 'session' because it believes its a CSRF attack. Current direction i'm heading, resolving why the sessions are getting invalidated or consolidate our ajax implementations and move from DWR to DOJO. Still need to research a bit on DOJO and DWR to make sure this effort is possible. Thoughts? Thanks, Joseph Leong > Plugin Progress Bar Not Updating > > > Key: GERONIMO-3746 > URL: https://issues.apache.org/jira/browse/GERONIMO-3746 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: console >Affects Versions: 2.1 >Reporter: Joseph Leong >Assignee: Joseph Leong > > When installing any plugin from the repository, the progress bar fails to > update correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
