[jira] Commented: (GERONIMO-3833) Hard-coded gbean names and versions in monitoring code
[ https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578351#action_12578351 ] Jarek Gawor commented on GERONIMO-3833: --- Viet, Wouldn't it be better to let the server do the actual query instead of shipping all the gbean names to the client and doing the query yourself? E.g. do something like that: SetObjectName objectNameSet = mbServerConn.queryNames(new ObjectName(*:name=MasterRemoteControlJMX,j2eeType=GBean,*), null); Hard-coded gbean names and versions in monitoring code -- Key: GERONIMO-3833 URL: https://issues.apache.org/jira/browse/GERONIMO-3833 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1, 2.1.1, 2.2 Reporter: Jarek Gawor Assignee: Viet Hung Nguyen Fix For: 2.1.1, 2.2 The monitoring code has hard-coded values in Java code and sql file: 1) The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant: private static final String PATH = geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo, name=MasterRemoteControlJMX,j2eeType=GBean; 2) The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values: 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector' I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3833) Hard-coded gbean names and versions in monitoring code
[ https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578600#action_12578600 ] Viet Hung Nguyen commented on GERONIMO-3833: Thanks for pointing this out Jarek. Committed revision 636991 in trunk. I also committed the 2.1 branch. Hard-coded gbean names and versions in monitoring code -- Key: GERONIMO-3833 URL: https://issues.apache.org/jira/browse/GERONIMO-3833 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1, 2.1.1, 2.2 Reporter: Jarek Gawor Assignee: Viet Hung Nguyen Fix For: 2.1.1, 2.2 The monitoring code has hard-coded values in Java code and sql file: 1) The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant: private static final String PATH = geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo, name=MasterRemoteControlJMX,j2eeType=GBean; 2) The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values: 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector' I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3833) Hard-coded gbean names and versions in monitoring code
[ https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12577898#action_12577898 ] Viet Hung Nguyen commented on GERONIMO-3833: Committed revision 636392 to trunk removing hard coded mbean name. dynamically fetches it instead. Hard-coded gbean names and versions in monitoring code -- Key: GERONIMO-3833 URL: https://issues.apache.org/jira/browse/GERONIMO-3833 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1, 2.1.1, 2.2 Reporter: Jarek Gawor Assignee: Viet Hung Nguyen Fix For: 2.1.1, 2.2 The monitoring code has hard-coded values in Java code and sql file: 1) The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant: private static final String PATH = geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo, name=MasterRemoteControlJMX,j2eeType=GBean; 2) The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values: 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector' I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3833) Hard-coded gbean names and versions in monitoring code
[ https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12578142#action_12578142 ] Viet Hung Nguyen commented on GERONIMO-3833: Committed revision 636624 to 2.1 branch. Hard-coded gbean names and versions in monitoring code -- Key: GERONIMO-3833 URL: https://issues.apache.org/jira/browse/GERONIMO-3833 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1, 2.1.1, 2.2 Reporter: Jarek Gawor Assignee: Viet Hung Nguyen Fix For: 2.1.1, 2.2 The monitoring code has hard-coded values in Java code and sql file: 1) The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant: private static final String PATH = geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo, name=MasterRemoteControlJMX,j2eeType=GBean; 2) The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values: 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector' I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3833) Hard-coded gbean names and versions in monitoring code
[ https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12573962#action_12573962 ] Erik B. Craig commented on GERONIMO-3833: - Committed revision 632438 to Trunk removing hard coded paths from the .sql file Committed revision 632440 to 2.1 branch Hard-coded gbean names and versions in monitoring code -- Key: GERONIMO-3833 URL: https://issues.apache.org/jira/browse/GERONIMO-3833 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: monitoring Affects Versions: 2.1, 2.1.1, 2.2 Reporter: Jarek Gawor Fix For: 2.1.1, 2.2 The monitoring code has hard-coded values in Java code and sql file: 1) The ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java contains the following constant: private static final String PATH = geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo, name=MasterRemoteControlJMX,j2eeType=GBean; 2) The ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql contains a bunch of the following values: 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector' I'm not sure how these are used but in general these type of hardcoded values should be avoided. It's really hard to maintain and keep track of. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
