[jira] Commented: (GERONIMO-4574) PolicyContext handler data objects are never released

2009-09-10 Thread David Jencks (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753901#action_12753901
 ] 

David Jencks commented on GERONIMO-4574:


This should work OK in 2.2 since the way handler data works was reimplemented 
(GERONIMO-4766)

 PolicyContext handler data objects are never released
 -

 Key: GERONIMO-4574
 URL: https://issues.apache.org/jira/browse/GERONIMO-4574
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: security
Affects Versions: 2.1.4, 2.2
Reporter: Jarek Gawor
Assignee: Jarek Gawor
 Fix For: 2.1.4, 2.2


 PolicyContext.setHandlerData() sets a given object on the thread. In Geronimo 
 Jetty and Tomcat code this is called to set the HttpServletRequest object as 
 the policy handler data. The problem is, that there is no call to unset the 
 handler data object from the thread. That causes the HttpServletRequest 
 objects (and its references) to stay in memory longer then necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-4574) PolicyContext handler data objects are never released

2009-03-06 Thread Jarek Gawor (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679663#action_12679663
 ] 

Jarek Gawor commented on GERONIMO-4574:
---

I added some calls to reset the PolicyContext handler data object to null in 
trunk (revision 750994) and branches/2.1 (revision 75099). However, that's not 
an optimal solution. It should be restoring to the previous handler data object 
but there is no easy way to get the current handler data value.


 PolicyContext handler data objects are never released
 -

 Key: GERONIMO-4574
 URL: https://issues.apache.org/jira/browse/GERONIMO-4574
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: security
Affects Versions: 2.1.4, 2.2
Reporter: Jarek Gawor
Assignee: Jarek Gawor

 PolicyContext.setHandlerData() sets a given object on the thread. In Geronimo 
 Jetty and Tomcat code this is called to set the HttpServletRequest object as 
 the policy handler data. The problem is, that there is no call to unset the 
 handler data object from the thread. That causes the HttpServletRequest 
 objects (and its references) to stay in memory longer then necessary.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.