[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751276#action_12751276 ] Rodger Zhang commented on GERONIMODEVTOOLS-283: --- The "rename" item is bond with a action, and probably there is no extension point to modify the action's wizard. Like wtp's "rename" , its wizard does not provide a check box for changing in web.xml. It is possible to implement this tiny feature but with a large effort, because the "rename" is not implemented by GEP. > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Priority: Minor > Fix For: 2.2.0 > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751705#action_12751705 ] Shiva Kumar H R commented on GERONIMODEVTOOLS-283: -- Please feel free to close this JIRA in that case. > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Priority: Minor > Fix For: 2.2.0 > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752991#action_12752991 ] Rodger Zhang commented on GERONIMODEVTOOLS-283: --- After a deeper investigation, this feature can be implemented by contributing to a extension-point. The UI is like pictures attached. > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Priority: Minor > Fix For: 2.2.0 > > Attachments: extend_rename.patch > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838230#action_12838230 ] Lu Jiang commented on GERONIMODEVTOOLS-283: --- Use latest GEP build,I faild to rename the name of Dynamic Web Project from "hello" to "hi". I created a simple helloworld project,and name this project as "hello",then a default geronimo-web.xml is created. http://geronimo.apache.org/xml/ns/j2ee/application-2.0"; xmlns:client="http://geronimo.apache.org/xml/ns/j2ee/application-client-2.0"; xmlns:conn="http://geronimo.apache.org/xml/ns/j2ee/connector-1.2"; xmlns:dep="http://geronimo.apache.org/xml/ns/deployment-1.2"; xmlns:ejb="http://openejb.apache.org/xml/ns/openejb-jar-2.2"; xmlns:log="http://geronimo.apache.org/xml/ns/loginconfig-2.0"; xmlns:name="http://geronimo.apache.org/xml/ns/naming-1.2"; xmlns:pers="http://java.sun.com/xml/ns/persistence"; xmlns:pkgen="http://openejb.apache.org/xml/ns/pkgen-2.1"; xmlns:sec="http://geronimo.apache.org/xml/ns/security-2.0"; xmlns:web="http://geronimo.apache.org/xml/ns/j2ee/web-2.0.1";> default hello 1.0 car /hello Click Refactor->Rename to change the project name from "hello" to "hi". The check box shown in the screen snapshot didn't appear.So I cann't choose whether to "rename artifact-id and context-root in geronimo-web.xml". But actually ,some wrong operation was done to artifactId and moduleId in geronimo-web.xml during Renaming. See the geronimo-web.xml below,after rename from "hello" to "hi",it became a badly formed xml file. http://geronimo.apache.org/xml/ns/j2ee/application-2.0"; xmlns:client="http://geronimo.apache.org/xml/ns/j2ee/application-client-2.0"; xmlns:conn="http://geronimo.apache.org/xml/ns/j2ee/connector-1.2"; xmlns:dep="http://geronimo.apache.org/xml/ns/deployment-1.2"; xmlns:ejb="http://openejb.apache.org/xml/ns/openejb-jar-2.2"; xmlns:log="http://geronimo.apache.org/xml/ns/loginconfig-2.0"; xmlns:name="http://geronimo.apache.org/xml/ns/naming-1.2"; xmlns:pers="http://java.sun.com/xml/ns/persistence"; xmlns:pkgen="http://openejb.apache.org/xml/ns/pkgen-2.1"; xmlns:sec="http://geronimo.apache.org/xml/ns/security-2.0"; xmlns:web="http://geronimo.apache.org/xml/ns/j2ee/web-2.0.1";> default hehidep:artifactId> 1.0 car /h/hiweb:context-root> I suggest to reopen this JIRA. > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Priority: Minor > Fix For: 2.1.5, 2.2.0 > > Attachments: extend_rename.patch, screenshot-1.jpg, screenshot-2.jpg > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840534#action_12840534 ] Delos Dai commented on GERONIMODEVTOOLS-283: It works for 2.1.5 branch, but failed in 2.2.1 branch. Reopen it. Will fix it later. > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Priority: Minor > Fix For: 2.1.5, 2.2.0 > > Attachments: extend_rename.patch, screenshot-1.jpg, screenshot-2.jpg > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841134#action_12841134 ] Delos Dai commented on GERONIMODEVTOOLS-283: The problem happens with JDK 6. JDK 6 behavior differently in calculating character offset in xml file. #918900 for 2.2.1 branch,#918905 for trunk and #918907 for 2.1.5 branch > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Assignee: Delos Dai >Priority: Minor > Fix For: 2.1.5, 2.2.0 > > Attachments: extend_rename.patch, screenshot-1.jpg, screenshot-2.jpg > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718076#action_12718076 ] Delos Dai commented on GERONIMODEVTOOLS-283: I think it's not right behavior for refactor. Indeed, the default values of module-id and context-root are the same as the project name. But it's not always the case. User can change module-id or context-root into other names. So we have to keep them independent of each other. If possible, suggest to close this JIRA! Thanks! > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Assignee: Shiva Kumar H R >Priority: Minor > Fix For: 2.2.0 > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718308#action_12718308 ] Shiva Kumar H R commented on GERONIMODEVTOOLS-283: -- Or how about the below option? If module-id and context-root have the same values as project-name (i.e. the user has not changed them from their default values or has intentionally kept all of them same) then provide an user option (say a check box) during refactoring that allows the user to select "renaming module-id and context-root to match the new project name". > Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & > context root > - > > Key: GERONIMODEVTOOLS-283 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283 > Project: Geronimo-Devtools > Issue Type: Wish > Components: eclipse-plugin >Reporter: Shiva Kumar H R >Assignee: Shiva Kumar H R >Priority: Minor > Fix For: 2.2.0 > > > When a Dynamic Web Project with name say "tt" is created, a Geronimo > deployment plan "geronimo-web.xml" will get created with module-id as > "default/tt-1.0.car" and context-root as "/tt". > When this project is re-factored to say "tz", the module-id will still be the > same "default/tt-1.0.car" (note that artifact id is not re-factored from "tt" > to "tz"). The context-root also remains the same "/tt". > Although this doesn't pose any problem, wouldn't it be better to refactor the > artifact-id & context-root to match the project name? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
