[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-26 Thread Delos Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735448#action_12735448
 ] 

Delos Dai commented on GERONIMODEVTOOLS-575:


Hi Tim, thanks very much for your help. For the deploy status problem, i have 
found your post in WTP dev list. Yes, since WTP don't think it's problem, all 
we can do is to set  UNKNOWN status.  

Thanks again for reviewing the patch at weekend -:) 

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_startserver.patch, 
 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-25 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735322#action_12735322
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Hi again Delos, I committed the portion of your 575-new.patch that properly 
handles the scenario where the configuration module Id cannot be found during 
redeploy/undeploy. It works great. Thanks much

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_startserver.patch, 
 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-24 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734952#action_12734952
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Hi Delos, applied your 575-startserver.patch and it fixes all remaining known 
issues when errors occur on the GEP side during startup of the server. That 
means that all failing scenarios related to starting, stopping, and restarting 
the server appear to be handled in a well-behaved and consistent manner at 
least from the end-user perspective. Thanks very much !!

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_startserver.patch, 
 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-24 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735230#action_12735230
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Delos, it looks like we're not going to be able to fix the scenario where 
there is a deployment exception and the Server view still shows the project as 
published appears to be a WTP problem. Here is the bugzilla:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=267993

However, the WTP consensus is that it's expected behavior and not a bug, which 
is somewhat disconcerting. I'll follow-up to see if there is a better solution 
and/or work-around. Thanks.

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_startserver.patch, 
 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-24 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735236#action_12735236
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Delos, looks like the best we can do at this time when an exception occurs 
during deployment is to set the module publish state to UNKNOWN so that WTP 
will not display Synchronized for the module and server. What we should see 
in the Eclipse Server View in this case is nothing for the module, but 
Republish for the server. This is a very subtle distinction (IMO) but the 
only indication to the GEP end-user that their module was not successfully 
deployed. At least it's better than what we had before when we didn't 
display/show anything differently. Committed this change to both trunk 
(r797712) and 2.1.5 (r797713). Thanks


 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_startserver.patch, 
 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-23 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734482#action_12734482
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Hi Delos, thanks much for the stopserver patch. Given what we currently know 
about the implementation of the stop() method in WTP's ServerBehaviourDelegate 
class, this works very nicely. When I inject an Exception during the stop 
process in GeronimoServerBehaviourDelegate on the GEP side we get a Problem 
Occurred dialog that presents the Stopping Apache Geronimo v2.1 server at 
local host has encountered a problem message and an entry to the Eclipse Error 
log stating that Error calling delegate stop() Apache Geronimo v2.1 server at 
local host from the org.eclipse.wst.server.core plugin. Note that we were 
getting neither of these before and they are precisely what needs to be 
presented to the GEP user during this type of failure. 

With all this said though, just for the sake of completeness I've posted a 
question to the Eclipse wtp-dev mailing list to ensure we're doing exactly what 
they expect in this case (i.e., throwing a Runtime Exception instead of a 
CoreException). Will let you know what they respond with. 

Thanks again

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-07-23 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734769#action_12734769
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


Hi again Delos, got a response today from WTP devlist concerning the usage of a 
RuntimeException instead of a CoreException (discussed above) and that is what 
they expect. WTP will rethrow the RuntimeException in order to terminate the 
stop Eclipse job which is exactly what we need. So this works fine on Galileo 
but we probably need to try it on Ganymede as well to ensure we get the same 
behavior. 

Also, I got a good suggestion from them on how to handle the case where there 
is a failure on the GEP side during setup of the Launch Configuration. 
Currently, we throw a CoreException from the 
GeronimoServerBehaviourDelegate.setupLaunchConfiguration() method, which 
doesn't really do much as it is ignored by both WTP and the server. However, if 
we catch the exception in setupLaunchConfiguration() ourselves and set an error 
flag in the Geronimo server configuration indicating that it was not setup 
properly we can subsequently check that flag in the 
GeronimoLaunchConfigurationDelegate.launch() method and throw the CoreException 
from there instead. Supposedly, WTP will then handle it correctly. Is that 
something you think you could look into ??

Thanks

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.1.4, 2.2.0
Reporter: Tim McConnell
Assignee: Tim McConnell
 Attachments: 575.patch, 575_new.patch, 575_stopserver.patch


 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-07 Thread Delos Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717115#action_12717115
 ] 

Delos Dai commented on GERONIMODEVTOOLS-575:


Now, as my understanding, you hope GEP to throw CoreException nested details, 
then eclipse itself will pop up a Problem Occur window to show the details. 

Currently, I have some concerns about your solution. Maybe they're not 
accurate, but I hope to learn more about it if you can give some explanation. 
Thanks in advance!

1) In most cases,  GEP can catch the exception thrown by WTP. But sometimes, 
WTP may invoke some callback methods in GEP. Then, WTP may catch the exception 
thrown by GEP. If WTP just catches the exception but doesn't throw it, does 
that mean user won't get the details for the exception?

2) Besides the Problem Occur error dialog, there are some other error 
dialogs, such as dialogs shown by openError() method of MessageDialog or 
ErrorDialog. As JIRA 575 indicated, we need to check and revise error messages 
for all these dialogs. Seems not all these error dialogs are shown due to 
CoreException. So maybe we need to take all these cases into account, what's 
your opinion? (The senarios mentioned in you note are all eclipse Job - 
org.eclipse.core.runtime.jobs, I think that's the reason why the CoreExceptions 
thrown by them will show the Problem Occur error dialog, is that right?)

Thanks!


 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-05 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12716658#action_12716658
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


After looking at this problem more thoroughly I think I finally see what's 
going on. Ideally as a best practice the GEP should strive to convey error 
and/or exception messages (to the end user) in a consistent manner when 
interactions with the Geronimo server are involved. Unfortunately, this is not 
the case as there seems to be multiples paths in the GEP that entail 
interactions with the server that do not handle exceptions in a consistent, 
well-behaved manner. 

A relatively good implementation of a usage scenario is when artifacts get 
deployed/undeployed to the server. The GEP in most cases throws CoreExceptions 
(with nested exceptions and statuses) that results in a Problem Occurred 
dialog with detailed information about the problem/exception. One nice aspect 
of this approach is that it is fairly standard in Eclipse and is the same 
approach used by WTP. Although this is the best example in the GEP, even this 
implementation is far from perfect; there are at least three scenarios that are 
not handled correctly. One is the case where WAR file can be deployed to the 
server that results in deployment errors that are not conveyed to the end-user 
-- they are only written to the Eclipse Error log file. The other case is the 
GERONIMODEVTOOLS-575 JIRA  just opened where a WAR file without a 
geroniom-web.xml not only doesn't deploy, it doesn't convey anything to the 
end-user (not good), nor does it write anything to the Eclipse Error log file. 
The third is the case where a Target Module ID cannot be found on the server 
(i.e., TargetModuleIdNotFoundException) and is essentially ignored by the GEP 
(again not good). 

Two other scenarios that involve interactions with the Geronimo server seem to 
be inconsistently implemented. Errors starting and/or stopping the server don't 
do much other than log exceptions to the Eclipse error log and depends upon WTP 
to throw the CoreException. But these CoreExceptions are too generic to be of 
much value to the end-user. This can be seen when we try to start the server 
with incorrect security credentials. The CoreException just conveys that the 
server failed to start, which is all that WTP about knows. The GEP knows the 
root cause but only writes it to Eclipse Error log, which is not normally 
visible to the end-user. Similarly, errors connecting and/or disconnecting 
to/from the server are inconsistently handled which makes diagnosis somewhat 
confusing or problematic for the end-user. 

My recommendation is that we refactor the code that interacts with the Geronimo 
server to consistently throw CoreExceptions (with nested Exceptions and 
MultiStatus objects) and open Error Dialogs when anything needs to be conveyed 
to the end-user. As noted above we do some of this already, but not 
well-enough. Of the three typical usage scenarios I've mentioned 
(connecting/disconnecting, starting/stopping, deploying/undeploying) I would 
think that starting/stopping the server would be the easiest and most 
straightforward. This is just a guess at this point though. Once that is 
accomplished I think that doing the same for the connecting/disconnecting 
scenarios would be fairly easy, and hopefully we'd learn enough to then plug 
the existing holes in the deploying/undeploying scenarios. Then finally as a 
last resort, if there are cases where it is just impossible to throw a 
CoreExcpetion (and display an Error Dialog) to convey information to the 
end-user we can then exercise the new code that I just recently added to the 
GEP to display the Eclipse Error log. 

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-03 Thread Delos Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715874#action_12715874
 ] 

Delos Dai commented on GERONIMODEVTOOLS-575:


Kevan, for the case you mentioned, I have something to clarify.

Current pop-up window is thrown by WTP, which is not controlled by GEP. Seems 
we can add aother pop-up dialog in GEP to tell user that user name isn't valid. 
But it's not easy to remove the original pop-up window. I'm investigation it, 
but I'm not sure it can be removed.


 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-02 Thread Kevan Miller (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715542#action_12715542
 ] 

Kevan Miller commented on GERONIMODEVTOOLS-575:
---

Might help. The error log tab is kind of hard to read. And can be difficult 
what errors apply to the current problem, or to previous problems.

One test case I'm looking at is changing the admin user name and trying to 
start the server from Eclipse will lead to the following error notification:

Server Apache Geronimo v2.1 Server at localhost failed to start. This does 
very little to help me identify the problem. From the error log, I can back up 
an error or two and see the underlying problem. The best solution would be to 
see the true cause of the error appear in the Problem Occurred window.

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-01 Thread Kevan Miller (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715220#action_12715220
 ] 

Kevan Miller commented on GERONIMODEVTOOLS-575:
---

I'm not sure that is the best example for an error message. That error is 
already presented pretty well to the user in a Problem Occurred pop up window 
(sorry if I don't use the appropriate Eclipse terms...).

I'm a little worried that this change may end up presenting confusingly 
redundant (i.e. duplicate messages) or false positives (indicate an error, when 
there isn't one) error indications to users.

FYI, here's the error that I get on GEP 2.1.4 when deploying apache-archiva 
with a default deployment plan...

Distribution of module failed.  See log for details.
  Unable to resolve resource reference 'jdbc/users' (Could not auto-map to 
resource.  Try adding a resource-ref mapping to your Geronimo deployment plan.
  Search conducted in current module and dependencies:
  [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
  [CLASSES: org.apache.geronimo.configs/openejb//car]
  [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
  [ALL: org.apache.geronimo.configs/axis//car]
  [ALL: org.apache.geronimo.configs/axis2//car]
  [ALL: org.apache.geronimo.configs/openjpa//car]
  )
  org.apache.geronimo.common.DeploymentException: Unable to resolve resource 
reference 'jdbc/users' (Could not auto-map to resource.  Try adding a 
resource-ref mapping to your Geronimo deployment plan.
  Search conducted in current module and dependencies:
  [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
  [CLASSES: org.apache.geronimo.configs/openejb//car]
  [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
  [ALL: org.apache.geronimo.configs/axis//car]
  [ALL: org.apache.geronimo.configs/axis2//car]
  [ALL: org.apache.geronimo.configs/openjpa//car]
  )
at 
org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
at 
org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
at 
org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
at 
org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
at 
org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
at 
org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:647)
at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:255)
at org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:134)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at 
org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
at 
org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
at 
org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
at 
org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
at org.apache.geronimo.kernel.KernelGBean.invoke(KernelGBean.java:342)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at 
org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34)
at 
org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124)
at 
org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867)
at 
org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239)
at 
org.apache.geronimo.system.jmx.MBeanGBeanBridge.invoke(MBeanGBeanBridge.java:172)
at 
com.sun.jmx.mbeanserver.DynamicMetaDataImpl.invoke(DynamicMetaDataImpl.java:213)
at com.sun.jmx.mbeanserver.MetaDataImpl.invoke(MetaDataImpl.java:220)
at 
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:815)
at 
com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:784)
at 
javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1410)
at 
javax.management.remote.rmi.RMIConnectionImpl.access$100(RMIConnectionImpl.java:81)
at 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-01 Thread Tim McConnell (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715247#action_12715247
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-575:


It may be that we would need to display the Eclipse Error Log only in the 
case(s) where the Activator (i.e., pop-up window) has not already been 
displayed. I will investigate and see if this is a common occurrence -- it 
really shouldn't be, but that might not be the case

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-01 Thread Kevan Miller (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715258#action_12715258
 ] 

Kevan Miller commented on GERONIMODEVTOOLS-575:
---

That might help. I'll be looking some more. Have definitely found some errors 
where the new messages are very valuable...

 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:647)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 

[jira] Commented: (GERONIMODEVTOOLS-575) GEP errors that are logged to the Eclipse error log are not always seen by end-user

2009-06-01 Thread Delos Dai (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12715341#action_12715341
 ] 

Delos Dai commented on GERONIMODEVTOOLS-575:


In eclipse, if some problems found, its error message can be shown to user by 
openError method of MessageDialog or ErrorDialog. 
Maybe we can invoke openError() in GEP when we need to show error message. 
Maybe we can invoke openError() when we need to show error message, but seems 
there no way to avoid duplicate error message, because WTP may also pop-up a 
dialog to show an error message about the same problem.

Any suggestion?


 GEP errors that are logged to the Eclipse error log are not always seen by 
 end-user
 ---

 Key: GERONIMODEVTOOLS-575
 URL: 
 https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575
 Project: Geronimo-Devtools
  Issue Type: Bug
  Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell

 For example, when deploying an erroneous war file to the Geronimo server will 
 result in the following to the Eclispe.log that the end-user may not likely 
 see.
 !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Distribution of module failed.  See log for details.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not 
 auto-map to resource.  Try adding a resource-ref mapping to your Geronimo 
 deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve 
 resource reference 'jdbc/users' (Could not auto-map to resource.  Try adding 
 a resource-ref mapping to your Geronimo deployment plan.
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE Search conducted in current module and dependencies:
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car]
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE )
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347)
 !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859
 !MESSAGE  at 
 org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165)