Re: [jira] Commented: (XBEAN-109) org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
On May 20, 2009, at 7:18 AM, Ivan (JIRA) wrote: [ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711154 #action_12711154 ] Ivan commented on XBEAN-109: Hi, just find that for XBean JIRAs, there is no resolve action. So for these JIRAs, shall I need to start a RTC view, then commit the patch files ? no, just close the issue. If you can figure out how to get the workflow to be the same as in geronimo, even better. thanks david jencks org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces Key: XBEAN-109 URL: https://issues.apache.org/jira/browse/XBEAN-109 Project: XBean Issue Type: Bug Components: classloader Environment: jdk1.6, Windows 2000 Latest version from SVN Reporter: Ingo Bormann Assignee: Ivan Attachments: xbean.diff A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead. I have a patched version where this is fixed for the full package org.apache.xbean.classloader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (XBEAN-109) org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711152#action_12711152 ] Ivan commented on XBEAN-109: Merge the patch to XBean trunk at rev 776705. Thanks Ingo Bormann for the patch ! org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces Key: XBEAN-109 URL: https://issues.apache.org/jira/browse/XBEAN-109 Project: XBean Issue Type: Bug Components: classloader Environment: jdk1.6, Windows 2000 Latest version from SVN Reporter: Ingo Bormann Assignee: Ivan Attachments: xbean.diff A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead. I have a patched version where this is fixed for the full package org.apache.xbean.classloader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (XBEAN-109) org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
[ https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711154#action_12711154 ] Ivan commented on XBEAN-109: Hi, just find that for XBean JIRAs, there is no resolve action. So for these JIRAs, shall I need to start a RTC view, then commit the patch files ? org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces Key: XBEAN-109 URL: https://issues.apache.org/jira/browse/XBEAN-109 Project: XBean Issue Type: Bug Components: classloader Environment: jdk1.6, Windows 2000 Latest version from SVN Reporter: Ingo Bormann Assignee: Ivan Attachments: xbean.diff A lot of classes in the package org.apache.xbean.classloader use File.toURL() instead of File.toURI().toURL(). File.toURL() is deprecated and does not work on windows with pathnames containing spaces. If a pathname contains spaces then File.toURL() does not convert spaces correctly. Javadoc recommends to use File.toURI().toURL() instead. I have a patched version where this is fixed for the full package org.apache.xbean.classloader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (XBEAN-109) org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames with containing spaces
[
https://issues.apache.org/jira/browse/XBEAN-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639377#action_12639377
]
Benjamin Bentmann commented on XBEAN-109:
-
+1 on the usage of {{File.toURI().toURL()}}
-1 on the replacement of {{new File(url.toURI())}} with {{new
File(url.getPath())}}. {{URL.getPath()}} merely returns a substring of the URL
and as such can still contain percent-encoded characters. Therefore, {{new
File(url.getPath())}} should only be used as a fallback in case the
URISyntaxException indicates an unescaped URL.
org.apache.xbean.classloader.JarFileClassLoader can not handle pathnames
with containing spaces
Key: XBEAN-109
URL: https://issues.apache.org/jira/browse/XBEAN-109
Project: XBean
Issue Type: Bug
Components: classloader
Environment: jdk1.6, Windows 2000 Latest version from SVN
Reporter: Ingo Bormann
Attachments: xbean.diff
A lot of classes in the package org.apache.xbean.classloader use File.toURL()
instead of File.toURI().toURL(). File.toURL() is deprecated and does not work
on windows with pathnames containing spaces. If a pathname contains spaces
then File.toURL() does not convert spaces correctly. Javadoc recommends to
use File.toURI().toURL() instead.
I have a patched version where this is fixed for the full package
org.apache.xbean.classloader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
