[jira] Closed: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-06-14 Thread Jay D. McHugh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay D. McHugh closed GERONIMO-3060.
---


Looks good.

Thanks Donald.

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M5
Reporter: Jay D. McHugh
Assignee: Jay D. McHugh
Priority: Minor
 Fix For: 2.0-M7

 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-06-13 Thread Donald Woods (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Woods resolved GERONIMO-3060.


   Resolution: Fixed
Fix Version/s: 2.0-M7
 Assignee: Jay D. McHugh  (was: Matt Hogstrom)

Applied Jay's patch as revision 546902.
Please close this issue if everything looks okay.

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M5
Reporter: Jay D. McHugh
Assignee: Jay D. McHugh
Priority: Minor
 Fix For: 2.0-M7

 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-06-12 Thread Jay D. McHugh (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504072
 ] 

Jay D. McHugh commented on GERONIMO-3060:
-

Could you go ahead an apply this please?
(thank you)

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M5
Reporter: Jay D. McHugh
Assignee: Matt Hogstrom
Priority: Minor
 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-04-24 Thread Jay D. McHugh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay D. McHugh updated GERONIMO-3060:


Affects Version/s: (was: 2.0-M4)
   (was: 2.0-M5)
   2.0-M6

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M6
Reporter: Jay D. McHugh
 Assigned To: Jay D. McHugh
Priority: Minor
 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-04-24 Thread Matt Hogstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Hogstrom reassigned GERONIMO-3060:
---

Assignee: Matt Hogstrom  (was: Jay D. McHugh)

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M5
Reporter: Jay D. McHugh
 Assigned To: Matt Hogstrom
Priority: Minor
 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-04-24 Thread Matt Hogstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Hogstrom updated GERONIMO-3060:


Affects Version/s: (was: 2.0-M6)
   2.0-M5

Will apply this patch for 2.0-M5

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M5
Reporter: Jay D. McHugh
 Assigned To: Matt Hogstrom
Priority: Minor
 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-04-03 Thread Jay D. McHugh (JIRA)
Add a separate tree branch for persistence units into the JMX viewer


 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public (Regular issues)
  Components: console, persistence
Affects Versions: 2.0-M4, 2.0-M5
Reporter: Jay D. McHugh
 Assigned To: Jay D. McHugh
Priority: Minor


Added a branch under J2EE Managed Objects that show the persistence unit gbeans.

Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-3060) Add a separate tree branch for persistence units into the JMX viewer

2007-04-03 Thread Jay D. McHugh (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jay D. McHugh updated GERONIMO-3060:


Attachment: geronimo-3060.patch

 Add a separate tree branch for persistence units into the JMX viewer
 

 Key: GERONIMO-3060
 URL: https://issues.apache.org/jira/browse/GERONIMO-3060
 Project: Geronimo
  Issue Type: Sub-task
  Security Level: public(Regular issues) 
  Components: console, persistence
Affects Versions: 2.0-M4, 2.0-M5
Reporter: Jay D. McHugh
 Assigned To: Jay D. McHugh
Priority: Minor
 Attachments: geronimo-3060.patch


 Added a branch under J2EE Managed Objects that show the persistence unit 
 gbeans.
 Note: persistence unit gbeans still appear under All MBeans/geronimo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (GERONIMO-2853) Add a way to view MBean stats info in the JMX Viewer portlet

2007-03-26 Thread Christopher M. Cardona (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher M. Cardona closed GERONIMO-2853.


Resolution: Fixed

 Add a way to view MBean stats info in the JMX Viewer portlet
 

 Key: GERONIMO-2853
 URL: https://issues.apache.org/jira/browse/GERONIMO-2853
 Project: Geronimo
  Issue Type: Improvement
  Security Level: public(Regular issues) 
  Components: console
Affects Versions: 2.0-M5
Reporter: Christopher M. Cardona
 Assigned To: Christopher M. Cardona
Priority: Minor
 Fix For: 2.0-M5

 Attachments: GERONIMO-2853.patch


 Modify the JMX Viewer portlet and add a way to view a list of MBeans that 
 provides statistics. Add 'Stats' tab which lists the stats of an MBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-2853) Add a way to view MBean stats info in the JMX Viewer portlet

2007-02-23 Thread Christopher M. Cardona (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475352
 ] 

Christopher M. Cardona commented on GERONIMO-2853:
--

Added the 'Refresh Stats' button to the ff. revisions:

- trunk rev. 510727
- 2.0-M3 rev. 510759

 Add a way to view MBean stats info in the JMX Viewer portlet
 

 Key: GERONIMO-2853
 URL: https://issues.apache.org/jira/browse/GERONIMO-2853
 Project: Geronimo
  Issue Type: Improvement
  Security Level: public(Regular issues) 
  Components: console
Affects Versions: 2.0
Reporter: Christopher M. Cardona
 Assigned To: Christopher M. Cardona
Priority: Minor
 Fix For: 2.0

 Attachments: GERONIMO-2853.patch


 Modify the JMX Viewer portlet and add a way to view a list of MBeans that 
 provides statistics. Add 'Stats' tab which lists the stats of an MBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (GERONIMO-2853) Add a way to view MBean stats info in the JMX Viewer portlet

2007-02-20 Thread Christopher M. Cardona (JIRA)
Add a way to view MBean stats info in the JMX Viewer portlet


 Key: GERONIMO-2853
 URL: https://issues.apache.org/jira/browse/GERONIMO-2853
 Project: Geronimo
  Issue Type: Improvement
  Security Level: public (Regular issues)
  Components: console
Affects Versions: 2.0
Reporter: Christopher M. Cardona
 Assigned To: Christopher M. Cardona
Priority: Minor
 Fix For: 2.0


Modify the JMX Viewer portlet and add a way to view a list of MBeans that 
provides statistics. Add 'Stats' tab which lists the stats of an MBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (GERONIMO-2853) Add a way to view MBean stats info in the JMX Viewer portlet

2007-02-20 Thread Christopher M. Cardona (JIRA)

 [ 
https://issues.apache.org/jira/browse/GERONIMO-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher M. Cardona updated GERONIMO-2853:
-

Attachment: GERONIMO-2853.patch

Tested the patch to work on trunk rev. 509438

 Add a way to view MBean stats info in the JMX Viewer portlet
 

 Key: GERONIMO-2853
 URL: https://issues.apache.org/jira/browse/GERONIMO-2853
 Project: Geronimo
  Issue Type: Improvement
  Security Level: public(Regular issues) 
  Components: console
Affects Versions: 2.0
Reporter: Christopher M. Cardona
 Assigned To: Christopher M. Cardona
Priority: Minor
 Fix For: 2.0

 Attachments: GERONIMO-2853.patch


 Modify the JMX Viewer portlet and add a way to view a list of MBeans that 
 provides statistics. Add 'Stats' tab which lists the stats of an MBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (GERONIMO-2853) Add a way to view MBean stats info in the JMX Viewer portlet

2007-02-20 Thread Anita Kulshreshtha (JIRA)

[ 
https://issues.apache.org/jira/browse/GERONIMO-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474473
 ] 

Anita Kulshreshtha commented on GERONIMO-2853:
--

It would be nice to have a 'refresh' button to get the latest value of the 
stats. 

 Add a way to view MBean stats info in the JMX Viewer portlet
 

 Key: GERONIMO-2853
 URL: https://issues.apache.org/jira/browse/GERONIMO-2853
 Project: Geronimo
  Issue Type: Improvement
  Security Level: public(Regular issues) 
  Components: console
Affects Versions: 2.0
Reporter: Christopher M. Cardona
 Assigned To: Christopher M. Cardona
Priority: Minor
 Fix For: 2.0

 Attachments: GERONIMO-2853.patch


 Modify the JMX Viewer portlet and add a way to view a list of MBeans that 
 provides statistics. Add 'Stats' tab which lists the stats of an MBean.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: JMX Viewer

2006-10-10 Thread Christopher M. Cardona

Hi Anita,

I don’t think this would work since there is no guarantee that a 
“complete list of all valid j2eeTypes” will be created. Your suggestion 
might result to an incomplete list of j2eeTypes. I designed the JMX tree 
to list all the possible j2eeTypes whether there is one available or 
not. IMO this is a better design because it gives you an idea of what 
other j2eeTypes are available. Again AFAIK there is no way of getting 
this complete list using our existing api hence I decided to hardcode 
the list in the jsp. Obviously the advantage here is faster loading of 
the page and it’s easy to update the list without recompiling any java 
files. The disadvantage of course is updating the jsp file every time 
the list changes (most likely only for G specific j2eeTypes and I’m not 
sure if this is likely to happen) vs. getting the complete list from the 
server (assuming it’s possible or it’s available) and rendering the tree 
to display the list.


Best wishes,
chris


anita kulshreshtha wrote:

Chris,
Assuming that the listGBeans method can not be qureied to return such 
a list, can't we create a list of _distinct_ j2eeTypes by processing 
the list of all MBeans? Would such a list work for you?


Thanks
Anita

- Original Message 
From: Christopher M. Cardona [EMAIL PROTECTED]
To: dev@geronimo.apache.org
Sent: Friday, October 6, 2006 12:18:49 PM
Subject: Re: JMX Viewer

Anita,

This is not a requirement of Dojo. AFAIK there is no way of getting a
list of all the j2eeTypes (standard j2ee and G specific) using any
Kernel api. I got the list by looking at G source and combining it with
the different types returned when calling Kernel.listGBeans(). If you
know a solution for this then I'm more than willing to try it out.

Best wishes,
chris

anita kulshreshtha wrote:
 Chris,
 I was going through the code (JMXServer.jsp). I see that all the
 MBean names are hardcoded. Is this something that is required by dojo?
 Ideally, when the JMXViewer is invoked for the first time the MBean
 names should be generated using kernel.listGBeans. Am I missing 
something?


 Thanks
 Anita

 - Original Message 
 From: anita kulshreshtha [EMAIL PROTECTED]
 To: dev@geronimo.apache.org
 Sent: Thursday, September 28, 2006 10:25:19 AM
 Subject: Re: JMX Viewer

 .









Re: JMX Viewer

2006-10-08 Thread anita kulshreshtha
Chris, Assuming that the listGBeans method can not be qureied to return such a list, can't we create a list of _distinct_ j2eeTypes by processing the list of all MBeans? Would such a list work for you?ThanksAnita- Original Message From: Christopher M. Cardona [EMAIL PROTECTED]To: dev@geronimo.apache.orgSent: Friday, October 6, 2006 12:18:49 PMSubject: Re: JMX ViewerAnita,This is not a requirement of Dojo. AFAIK there is no way of getting a list of all the j2eeTypes (standard j2ee and G specific) using any Kernel api. I got the list by
 looking at G source and combining it with the different types returned when calling Kernel.listGBeans(). If you know a solution for this then I'm more than willing to try it out.Best wishes,chrisanita kulshreshtha wrote: Chris,I was going through the code (JMXServer.jsp). I see that all the  MBean names are hardcoded. Is this something that is required by dojo?  Ideally, when the JMXViewer is invoked for the first time the MBean  names should be generated using kernel.listGBeans. Am I missing something? Thanks Anita - Original Message  From: anita kulshreshtha [EMAIL PROTECTED] To: dev@geronimo.apache.org Sent: Thursday, September 28, 2006 10:25:19 AM Subject: Re: JMX Viewer
 .

Re: Remarks on quoting style in emails (was: Re: JMX Viewer)

2006-10-08 Thread anita kulshreshtha
- Original Message From: Jacek Laskowski [EMAIL PROTECTED]1/ "Comments inline" are unnecessary. We all know that we send emailsto be involved in a converstation. We'll look them up.2/ Some emails need formatting before responding. Remove unnecessaryempty lines as they don't bring any value and complicate reading.3/ Do not quote too much - only relevant part of a message. The restis in the original message and everybody can read it in the archives(unless it's not in one's mailbox already)If you think they're valid points please use them. Else comment onthem so I'll change my habits
 and expectations.I agree with all of them and plan to use them..ThanksAnitaJacek-- Jacek Laskowskihttp://www.laskowski.net.pl

Re: Remarks on quoting style in emails (was: Re: JMX Viewer)

2006-10-08 Thread anita kulshreshtha
I am adding to the list:4/ Avoid using Beta version of mail programs ;-)ThanksAnitaanita kulshreshtha [EMAIL PROTECTED] wrote: - Original Message From: Jacek Laskowski [EMAIL PROTECTED]1/ "Comments inline" are unnecessary. We all know that we send emailsto be involved in a converstation. We'll look them up.2/ Some emails need formatting before responding. Remove unnecessaryempty lines as they don't bring any value and complicate reading.3/ Do not quote too much - only
 relevant part of a message. The restis in the original message and everybody can read it in the archives(unless it's not in one's mailbox already)If you think they're valid points please use them. Else comment onthem so I'll change my habits  and expectations.I agree with all of them and plan to use them..ThanksAnitaJacek-- Jacek Laskowskihttp://www.laskowski.net.pl 
		Do you Yahoo!? Everyone is raving about the  all-new Yahoo! Mail.

Re: JMX Viewer

2006-10-06 Thread Christopher M. Cardona

See inline comments...

anita kulshreshtha wrote:

Comments inline..

--- Christopher M. Cardona [EMAIL PROTECTED] wrote:


  

1. Is it possible to display 'Geronimo MBeans' (console.doc) sorted
according to the configurations they belong to?
  
snip... 
  

One thing we can do is
to 
add a list of ServiceModules and clicking each node will list its
MBeans 
which is almost close to what you want. 



   This would be nice to have.

  
OK. I already created a JIRA for this - 
http://issues.apache.org/jira/browse/GERONIMO-2448.

2. Is it possible to view tomcat MBeans?
  
  

Yes. Currently there are two ways to do this the fastest. One option
is 
to navigate the tree - Geronimo MBeans  GBean. Another option is to
do 
an MBean search using a pattern like: “geronimo:j2eeType=GBean,*”.
Both 
will give a list of all the GBeans which include the Tomcat MBeans.



   This only gives only the MBeans that have been exposed via GBeans. A
typical tomcat MBean has a name attribute like:
Name: Geronimo:type=Connector, port=8443, address=%2F0.0.0.0

 If you are using kernel.listGBeans to find the MBeans, they will
not be visible. One must query the MBeanserver to find these. Earlier
listGBeans used to return all the MBeans. Let's wait for other
suggestions about how to do this.. 
 
  
Yes my implementation is using Kernel.listGBeans() so I'm not doing a 
direct query to the MBeanServer. There might be a reason why other 
Tomcat MBeans are not being returned. I agree that we should wait for 
suggestions to retrieve it.

3. I like the jconsole's view of the attributes (jconsole2.doc).
  

The


attributes are color coded. Jconsole even allows modification of
  

these


attributes. I am not sure if we want to allow that. Please compare
  

this


with console2.doc
  
  

I think this is doable. We can set the Attribute value’s color
depending 
on its property (readonly, writable, unavailable). Right now
modifying 
the attribute values is supported but with limitation. We can only
set 
the values for attributes with primitive data types and some commonly


used classes that can be constructed with a String class. A button 
should display under the Setter column if an attribute is writable.
Not 
sure if we want to allow this but my initial implementation allows

it.



   I get an 'error:invalid reply from the server' while setting the
value using the setter button. After this the JMX viewer stopped
working. It kept returning same error for all the clicks.

  


I'm not seeing this in my machine. Can you please file a jira for this 
and include some steps on how to replicate the error?


  
   The following are minor things that should be easy to fix - 
1. The deploymentDescriptor attribute of the WebModule (see

framework.war) is not right.
  
  

Can you give more details? What is not right?



   The value of DD is not right. (See DD.jpg). To create this search
for j2eeType=WebModule and click on remote-deploy-tomcat. The DD was
not listed as an attribute in the normal display of J2EEMBeans --
WebModule.
   All the attributes of TomcatWebConnector are not listed.

  


I'm not seeing the exact problem you are seeing but I was able to 
replicate the problem of not displaying all the attributes of a web 
module. I created a jira for this - 
http://issues.apache.org/jira/browse/GERONIMO-2471



2. In 'J2EE MBeans' -- attribute display the Getter and Setter
  

columns


are redundant. And we should color code the value of
readable/writable/manageable attributes (jconsole2.doc). I do not
  

know


how easy this will be.
  
  

Can you explain more why you think it’s redundant?



A readable attribute X implies it has a getter. If the attribute
type is boolean the getter is 'isX' otherwise it is getX. The only
exceptions to this are the magical attributes like classloader, kernel
etc. Similarly a writable attribute implies a setter. We should use a
different color for magical attribute (if possible).

  


IMO this might be automatic for us developers but not for 
non-developers. We can’t expect that all users of the console are 
technical. One reason why these columns are included here is for 
completeness. These are all the information that we can extract from a 
GAttributeInfo class. Another reason is the setter column is used to 
display a button with the setter name as the label for setting writable 
attributes. The getter might be used the same way for getting the latest 
value of an attribute as a future enhancement. Removing these columns 
will disable these features. I’m open to removing these columns if 
others think this is a bad idea.



3. Jconsole does not display GBeanInfo but JMX Viewer does. The JMX
viewer should display a message 'click here for more info' in the
geronimo.config --'GBeanInfo' row, and display full information
  

only


when the user clicks on it. Jconsole has similar feature

Remarks on quoting style in emails (was: Re: JMX Viewer)

2006-10-06 Thread Jacek Laskowski

On 10/6/06, Christopher M. Cardona [EMAIL PROTECTED] wrote:

See inline comments...

anita kulshreshtha wrote:
 Comments inline..


I've been following this type of quoting for a while and think it's
time to change (improve?) it a little. I've seen that Anita has been
doing it too, but let me take your email as an example. I'd like to
hear everybody's opinion on them before changing anything, though,
since *I* might be completely wrong.

Here are my comments:

1/ Comments inline are unnecessary. We all know that we send emails
to be involved in a converstation. We'll look them up.



 --- Christopher M. Cardona [EMAIL PROTECTED] wrote:



 1. Is it possible to display 'Geronimo MBeans' (console.doc) sorted
 according to the configurations they belong to?

 snip...


2/ Some emails need formatting before responding. Remove unnecessary
empty lines as they don't bring any value and complicate reading.


 One thing we can do is
 to
 add a list of ServiceModules and clicking each node will list its
 MBeans
 which is almost close to what you want.


This would be nice to have.


OK. I already created a JIRA for this -
http://issues.apache.org/jira/browse/GERONIMO-2448.
 2. Is it possible to view tomcat MBeans?


 Yes. Currently there are two ways to do this the fastest. One option
 is
 to navigate the tree - Geronimo MBeans  GBean. Another option is to
 do
 an MBean search using a pattern like: geronimo:j2eeType=GBean,*.
 Both
 will give a list of all the GBeans which include the Tomcat MBeans.


This only gives only the MBeans that have been exposed via GBeans. A
 typical tomcat MBean has a name attribute like:
 Name: Geronimo:type=Connector, port=8443, address=%2F0.0.0.0


3/ Do not quote too much - only relevant part of a message. The rest
is in the original message and everybody can read it in the archives
(unless it's not in one's mailbox already)

If you think they're valid points please use them. Else comment on
them so I'll change my habits and expectations.

Jacek

--
Jacek Laskowski
http://www.laskowski.net.pl


Re: JMX Viewer

2006-10-06 Thread anita kulshreshtha
Chris, I was going through the code (JMXServer.jsp). I see that all the MBean names are hardcoded. Is this something that is required by dojo? Ideally, when the JMXViewer is invoked for the first time the MBean names should be generated using kernel.listGBeans. Am I missing something?ThanksAnita- Original Message From: anita kulshreshtha [EMAIL PROTECTED]To: dev@geronimo.apache.orgSent: Thursday, September 28, 2006 10:25:19 AMSubject: Re: JMX Viewer.

Re: JMX Viewer

2006-10-06 Thread Christopher M. Cardona

Anita,

This is not a requirement of Dojo. AFAIK there is no way of getting a 
list of all the j2eeTypes (standard j2ee and G specific) using any 
Kernel api. I got the list by looking at G source and combining it with 
the different types returned when calling Kernel.listGBeans(). If you 
know a solution for this then I'm more than willing to try it out.


Best wishes,
chris

anita kulshreshtha wrote:

Chris,
 I was going through the code (JMXServer.jsp). I see that all the 
MBean names are hardcoded. Is this something that is required by dojo? 
Ideally, when the JMXViewer is invoked for the first time the MBean 
names should be generated using kernel.listGBeans. Am I missing something?


Thanks
Anita

- Original Message 
From: anita kulshreshtha [EMAIL PROTECTED]
To: dev@geronimo.apache.org
Sent: Thursday, September 28, 2006 10:25:19 AM
Subject: Re: JMX Viewer

.






Re: JMX Viewer

2006-09-26 Thread Christopher M. Cardona

Anita,

Thanks for spending time on checking out the JMX viewer portlet. Your 
comments are definitely helpful. Please see my comments below...


anita kulshreshtha wrote:

Chris,
Thanks for the great work! I have been comparing jmx viewer with
the jconsole view. I would like to make some comments. I will start
with some features that are personal preferences and I do not have
strong opinion about them. 
1. Is it possible to display 'Geronimo MBeans' (console.doc) sorted

according to the configurations they belong to? I like jconsole's
presentation (jconsole1.doc) and find it more informative. Here is the
link for running jconsole
http://www.nabble.com/Browsing-G-1.1-using-jconsole-p3982569.html
  


I think this is possible but we need to refactor our current design 
which basically groups MBeans using the j2eeType. JConsole groups MBeans 
using the object name keys following its order which IMO sometimes 
doesn’t result to a very organized grouping. I would say this will be a 
major change if we decide to implement this. One thing we can do is to 
add a list of ServiceModules and clicking each node will list its MBeans 
which is almost close to what you want. I’m open to other suggestions…



2. Is it possible to view tomcat MBeans?
  


Yes. Currently there are two ways to do this the fastest. One option is 
to navigate the tree - Geronimo MBeans  GBean. Another option is to do 
an MBean search using a pattern like: “geronimo:j2eeType=GBean,*”. Both 
will give a list of all the GBeans which include the Tomcat MBeans.



3. I like the jconsole's view of the attributes (jconsole2.doc). The
attributes are color coded. Jconsole even allows modification of these
attributes. I am not sure if we want to allow that. Please compare this
with console2.doc
  


I think this is doable. We can set the Attribute value’s color depending 
on its property (readonly, writable, unavailable). Right now modifying 
the attribute values is supported but with limitation. We can only set 
the values for attributes with primitive data types and some commonly 
used classes that can be constructed with a String class. A button 
should display under the Setter column if an attribute is writable. Not 
sure if we want to allow this but my initial implementation allows it.


   The following are minor things that should be easy to fix - 
1. The deploymentDescriptor attribute of the WebModule (see

framework.war) is not right.
  

Can you give more details? What is not right?

2. In 'J2EE MBeans' -- attribute display the Getter and Setter columns
are redundant. And we should color code the value of
readable/writable/manageable attributes (jconsole2.doc). I do not know
how easy this will be.
  

Can you explain more why you think it’s redundant?

3. Jconsole does not display GBeanInfo but JMX Viewer does. The JMX
viewer should display a message 'click here for more info' in the
geronimo.config --'GBeanInfo' row, and display full information only
when the user clicks on it. Jconsole has similar feature for some
values. The current view (console3.doc) is hard to comprehend.
  


A couple of things we can do here. One is to totally remove the display 
of GBeanInfo attribute which I think is redundant data or if we decide 
not to remove it then I can just copy what JConsole is doing which is to 
display ‘Unavailable’ for the GBeanInfo value. Your suggestion of 
clicking and displaying full information needs more work because of the 
way Dojo table widget is designed. What do you think?


  
 I hope you find these comments constructive.


thanks
Anita
  


This helps a lot. Any feedback I can get is always positive. ;)

Best wishes,

Chris


__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com