Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
OK, fixed: - http://issues.apache.org/jira/browse/GERONIMO-1434 - http://issues.apache.org/jira/browse/GERONIMO-1884 - http://issues.apache.org/jira/browse/GERONIMO-1938 - http://issues.apache.org/jira/browse/GERONIMO-1791 - http://issues.apache.org/jira/browse/GERONIMO-1817 - http://issues.apache.org/jira/browse/GERONIMO-1887 - http://issues.apache.org/jira/browse/GERONIMO-2093 Won't fix - http://issues.apache.org/jira/browse/GERONIMO-2083 Maybe someone else could look at: - http://issues.apache.org/jira/browse/GERONIMO-1451 - http://issues.apache.org/jira/browse/GERONIMO-1781 Thanks, Aaron On 6/8/06, David Jencks <[EMAIL PROTECTED]> wrote: On Jun 7, 2006, at 9:23 PM, Aaron Mulder wrote: > On 6/7/06, Matt Hogstrom <[EMAIL PROTECTED]> wrote: >> Its been a long day and I've caught up on the JIRAs you created. >> I think I'm ok with your fixes >> given the JIRA entries I read through. > > OK I'm OK with these bug fixes too. > >> I think the PluginRepositoryExporter.java should not be hardcoding >> values in it. Can you look at >> moving this to a property file in the future? Geronimo has way >> too many configuration items hard >> coded in the server (or requires a server rebuild to make >> changes). I would prefer not to see any >> other changes in this area for 1.1. > > Yes, it was just going to be a bigger change to put in a properties > file and get it to read from that. > >> Are there any other bugs that you are aware of that we need to be >> tracking? > > http://issues.apache.org/jira/browse/GERONIMO-1434 > > There's an OpenEJB patch listed as pending. I think this was the one > that caused all the problems when the repo was down and has now been > applied, but I'm not sure. David J, can you confirm? Kevan applied the patch for me, I've closed this one. > > http://issues.apache.org/jira/browse/GERONIMO-1451 > > There's an ActiveMQ patch that hasn't been applied because it needs to > be done against the *-g1_1 module not the 1.0 module. Perhaps not > tremendously important, but if it fixes the problem it would be nice > to put into ActiveMQ 3.2.4 instead of immediately going to a new > ActiveMQ SNAPSHOT. > > http://issues.apache.org/jira/browse/GERONIMO-1884 > > Should change the terminology on the plugin screen in the console to > be consistent (there's a patch for this in > http://issues.apache.org/jira/browse/GERONIMO-1938), and perhaps add a > few words about removing plugins. I don't think we need to do > anything else for this issue. > > http://issues.apache.org/jira/browse/GERONIMO-1791 > http://issues.apache.org/jira/browse/GERONIMO-1817 > > Trivial patches to avoid NPEs in the LDAP realm. > > http://issues.apache.org/jira/browse/GERONIMO-1781 > > Reportedly, the repository blows up on a module like foo-1.jar > > NO URL > > There's no Jira for this, but we should remove the "old keystore" > portlet from the console for the 1.1 release (but leave it there for > 1.1.1, until all the functionality is replaced). > > http://issues.apache.org/jira/browse/GERONIMO-1887 > > The console has 1.7 MB of (potentially) unnecessary JARs. > > http://issues.apache.org/jira/browse/GERONIMO-2083 > > Should we upgrade to the current HOWL? no, we'd need an upload to ibiblio for this. I got a nice m2 build for howl working and created an m2 compliant upload request, but maven is not accepting them until it gets a new piece of hardware set up. thanks for looking through all of these! david jencks > > http://issues.apache.org/jira/browse/GERONIMO-1922 > > Would be nice to force a plugin export to fail if you've used the > SharedLib dependency. I thought we had done this, but I don't see the > code. So for now it's a "training issue". > > > I can look at most of these before noon on 6/8 if you are OK with > that. Anything that you don't want to see go in? > >> Also, if you could take a whack at the JIRAs you moved into 1.1 >> and move them out that would be >> really helpful. > > Hmm... thought you were going to do that. :) > > Thanks, > Aaron > >> Matt Hogstrom wrote: >> > Aaron, >> > >> > We are in the process of releasing 1.1. In the release note I >> requested >> > that people please let me know before commiting changes to 1.1. >> The >> > number of changes you've made below are significant changes. >> Can you >> > please revert this change as well as 412621 and hold them for >> 1.1 please. >> > >> > For specific issues with 1.1 please post a note about the change >> so we >> > can discuss the content of hte change before applying it to the >> build. >> > >> > If you would like to bring these issues forward for discussion that >> > would be fine but I'm inclinced to get 1.1 out and have these in >> 1.1.1. >> > >> > Thanks. >> > >> > Matt >> > >> > [EMAIL PROTECTED] wrote: >> >> Author: ammulder >> >> Date: Wed Jun 7 15:56:52 2006 >> >> New Revision: 412604 >> >> >> >> URL: http://svn.apache.org/viewvc?rev=412604&view=rev >> >> Log: >> >> Fixes to config.xml, plugins, plugin repo li
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
On 6/8/06, Alan D. Cabrera <[EMAIL PROTECTED]> wrote: I see some gold plating sneaking into a feature "frozen" branch. Since I am not doing any heavy lifting, I'll leave my comment at that. I've volunteered to be release manager for 1.2. Want to join me? A little counterweight? :) Thanks, Aaron Matt Hogstrom wrote: > Aaron, > > Its been a long day and I've caught up on the JIRAs you created. I > think I'm ok with your fixes given the JIRA entries I read through. > > I think the PluginRepositoryExporter.java should not be hardcoding > values in it. Can you look at moving this to a property file in the > future? Geronimo has way too many configuration items hard coded in > the server (or requires a server rebuild to make changes). I would > prefer not to see any other changes in this area for 1.1. > > Are there any other bugs that you are aware of that we need to be > tracking? > > Also, if you could take a whack at the JIRAs you moved into 1.1 and > move them out that would be really helpful. > > Thanks > > Matt > > Matt Hogstrom wrote: >> Aaron, >> >> We are in the process of releasing 1.1. In the release note I >> requested that people please let me know before commiting changes to >> 1.1. The number of changes you've made below are significant >> changes. Can you please revert this change as well as 412621 and >> hold them for 1.1 please. >> >> For specific issues with 1.1 please post a note about the change so >> we can discuss the content of hte change before applying it to the >> build. >> >> If you would like to bring these issues forward for discussion that >> would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1. >> >> Thanks. >> >> Matt >> >> [EMAIL PROTECTED] wrote: >>> Author: ammulder >>> Date: Wed Jun 7 15:56:52 2006 >>> New Revision: 412604 >>> >>> URL: http://svn.apache.org/viewvc?rev=412604&view=rev >>> Log: >>> Fixes to config.xml, plugins, plugin repo list, plugin installer >>> - Plugin exporter can map current version to a set of supported >>> versions >>>to help with problems caused by plugins not running on new test >>> builds >>>of Geronimo >>> - config.xml has placeholder for user-added plugin repositories >>>GERONIMO-2076 >>> - Removed Apache directory content from config.xml for 4 main >>> assemblies >>> - Added directory config.xml content to directory plugin metadata >>> - Plugin installer writes correct elements for config.xml content >>>GERONIMO-2088 >>> - Plugin exporter includes file copy and config.xml content >>>GERONIMO-2089 >>> - Plugin repository list points to a version-specific file (so 1.1 and >>>1.2 can point to different repositories) >>> - Trim entries in plugin repository list, just in case >>> - Remove some extraneous logging during console plugin download >>> >>> Modified: >>> >>> geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java >>> >>> >>> geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml >>> >>> >>> geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml >>> >>> >>> geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml >>> >>> >>> geronimo/branches/1.1/assemblies/minimal-tomcat-server/src/var/config/config.xml >>> >>> >>> geronimo/branches/1.1/assemblies/j2ee-installer/src/var/config/config.xml >>> >>> >>> geronimo/branches/1.1/configs/directory/src/conf/geronimo-plugin.xml >>> >>> geronimo/branches/1.1/modules/common/src/test/org/apache/geronimo/common/propertyeditor/AbstractCollectionEditorTest.java >>> >>> >>> geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java >>> >>> >>> geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginRepositoryDownloader.java >>> >>> >>> geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/util/PluginRepositoryExporter.java >>> >>> >>> Modified: >>> geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java >>> >>> URL: >>> http://svn.apache.org/viewvc/geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java?rev=412604&r1=412603&r2=412604&view=diff >>> >>> == >>> >>> --- >>> geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java >>> (original) >>> +++ >>> geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java >>> Wed Jun 7 15:56:52 2006 >>> @@ -152,9 +152,9 @@ >>> >>> progressInfo.setMainMessage(results.getCurrentMessage()); >>> >>> progressInfo.setProgressPercent(results.getCurrentFilePercent()); >>> progressInfo.setFinished(results.isFinished()); >>> -
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
P.S. :) You guys rock, BTW!
Alan D. Cabrera wrote:
I see some gold plating sneaking into a feature "frozen" branch.
Since I am not doing any heavy lifting, I'll leave my comment at that.
Regards,
Alan
Matt Hogstrom wrote:
Aaron,
Its been a long day and I've caught up on the JIRAs you created. I
think I'm ok with your fixes given the JIRA entries I read through.
I think the PluginRepositoryExporter.java should not be hardcoding
values in it. Can you look at moving this to a property file in the
future? Geronimo has way too many configuration items hard coded in
the server (or requires a server rebuild to make changes). I would
prefer not to see any other changes in this area for 1.1.
Are there any other bugs that you are aware of that we need to be
tracking?
Also, if you could take a whack at the JIRAs you moved into 1.1 and
move them out that would be really helpful.
Thanks
Matt
Matt Hogstrom wrote:
Aaron,
We are in the process of releasing 1.1. In the release note I
requested that people please let me know before commiting changes to
1.1. The number of changes you've made below are significant
changes. Can you please revert this change as well as 412621 and
hold them for 1.1 please.
For specific issues with 1.1 please post a note about the change so
we can discuss the content of hte change before applying it to the
build.
If you would like to bring these issues forward for discussion that
would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1.
Thanks.
Matt
[EMAIL PROTECTED] wrote:
Author: ammulder
Date: Wed Jun 7 15:56:52 2006
New Revision: 412604
URL: http://svn.apache.org/viewvc?rev=412604&view=rev
Log:
Fixes to config.xml, plugins, plugin repo list, plugin installer
- Plugin exporter can map current version to a set of supported
versions
to help with problems caused by plugins not running on new test
builds
of Geronimo
- config.xml has placeholder for user-added plugin repositories
GERONIMO-2076
- Removed Apache directory content from config.xml for 4 main
assemblies
- Added directory config.xml content to directory plugin metadata
- Plugin installer writes correct elements for config.xml content
GERONIMO-2088
- Plugin exporter includes file copy and config.xml content
GERONIMO-2089
- Plugin repository list points to a version-specific file (so 1.1
and
1.2 can point to different repositories)
- Trim entries in plugin repository list, just in case
- Remove some extraneous logging during console plugin download
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-installer/src/var/config/config.xml
geronimo/branches/1.1/configs/directory/src/conf/geronimo-plugin.xml
geronimo/branches/1.1/modules/common/src/test/org/apache/geronimo/common/propertyeditor/AbstractCollectionEditorTest.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginRepositoryDownloader.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/util/PluginRepositoryExporter.java
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
URL:
http://svn.apache.org/viewvc/geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java?rev=412604&r1=412603&r2=412604&view=diff
==
---
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
(original)
+++
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
Wed Jun 7 15:56:52 2006
@@ -152,9 +152,9 @@
progressInfo.setMainMessage(results.getCurrentMessage());
progressInfo.setProgressPercent(results.getCurrentFilePercent());
progressInfo.setFinished(results.isFinished());
-log.info(progressInfo.getMainMessage());
+log.debug(progressInfo.getMainMessage());
if (results.isFinished()) {
-log.info("Installation finished");
+log.debug("Installation finished");
session.setAttribute(DOWNLOAD_RESULTS_SESSION_KEY, results);
break
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
I see some gold plating sneaking into a feature "frozen" branch. Since
I am not doing any heavy lifting, I'll leave my comment at that.
Regards,
Alan
Matt Hogstrom wrote:
Aaron,
Its been a long day and I've caught up on the JIRAs you created. I
think I'm ok with your fixes given the JIRA entries I read through.
I think the PluginRepositoryExporter.java should not be hardcoding
values in it. Can you look at moving this to a property file in the
future? Geronimo has way too many configuration items hard coded in
the server (or requires a server rebuild to make changes). I would
prefer not to see any other changes in this area for 1.1.
Are there any other bugs that you are aware of that we need to be
tracking?
Also, if you could take a whack at the JIRAs you moved into 1.1 and
move them out that would be really helpful.
Thanks
Matt
Matt Hogstrom wrote:
Aaron,
We are in the process of releasing 1.1. In the release note I
requested that people please let me know before commiting changes to
1.1. The number of changes you've made below are significant
changes. Can you please revert this change as well as 412621 and
hold them for 1.1 please.
For specific issues with 1.1 please post a note about the change so
we can discuss the content of hte change before applying it to the
build.
If you would like to bring these issues forward for discussion that
would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1.
Thanks.
Matt
[EMAIL PROTECTED] wrote:
Author: ammulder
Date: Wed Jun 7 15:56:52 2006
New Revision: 412604
URL: http://svn.apache.org/viewvc?rev=412604&view=rev
Log:
Fixes to config.xml, plugins, plugin repo list, plugin installer
- Plugin exporter can map current version to a set of supported
versions
to help with problems caused by plugins not running on new test
builds
of Geronimo
- config.xml has placeholder for user-added plugin repositories
GERONIMO-2076
- Removed Apache directory content from config.xml for 4 main
assemblies
- Added directory config.xml content to directory plugin metadata
- Plugin installer writes correct elements for config.xml content
GERONIMO-2088
- Plugin exporter includes file copy and config.xml content
GERONIMO-2089
- Plugin repository list points to a version-specific file (so 1.1 and
1.2 can point to different repositories)
- Trim entries in plugin repository list, just in case
- Remove some extraneous logging during console plugin download
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-installer/src/var/config/config.xml
geronimo/branches/1.1/configs/directory/src/conf/geronimo-plugin.xml
geronimo/branches/1.1/modules/common/src/test/org/apache/geronimo/common/propertyeditor/AbstractCollectionEditorTest.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginRepositoryDownloader.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/util/PluginRepositoryExporter.java
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
URL:
http://svn.apache.org/viewvc/geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java?rev=412604&r1=412603&r2=412604&view=diff
==
---
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
(original)
+++
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
Wed Jun 7 15:56:52 2006
@@ -152,9 +152,9 @@
progressInfo.setMainMessage(results.getCurrentMessage());
progressInfo.setProgressPercent(results.getCurrentFilePercent());
progressInfo.setFinished(results.isFinished());
-log.info(progressInfo.getMainMessage());
+log.debug(progressInfo.getMainMessage());
if (results.isFinished()) {
-log.info("Installation finished");
+log.debug("Installation finished");
session.setAttribute(DOWNLOAD_RESULTS_SESSION_KEY, results);
break;
} else {
Modified:
geronimo/branches
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
On Jun 7, 2006, at 9:23 PM, Aaron Mulder wrote: On 6/7/06, Matt Hogstrom <[EMAIL PROTECTED]> wrote: Its been a long day and I've caught up on the JIRAs you created. I think I'm ok with your fixes given the JIRA entries I read through. OK I'm OK with these bug fixes too. I think the PluginRepositoryExporter.java should not be hardcoding values in it. Can you look at moving this to a property file in the future? Geronimo has way too many configuration items hard coded in the server (or requires a server rebuild to make changes). I would prefer not to see any other changes in this area for 1.1. Yes, it was just going to be a bigger change to put in a properties file and get it to read from that. Are there any other bugs that you are aware of that we need to be tracking? http://issues.apache.org/jira/browse/GERONIMO-1434 There's an OpenEJB patch listed as pending. I think this was the one that caused all the problems when the repo was down and has now been applied, but I'm not sure. David J, can you confirm? Kevan applied the patch for me, I've closed this one. http://issues.apache.org/jira/browse/GERONIMO-1451 There's an ActiveMQ patch that hasn't been applied because it needs to be done against the *-g1_1 module not the 1.0 module. Perhaps not tremendously important, but if it fixes the problem it would be nice to put into ActiveMQ 3.2.4 instead of immediately going to a new ActiveMQ SNAPSHOT. http://issues.apache.org/jira/browse/GERONIMO-1884 Should change the terminology on the plugin screen in the console to be consistent (there's a patch for this in http://issues.apache.org/jira/browse/GERONIMO-1938), and perhaps add a few words about removing plugins. I don't think we need to do anything else for this issue. http://issues.apache.org/jira/browse/GERONIMO-1791 http://issues.apache.org/jira/browse/GERONIMO-1817 Trivial patches to avoid NPEs in the LDAP realm. http://issues.apache.org/jira/browse/GERONIMO-1781 Reportedly, the repository blows up on a module like foo-1.jar NO URL There's no Jira for this, but we should remove the "old keystore" portlet from the console for the 1.1 release (but leave it there for 1.1.1, until all the functionality is replaced). http://issues.apache.org/jira/browse/GERONIMO-1887 The console has 1.7 MB of (potentially) unnecessary JARs. http://issues.apache.org/jira/browse/GERONIMO-2083 Should we upgrade to the current HOWL? no, we'd need an upload to ibiblio for this. I got a nice m2 build for howl working and created an m2 compliant upload request, but maven is not accepting them until it gets a new piece of hardware set up. thanks for looking through all of these! david jencks http://issues.apache.org/jira/browse/GERONIMO-1922 Would be nice to force a plugin export to fail if you've used the SharedLib dependency. I thought we had done this, but I don't see the code. So for now it's a "training issue". I can look at most of these before noon on 6/8 if you are OK with that. Anything that you don't want to see go in? Also, if you could take a whack at the JIRAs you moved into 1.1 and move them out that would be really helpful. Hmm... thought you were going to do that. :) Thanks, Aaron Matt Hogstrom wrote: > Aaron, > > We are in the process of releasing 1.1. In the release note I requested > that people please let me know before commiting changes to 1.1. The > number of changes you've made below are significant changes. Can you > please revert this change as well as 412621 and hold them for 1.1 please. > > For specific issues with 1.1 please post a note about the change so we > can discuss the content of hte change before applying it to the build. > > If you would like to bring these issues forward for discussion that > would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1. > > Thanks. > > Matt > > [EMAIL PROTECTED] wrote: >> Author: ammulder >> Date: Wed Jun 7 15:56:52 2006 >> New Revision: 412604 >> >> URL: http://svn.apache.org/viewvc?rev=412604&view=rev >> Log: >> Fixes to config.xml, plugins, plugin repo list, plugin installer >> - Plugin exporter can map current version to a set of supported versions >>to help with problems caused by plugins not running on new test builds >>of Geronimo >> - config.xml has placeholder for user-added plugin repositories >>GERONIMO-2076 >> - Removed Apache directory content from config.xml for 4 main assemblies >> - Added directory config.xml content to directory plugin metadata >> - Plugin installer writes correct elements for config.xml content >>GERONIMO-2088 >> - Plugin exporter includes file copy and config.xml content >>GERONIMO-2089 >> - Plugin repository list points to a version-specific file (so 1.1 and >>1.2 can point to different repositories) >> - Trim entries in plugin repository list, just in case >> - Remove some extraneous logging during console plugin downloa
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
On 6/7/06, Matt Hogstrom <[EMAIL PROTECTED]> wrote: Its been a long day and I've caught up on the JIRAs you created. I think I'm ok with your fixes given the JIRA entries I read through. OK I think the PluginRepositoryExporter.java should not be hardcoding values in it. Can you look at moving this to a property file in the future? Geronimo has way too many configuration items hard coded in the server (or requires a server rebuild to make changes). I would prefer not to see any other changes in this area for 1.1. Yes, it was just going to be a bigger change to put in a properties file and get it to read from that. Are there any other bugs that you are aware of that we need to be tracking? http://issues.apache.org/jira/browse/GERONIMO-1434 There's an OpenEJB patch listed as pending. I think this was the one that caused all the problems when the repo was down and has now been applied, but I'm not sure. David J, can you confirm? http://issues.apache.org/jira/browse/GERONIMO-1451 There's an ActiveMQ patch that hasn't been applied because it needs to be done against the *-g1_1 module not the 1.0 module. Perhaps not tremendously important, but if it fixes the problem it would be nice to put into ActiveMQ 3.2.4 instead of immediately going to a new ActiveMQ SNAPSHOT. http://issues.apache.org/jira/browse/GERONIMO-1884 Should change the terminology on the plugin screen in the console to be consistent (there's a patch for this in http://issues.apache.org/jira/browse/GERONIMO-1938), and perhaps add a few words about removing plugins. I don't think we need to do anything else for this issue. http://issues.apache.org/jira/browse/GERONIMO-1791 http://issues.apache.org/jira/browse/GERONIMO-1817 Trivial patches to avoid NPEs in the LDAP realm. http://issues.apache.org/jira/browse/GERONIMO-1781 Reportedly, the repository blows up on a module like foo-1.jar NO URL There's no Jira for this, but we should remove the "old keystore" portlet from the console for the 1.1 release (but leave it there for 1.1.1, until all the functionality is replaced). http://issues.apache.org/jira/browse/GERONIMO-1887 The console has 1.7 MB of (potentially) unnecessary JARs. http://issues.apache.org/jira/browse/GERONIMO-2083 Should we upgrade to the current HOWL? http://issues.apache.org/jira/browse/GERONIMO-1922 Would be nice to force a plugin export to fail if you've used the SharedLib dependency. I thought we had done this, but I don't see the code. So for now it's a "training issue". I can look at most of these before noon on 6/8 if you are OK with that. Anything that you don't want to see go in? Also, if you could take a whack at the JIRAs you moved into 1.1 and move them out that would be really helpful. Hmm... thought you were going to do that. :) Thanks, Aaron Matt Hogstrom wrote: > Aaron, > > We are in the process of releasing 1.1. In the release note I requested > that people please let me know before commiting changes to 1.1. The > number of changes you've made below are significant changes. Can you > please revert this change as well as 412621 and hold them for 1.1 please. > > For specific issues with 1.1 please post a note about the change so we > can discuss the content of hte change before applying it to the build. > > If you would like to bring these issues forward for discussion that > would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1. > > Thanks. > > Matt > > [EMAIL PROTECTED] wrote: >> Author: ammulder >> Date: Wed Jun 7 15:56:52 2006 >> New Revision: 412604 >> >> URL: http://svn.apache.org/viewvc?rev=412604&view=rev >> Log: >> Fixes to config.xml, plugins, plugin repo list, plugin installer >> - Plugin exporter can map current version to a set of supported versions >>to help with problems caused by plugins not running on new test builds >>of Geronimo >> - config.xml has placeholder for user-added plugin repositories >>GERONIMO-2076 >> - Removed Apache directory content from config.xml for 4 main assemblies >> - Added directory config.xml content to directory plugin metadata >> - Plugin installer writes correct elements for config.xml content >>GERONIMO-2088 >> - Plugin exporter includes file copy and config.xml content >>GERONIMO-2089 >> - Plugin repository list points to a version-specific file (so 1.1 and >>1.2 can point to different repositories) >> - Trim entries in plugin repository list, just in case >> - Remove some extraneous logging during console plugin download >> >> Modified: >> >> geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java >> >> >> geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml >> >> >> geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml >> >> >> geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml >> >> >> geronimo/branches/1.1/assemblies/mini
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
Aaron,
Its been a long day and I've caught up on the JIRAs you created. I think I'm ok with your fixes
given the JIRA entries I read through.
I think the PluginRepositoryExporter.java should not be hardcoding values in it. Can you look at
moving this to a property file in the future? Geronimo has way too many configuration items hard
coded in the server (or requires a server rebuild to make changes). I would prefer not to see any
other changes in this area for 1.1.
Are there any other bugs that you are aware of that we need to be tracking?
Also, if you could take a whack at the JIRAs you moved into 1.1 and move them out that would be
really helpful.
Thanks
Matt
Matt Hogstrom wrote:
Aaron,
We are in the process of releasing 1.1. In the release note I requested
that people please let me know before commiting changes to 1.1. The
number of changes you've made below are significant changes. Can you
please revert this change as well as 412621 and hold them for 1.1 please.
For specific issues with 1.1 please post a note about the change so we
can discuss the content of hte change before applying it to the build.
If you would like to bring these issues forward for discussion that
would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1.
Thanks.
Matt
[EMAIL PROTECTED] wrote:
Author: ammulder
Date: Wed Jun 7 15:56:52 2006
New Revision: 412604
URL: http://svn.apache.org/viewvc?rev=412604&view=rev
Log:
Fixes to config.xml, plugins, plugin repo list, plugin installer
- Plugin exporter can map current version to a set of supported versions
to help with problems caused by plugins not running on new test builds
of Geronimo
- config.xml has placeholder for user-added plugin repositories
GERONIMO-2076
- Removed Apache directory content from config.xml for 4 main assemblies
- Added directory config.xml content to directory plugin metadata
- Plugin installer writes correct elements for config.xml content
GERONIMO-2088
- Plugin exporter includes file copy and config.xml content
GERONIMO-2089
- Plugin repository list points to a version-specific file (so 1.1 and
1.2 can point to different repositories)
- Trim entries in plugin repository list, just in case
- Remove some extraneous logging during console plugin download
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/minimal-tomcat-server/src/var/config/config.xml
geronimo/branches/1.1/assemblies/j2ee-installer/src/var/config/config.xml
geronimo/branches/1.1/configs/directory/src/conf/geronimo-plugin.xml
geronimo/branches/1.1/modules/common/src/test/org/apache/geronimo/common/propertyeditor/AbstractCollectionEditorTest.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginRepositoryDownloader.java
geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/util/PluginRepositoryExporter.java
Modified:
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
URL:
http://svn.apache.org/viewvc/geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java?rev=412604&r1=412603&r2=412604&view=diff
==
---
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
(original)
+++
geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java
Wed Jun 7 15:56:52 2006
@@ -152,9 +152,9 @@
progressInfo.setMainMessage(results.getCurrentMessage());
progressInfo.setProgressPercent(results.getCurrentFilePercent());
progressInfo.setFinished(results.isFinished());
-log.info(progressInfo.getMainMessage());
+log.debug(progressInfo.getMainMessage());
if (results.isFinished()) {
-log.info("Installation finished");
+log.debug("Installation finished");
session.setAttribute(DOWNLOAD_RESULTS_SESSION_KEY, results);
break;
} else {
Modified:
geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml
URL:
http://svn.apache.org/viewvc/geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml?rev=412604&r1
Re: Please reverse these commits...Re: svn commit: r412604 - in /geronimo/branches/1.1: applications/console-standard/src/java/org/apache/geronimo/console/car/ assemblies/j2ee-jetty-server/src/var/con
Isn't the point of creating a release candidate to flush out any final problems before the release? We created a release candidate... We found some problems (with the plugin installer, the config.xml, one of the plugins, etc.). I fixed them. Now I think we're closer to having a solid 1.1 release. As far as you asking to let you know, I send you a heads up e-mail before I committed the changes. What did you have in mind? As far as "in the process of releasing 1.1" -- I'm not sure what that means. Does that mean that you're actively producing 1.1 artifacts? I'd have to say that if so, IMHO that's a mistake -- we can't produce our only release candidate and cut the release 24 hours later and ignore the feedback on the release candidate. Finally, as to what goes in 1.1 vs. 1.1.1... I have a strong preference for putting plugin installer fixes in for 1.1. The issue is, we can use the plugin installer to make 1.1.1 an in-place upgrade (no restart, etc.). I think in-place upgrades are one of our big competitive advantages. But the plugin installer can't replace itself (or anything in j2ee-system or rmi-naming). And, happily, there's no TCK impact. Also, there's no process for removing arbitrary config.xml content at runtime or as part of an installation. So the only way to remove the directory cruft that causes exceptions if you use it is to actually change the config.xml file before we ship it. If your perspective is different, can you lay out the time frame for any additional release candidates, fixes based on problems found in the release candidates, finalizing the RELEASE-NOTES-1.1.txt file for the final build (which, by the way, is 90% incorrect and needs a lot of love), creating a final tag/build, TCK testing the final build, posting the plugins built from the final tag, etc.? I'd suggest the most aggressive plan would be to get the README, the ActiveMQ release, and any final issues found in the release candidate fixed up in the next 48 hours, creating a final release candidate on Friday, TCK testing it over the weekend, and voting on it next week. But that still only gives 72 hours for community feedback on the 6/7 release candidate before it gets set in stone. Thanks, Aaron On 6/7/06, Matt Hogstrom <[EMAIL PROTECTED]> wrote: Aaron, We are in the process of releasing 1.1. In the release note I requested that people please let me know before commiting changes to 1.1. The number of changes you've made below are significant changes. Can you please revert this change as well as 412621 and hold them for 1.1 please. For specific issues with 1.1 please post a note about the change so we can discuss the content of hte change before applying it to the build. If you would like to bring these issues forward for discussion that would be fine but I'm inclinced to get 1.1 out and have these in 1.1.1. Thanks. Matt [EMAIL PROTECTED] wrote: > Author: ammulder > Date: Wed Jun 7 15:56:52 2006 > New Revision: 412604 > > URL: http://svn.apache.org/viewvc?rev=412604&view=rev > Log: > Fixes to config.xml, plugins, plugin repo list, plugin installer > - Plugin exporter can map current version to a set of supported versions >to help with problems caused by plugins not running on new test builds >of Geronimo > - config.xml has placeholder for user-added plugin repositories >GERONIMO-2076 > - Removed Apache directory content from config.xml for 4 main assemblies > - Added directory config.xml content to directory plugin metadata > - Plugin installer writes correct elements for config.xml content >GERONIMO-2088 > - Plugin exporter includes file copy and config.xml content >GERONIMO-2089 > - Plugin repository list points to a version-specific file (so 1.1 and >1.2 can point to different repositories) > - Trim entries in plugin repository list, just in case > - Remove some extraneous logging during console plugin download > > Modified: > geronimo/branches/1.1/applications/console-standard/src/java/org/apache/geronimo/console/car/DownloadCARHandler.java > geronimo/branches/1.1/assemblies/j2ee-jetty-server/src/var/config/config.xml > geronimo/branches/1.1/assemblies/j2ee-tomcat-server/src/var/config/config.xml > geronimo/branches/1.1/assemblies/minimal-jetty-server/src/var/config/config.xml > geronimo/branches/1.1/assemblies/minimal-tomcat-server/src/var/config/config.xml > geronimo/branches/1.1/assemblies/j2ee-installer/src/var/config/config.xml > geronimo/branches/1.1/configs/directory/src/conf/geronimo-plugin.xml > geronimo/branches/1.1/modules/common/src/test/org/apache/geronimo/common/propertyeditor/AbstractCollectionEditorTest.java > geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java > geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/plugin/PluginRepositoryDownloader.java > geronimo/branches/1.1/modules/system/src/java/org/a
