Re: Possible user code changes required when we upgrade to Tomcat 6.0.18
For the new spec compliant escape quoting behavior, users can enable the
prior support in Tomcat by setting -
org.apache.jasper.compiler.Parser.STRICT_QUOTE_ESCAPING=false
http://www.nabble.com/svn-commit%3A-r685823---in--tomcat%3A-container-tc5.5.x-webapps-docs-config-systemprops.xml-current-tc5.5.x-STATUS.txt-jasper-tc5.5.x-src-share-org-apache-jasper-compiler-Parser.java-jasper-tc5.5.x-src-share-org-apache-jasper-resources-LocalStrings.properties-tt18978132.html
-Donald
Donald Woods wrote:
This is a notice to developers and users -
I've run into several JSP files in our build (mainly the monitor webapp)
that require code changes to work with Tomcat 6.0.18, due to tightened
code around the JSP 2.0 spec in Jasper during the Tomcat 6.0.17 release.
The build errors look something like -
org.apache.jasper.JasperException:
file:/Users/drwoods/geronimo/server-trunk/plugins/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditView.jsp(168,168)
Attribute value rs.getString("server_id") is quoted with " which must be
escaped when used within the value
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
There are several places in the portlet code where we have -
value="<%=rs.getString("server_id")%>"
which had to be changed to
value='<%=rs.getString("server_id")%>'
The full text of the Tomcat Jasper change can be found at -
https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
with the basic explanation being -
According to JSP 2.0 specification (chapter 1.7 page 72,73)
This code is illegal:
" />
Instead the correct sentence would be:
" />
...
-Donald
smime.p7s
Description: S/MIME Cryptographic Signature
Re: Possible user code changes required when we upgrade to Tomcat 6.0.18
Think I'm making progress
If I upgrade the 2.1 branch to 6.0.18 and build, I get compile time
errors which don't show up with trunk builds -
[INFO]
[ERROR] FATAL ERROR
[INFO]
[INFO]
file:/Users/drwoods/geronimo/server-2.1.x/plugins/activemq/activemq-portlets/src/main/webapp/WEB-INF/view/jmswizard/factory.jsp(170,26)
"${empty(factory.instanceName)}" contains invalid expression(s):
javax.el.ELException: Function ':empty' not found
Changing the line from -
fixed the compile error. Now, I just need to fix all the other
occurrences of this
-Donald
Jarek Gawor wrote:
Donald,
The console testsuites are failing. I'm seeing the following exception
on a number of different portlets in the console:
11:49:49,298 ERROR [[JMSWizard]] Servlet.service() for servlet
JMSWizard threw exception
java.lang.ClassCastException: java.lang.NullPointerException
at
org.apache.el.lang.ExpressionBuilder.prepare(ExpressionBuilder.java:135)
at
org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:147)
at
org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:190)
at
org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68)
at
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:924)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fwhen_005f0(list_jsp.java:218)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fchoose_005f0(list_jsp.java:192)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspService(list_jsp.java:117)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:630)
at
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:535)
at
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:472)
at
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:106)
at
org.apache.geronimo.console.MultiPagePortlet.doView(MultiPagePortlet.java:151)
at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:247)
at javax.portlet.GenericPortlet.render(GenericPortlet.java:175)
at
org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:208)
at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:139)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:693)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
I'm not sure if this is a new bug somewhere or if some other changes
are required to the JSPs.
Jarek
On Fri, Aug 15, 2008 at 12:03 AM, Donald Woods <[EMAIL PROTECTED]> wrote:
This is a notice to developers and users -
I've run into several JSP files in our build (mainly the monitor webapp)
that require code changes to work with Tomcat 6.0.18, due to tightened code
around the JSP 2.0 spec in Jasper during the Tomcat 6.0.17 release.
The build errors look something like -
org.apache.jasper.JasperException:
file:/Users/drwoods/geronimo/server-trunk/plugins/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditView.jsp(168,168)
Attribute value rs.getString("server_id") is quoted with " which must be
escaped when used within the value
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
There are several places in the portlet code where we have -
value="<%=rs.getString("server_id")%>"
which had to be changed to
value='<%=rs.getString("server_id")%>'
The full text of the Tomcat Jasper change can be found at -
https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
with the basic explanation being -
According to JSP 2.0 specification (chapter 1.7 page 72,73)
This code is illegal:
" />
Instead the correct sentence would be:
" />
...
-Donald
smime.p7s
Description: S/MIME Cryptographic Signature
Re: Possible user code changes required when we upgrade to Tomcat 6.0.18
Yep, I'm looking at it. Thanks for mentioning it on the list.
-Donald
Jarek Gawor wrote:
Donald,
The console testsuites are failing. I'm seeing the following exception
on a number of different portlets in the console:
11:49:49,298 ERROR [[JMSWizard]] Servlet.service() for servlet
JMSWizard threw exception
java.lang.ClassCastException: java.lang.NullPointerException
at
org.apache.el.lang.ExpressionBuilder.prepare(ExpressionBuilder.java:135)
at
org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:147)
at
org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:190)
at
org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68)
at
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:924)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fwhen_005f0(list_jsp.java:218)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fchoose_005f0(list_jsp.java:192)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspService(list_jsp.java:117)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:630)
at
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:535)
at
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:472)
at
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:106)
at
org.apache.geronimo.console.MultiPagePortlet.doView(MultiPagePortlet.java:151)
at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:247)
at javax.portlet.GenericPortlet.render(GenericPortlet.java:175)
at
org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:208)
at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:139)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:693)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
I'm not sure if this is a new bug somewhere or if some other changes
are required to the JSPs.
Jarek
On Fri, Aug 15, 2008 at 12:03 AM, Donald Woods <[EMAIL PROTECTED]> wrote:
This is a notice to developers and users -
I've run into several JSP files in our build (mainly the monitor webapp)
that require code changes to work with Tomcat 6.0.18, due to tightened code
around the JSP 2.0 spec in Jasper during the Tomcat 6.0.17 release.
The build errors look something like -
org.apache.jasper.JasperException:
file:/Users/drwoods/geronimo/server-trunk/plugins/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditView.jsp(168,168)
Attribute value rs.getString("server_id") is quoted with " which must be
escaped when used within the value
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
There are several places in the portlet code where we have -
value="<%=rs.getString("server_id")%>"
which had to be changed to
value='<%=rs.getString("server_id")%>'
The full text of the Tomcat Jasper change can be found at -
https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
with the basic explanation being -
According to JSP 2.0 specification (chapter 1.7 page 72,73)
This code is illegal:
" />
Instead the correct sentence would be:
" />
...
-Donald
smime.p7s
Description: S/MIME Cryptographic Signature
Re: Possible user code changes required when we upgrade to Tomcat 6.0.18
Donald,
The console testsuites are failing. I'm seeing the following exception
on a number of different portlets in the console:
11:49:49,298 ERROR [[JMSWizard]] Servlet.service() for servlet
JMSWizard threw exception
java.lang.ClassCastException: java.lang.NullPointerException
at
org.apache.el.lang.ExpressionBuilder.prepare(ExpressionBuilder.java:135)
at
org.apache.el.lang.ExpressionBuilder.build(ExpressionBuilder.java:147)
at
org.apache.el.lang.ExpressionBuilder.createValueExpression(ExpressionBuilder.java:190)
at
org.apache.el.ExpressionFactoryImpl.createValueExpression(ExpressionFactoryImpl.java:68)
at
org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:924)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fwhen_005f0(list_jsp.java:218)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspx_meth_c_005fchoose_005f0(list_jsp.java:192)
at
jsp.WEB_002dINF.view.jmswizard.list_jsp._jspService(list_jsp.java:117)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:630)
at
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:535)
at
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:472)
at
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:106)
at
org.apache.geronimo.console.MultiPagePortlet.doView(MultiPagePortlet.java:151)
at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:247)
at javax.portlet.GenericPortlet.render(GenericPortlet.java:175)
at
org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:208)
at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:139)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:693)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:806)
I'm not sure if this is a new bug somewhere or if some other changes
are required to the JSPs.
Jarek
On Fri, Aug 15, 2008 at 12:03 AM, Donald Woods <[EMAIL PROTECTED]> wrote:
> This is a notice to developers and users -
>
> I've run into several JSP files in our build (mainly the monitor webapp)
> that require code changes to work with Tomcat 6.0.18, due to tightened code
> around the JSP 2.0 spec in Jasper during the Tomcat 6.0.17 release.
>
> The build errors look something like -
> org.apache.jasper.JasperException:
> file:/Users/drwoods/geronimo/server-trunk/plugins/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditView.jsp(168,168)
> Attribute value rs.getString("server_id") is quoted with " which must be
> escaped when used within the value
>at
> org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
>
>
> There are several places in the portlet code where we have -
> value="<%=rs.getString("server_id")%>"
> which had to be changed to
> value='<%=rs.getString("server_id")%>'
>
>
> The full text of the Tomcat Jasper change can be found at -
> https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
> with the basic explanation being -
>
> According to JSP 2.0 specification (chapter 1.7 page 72,73)
>
> This code is illegal:
> " />
>
> Instead the correct sentence would be:
>
> " />
>
> ...
>
>
> -Donald
>
Possible user code changes required when we upgrade to Tomcat 6.0.18
This is a notice to developers and users -
I've run into several JSP files in our build (mainly the monitor webapp)
that require code changes to work with Tomcat 6.0.18, due to tightened
code around the JSP 2.0 spec in Jasper during the Tomcat 6.0.17 release.
The build errors look something like -
org.apache.jasper.JasperException:
file:/Users/drwoods/geronimo/server-trunk/plugins/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditView.jsp(168,168)
Attribute value rs.getString("server_id") is quoted with " which must be
escaped when used within the value
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
There are several places in the portlet code where we have -
value="<%=rs.getString("server_id")%>"
which had to be changed to
value='<%=rs.getString("server_id")%>'
The full text of the Tomcat Jasper change can be found at -
https://issues.apache.org/bugzilla/show_bug.cgi?id=45015
with the basic explanation being -
According to JSP 2.0 specification (chapter 1.7 page 72,73)
This code is illegal:
" />
Instead the correct sentence would be:
" />
...
-Donald
smime.p7s
Description: S/MIME Cryptographic Signature
