Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
Close the vote 2011/7/21 Forrest Xia > +1 > > Forrest > > > On Thu, Jul 21, 2011 at 2:43 PM, viola lu wrote: > >> +1 >> >> >> On Thu, Jul 21, 2011 at 1:54 PM, Rex Wang wrote: >> >>> +1 rat:check, build pass >>> >>> 2011/7/20 Ivan >>> Please vote for Geronimo Customized Tomcat 7.0.19.1 The codes are based on Apache Tomcat 7.0.19 tag, and include the following extra changes : a. Recover the changes of rev.1144690, which brought a cycle dependency issue We might combine the catalina and catalina-ha in one module in the future b. GERONIMO-5622 A more expansive view of AysncListeners Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove (and reason why) Staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-019 Source repo: https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ -- Ivan >>> >>> >>> >>> -- >>> Lei Wang (Rex) >>> rwonly AT apache.org >>> >> >> >> >> -- >> viola >> >> Apache Geronimo >> >> > -- Ivan
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
+1 Forrest On Thu, Jul 21, 2011 at 2:43 PM, viola lu wrote: > +1 > > > On Thu, Jul 21, 2011 at 1:54 PM, Rex Wang wrote: > >> +1 rat:check, build pass >> >> 2011/7/20 Ivan >> >>> Please vote for Geronimo Customized Tomcat 7.0.19.1 >>> >>> The codes are based on Apache Tomcat 7.0.19 tag, and include the >>> following extra changes : >>> a. Recover the changes of rev.1144690, which brought a cycle dependency >>> issue We might combine the catalina and catalina-ha in one module in the >>> future >>> b. GERONIMO-5622 A more expansive view of AysncListeners >>> >>> Vote will be open for 72 hours. >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove (and reason why) >>> >>> >>> Staging repo: >>> >>> https://repository.apache.org/content/repositories/orgapachegeronimo-019 >>> >>> Source repo: >>> >>> >>> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ >>> >>> >>> -- >>> Ivan >>> >> >> >> >> -- >> Lei Wang (Rex) >> rwonly AT apache.org >> > > > > -- > viola > > Apache Geronimo > >
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
+1 On Thu, Jul 21, 2011 at 1:54 PM, Rex Wang wrote: > +1 rat:check, build pass > > 2011/7/20 Ivan > >> Please vote for Geronimo Customized Tomcat 7.0.19.1 >> >> The codes are based on Apache Tomcat 7.0.19 tag, and include the following >> extra changes : >> a. Recover the changes of rev.1144690, which brought a cycle dependency >> issue We might combine the catalina and catalina-ha in one module in the >> future >> b. GERONIMO-5622 A more expansive view of AysncListeners >> >> Vote will be open for 72 hours. >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> >> Staging repo: >> >> https://repository.apache.org/content/repositories/orgapachegeronimo-019 >> >> Source repo: >> >> >> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ >> >> >> -- >> Ivan >> > > > > -- > Lei Wang (Rex) > rwonly AT apache.org > -- viola Apache Geronimo
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
+1 rat:check, build pass 2011/7/20 Ivan > Please vote for Geronimo Customized Tomcat 7.0.19.1 > > The codes are based on Apache Tomcat 7.0.19 tag, and include the following > extra changes : > a. Recover the changes of rev.1144690, which brought a cycle dependency > issue We might combine the catalina and catalina-ha in one module in the > future > b. GERONIMO-5622 A more expansive view of AysncListeners > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Staging repo: > > https://repository.apache.org/content/repositories/orgapachegeronimo-019 > > Source repo: > > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ > > > -- > Ivan > -- Lei Wang (Rex) rwonly AT apache.org
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
Looks good to me. Checksums/signatures, source, license/notice, build -- all look good to me. Assuming tck looks good, here's my +1 --kevan On Jul 20, 2011, at 10:21 PM, Shawn Jiang wrote: > If we are voting > > https://repository.apache.org/content/repositories/orgapachegeronimo-019/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.19/7.0.19.1/tomcat-parent-7.0.19-7.0.19.1-source-release.tar.gz > https://repository.apache.org/content/repositories/orgapachegeronimo-019/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.19/7.0.19.1/tomcat-parent-7.0.19-7.0.19.1-source-release.zip > > build, rat:check are all good. Here is my +1. > > > On Wed, Jul 20, 2011 at 10:25 PM, Ivan wrote: > Please vote for Geronimo Customized Tomcat 7.0.19.1 > > The codes are based on Apache Tomcat 7.0.19 tag, and include the following > extra changes : > a. Recover the changes of rev.1144690, which brought a cycle dependency issue > We might combine the catalina and catalina-ha in one module in the future > b. GERONIMO-5622 A more expansive view of AysncListeners > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Staging repo: > > https://repository.apache.org/content/repositories/orgapachegeronimo-019 > > Source repo: > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ > > > -- > Ivan > > > > -- > Shawn
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
If we are voting https://repository.apache.org/content/repositories/orgapachegeronimo-019/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.19/7.0.19.1/tomcat-parent-7.0.19-7.0.19.1-source-release.tar.gz https://repository.apache.org/content/repositories/orgapachegeronimo-019/org/apache/geronimo/ext/tomcat/tomcat-parent-7.0.19/7.0.19.1/tomcat-parent-7.0.19-7.0.19.1-source-release.zip build, rat:check are all good. Here is my +1. On Wed, Jul 20, 2011 at 10:25 PM, Ivan wrote: > Please vote for Geronimo Customized Tomcat 7.0.19.1 > > The codes are based on Apache Tomcat 7.0.19 tag, and include the following > extra changes : > a. Recover the changes of rev.1144690, which brought a cycle dependency > issue We might combine the catalina and catalina-ha in one module in the > future > b. GERONIMO-5622 A more expansive view of AysncListeners > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Staging repo: > > https://repository.apache.org/content/repositories/orgapachegeronimo-019 > > Source repo: > > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ > > > -- > Ivan > -- Shawn
Re: [VOTE] Geronimo customized Tomcat 7.0.19.1
my own +1 2011/7/20 Ivan > Please vote for Geronimo Customized Tomcat 7.0.19.1 > > The codes are based on Apache Tomcat 7.0.19 tag, and include the following > extra changes : > a. Recover the changes of rev.1144690, which brought a cycle dependency > issue We might combine the catalina and catalina-ha in one module in the > future > b. GERONIMO-5622 A more expansive view of AysncListeners > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Staging repo: > > https://repository.apache.org/content/repositories/orgapachegeronimo-019 > > Source repo: > > > https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.19.1/ > > > -- > Ivan > -- Ivan