[jira] Updated: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick McGuire updated GERONIMO-5337: --- Fix Version/s: 3.0-M1 (was: 3.0) (was: 2.2.1) ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Assignee: Ivan Fix For: 3.0-M1 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan resolved GERONIMO-5337. Fix Version/s: 2.2.1 Resolution: Fixed Commit changes to trunk At revision: 947969. 3.0 M1 At revision: 947973 and 2.2.1 branch At revision: 947971 ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Assignee: Ivan Fix For: 2.2.1, 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870592#action_12870592 ] Kevan Miller commented on GERONIMO-5337: As long as it's configurable via config-substitution.properties, that's fine. ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870685#action_12870685 ] David Jencks commented on GERONIMO-5337: cf https://issues.apache.org/jira/browse/GERONIMO-5343. I think we should eliminate config-substitutions.properties eventually. ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870756#action_12870756 ] Donald Woods commented on GERONIMO-5337: How would we preserve plugin overrides in car-maven-plugin then? Or would switching to osgi version ranges allow us to finally remove all of the hard coded version info in CARs? ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan reassigned GERONIMO-5337: -- Assignee: Ivan ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Assignee: Ivan Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-5337) ServerHostName does not control the bind ip address for Tomcat Connectors
[ https://issues.apache.org/jira/browse/GERONIMO-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870342#action_12870342 ] David Jencks commented on GERONIMO-5337: Lets hook this up to config admin, rather than our gbean properties stuff. ServerHostName does not control the bind ip address for Tomcat Connectors - Key: GERONIMO-5337 URL: https://issues.apache.org/jira/browse/GERONIMO-5337 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 3.0 Reporter: Kevan Miller Fix For: 3.0 ServerHostName in config-substitutions.properties does not control the bind address for Tomcat Connectors. They are always 0.0.0.0 Note I didn't test Jetty. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Tomcat connectors
I would like to see this too. Do you intend to make this change in the 2.0 version of Geronimo or later (2.0.1/2.1)? Thanks, Gautham. jgenender wrote: David Jencks wrote: Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. +1...excellent idea. Jeff -- View this message in context: http://www.nabble.com/Tomcat-connectors-tf4132628s134.html#a12125013 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
David Jencks wrote: On Aug 9, 2007, at 3:58 PM, Filip Hanik - Dev Lists wrote: David Jencks wrote: On Aug 9, 2007, at 11:18 AM, threepointsomething wrote: I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBeangt; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. I'd ship with the 6.0.14 code, tons of fixes since the last stable release. the code has been voted stable and ready to announce, we're just waiting for the RM to pull his head out of his rear :) http://people.apache.org/~remm/tomcat-6/v6.0.14/ That's a bit of a different point. I was referring to which of the 8 or so tomcat connectors we turn on by default: I think we want to turn on the NIO ones rather than the BIO ones. The tomcat code base we are shipping is based pretty much on near-to-6.0.14 code but with the annotation processor changes applied, which we need for certification. I imagine as soon as the annotation processor changes are in a released tomcat version we'll switch to that, until then we are stuck building our own copies. thanks david jencks forgot about that, I'll probably volunteer as RM for the trunk project, so that we can get some snapshots and alpha/beta(s) out the door Filip Filip However until we get there you can either turn off the BIO connector and add a NIO connector in var/config/config.xml or turn off the BIO connector in config.xml and add the appropriate connector to the geronimo plan for your app. You can add the NIO connector using the admin console, but I think you need to turn off the BIO connector by editing config.xml when geronimo is not running. add the attribute load=false to the gbean entry for the BIO connector. Hope this helps david jencks Thanks, Gautham. --View this message in context: http://www.nabble.com/Tomcat-connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com. --No virus found in this incoming message. Checked by AVG Free Edition.Version: 7.5.476 / Virus Database: 269.11.10/943 - Release Date: 8/8/2007 5:38 PM --No virus found in this incoming message. Checked by AVG Free Edition.Version: 7.5.476 / Virus Database: 269.11.10/943 - Release Date: 8/8/2007 5:38 PM
Re: Tomcat connectors
I was finally able to get Comet to work in Geronimo using the Tomcat NIO connector. Thanks, Gautham. Paul McMahan-2 wrote: This work is complete now and available in trunk and the 2.0 branch. As a side effect of introducing these new connectors we needed to make some changes to the management apis (mainly WebManager) to allow the connectors to specify which attributes they support, what their types are (string, boolean, integer, etc), whether or not they are required vs. optional, etc. All this used to be hard coded in the portlet but now they are defined per connector type in JettyManagerImpl and TomcatManagerImpl and the portlet just renders a form with corresponding inputs and validation. I tried to cover as much testing as possible within our proposed timeframe for 2.0 but there may still be some rough edges. In particular I was not able to test the APR connectors without having the native libraries. You can successfully create an APR connector but without the libraries it won't start due to an unsatisfied link error (as expected). Thanks to Jeff and David Jencks for all their help on getting this important feature into 2.0. Best wishes, Paul On Jul 25, 2007, at 1:43 PM, Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re-add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff -- View this message in context: http://www.nabble.com/Tomcat-connectors-tf4132628s134.html#a12072217 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
That's great! Thanks for letting us know. Would you mind sharing what steps you took to make this work? We have a wiki at http:// cwiki.apache.org/GMOxDOC20/documentation.html where you could record this information. Or if you would rather just respond to this thread then I would be happy to transcribe to the wiki. Best wishes, Paul On Aug 9, 2007, at 9:14 AM, threepointsomething wrote: I was finally able to get Comet to work in Geronimo using the Tomcat NIO connector. Thanks, Gautham. Paul McMahan-2 wrote: This work is complete now and available in trunk and the 2.0 branch. As a side effect of introducing these new connectors we needed to make some changes to the management apis (mainly WebManager) to allow the connectors to specify which attributes they support, what their types are (string, boolean, integer, etc), whether or not they are required vs. optional, etc. All this used to be hard coded in the portlet but now they are defined per connector type in JettyManagerImpl and TomcatManagerImpl and the portlet just renders a form with corresponding inputs and validation. I tried to cover as much testing as possible within our proposed timeframe for 2.0 but there may still be some rough edges. In particular I was not able to test the APR connectors without having the native libraries. You can successfully create an APR connector but without the libraries it won't start due to an unsatisfied link error (as expected). Thanks to Jeff and David Jencks for all their help on getting this important feature into 2.0. Best wishes, Paul On Jul 25, 2007, at 1:43 PM, Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re- add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff -- View this message in context: http://www.nabble.com/Tomcat- connectors-tf4132628s134.html#a12072217 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBeangt; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Thanks, Gautham. -- View this message in context: http://www.nabble.com/Tomcat-connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
On Aug 9, 2007, at 11:18 AM, threepointsomething wrote: I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBeang t; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. However until we get there you can either turn off the BIO connector and add a NIO connector in var/config/config.xml or turn off the BIO connector in config.xml and add the appropriate connector to the geronimo plan for your app. You can add the NIO connector using the admin console, but I think you need to turn off the BIO connector by editing config.xml when geronimo is not running. add the attribute load=false to the gbean entry for the BIO connector. Hope this helps david jencks Thanks, Gautham. -- View this message in context: http://www.nabble.com/Tomcat- connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
Great! I followed your suggestions and am now able to configure the connector via config.xml. Here are the steps: 1. Ensure the server is not running. 2. Disable the BIO connector by making the following change in var\config\config.xml: Remove the element lt;gbean name=TomcatWebConnectorgt; or change it to lt;gbean name=TomcatWebConnector load=falsegt; 3. Add the NIO connector by adding the following to var\config\config.xml: lt;gbean gbeanInfo=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBean name=org.apache.geronimo.configs/tomcat6/2.0.1-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/tomcat6/2.0.1-SNAPSHOT/car,j2eeType=GBean,name=TomcatNIOConnectorgt; lt;attribute name=portgt;${HTTPPortPrimary + PortOffset}lt;/attributegt; lt;attribute name=redirectPortgt;${HTTPSPortPrimary + PortOffset}lt;/attributegt; lt;attribute name=maxThreadsgt;150lt;/attributegt; lt;attribute name=connectionTimeoutgt;6lt;/attributegt; lt;attribute name=namegt;TomcatNIOConnectorlt;/attributegt; lt;attribute name=hostgt;${ServerHostname}lt;/attributegt; lt;reference name=TomcatContainergt; lt;patterngt; lt;groupIdgt;org.apache.geronimo.configslt;/groupIdgt; lt;artifactIdgt;tomcat6lt;/artifactIdgt; lt;versiongt;2.0.1-SNAPSHOTlt;/versiongt; lt;typegt;carlt;/typegt; lt;namegt;TomcatWebContainerlt;/namegt; lt;/patterngt; lt;/referencegt; lt;reference name=ServerInfogt; lt;patterngt; lt;groupIdgt;org.apache.geronimo.configslt;/groupIdgt; lt;artifactIdgt;j2ee-systemlt;/artifactIdgt; lt;versiongt;2.0.1-SNAPSHOTlt;/versiongt; lt;typegt;carlt;/typegt; lt;namegt;ServerInfolt;/namegt; lt;/patterngt; lt;/referencegt; lt;/gbeangt; 4. Start Geronimo. You should see the following: Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO TomcatNIOConnector 8080 0.0.0.0 Tomcat Connector HTTP BIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector (It seems to show 8080 with a BIO connector as well. Is this a bug?) Gautham. djencks wrote: On Aug 9, 2007, at 11:18 AM, threepointsomething wrote: I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBeang t; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. However until we get there you can either turn off the BIO connector and add a NIO connector in var/config/config.xml or turn off the BIO connector in config.xml and add the appropriate connector to the geronimo plan for your app. You can add the NIO connector using the admin console, but I think you need to turn off the BIO connector by editing config.xml when geronimo is not running. add the attribute load=false to the gbean entry for the BIO connector. Hope this helps david jencks Thanks, Gautham. -- View this message in context: http://www.nabble.com/Tomcat- connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive
Re: Tomcat connectors
Thanks, Gautham. -- View this message in context: http://www.nabble.com/Tomcat- connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.
Re: Tomcat connectors
On Aug 9, 2007, at 4:56 PM, threepointsomething wrote: I had removed the entire element lt;gbean name=TomcatWebConnectorgt;...lt;/gbeangt; from config.xml. That is when it was showing 2 8080 connectors. If I use load=false it seems fine and only 1 8080 connector is shown. I think you are seeing this because when you remove that section of XML from config.xml you are not actually removing the connector, just the configuration overrides for it. The connector is actually defined in tomcat's deployment plan. Setting load=false in config.xml prevents the connector (which was defined elsewhere) from starting. Best wishes, Paul
Re: Tomcat connectors
David Jencks wrote: On Aug 9, 2007, at 11:18 AM, threepointsomething wrote: I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBeangt; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. I'd ship with the 6.0.14 code, tons of fixes since the last stable release. the code has been voted stable and ready to announce, we're just waiting for the RM to pull his head out of his rear :) http://people.apache.org/~remm/tomcat-6/v6.0.14/ Filip However until we get there you can either turn off the BIO connector and add a NIO connector in var/config/config.xml or turn off the BIO connector in config.xml and add the appropriate connector to the geronimo plan for your app. You can add the NIO connector using the admin console, but I think you need to turn off the BIO connector by editing config.xml when geronimo is not running. add the attribute load=false to the gbean entry for the BIO connector. Hope this helps david jencks Thanks, Gautham. --View this message in context: http://www.nabble.com/Tomcat-connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com. --No virus found in this incoming message. Checked by AVG Free Edition.Version: 7.5.476 / Virus Database: 269.11.10/943 - Release Date: 8/8/2007 5:38 PM
Re: Tomcat connectors
On Aug 9, 2007, at 3:58 PM, Filip Hanik - Dev Lists wrote: David Jencks wrote: On Aug 9, 2007, at 11:18 AM, threepointsomething wrote: I am quite new to Geronimo, so I am not sure if the steps I followed are right. Here goes: I had to ensure that the NIO connector is picked up in place of the basic HTTP connector, so I made the following change in configs\tomcat6\src\plan\plan.xml: lt;gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBean gt; I then rebuilt config\tomcat6\. When I started Geronimo, it picked up the NIO connector as expected. Listening on Ports: 1050 127.0.0.1 CORBA Naming Service 1099 0.0.0.0 RMI Naming 1527 0.0.0.0 Derby Connector 2001 127.0.0.1 OpenEJB ORB Adapter 4201 0.0.0.0 OpenEJB Daemon 6882 127.0.0.1 OpenEJB ORB Adapter 8009 0.0.0.0 Tomcat Connector AJP AJP 8080 0.0.0.0 Tomcat Connector HTTP NIO HTTP 8443 0.0.0.0 Tomcat Connector HTTPS BIO HTTPS 0.0.0.0 JMX Remoting Connector 61613 0.0.0.0 ActiveMQ Transport Connector 61616 0.0.0.0 ActiveMQ Transport Connector I then ran a sample comet application (WAR) that was executing properly in Tomcat and tried it in this instance of Geronimo. Seemed to work fine. I was wondering if there is a simpler way of configuring NIO without having to rebuild config\tomcat6. If so can you please suggest how I can do that? Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. I'd ship with the 6.0.14 code, tons of fixes since the last stable release. the code has been voted stable and ready to announce, we're just waiting for the RM to pull his head out of his rear :) http://people.apache.org/~remm/tomcat-6/v6.0.14/ That's a bit of a different point. I was referring to which of the 8 or so tomcat connectors we turn on by default: I think we want to turn on the NIO ones rather than the BIO ones. The tomcat code base we are shipping is based pretty much on near-to-6.0.14 code but with the annotation processor changes applied, which we need for certification. I imagine as soon as the annotation processor changes are in a released tomcat version we'll switch to that, until then we are stuck building our own copies. thanks david jencks Filip However until we get there you can either turn off the BIO connector and add a NIO connector in var/config/config.xml or turn off the BIO connector in config.xml and add the appropriate connector to the geronimo plan for your app. You can add the NIO connector using the admin console, but I think you need to turn off the BIO connector by editing config.xml when geronimo is not running. add the attribute load=false to the gbean entry for the BIO connector. Hope this helps david jencks Thanks, Gautham. --View this message in context: http://www.nabble.com/Tomcat- connectors-tf4132628s134.html#a12077742 Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com. --No virus found in this incoming message. Checked by AVG Free Edition.Version: 7.5.476 / Virus Database: 269.11.10/943 - Release Date: 8/8/2007 5:38 PM
Re: Tomcat connectors
David Jencks wrote: Well, I expect we actually want to ship with the NIO connectors used by default anyway, like we do for jetty. +1...excellent idea. Jeff
Re: Tomcat connectors
Yeah...I would like to see us fix this at some point. I think if we delete a GBean, it should rebuild the car that it references or something along those lines. A deletion is a deletion and I think a load=false is not really a deletion. Jeff Paul McMahan wrote: On Aug 9, 2007, at 4:56 PM, threepointsomething wrote: I had removed the entire element lt;gbean name=TomcatWebConnectorgt;...lt;/gbeangt; from config.xml. That is when it was showing 2 8080 connectors. If I use load=false it seems fine and only 1 8080 connector is shown. I think you are seeing this because when you remove that section of XML from config.xml you are not actually removing the connector, just the configuration overrides for it. The connector is actually defined in tomcat's deployment plan. Setting load=false in config.xml prevents the connector (which was defined elsewhere) from starting. Best wishes, Paul
Re: Tomcat connectors
On Aug 9, 2007, at 7:12 PM, David Jencks wrote: I imagine as soon as the annotation processor changes are in a released tomcat version we'll switch to that, until then we are stuck building our own copies. Yep that's why I keep nagging on [EMAIL PROTECTED] about keeping tomcat/ trunk in synch with tomcat/6.0.x/trunk :-)The annotation processor changes were only applied to tomcat/trunk. Best wishes, Paul
Re: Tomcat connectors
This work is complete now and available in trunk and the 2.0 branch. As a side effect of introducing these new connectors we needed to make some changes to the management apis (mainly WebManager) to allow the connectors to specify which attributes they support, what their types are (string, boolean, integer, etc), whether or not they are required vs. optional, etc. All this used to be hard coded in the portlet but now they are defined per connector type in JettyManagerImpl and TomcatManagerImpl and the portlet just renders a form with corresponding inputs and validation. I tried to cover as much testing as possible within our proposed timeframe for 2.0 but there may still be some rough edges. In particular I was not able to test the APR connectors without having the native libraries. You can successfully create an APR connector but without the libraries it won't start due to an unsatisfied link error (as expected). Thanks to Jeff and David Jencks for all their help on getting this important feature into 2.0. Best wishes, Paul On Jul 25, 2007, at 1:43 PM, Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re-add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
FYI -- I'm working on fixing the console's web connector portlet for the new WebManager apis added to support these new connectors. Best wishes, Paul On Jul 25, 2007, at 1:43 PM, Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re-add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
Filip Hanik - Dev Lists wrote: so there is no need to dabble with the auto select, personally I don't think its very usable feature, since the APR SSL connector has different attributes than the Java SSL connector and the auto select wouldn't work in that scenario anyway. Great to hear...Ill add that connector in then ;-) Jeff
Re: Tomcat connectors
Ok..I added APR connectors... Jeff Filip Hanik - Dev Lists wrote: Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. not really, it works the same as the NIO connector selection, in server.xml if protocol=HTTP/1.1 and the java.library.path contains the TC native library (tcnative.dll or libtcnative.so) then APR is selected. however, the protocol attribute also takes a complete class name, like protocol=org.apache.coyote.http11.Http11Protocol -- java blocking connector protocol=org.apache.coyote.http11.Http11NioProtocol -- java non blocking connector protocol=org.apache.coyote.http11.Http11AprProtocol -- APR connector so there is no need to dabble with the auto select, personally I don't think its very usable feature, since the APR SSL connector has different attributes than the Java SSL connector and the auto select wouldn't work in that scenario anyway. Filip Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re-add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
Jeff Genender wrote: Ok I added a whole bunch of new connectors in the o.a.g.t.connectors package. I am still working on APR - more notes to follow on this as its a little squirly since the Tomcat Connector somewhat chooses this automatically based on the existence of a native libraries. For the console we may wish to do a check on whether the native libs exist, and if so, present the APR connector. More on this in another email. not really, it works the same as the NIO connector selection, in server.xml if protocol=HTTP/1.1 and the java.library.path contains the TC native library (tcnative.dll or libtcnative.so) then APR is selected. however, the protocol attribute also takes a complete class name, like protocol=org.apache.coyote.http11.Http11Protocol -- java blocking connector protocol=org.apache.coyote.http11.Http11NioProtocol -- java non blocking connector protocol=org.apache.coyote.http11.Http11AprProtocol -- APR connector so there is no need to dabble with the auto select, personally I don't think its very usable feature, since the APR SSL connector has different attributes than the Java SSL connector and the auto select wouldn't work in that scenario anyway. Filip Here are the connectors we care about at the moment... AJP13ConnectorGBean - Implements AJP Http11ConnectorGBean - Implements blocking Http connector Https11ConnectorGBean - Implements blocking Https connector Http11NIOConnectorGBean - Implements non-blocking Http connector Https11NIOConnectorGBean - Implements non-blocking Https connector I have not wired them into the container and other GBeans yet...I want to clena them up and get any feedback before making the switch since this obviously will impact the console upon wiring them in. As a side note...I am not using any references to the WebManager or other interfaces we used that hooked into the console. We can re-add those if those are deemed necessary. Jeff Paul McMahan wrote: I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
+1 Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
I agree NIO support would be great to have in 2.0, especially since its required for comet. Best wishes, Paul On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Tomcat connectors
Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Jeff
Re: Tomcat connectors
On Jul 23, 2007, at 2:42 PM, Jeff Genender wrote: Hi, I was going through some JIRAs and the Geronimo2.0 source and noticed it will be difficult at best to get the NIO connector and setting attributes on the APR connector for Tomcat due to its current implementation. I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Fine with me. I think I had to do something similar for jetty 6 :-) thanks david jencks Jeff
Re: Tomcat connectors
+1 Thanks Anita --- Jeff Genender [EMAIL PROTECTED] wrote: I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Building a website is a piece of cake. Yahoo! Small Business gives you all the tools to get online. http://smallbusiness.yahoo.com/webhosting
Re: Tomcat connectors
+1 Vamsi On 7/24/07, Anita Kulshreshtha [EMAIL PROTECTED] wrote: +1 Thanks Anita --- Jeff Genender [EMAIL PROTECTED] wrote: I really think the ability to use these 2 connectors is very important for the 2.0 release and I would like to put these in. If there are no objections, I would like this to be a part of the 2.0 release. Building a website is a piece of cake. Yahoo! Small Business gives you all the tools to get online. http://smallbusiness.yahoo.com/webhosting
[jira] Closed: (GERONIMO-2481) WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes
[ https://issues.apache.org/jira/browse/GERONIMO-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vamsavardhana Reddy closed GERONIMO-2481. - Resolution: Fixed Fix Version/s: (was: 1.x) Completed with rev 546500 in trunk. WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes -- Key: GERONIMO-2481 URL: https://issues.apache.org/jira/browse/GERONIMO-2481 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: console Affects Versions: 1.2, 2.0-M5 Reporter: Vamsavardhana Reddy Assignee: Vamsavardhana Reddy Fix For: 2.0-M7 Thanks to GERONIMO-2390 Tomcat connectors missing several attributes, we now have tomcat connectors supporting all possible attributes. In the same line, the webservers portlet should support all the attributes in creating/editing tomcat connectors. editHttp and editHttps pages may become long with this addition, but then we can group the commonly used attributes at the top and may be show the uncommon attributes upon checking an Advanced or so checkbox. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2481) WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes
[ https://issues.apache.org/jira/browse/GERONIMO-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502378 ] Vamsavardhana Reddy commented on GERONIMO-2481: --- Committed in Rev 545212 in trunk. WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes -- Key: GERONIMO-2481 URL: https://issues.apache.org/jira/browse/GERONIMO-2481 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: console Affects Versions: 1.2, 2.0-M5 Reporter: Vamsavardhana Reddy Assignee: Vamsavardhana Reddy Fix For: 1.x, 2.0-M7 Thanks to GERONIMO-2390 Tomcat connectors missing several attributes, we now have tomcat connectors supporting all possible attributes. In the same line, the webservers portlet should support all the attributes in creating/editing tomcat connectors. editHttp and editHttps pages may become long with this addition, but then we can group the commonly used attributes at the top and may be show the uncommon attributes upon checking an Advanced or so checkbox. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2481) WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2481?page=all ] Vamsavardhana Reddy updated GERONIMO-2481: -- Fix Version/s: 1.x 2.0 (was: 1.2) Affects Version/s: 2.0 Assignee: Vamsavardhana Reddy WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes -- Key: GERONIMO-2481 URL: http://issues.apache.org/jira/browse/GERONIMO-2481 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: console Affects Versions: 2.0, 1.2 Reporter: Vamsavardhana Reddy Assigned To: Vamsavardhana Reddy Fix For: 1.x, 2.0 Thanks to GERONIMO-2390 Tomcat connectors missing several attributes, we now have tomcat connectors supporting all possible attributes. In the same line, the webservers portlet should support all the attributes in creating/editing tomcat connectors. editHttp and editHttps pages may become long with this addition, but then we can group the commonly used attributes at the top and may be show the uncommon attributes upon checking an Advanced or so checkbox. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (GERONIMO-2481) WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes
WebServers portlet: Create/Edit Tomcat Connectors should support editing of all supported connector attributes -- Key: GERONIMO-2481 URL: http://issues.apache.org/jira/browse/GERONIMO-2481 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: console Affects Versions: 1.2 Reporter: Vamsavardhana Reddy Fix For: 1.2 Thanks to GERONIMO-2390 Tomcat connectors missing several attributes, we now have tomcat connectors supporting all possible attributes. In the same line, the webservers portlet should support all the attributes in creating/editing tomcat connectors. editHttp and editHttps pages may become long with this addition, but then we can group the commonly used attributes at the top and may be show the uncommon attributes upon checking an Advanced or so checkbox. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=all ] Jeff Genender closed GERONIMO-2390. --- Second patch applied, thanks. Sending geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/ConnectorGBean.java Sending geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatWebConnector.java Transmitting file data .. Committed revision 441934. Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: GERONIMO-2390-onemore.patch, geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=comments#action_12433635 ] David Jencks commented on GERONIMO-2390: This is a bug fix and I recommend you assume that the votes imply +1 comments that our RTC model is supposed to require. Anyway here's my +`1 Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=comments#action_12433663 ] Vamsavardhana Reddy commented on GERONIMO-2390: --- server and strategy attributes are still missing!! http://tomcat.apache.org/tomcat-5.5-doc/config/http.html Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=all ] Vamsavardhana Reddy updated GERONIMO-2390: -- Attachment: GERONIMO-2390-onemore.patch GERONIMO-2390-onemore.patch: Addresses missing server and strategy attributes. Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: GERONIMO-2390-onemore.patch, geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (GERONIMO-2390) Tomcat connectors missing several attributes
Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Fix For: 1.2 Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=all ] Jeff Genender updated GERONIMO-2390: Assignee: Jeff Genender Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=all ] Jeff Genender updated GERONIMO-2390: Attachment: geronimo-2390.patch Patch attached Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Bug Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2390) Tomcat connectors missing several attributes
[ http://issues.apache.org/jira/browse/GERONIMO-2390?page=all ] Jeff Genender updated GERONIMO-2390: Issue Type: Improvement (was: Bug) Workflow: RTC Workflow (was: jira) Tomcat connectors missing several attributes Key: GERONIMO-2390 URL: http://issues.apache.org/jira/browse/GERONIMO-2390 Project: Geronimo Issue Type: Improvement Security Level: public(Regular issues) Components: Tomcat Affects Versions: 1.1 Reporter: Jeff Genender Assigned To: Jeff Genender Fix For: 1.2 Attachments: geronimo-2390.patch Tomcat connector missing the following attributes: allowTrace proxyName proxyPort scheme secure uriEncoding useIPVHosts xpoweredBy compressableMimeType compression noCompressionUserAgents restrictedUserAgents threadPriority ciphers -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
Can't set listen host/IP for Tomcat Connectors -- Key: GERONIMO-702 URL: http://issues.apache.org/jira/browse/GERONIMO-702 Project: Geronimo Type: Bug Components: Tomcat Versions: 1.0-M3 Reporter: Aaron Mulder Currently the Tomcat network connector GBean lets you specify the port to listen on, but not the host/IP. Both should be allowed. The class in question is: geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean When this is done, the getAddress method on that class should be changed to return the correct listen address instead of being hardcoded to return 0.0.0.0 and the relevant port. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
[ http://issues.apache.org/jira/browse/GERONIMO-702?page=all ] Jeff Genender reassigned GERONIMO-702: -- Assign To: Jeff Genender Can't set listen host/IP for Tomcat Connectors -- Key: GERONIMO-702 URL: http://issues.apache.org/jira/browse/GERONIMO-702 Project: Geronimo Type: Bug Components: Tomcat Versions: 1.0-M3 Reporter: Aaron Mulder Assignee: Jeff Genender Currently the Tomcat network connector GBean lets you specify the port to listen on, but not the host/IP. Both should be allowed. The class in question is: geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean When this is done, the getAddress method on that class should be changed to return the correct listen address instead of being hardcoded to return 0.0.0.0 and the relevant port. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Created: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
Aaron, I am confident we handle this. The ConnectorGBean is a simply a GBean proxy for the Tomcat Connector object. You can declaritively change the ip address to listen on with an initParam called address in the GBean configuration. See here for an example of how this would be done in our j2ee-server-tomcat-plan.xml using 192.168.0.1: gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.ConnectorGBean attribute name=initParams address=192.168.0.1 port=${PlanTomcatHTTPPort} maxHttpHeaderSize=8192 maxThreads=150 minSpareThreads=25 maxSpareThreads=75 enableLookups=false redirectPort=${PlanTomcatHTTPSPort} acceptCount=100 connectionTimeout=2 disableUploadTimeout=true /attribute reference name=TomcatContainer nameTomcatWebContainer/name /reference /gbean Since we are proxying the call to the Connector object, we support and pass on all Tomcat configurations to the Tomcat engine as listed here: http://jakarta.apache.org/tomcat/tomcat-5.5-doc/config/http.html. So, IMHO, I believe we support this for Tomcat. Does this handle the concern? Thanks, Jeff Aaron Mulder (JIRA) wrote: Can't set listen host/IP for Tomcat Connectors -- Key: GERONIMO-702 URL: http://issues.apache.org/jira/browse/GERONIMO-702 Project: Geronimo Type: Bug Components: Tomcat Versions: 1.0-M3 Reporter: Aaron Mulder Currently the Tomcat network connector GBean lets you specify the port to listen on, but not the host/IP. Both should be allowed. The class in question is: geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean When this is done, the getAddress method on that class should be changed to return the correct listen address instead of being hardcoded to return 0.0.0.0 and the relevant port.
Re: [jira] Created: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
Jeff, I'd like to remove the host and port fron the initParams block and make separate GBean attributes for them. Then in the GBean constructor, we can put the appropriate name/value pairs into the initParams before applying them. I think it would be best to work toward as many GBean attributes as we can at the expense of blocks of XML or Properties or whatever. Is that OK with you? In fact, maybe we should just go ahead and make GBean attributes for all the values you can list in the initParams section. But right now, it's the host and port I care about most. Also, I haven't checked in the getAddress method yet, so that bit of the JIRA report may not make too much sense. :) Thanks, Aaron On Mon, 4 Jul 2005, Jeff Genender wrote: Aaron, I am confident we handle this. The ConnectorGBean is a simply a GBean proxy for the Tomcat Connector object. You can declaritively change the ip address to listen on with an initParam called address in the GBean configuration. See here for an example of how this would be done in our j2ee-server-tomcat-plan.xml using 192.168.0.1: gbean name=TomcatWebConnector class=org.apache.geronimo.tomcat.ConnectorGBean attribute name=initParams address=192.168.0.1 port=${PlanTomcatHTTPPort} maxHttpHeaderSize=8192 maxThreads=150 minSpareThreads=25 maxSpareThreads=75 enableLookups=false redirectPort=${PlanTomcatHTTPSPort} acceptCount=100 connectionTimeout=2 disableUploadTimeout=true /attribute reference name=TomcatContainer nameTomcatWebContainer/name /reference /gbean Since we are proxying the call to the Connector object, we support and pass on all Tomcat configurations to the Tomcat engine as listed here: http://jakarta.apache.org/tomcat/tomcat-5.5-doc/config/http.html. So, IMHO, I believe we support this for Tomcat. Does this handle the concern? Thanks, Jeff Aaron Mulder (JIRA) wrote: Can't set listen host/IP for Tomcat Connectors -- Key: GERONIMO-702 URL: http://issues.apache.org/jira/browse/GERONIMO-702 Project: Geronimo Type: Bug Components: Tomcat Versions: 1.0-M3 Reporter: Aaron Mulder Currently the Tomcat network connector GBean lets you specify the port to listen on, but not the host/IP. Both should be allowed. The class in question is: geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean When this is done, the getAddress method on that class should be changed to return the correct listen address instead of being hardcoded to return 0.0.0.0 and the relevant port.
[jira] Closed: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
[ http://issues.apache.org/jira/browse/GERONIMO-702?page=all ] Jeff Genender closed GERONIMO-702: -- Fix Version: 1.0-M4 Resolution: Invalid The ConnectorGBean is a simply a GBean proxy for the Tomcat Connector object. You can declaritively change the ip address to listen on with an initParam called address in the GBean configuration. Can't set listen host/IP for Tomcat Connectors -- Key: GERONIMO-702 URL: http://issues.apache.org/jira/browse/GERONIMO-702 Project: Geronimo Type: Bug Components: Tomcat Versions: 1.0-M3 Reporter: Aaron Mulder Assignee: Jeff Genender Fix For: 1.0-M4 Currently the Tomcat network connector GBean lets you specify the port to listen on, but not the host/IP. Both should be allowed. The class in question is: geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean When this is done, the getAddress method on that class should be changed to return the correct listen address instead of being hardcoded to return 0.0.0.0 and the relevant port. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira